8128: GtkDialog mapped without a transient parent

gramps/gen/filters/rules/person/_deeprelationshippathbetween.py

@@ -133,7 +133,8 @@ class DeepRelationshipPathBetween(Rule):
         root_person_id = self.list[0]
         root_person = db.get_person_from_gramps_id(root_person_id)
 
-        progress = ProgressMeter(_('Finding relationship paths')) # no-parent
+        progress = ProgressMeter( # TODO no-parent
+                                 _('Finding relationship paths'))
         progress.set_pass(header=_('Evaluating people'), mode=ProgressMeter.MODE_ACTIVITY)
 
         filter_name = self.list[1]

gramps/gui/grampsgui.py

@@ -281,13 +281,13 @@ def __startgramps(errors, argparser):
         #handle first existing errors in GUI fashion
         if errors:
             for error in errors:
-                ErrorDialog(error[0], error[1]) # no-parent
+                ErrorDialog(error[0], error[1]) # TODO no-parent
             Gtk.main_quit()
             sys.exit(1)
 
         if argparser.errors:
             for error in argparser.errors:
-                ErrorDialog(error[0], error[1]) # no-parent
+                ErrorDialog(error[0], error[1]) # TODO no-parent
             Gtk.main_quit()
             sys.exit(1)
 

gramps/gui/utils.py

@@ -372,7 +372,7 @@ def display_error_dialog (index, errorstrings):
         else:
             error = errorstrings
 
-    ErrorDialog(_("Error from external program"), error) # no-parent
+    ErrorDialog(_("Error from external program"), error) # TODO no-parent
 
 def poll_external (args):
     """

gramps/plugins/db/bsddb/upgrade.py

@@ -799,7 +799,7 @@ def gramps_upgrade_16(self):
              "Tools -> Family Tree Processing -> Merge\n"
              "in order to merge citations that contain similar\n"
              "information")
-    InfoDialog(_('Upgrade Statistics'), txt, monospaced=True) # no-parent
+    InfoDialog(_('Upgrade Statistics'), txt, monospaced=True) # TODO no-parent
 
 def upgrade_media_list_16(self, media_list):
     new_media_list = []

gramps/plugins/docgen/htmldoc.py

@@ -45,6 +45,7 @@ import logging
 #------------------------------------------------------------------------
 from gramps.gen.utils.image import resize_to_jpeg
 from gramps.gen.const import DATA_DIR, IMAGE_DIR, PROGRAM_NAME, URL_HOMEPAGE
+from gramps.gen.errors import ReportError
 from gramps.version import VERSION
 from gramps.gen.plug.docgen import BaseDoc, TextDoc, URL_PATTERN
 from gramps.plugins.lib.libhtmlbackend import HtmlBackend, process_spaces
@@ -268,9 +269,8 @@ class HtmlDoc(BaseDoc, TextDoc):
         if from_fname != dest:
             shutil.copyfile(from_fname, dest)
         elif self.warn_dir:
-            from gramps.gui.dialog import WarningDialog
-            WarningDialog( # no-parent
-                _("Possible destination error") + "\n" +
+            raise ReportError(
+                _("Possible destination error"),
                 _("You appear to have set your target directory "
                   "to a directory used for data storage. This "
                   "could create problems with file management. "

gramps/plugins/docgen/latexdoc.py

@@ -1243,7 +1243,7 @@ class LaTeXDoc(BaseDoc, TextDoc):
                                 "Use your package manager to install "
                                 "python-imaging or python-pillow or "
                                 "python3-pillow")
-                    MessageHideDialog(title, message, # no-parent
+                    MessageHideDialog(title, message, # TODO no-parent
                                       'interface.ignore-pil')
             self.emit(''.join(('%\n *** Error: cannot convert ', infile,
                                '\n ***                    to ', outfile,

gramps/plugins/gramplet/gramplet.gpr.py

@@ -422,7 +422,7 @@ else:
             message = _("Image metadata functionality will not be available.\n"
                         "To build it for Gramps see "
                         "%(gramps_wiki_build_gexiv2_url)s" % gexiv2_dict )
-            MessageHideDialog(title, message, # no-parent
+            MessageHideDialog(title, message, # TODO no-parent
                               'interface.ignore-gexiv2')
 
 register(GRAMPLET,

gramps/plugins/importer/importprogen.py

@@ -511,7 +511,8 @@ class ProgenParser:
     def parse_progen_file(self):
         self.def_ = PG30_Def(self.fname)
         #print self.def_.diag()
-        self.progress = ProgressMeter(_("Import from Pro-Gen"), '') # no-parent
+        self.progress = ProgressMeter( # TODO no-parent
+                                      _("Import from Pro-Gen"), '')
 
         self.mems = _read_mem(self.bname)
         self.pers = _read_recs(self.def_['Table_1'], self.bname)

gramps/plugins/view/geography.gpr.py

@@ -72,7 +72,7 @@ if not OSMGPSMAP:
             MESSAGE = _("Geography functionality will not be available.\n"
                        "To build it for Gramps see "
                        "%(gramps_wiki_build_osmgps_url)s") % OSMGPS_DICT
-            MessageHideDialog(TITLE, MESSAGE, # no-parent
+            MessageHideDialog(TITLE, MESSAGE, # TODO no-parent
                               'interface.ignore-osmgpsmap')
 else:
     # Load the view only if osmgpsmap library is present.