File copy doesn't work if the glob can match directories.

Fixes bug #10705.

ChangeLog

@@ -1,247 +1,13 @@
-2018-02-08  Nick Hall <nick-h@gramps-project.org>
-
-	* po/gramps.pot: Update translation template for new release
-
-2018-02-05  prculley <paulr2787@gmail.com>
-
-	* gramps/gen/utils/docgen/csvtab.py: Fix Export View to CSV when
-	Unicode characters are present Fixes #10404
-
-2018-02-05  prculley <paulr2787@gmail.com>
-
-	* gramps/gen/datehandler/_date_de.py,
-	gramps/gen/datehandler/_date_el.py,
-	gramps/gen/datehandler/_date_lt.py,
-	gramps/gen/datehandler/_date_nl.py,
-	gramps/gen/datehandler/_date_pl.py,
-	gramps/gen/datehandler/_date_sr.py: Fix several intl date displayers
-	for missing parameter.  Fixes #10196
-
-2018-01-29  niememat <niememat@gmail.com>
-
-	* po/fi.po: Update finnish translation
-
-2018-01-28  Paul Culley <paulr2787@gmail.com>
-
-	* gramps/plugins/drawreport/descendtree.py,
-	gramps/plugins/lib/libtreebase.py: DescendantTree report; fix
-	crashes and Title spacing for Gramps42 (#537) * Fix DescendentTree report for crashes Fixes #10377 * Fix DescendentTree report; more space beneath Title Issue #10377
-
-2018-01-28  Paul Culley <paulr2787@gmail.com>
-
-	* gramps/gen/plug/report/_book.py,
-	gramps/gui/plug/report/_bookdialog.py,
-	gramps/gui/plug/report/_docreportdialog.py: Fix Book XML handler to
-	deal with unusual characters in Book name Gramps42 (#536) * Fix Book XML handler to deal with unusual characters in Book name Fixes #10387 * Fix 'Generate Book' dialog for bad transient parent * Fix Book XML handler for unusual characters in report name Issue #10387
-
-2018-01-27  Leonhaeuser <mirko@leonhaeuser.de>
-
-	* po/de.po: update German translation
-
-2017-11-21  Nick Hall <nick-h@gramps-project.org>
-
-	* gramps/cli/plug/__init__.py, gramps/gen/plug/__init__.py,
-	gramps/gen/plug/_pluginreg.py, gramps/gen/plug/docgen/__init__.py,
-	gramps/gen/plug/docgen/treedoc.py,
-	gramps/gen/plug/report/_constants.py,
-	gramps/gui/plug/report/_graphreportdialog.py,
-	gramps/gui/plug/report/_graphvizreportdialog.py,
-	gramps/gui/plug/report/_reportdialog.py,
-	gramps/gui/plug/report/_treereportdialog.py, po/POTFILES.in: Add
-	support for new genealogy tree report category Issue #10223.
-
-2017-12-26  prculley <paulr2787@gmail.com>
-
-	* gramps/plugins/gramplet/mediapreview.py: Fix Media Preview
-	Gramplet for closed db Fixes #10332
-
-2017-12-12  prculley <paulr2787@gmail.com>
-
-	* gramps/plugins/lib/libgedcom.py: Suport FTM 2017 Gedcom tags on
-	import Bug #10285 FTM adds subordinate PLAC and OBJE data to INDI.ADDR
-	which is non-standard.  So treat it as a Residence Event, instead of
-	an Address.  FTM puts _DATE and _TEXT tags subordinate to OBJE, also
-	non-standard.
-
-2017-12-01  prculley <paulr2787@gmail.com>
-
-	* gramps/gui/filters/sidebar/_familysidebarfilter.py,
-	gramps/gui/filters/sidebar/_personsidebarfilter.py: Fix Person,
-	Family Sidebar Filters to add custom Event types Fixes #10112 Also fix Family Sidebar Filter RelType init with closed
-	db
-
-2017-12-07  prculley <paulr2787@gmail.com>
-
-	* gramps/gui/dialog.py: Fix QuestionDialog display for html like
-	characters in title Fixes #10298
-
-2017-11-27  prculley <paulr2787@gmail.com>
-
-	* gramps/gen/lib/familyreltype.py: Fix FamilyRelationshpType
-	_DATAMAP order to correspond with values Fixes #10275
-
-2017-11-21  prculley <paulr2787@gmail.com>
-
-	* gramps/plugins/lib/libgedcom.py: Fix Gedcom import for illegal
-	Gedcom Family Attributes Issue #10262 TMG Gedcom exports an illegal NCHI with sub-data for
-	FAM.  Gramps could not handle this and attached the sub-data to the
-	FAM creating some corrupted Event records.
-
-2017-10-27  prculley <paulr2787@gmail.com>
-
-	* gramps/plugins/lib/libgedcom.py: Fix Gedcom export for bad Hebrew
-	Months Fixes #10245
-
-2017-11-05  prculley <paulr2787@gmail.com>
-
-	* INSTALL: Change INSTALL to replace 'python' with 'python3 for
-	script invokes
-
-2017-10-25  prculley <paulr2787@gmail.com>
-
-	* gramps/plugins/importer/importcsv.py: Fix CSV importer for place
-	event name using gramps_id Fixes #10239
-
-2017-10-14  prculley <paulr2787@gmail.com>
+2018-02-09  prculley <paulr2787@gmail.com>
 
 	* gramps/plugins/view/geoclose.py,
 	gramps/plugins/view/geoevents.py,
 	gramps/plugins/view/geofamclose.py,
 	gramps/plugins/view/geofamily.py, gramps/plugins/view/geoperson.py,
-	gramps/plugins/view/geoplaces.py: Fix Geography view 'Find' when db
-	is closed.  Fixes #10229
+	gramps/plugins/view/geoplaces.py: Fix Geography views for bad
+	'dbstate.is_open()' test Fixes #10417
 
-2017-10-13  prculley <paulr2787@gmail.com>
+2018-02-08  Nick Hall <nick-h@gramps-project.org>
 
-	* gramps/gui/widgets/interactivesearchbox.py: Fix interactive search
-	for exception on click then down arrow Fixes #10226
-
-2017-10-09  prculley <paulr2787@gmail.com>
-
-	* gramps/gen/plug/docgen/graphdoc.py, gramps/gen/utils/file.py: 
-	Create where_is utility to locate a binary in the standard places This is particularly useful on Mac OS X where Gramps is passed a
-	PATH that does not include elements added by the terminal shell.
-
-2017-10-05  prculley <paulr2787@gmail.com>
-
-	* gramps/gen/plug/docgen/graphdoc.py: Fix relationship Graph so
-	Unicode chars on Multiple pages works.  Fixes: #9783, #9359, #8080, #6782, #6108 Bugs: #6431, #4164, #1485,
-	#2964, #2790
-
-2017-10-01  prculley <paulr2787@gmail.com>
-
-	* data/authors.xml: update authors file
-
-2017-09-22  prculley <paulr2787@gmail.com>
-
-	* gramps/plugins/lib/libgedcom.py: Fix Gedcom import for "1 MARR Y"
-	issue Fixes #10188
-
-2018-01-19  Paul Culley <paulr2787@gmail.com>
-
-	* gramps/plugins/export/exportftree.py: Fix Export Web Family Tree
-	for errors on file write (#525) Fixes #10364
-
-2018-01-19  Paul Culley <paulr2787@gmail.com>
-
-	* gramps/gui/glade/editcitation.glade: Fix Citation Editor to Tab
-	out of Confidence ComboBox (#526) Fixes #10351
-
-2018-01-15  John Ralls <jralls@ceridwen.us>
-
-	* mac/gramps.modules: Reset the dependencies on the new meta-module.
-
-2018-01-15  John Ralls <jralls@ceridwen.us>
-
-	* mac/gramps.modules: Use online modules.  Instead of the path that works on my machines only.
-
-2018-01-15  John Ralls <jralls@ceridwen.us>
-
-	* mac/gramps.modules: Consolidate Python2 and Python3 meta-modules.  GObject-Introspection now works with Python3 so the split isn't
-	needed any more.
-
-2018-01-13  Nick Hall <nick-h@gramps-project.org>
-
-	* gramps/gui/views/listview.py: Use None as the foreground colour
-	for untagged rows in list views The call to get_style_context is not required.  It also caused
-	problems in Windows due to excessive calls to the foreground_color
-	method.  Fixes #10365.
-
-2017-12-18  Nick Hall <nick-h@gramps-project.org>
-
-	* gramps/gui/widgets/__init__.py, gramps/gui/widgets/shadebox.py,
-	gramps/plugins/view/relview.py, po/POTFILES.skip: Fix shading colour
-	in relationship view for dark themes Fixes #7749.
-
-2017-12-18  Nick Hall <nick-h@gramps-project.org>
-
-	* gramps/gui/utils.py, gramps/gui/widgets/grampletpane.py,
-	gramps/gui/widgets/labels.py,
-	gramps/gui/widgets/styledtexteditor.py: Fix link colour for dark
-	themes Issue #7749.
-
-2017-12-18  Nick Hall <nick-h@gramps-project.org>
-
-	* gramps/gui/views/listview.py,
-	gramps/gui/views/treemodels/citationbasemodel.py,
-	gramps/gui/views/treemodels/eventmodel.py,
-	gramps/gui/views/treemodels/familymodel.py,
-	gramps/gui/views/treemodels/mediamodel.py,
-	gramps/gui/views/treemodels/notemodel.py,
-	gramps/gui/views/treemodels/peoplemodel.py,
-	gramps/gui/views/treemodels/placemodel.py,
-	gramps/gui/views/treemodels/repomodel.py,
-	gramps/gui/views/treemodels/sourcemodel.py,
-	gramps/gui/views/treemodels/treebasemodel.py: Fix default foreground
-	colour in list views for dark themes Issue #7749.
-
-2017-02-20  prculley <paulr2787@gmail.com>
-
-	* gramps/gui/undohistory.py: fix Undo; crashes due to race in Gtk Some Redraws occur during a model clear when the row changed signal
-	is emmitted.  Model is only partially cleared at that point.  Under
-	some conditions, some more of the model gets cleared before the
-	redraw completes, and redraw fails.  fixes #9932
-
-2017-05-29  prculley <paulr2787@gmail.com>
-
-	* gramps/plugins/lib/libgedcom.py: Gedcom import with OBJE/FORM URL
-	on event Fixes #7593.
-
-2017-06-04  Josip <bpisoj@gmail.com>
-
-	* gramps/gui/clipboard.py: EOFError [Ran out of input] in Clipboard
-	(#411) [EOFError: Ran out of input] for Clipboard when you drag and drop
-	the bolded lines in selected tabs of Person Edit Attempt to drag and drop any of the "bolded lines" in the Events or
-	Names tabs into the clipboard window. The unbolded lines drag and
-	drop ok.  Fixes #8788.
-
-2017-05-28  Josip <bpisoj@gmail.com>
-
-	* gramps/gui/clipboard.py: Cannot drag & drop textual value via
-	clipboard Allows dnd of textual values from clipboard and shows icon of
-	target-type during dragging instead of row image, except for text
-	target shows actual text as drag icon.  Fixes #7532.
-
-2017-10-06  prculley <paulr2787@gmail.com>
-
-	* gramps/gen/utils/callback.py: Fix 'DbBsddbRead' object has no
-	attribute '_Callback__callback_map' Fixes #10219 Same idea as 87a5412 for Gramps50
-
-2017-09-24  SNoiraud <serge.noiraud@laposte.net>
-
-	* gramps/plugins/webreport/narrativeweb.py: Reports - Narrated Web
-	Site Failure Fixes #10206
-
-2017-08-26  John Ralls <jralls@ceridwen.us>
-
-	* mac/gramps.bundle: Fix link path in gramps-launcher compile
-	instructions.
-
-2017-08-26  John Ralls <jralls@ceridwen.us>
-
-	* mac/Info.plist, mac/gramps.modules: Release 4.2.6 on Mac.
-
-2017-08-01  romjerome <romjerome@users.noreply.github.com>
-
-	* bump to 4.2.7
+	* Bump to 4.2.8
 

NEWS

@@ -1,3 +1,7 @@
+2018-02-09
+Version 4.2.8
+* Fix Geography views for bad 'dbstate.is_open()' test
+
 2018-02-08
 Version 4.2.7
 * Fix Export View to CSV when Unicode characters are present

gramps/gen/const.py

@@ -132,7 +132,7 @@ sys.path.insert(0, ROOT_DIR)
 git_revision = get_git_revision(ROOT_DIR)
 if sys.platform == 'win32' and git_revision == "":
     git_revision = get_git_revision(os.path.split(ROOT_DIR)[1])
-#VERSION += git_revision
+VERSION += git_revision
 #VERSION += "-1"
 
 #
@@ -190,7 +190,7 @@ GTK_GETTEXT_DOMAIN = 'gtk30'
 #
 #-------------------------------------------------------------------------
 COPYRIGHT_MSG  = "© 2001-2006 Donald N. Allingham\n" \
-                 "© 2007-2016 The Gramps Developers"
+                 "© 2007-2018 The Gramps Developers"
 COMMENTS       = _("Gramps\n (Genealogical Research and Analysis "
                    "Management Programming System)\n"
                    "is a personal genealogy program.")

gramps/gen/db/write.py

@@ -763,11 +763,11 @@ class DbBsddb(DbBsddbRead, DbWriteBase, UpdateCallback):
         
         # The DB_PRIVATE flag must go if we ever move to multi-user setup
         env_flags = db.DB_CREATE | db.DB_PRIVATE |\
-                    db.DB_INIT_MPOOL |\
-                    db.DB_INIT_LOG | db.DB_INIT_TXN
-
-        # As opposed to before, we always try recovery on databases
-        env_flags |= db.DB_RECOVER
+                    db.DB_INIT_MPOOL
+        if not self.readonly:
+            env_flags |= db.DB_INIT_LOG | db.DB_INIT_TXN
+            # As opposed to before, we always try recovery on databases
+            env_flags |= db.DB_RECOVER
 
         # Environment name is now based on the filename
         env_name = name
@@ -782,7 +782,8 @@ class DbBsddb(DbBsddbRead, DbWriteBase, UpdateCallback):
                 pass
             raise DbEnvironmentError(msg)
 
-        self.env.txn_checkpoint()
+        if not self.readonly:
+            self.env.txn_checkpoint()
 
         if callback:
             callback(25)
@@ -1478,7 +1479,8 @@ class DbBsddb(DbBsddbRead, DbWriteBase, UpdateCallback):
             return
         if self.txn:
             self.transaction_abort(self.transaction)
-        self.env.txn_checkpoint()
+        if not self.readonly:
+            self.env.txn_checkpoint()
 
         self.__close_metadata()
         self.name_group.close()

gramps/gen/plug/docgen/graphdoc.py

@@ -986,7 +986,7 @@ class GVPdfGsDoc(GVDocBase):
             os.system(command)
         # Merge pieces to single multipage PDF ;
         command = '%s -q -dBATCH -dNOPAUSE '\
-            '-sOUTPUTFILE=%s -r72 -sDEVICE=pdfwrite %s '\
+            '-sOUTPUTFILE="%s" -r72 -sDEVICE=pdfwrite %s '\
             % (_GS_CMD, self._filename, ' '.join(list_of_pieces))
         os.system(command)
 

gramps/gui/widgets/fanchartdesc.py

@@ -615,7 +615,7 @@ class FanChartDescWidget(FanChartBaseWidget):
         elif nrparent <= 4:
             angleinc = math.pi/2
         else:
-            angleinc = 2 * math.pi / nrchild
+            angleinc = 2 * math.pi / nrparent
         for data in self.parentsroot:
             self.draw_innerring(cr, data[0], data[1], startangle, angleinc)
             startangle += angleinc

gramps/plugins/view/geoclose.py

@@ -314,7 +314,7 @@ class GeoClose(GeoGraphyView):
         information.
         """
         self.lifeway_layer.clear_ways()
-        if not self.dbstate.is_open():
+        if not self.dbstate.open:
             return
         active = self.get_active()
         if active:

gramps/plugins/view/geoevents.py

@@ -188,7 +188,7 @@ class GeoEvents(GeoGraphyView):
         all handling of visibility is now in rebuild_trees, see that for more
         information.
         """
-        if not self.dbstate.is_open():
+        if not self.dbstate.open:
             return
         active = self.uistate.get_active('Event')
         if active:

gramps/plugins/view/geofamclose.py

@@ -305,7 +305,7 @@ class GeoFamClose(GeoGraphyView):
         information.
         """
         self.lifeway_layer.clear_ways()
-        if not self.dbstate.is_open():
+        if not self.dbstate.open:
             return
         active = self.get_active()
         family = self.dbstate.db.get_family_from_handle(active)

gramps/plugins/view/geofamily.py

@@ -178,7 +178,7 @@ class GeoFamily(GeoGraphyView):
         all handling of visibility is now in rebuild_trees, see that for more
         information.
         """
-        if not self.dbstate.is_open():
+        if not self.dbstate.open:
             return
         if self.uistate.get_active('Family'):
             self._createmap(self.uistate.get_active('Family'))

gramps/plugins/view/geoperson.py

@@ -215,7 +215,7 @@ class GeoPerson(GeoGraphyView):
         all handling of visibility is now in rebuild_trees, see that for more
         information.
         """
-        if not self.dbstate.is_open():
+        if not self.dbstate.open:
             return
         active = self.get_active()
         self._createmap(active)

gramps/plugins/view/geoplaces.py

@@ -189,7 +189,7 @@ class GeoPlaces(GeoGraphyView):
         all handling of visibility is now in rebuild_trees, see that for more
         information.
         """
-        if not self.dbstate.is_open():
+        if not self.dbstate.open:
             return
         active = self.uistate.get_active('Place')
         if active:

gramps/version.py

@@ -18,6 +18,6 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #
 
-VERSION_TUPLE = (4, 2, 7)
+VERSION_TUPLE = (4, 2, 9)
 VERSION        = '.'.join(map(str,VERSION_TUPLE))
 major_version = "%s.%s" % (VERSION_TUPLE[0], VERSION_TUPLE[1])

mac/Info.plist

@@ -7,7 +7,7 @@
     <key>CFBundleExecutable</key>
     <string>Gramps</string>
     <key>CFBundleGetInfoString</key>
-    <string>Gramps-4.2.6, (C) 1997-2017 The Gramps Team http://www.gramps-project.org</string>
+    <string>Gramps-4.2.8, (C) 1997-2018 The Gramps Team http://www.gramps-project.org</string>
     <key>CFBundleIconFile</key>
     <string>gramps.icns</string>
     <key>CFBundleIdentifier</key>
@@ -17,11 +17,11 @@
     <key>CFBundlePackageType</key>
     <string>APPL</string>
     <key>CFBundleShortVersionString</key>
-    <string>4.2.6</string>
+    <string>4.2.8</string>
     <key>CFBundleSignature</key>
     <string>????</string>
     <key>CFBundleVersion</key>
-    <string>Gramps-4.2.6-1</string>
+    <string>Gramps-4.2.8-1</string>
     <key>NSHumanReadableCopyright</key>
     <string>Copyright 1997 - 2017 The Gramps Team, GNU General Public License.</string>
     <key>LSMinimumSystemVersion</key>

mac/gramps.bundle

@@ -231,4 +231,15 @@
     ${project}/settings.ini
   </data>
 
+  <data>
+    ${prefix}/share/doc/gramps/*
+  </data>
+  
+  <data>
+    ${prefix}/share/doc/gramps/example/gedcom/sample.ged
+  </data>
+
+  <data>
+    ${prefix}/share/doc/gramps/example/gramps/*
+  </data>
 </app-bundle>

mac/gramps.modules

@@ -18,7 +18,7 @@
   <repository type="tarball" name="oracle"
 	      href="http://download.oracle.com/"/>
   <repository type="tarball" name="pymodules"
-	      href="http://pypi.python.org/packages/source/"/>
+	      href="https://pypi.python.org/packages/"/>
   <repository type="tarball" name="stowers"
 	     href="http://www.johnstowers.co.nz/files/"/>
   <repository type="git" name="github"
@@ -66,9 +66,9 @@ gtk-mac-bundler gtk-osx-build/projects/gramps/gramps.bundle
   </distutils>
 
   <distutils id="gramps" supports-non-srcdir-builds="no">
-    <branch module="gramps-project/gramps/archive/v4.2.6.tar.gz"
-	    repo="github-tarball" version="4.2.6"
-	    checkoutdir="gramps-gramps-4.2.6"/>
+    <branch module="gramps-project/gramps/archive/v4.2.8.tar.gz"
+	    repo="github-tarball" version="4.2.8"
+	    checkoutdir="gramps-gramps-4.2.8"/>
     <dependencies>
       <dep package="meta-gramps-modules"/>
     </dependencies>
@@ -112,9 +112,12 @@ gtk-mac-bundler gtk-osx-build/projects/gramps/gramps.bundle
 	     supports-non-srcdir-builds="no">
     <branch module="nzjrs/osm-gps-map" revision="1.0.2" repo="github"/>
     <dependencies>
-      <dep package="meta-gtk-osx-gtk3"/>
       <dep package="libsoup"/>
     </dependencies>
+    <after>
+      <dep package="meta-gtk-osx-gtk3"/>
+      <dep package="meta-gtk-osx-gtk3.14"/>
+    </after>
   </autotools>
 
   <autotools id="graphviz" autogen-sh="configure"
@@ -160,8 +163,8 @@ gtk-mac-bundler gtk-osx-build/projects/gramps/gramps.bundle
   </distutils>
 
  <distutils id='pyicu'>
-    <branch version='1.8' repo='pymodules'
-	    module='P/PyICU/PyICU-1.8.tar.gz'/>
+    <branch version='2.0.3' repo='pymodules'
+	    module='bb/ef/3a7fcbba81bfd213e479131ae21445a2ddd14b46d70ef0109640b580bc5d/PyICU-2.0.3.tar.gz'/>
     <dependencies>
       <dep package='icu'/>
     </dependencies>
@@ -170,8 +173,7 @@ gtk-mac-bundler gtk-osx-build/projects/gramps/gramps.bundle
   <metamodule id="meta-gramps-modules">
     <dependencies>
       <dep package="python3"/>
-      <dep package="meta-gtk-osx-gtk3"/>
-      <dep package="gtk-mac-integration-python"/>
+      <dep package="meta-gtk-osx-gtk3.14"/>
       <dep package="meta-gtk-osx-gtk3-core-themes"/>
       <dep package="goocanvas2"/>
       <dep package="librsvg"/>
@@ -183,10 +185,12 @@ gtk-mac-bundler gtk-osx-build/projects/gramps/gramps.bundle
       <dep package="pil"/>
       <dep package="gexiv2"/>
       <dep package="berkeleydb"/>
+      <dep package="gtk-mac-integration-python"/>
       <dep package="pycairo"/>
       <dep package="pygobject3"/>
       <dep package='pyicu'/>
       <dep package='pybsddb'/>
+      <dep package="pil"/>
     </dependencies>
   </metamodule>
 

po/ChangeLog

@@ -1,8 +0,0 @@
-2018-01-29  niememat <niememat@gmail.com>
-
-	* po/fi.po: Update finnish translation
-
-2018-01-27  Leonhaeuser <mirko@leonhaeuser.de>
-
-	* update German translation
-