ElyBy-Mirror/chrly
1
0
Fork 0
mirror of https://github.com/elyby/chrly.git synced 2024-12-22 21:19:55 +05:30
Code Issues Packages Projects Releases Wiki Activity

Fixes CHRLY-S. Don't return an error for an invalid username

Browse Source
This commit is contained in:
ErickSkrauch 2021-03-03 00:24:31 +01:00
parent d1d2c7ee6e
commit 1e3307dcbe
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mojangtextures/mojang_textures.go
View File

@ -1,7 +1,6 @@
package mojangtextures package mojangtextures
import ( import (
"errors"
"regexp" "regexp"
"strings" "strings"
"sync" "sync"
@ -92,7 +91,7 @@ func (ctx *Provider) GetForUsername(username string) (*mojang.SignedTexturesResp
}) })
if !allowedUsernamesRegex.MatchString(username) { if !allowedUsernamesRegex.MatchString(username) {
return nil, errors.New("invalid username") return nil, nil
} }
username = strings.ToLower(username) username = strings.ToLower(username)

2
mojangtextures/mojang_textures_test.go
View File

@ -391,7 +391,7 @@ func (suite *providerTestSuite) TestGetForTheSameUsernames() {
func (suite *providerTestSuite) TestGetForNotAllowedMojangUsername() { func (suite *providerTestSuite) TestGetForNotAllowedMojangUsername() {
result, err := suite.Provider.GetForUsername("Not allowed") result, err := suite.Provider.GetForUsername("Not allowed")
suite.Assert().Error(err, "invalid username") suite.Assert().Nil(err)
suite.Assert().Nil(result) suite.Assert().Nil(result)
} }