#1: Add test case for panic when trying to store response without textures

This commit is contained in:
ErickSkrauch 2019-04-30 00:45:29 +03:00
parent f213ed45c7
commit 94b930f388
2 changed files with 18 additions and 16 deletions

View File

@ -1,7 +1,6 @@
package queue
import (
"errors"
"sync"
"time"
@ -71,21 +70,9 @@ func (s *inMemoryTexturesStorage) StoreTextures(textures *mojang.SignedTexturesR
s.lock.Lock()
defer s.lock.Unlock()
var texturesProp *mojang.Property
for _, prop := range textures.Props {
if prop.Name == "textures" {
texturesProp = prop
break
}
}
if texturesProp == nil {
panic(errors.New("unable to find textures property"))
}
decoded, err := mojang.DecodeTextures(texturesProp.Value)
if err != nil {
panic(err)
decoded := textures.DecodeTextures()
if decoded == nil {
panic("unable to decode textures")
}
s.data[textures.Id] = &inMemoryItem{

View File

@ -109,6 +109,21 @@ func TestInMemoryTexturesStorage_StoreTextures(t *testing.T) {
assert.Equal(texturesWithSkin, result)
assert.Nil(err)
})
t.Run("should panic if textures prop is not decoded", func(t *testing.T) {
assert := testify.New(t)
toStore := &mojang.SignedTexturesResponse{
Id: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
Name: "mock",
Props: []*mojang.Property{},
}
assert.PanicsWithValue("unable to decode textures", func() {
storage := CreateInMemoryTexturesStorage()
storage.StoreTextures(toStore)
})
})
}
func TestInMemoryTexturesStorage_GarbageCollection(t *testing.T) {