ElyBy-Mirror/oauth2-server
1
0
Fork 0
mirror of https://github.com/elyby/oauth2-server.git synced 2024-12-22 13:09:44 +05:30
Code Issues Packages Projects Releases Wiki Activity

Fixed count placement to make code more efficient as per scrutinizer feedback

Browse Source
This commit is contained in:
Andrew Millington 2017-12-29 12:25:39 +00:00
parent 57ca83a8ba
commit 5b79b40df9
No known key found for this signature in database
GPG Key ID: 815DE090877B53F3
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
examples/public/api.php
View File

@ -49,16 +49,18 @@ $app->get(
], ],
]; ];
$totalUsers = count($users);
// If the access token doesn't have the `basic` scope hide users' names // If the access token doesn't have the `basic` scope hide users' names
if (in_array('basic', $request->getAttribute('oauth_scopes')) === false) { if (in_array('basic', $request->getAttribute('oauth_scopes')) === false) {
for ($i = 0; $i < count($users); $i++) { for ($i = 0; $i < $totalUsers; $i++) {
unset($users[$i]['name']); unset($users[$i]['name']);
} }
} }
// If the access token doesn't have the `email` scope hide users' email addresses // If the access token doesn't have the `email` scope hide users' email addresses
if (in_array('email', $request->getAttribute('oauth_scopes')) === false) { if (in_array('email', $request->getAttribute('oauth_scopes')) === false) {
for ($i = 0; $i < count($users); $i++) { for ($i = 0; $i < $totalUsers; $i++) {
unset($users[$i]['email']); unset($users[$i]['email']);
} }
} }