Erick Torres
ce2662ece7
Merge branch 'master' of github.com:thephpleague/oauth2-server into fix-pkce-implementation
...
# Conflicts:
# tests/Grant/AuthCodeGrantTest.php
2018-02-05 15:32:15 -05:00
Sergio Gómez
1b692e2298
Fix S256 code challenge method
...
According to [RFC7636#section-4.3](https://tools.ietf.org/html/rfc7636#section-4.3 ):
If the "code_challenge_method" from Section 4.3 was "S256", the
received "code_verifier" is hashed by SHA-256, base64url-encoded, and
then compared to the "code_challenge", i.e.:
BASE64URL-ENCODE(SHA256(ASCII(code_verifier))) == code_challenge
So, the hash must be done before the base64_encode.
The tests are modified to use example data from the
[RFC7636#appendix-B](https://tools.ietf.org/html/rfc7636#appendix-B ).
2018-01-18 05:31:44 +01:00
Erick Torres
01d21b2533
Update statement to generate codeChallenge in AuthCodeGrantTest
2017-12-29 12:32:12 -05:00
Andrew Millington
b6d9835281
Merge branch 'master' into fix-pkce-implementation
2017-12-28 16:37:37 +00:00
Andrew Millington
57ca83a8ba
Removing missing scope tests as temporarily reverted this functionality
2017-12-24 00:18:20 +00:00
Andrew Millington
41bba7f58c
Removing missing scope test
...
Temporarily removing missing scope test as have reverted this functionality for version 6.1.1
2017-12-24 00:07:22 +00:00
Andrew Millington
dcae4af6ce
Remove missing scope test
...
Temporarily removing missing scope test for the AuthGrant
2017-12-24 00:06:18 +00:00
Andrew Millington
1c36b70dab
Fixed ordering so we only hash after base64 encoding
2017-12-23 02:06:18 +00:00
Andrew Millington
f11e4c81cd
Merge pull request #697 from fkooman/fix-s256
...
Fix PKCE code verifier encoding to match specification
2017-12-23 01:52:33 +00:00
Gabriel Caruso
9ceafe5dd3
Refactoring tests
2017-12-06 18:24:42 -02:00
Sephster
b50c7622db
Add in validation for authorization requests.
...
Fixes thephpleague/oauth2-server#677
2017-11-14 00:12:04 +00:00
Sephster
dc9c1a1023
Remove blank line to keep code consistent
2017-11-13 23:59:55 +00:00
Sephster
7878cf9c13
Merge remote-tracking branch 'upstream/master'
2017-11-13 23:52:36 +00:00
Sephster
1bcee9aaba
Add a test for a missing scope for the password grant
2017-11-13 23:16:30 +00:00
Sephster
1e3a84fc85
Add a test to ensure response requests fail without a scope specified
2017-11-13 23:00:27 +00:00
Sephster
a5c5929dc9
Change default scope to be basic
2017-11-13 22:34:12 +00:00
Sephster
65789e0f39
Fix tests to support default scopes for authorization requests
2017-11-13 22:20:42 +00:00
Gabriel Caruso
04f3d39b45
Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase
2017-11-08 16:07:07 -02:00
Andrew Millington
ce8248c10f
Remove erroneous character
2017-11-06 22:56:54 +00:00
Andrew Millington
13be557825
Re-add the complete testCompleteAuthorizationRequestNoUser()
2017-11-06 22:51:11 +00:00
Andrew Millington
0f08063864
Fixed use of default scope so it is only for authorization requests
2017-11-06 22:33:28 +00:00
Andrew Millington
bd2cdaf5da
Change missing scope test to check for invalid_scope exception
2017-10-31 23:01:19 +00:00
Andrew Millington
d0619385b8
Add a basic test to ensure we throw an exception when no scope is given
2017-10-31 21:00:14 +00:00
Andrew Millington
f9143b5163
Fix the refresh token grant test
2017-10-30 23:26:11 +00:00
Brian Retterer
23c7138d48
Apply fixes from StyleCI
2017-10-23 15:26:10 +00:00
Andrew Millington
24f29b6382
Fix more tests to support default scope setting
2017-10-19 22:37:19 +01:00
Andrew Millington
4d28eadf93
Update tests so they don't trigger missing or invalid scope exceptions
2017-10-18 22:11:02 +01:00
Erick Torres
e2f9b73df3
Fix broken tests
2017-07-07 12:19:11 -05:00
Erick Torres
fbb3586cae
Merge branch 'master' of github.com:erickjth/oauth2-server into fix-pkce-implementation
...
# Conflicts:
# src/Grant/AuthCodeGrant.php
# tests/Grant/AuthCodeGrantTest.php
2017-07-07 12:06:32 -05:00
Alex Bilbie
aac467e616
Fixed broken tests
2017-07-01 18:11:19 +01:00
Alex Bilbie
57d199b889
Stricter validation of code challenge value to match RFC 7636 requirements
2017-07-01 16:44:43 +01:00
Erick Torres
11ad87b5f5
Update tests / Add missing.
2017-06-16 12:03:14 -05:00
François Kooman
6426e597a3
Fix PKCE code verifier encoding to match specification
...
The current implementation of PKCE does not follow the specification
correctly regarding the encoding of the code verifier. This patch
correctly encodes the hash of the code verifier according to
Appenix A of RFC 7636.
2017-01-24 11:36:34 +01:00
Alex Bilbie
56e8d374fb
Fix broken tests
2016-09-19 10:06:00 +01:00
Alex Bilbie
11ccc305d0
Applied fixes from StyleCI
2016-09-13 14:17:09 +00:00
Lukáš Unger
17b6e2a207
tests: Fix missing redirect uri test, add redirect uri mismatch test
2016-07-08 16:04:14 +02:00
Lukáš Unger
54422a244f
tests: AuthCodeGrantTest additional tests
2016-07-08 15:31:29 +02:00
Lukáš Unger
9899aa1f99
tests: ImplicitGrantTest additional tests
2016-07-08 15:30:59 +02:00
Lukáš Unger
32efd091a1
tests: use MockBuilder everywhere
2016-07-08 15:29:21 +02:00
Alex Bilbie
df20da1235
Merge pull request #601 from zerkms/ISSUE-596_UNIQUE_ACCESS_TOKEN
...
Added a check for unique access token constraint violation
2016-06-28 08:48:38 +01:00
Ian Littman
9775c0076b
Look at Authorization header directly for HTTP Basic auth check
...
Should allow for better compatibility with server implementations that aren't sitting on top of a standard SAPI (e.g. persistent web servers building a PSR-7 compatible request from a socket-received message).
One catch here is that I've seen Apache hijack the HTTP Authorization header in the past, though that would probably impact the other aspects of the server just as much as it would this, so I think that risk is manageable.
Added tests to cover all paths through the new code, so the AbstractGrant type still has 100% coverage :)
Did notice that, as of the latest versions of PHPUnit, the mock creation method is deprecated. Maybe that needs to be updated? Haven't checked to see whether the replacements are PHPUnit 4.8 compatible though, so maybe they need to stay in order to test on older PHP versions?
2016-06-21 21:08:38 -05:00
Ivan Kurnosov
b68ef973df
Added a check for unique access token constraint violation
2016-06-20 20:19:03 +12:00
Ivan Kurnosov
6b88cbeb13
Removed isExpired() from interfaces and traits
2016-06-17 19:50:04 +12:00
Alex Bilbie
8e8aed1a50
Implemented RFC7636. Fixes #574
2016-05-06 15:23:16 +01:00
Alex Bilbie
103b0cc50d
Fixed broken test
2016-04-10 17:15:48 +01:00
Alex Bilbie
495b55d1e8
Applied fixes from StyleCI
2016-04-10 11:14:08 -04:00
Alex Bilbie
92a483b3bd
Improved tests
2016-04-10 16:14:01 +01:00
Alex Bilbie
5969082963
Fix tests and improve code coverate
2016-04-10 15:58:01 +01:00
Alex Bilbie
7a6d9a4510
Fixed broken AuthCodeGrant tests
2016-04-10 15:15:29 +01:00
Alex Bilbie
a0c4900ee7
Client is not required here because of finalizeScopes method
2016-04-10 13:53:16 +01:00
