2006-07-03 01:17:05 +05:30
|
|
|
/* vi: set sw=4 ts=4: */
|
2010-03-26 14:39:34 +05:30
|
|
|
/*
|
2006-05-08 08:50:50 +05:30
|
|
|
* Russ Dill <Russ.Dill@asu.edu> September 2001
|
|
|
|
* Rewritten by Vladimir Oleynik <dzo@simtreas.ru> (C) 2003
|
|
|
|
*
|
2010-08-16 23:44:46 +05:30
|
|
|
* Licensed under GPLv2 or later, see file LICENSE in this source tree.
|
2006-05-08 08:50:50 +05:30
|
|
|
*/
|
2009-04-09 18:05:13 +05:30
|
|
|
#ifndef UDHCP_COMMON_H
|
|
|
|
#define UDHCP_COMMON_H 1
|
2006-05-08 08:50:50 +05:30
|
|
|
|
2007-05-27 00:30:18 +05:30
|
|
|
#include "libbb.h"
|
2016-04-21 19:56:30 +05:30
|
|
|
#include "common_bufsiz.h"
|
2008-05-09 23:29:34 +05:30
|
|
|
#include <netinet/udp.h>
|
|
|
|
#include <netinet/ip.h>
|
|
|
|
|
2009-04-09 18:05:13 +05:30
|
|
|
PUSH_AND_SET_FUNCTION_VISIBILITY_TO_HIDDEN
|
2006-11-19 01:21:32 +05:30
|
|
|
|
2012-07-26 16:28:41 +05:30
|
|
|
extern const uint8_t MAC_BCAST_ADDR[6] ALIGN2; /* six all-ones */
|
2006-11-19 01:21:32 +05:30
|
|
|
|
2010-03-22 18:59:13 +05:30
|
|
|
|
|
|
|
/*** DHCP packet ***/
|
2006-11-19 01:21:32 +05:30
|
|
|
|
2010-03-21 10:45:28 +05:30
|
|
|
/* DHCP protocol. See RFC 2131 */
|
|
|
|
#define DHCP_MAGIC 0x63825363
|
|
|
|
#define DHCP_OPTIONS_BUFSIZE 308
|
|
|
|
#define BOOTREQUEST 1
|
|
|
|
#define BOOTREPLY 2
|
2007-11-25 08:45:24 +05:30
|
|
|
|
2009-06-17 15:27:09 +05:30
|
|
|
//TODO: rename ciaddr/yiaddr/chaddr
|
|
|
|
struct dhcp_packet {
|
2010-03-21 10:45:28 +05:30
|
|
|
uint8_t op; /* BOOTREQUEST or BOOTREPLY */
|
2008-09-27 05:15:20 +05:30
|
|
|
uint8_t htype; /* hardware address type. 1 = 10mb ethernet */
|
|
|
|
uint8_t hlen; /* hardware address length */
|
|
|
|
uint8_t hops; /* used by relay agents only */
|
|
|
|
uint32_t xid; /* unique id */
|
|
|
|
uint16_t secs; /* elapsed since client began acquisition/renewal */
|
|
|
|
uint16_t flags; /* only one flag so far: */
|
|
|
|
#define BROADCAST_FLAG 0x8000 /* "I need broadcast replies" */
|
|
|
|
uint32_t ciaddr; /* client IP (if client is in BOUND, RENEW or REBINDING state) */
|
|
|
|
uint32_t yiaddr; /* 'your' (client) IP address */
|
2009-06-16 13:55:35 +05:30
|
|
|
/* IP address of next server to use in bootstrap, returned in DHCPOFFER, DHCPACK by server */
|
|
|
|
uint32_t siaddr_nip;
|
2019-05-23 18:54:03 +05:30
|
|
|
uint32_t gateway_nip; /* aka 'giaddr': relay agent IP address */
|
2009-06-16 13:55:35 +05:30
|
|
|
uint8_t chaddr[16]; /* link-layer client hardware address (MAC) */
|
|
|
|
uint8_t sname[64]; /* server host name (ASCIZ) */
|
|
|
|
uint8_t file[128]; /* boot file name (ASCIZ) */
|
|
|
|
uint32_t cookie; /* fixed first four option bytes (99,130,83,99 dec) */
|
2007-11-25 08:45:24 +05:30
|
|
|
uint8_t options[DHCP_OPTIONS_BUFSIZE + CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS];
|
2020-10-02 03:19:16 +05:30
|
|
|
};
|
2010-03-21 05:13:11 +05:30
|
|
|
#define DHCP_PKT_SNAME_LEN 64
|
|
|
|
#define DHCP_PKT_FILE_LEN 128
|
|
|
|
#define DHCP_PKT_SNAME_LEN_STR "64"
|
|
|
|
#define DHCP_PKT_FILE_LEN_STR "128"
|
2006-11-19 01:21:32 +05:30
|
|
|
|
2009-06-17 15:27:09 +05:30
|
|
|
struct ip_udp_dhcp_packet {
|
2006-11-19 01:21:32 +05:30
|
|
|
struct iphdr ip;
|
|
|
|
struct udphdr udp;
|
2009-06-17 15:27:09 +05:30
|
|
|
struct dhcp_packet data;
|
2020-10-02 03:19:16 +05:30
|
|
|
};
|
2007-11-23 05:38:54 +05:30
|
|
|
|
2010-05-31 03:11:23 +05:30
|
|
|
struct udp_dhcp_packet {
|
|
|
|
struct udphdr udp;
|
|
|
|
struct dhcp_packet data;
|
2020-10-02 03:19:16 +05:30
|
|
|
};
|
2010-05-31 03:11:23 +05:30
|
|
|
|
|
|
|
enum {
|
2010-10-20 21:34:36 +05:30
|
|
|
IP_UDP_DHCP_SIZE = sizeof(struct ip_udp_dhcp_packet) - CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS,
|
|
|
|
UDP_DHCP_SIZE = sizeof(struct udp_dhcp_packet) - CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS,
|
2010-05-31 03:11:23 +05:30
|
|
|
DHCP_SIZE = sizeof(struct dhcp_packet) - CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS,
|
|
|
|
};
|
|
|
|
|
2007-11-23 05:38:54 +05:30
|
|
|
/* Let's see whether compiler understood us right */
|
2009-06-17 15:27:09 +05:30
|
|
|
struct BUG_bad_sizeof_struct_ip_udp_dhcp_packet {
|
2010-10-20 21:34:36 +05:30
|
|
|
char c[IP_UDP_DHCP_SIZE == 576 ? 1 : -1];
|
2006-11-19 01:21:32 +05:30
|
|
|
};
|
|
|
|
|
2010-03-22 18:59:13 +05:30
|
|
|
|
|
|
|
/*** Options ***/
|
|
|
|
|
|
|
|
enum {
|
2020-06-10 03:29:54 +05:30
|
|
|
OPTION_IP = 0,
|
2010-03-22 18:59:13 +05:30
|
|
|
OPTION_IP_PAIR,
|
|
|
|
OPTION_STRING,
|
2011-12-08 21:11:05 +05:30
|
|
|
/* Opts of STRING_HOST type will be sanitized before they are passed
|
|
|
|
* to udhcpc script's environment: */
|
|
|
|
OPTION_STRING_HOST,
|
2010-03-26 13:05:24 +05:30
|
|
|
// OPTION_BOOLEAN,
|
2010-03-22 18:59:13 +05:30
|
|
|
OPTION_U8,
|
|
|
|
OPTION_U16,
|
2010-03-26 13:05:24 +05:30
|
|
|
// OPTION_S16,
|
2010-03-22 18:59:13 +05:30
|
|
|
OPTION_U32,
|
|
|
|
OPTION_S32,
|
2010-04-04 19:01:12 +05:30
|
|
|
OPTION_BIN,
|
2010-03-22 18:59:13 +05:30
|
|
|
OPTION_STATIC_ROUTES,
|
2011-10-20 02:10:35 +05:30
|
|
|
OPTION_6RD,
|
2017-06-28 22:48:17 +05:30
|
|
|
#if ENABLE_FEATURE_UDHCP_RFC3397 || ENABLE_FEATURE_UDHCPC6_RFC3646 || ENABLE_FEATURE_UDHCPC6_RFC4704
|
2010-04-04 19:01:12 +05:30
|
|
|
OPTION_DNS_STRING, /* RFC1035 compressed domain name list */
|
2017-06-28 22:48:17 +05:30
|
|
|
#endif
|
|
|
|
#if ENABLE_FEATURE_UDHCP_RFC3397
|
2010-04-04 19:01:12 +05:30
|
|
|
OPTION_SIP_SERVERS,
|
|
|
|
#endif
|
2010-03-22 18:59:13 +05:30
|
|
|
|
|
|
|
OPTION_TYPE_MASK = 0x0f,
|
|
|
|
/* Client requests this option by default */
|
|
|
|
OPTION_REQ = 0x10,
|
|
|
|
/* There can be a list of 1 or more of these */
|
|
|
|
OPTION_LIST = 0x20,
|
|
|
|
};
|
|
|
|
|
2020-06-24 01:55:08 +05:30
|
|
|
struct dhcp_scan_state {
|
|
|
|
int overload;
|
|
|
|
int rem;
|
|
|
|
uint8_t *optionptr;
|
|
|
|
};
|
|
|
|
|
2010-03-22 18:59:13 +05:30
|
|
|
/* DHCP option codes (partial list). See RFC 2132 and
|
|
|
|
* http://www.iana.org/assignments/bootp-dhcp-parameters/
|
|
|
|
* Commented out options are handled by common option machinery,
|
2011-10-20 12:24:16 +05:30
|
|
|
* uncommented ones have special cases (grep for them to see).
|
2010-03-22 18:59:13 +05:30
|
|
|
*/
|
|
|
|
#define DHCP_PADDING 0x00
|
|
|
|
#define DHCP_SUBNET 0x01
|
|
|
|
//#define DHCP_TIME_OFFSET 0x02 /* (localtime - UTC_time) in seconds. signed */
|
|
|
|
//#define DHCP_ROUTER 0x03
|
|
|
|
//#define DHCP_TIME_SERVER 0x04 /* RFC 868 time server (32-bit, 0 = 1.1.1900) */
|
|
|
|
//#define DHCP_NAME_SERVER 0x05 /* IEN 116 _really_ ancient kind of NS */
|
|
|
|
//#define DHCP_DNS_SERVER 0x06
|
2019-01-07 20:03:42 +05:30
|
|
|
//#define DHCP_LOG_SERVER 0x07 /* port 704 UDP log (not syslog) */
|
2010-03-22 18:59:13 +05:30
|
|
|
//#define DHCP_COOKIE_SERVER 0x08 /* "quote of the day" server */
|
|
|
|
//#define DHCP_LPR_SERVER 0x09
|
2018-07-04 19:35:48 +05:30
|
|
|
#define DHCP_HOST_NAME 0x0c /* 12: either client informs server or server gives name to client */
|
2010-03-22 18:59:13 +05:30
|
|
|
//#define DHCP_BOOT_SIZE 0x0d
|
2018-07-04 19:35:48 +05:30
|
|
|
//#define DHCP_DOMAIN_NAME 0x0f /* 15: server gives domain suffix */
|
2010-03-22 18:59:13 +05:30
|
|
|
//#define DHCP_SWAP_SERVER 0x10
|
|
|
|
//#define DHCP_ROOT_PATH 0x11
|
|
|
|
//#define DHCP_IP_TTL 0x17
|
|
|
|
//#define DHCP_MTU 0x1a
|
|
|
|
//#define DHCP_BROADCAST 0x1c
|
2010-09-26 03:45:12 +05:30
|
|
|
//#define DHCP_ROUTES 0x21
|
2010-03-22 18:59:13 +05:30
|
|
|
//#define DHCP_NIS_DOMAIN 0x28
|
|
|
|
//#define DHCP_NIS_SERVER 0x29
|
|
|
|
//#define DHCP_NTP_SERVER 0x2a
|
|
|
|
//#define DHCP_WINS_SERVER 0x2c
|
2018-07-04 19:35:48 +05:30
|
|
|
#define DHCP_REQUESTED_IP 0x32 /* 50: sent by client if specific IP is wanted */
|
|
|
|
#define DHCP_LEASE_TIME 0x33 /* 51: */
|
|
|
|
#define DHCP_OPTION_OVERLOAD 0x34 /* 52: */
|
|
|
|
#define DHCP_MESSAGE_TYPE 0x35 /* 53: */
|
|
|
|
#define DHCP_SERVER_ID 0x36 /* 54: server's IP */
|
|
|
|
#define DHCP_PARAM_REQ 0x37 /* 55: list of options client wants */
|
|
|
|
//#define DHCP_ERR_MESSAGE 0x38 /* 56: error message when sending NAK etc */
|
|
|
|
#define DHCP_MAX_SIZE 0x39 /* 57: */
|
|
|
|
#define DHCP_VENDOR 0x3c /* 60: client's vendor (a string) */
|
|
|
|
#define DHCP_CLIENT_ID 0x3d /* 61: by default client's MAC addr, but may be arbitrarily long */
|
|
|
|
//#define DHCP_TFTP_SERVER_NAME 0x42 /* 66: same as 'sname' field */
|
|
|
|
//#define DHCP_BOOT_FILE 0x43 /* 67: same as 'file' field */
|
|
|
|
//#define DHCP_USER_CLASS 0x4d /* 77: RFC 3004. set of LASCII strings. "I am a printer" etc */
|
|
|
|
#define DHCP_FQDN 0x51 /* 81: client asks to update DNS to map its FQDN to its new IP */
|
2019-03-08 19:54:42 +05:30
|
|
|
//#define DHCP_PCODE 0x64 /* 100: RFC 4833. IEEE 1003.1 TZ string */
|
|
|
|
//#define DHCP_TCODE 0x65 /* 101: RFC 4833. Reference to the TZ database string */
|
2018-07-04 19:35:48 +05:30
|
|
|
//#define DHCP_DOMAIN_SEARCH 0x77 /* 119: RFC 3397. set of ASCIZ string, DNS-style compressed */
|
|
|
|
//#define DHCP_SIP_SERVERS 0x78 /* 120: RFC 3361. flag byte, then: 0: domain names, 1: IP addrs */
|
|
|
|
//#define DHCP_STATIC_ROUTES 0x79 /* 121: RFC 3442. (mask,ip,router) tuples */
|
|
|
|
//#define DHCP_VLAN_ID 0x84 /* 132: 802.1P VLAN ID */
|
|
|
|
//#define DHCP_VLAN_PRIORITY 0x85 /* 133: 802.1Q VLAN priority */
|
2019-01-15 17:49:01 +05:30
|
|
|
//#define DHCP_PXE_CONF_FILE 0xd1 /* 209: RFC 5071 Configuration file */
|
|
|
|
//#define DHCP_PXE_PATH_PREFIX 0xd2 /* 210: RFC 5071 Path prefix */
|
2018-07-04 19:35:48 +05:30
|
|
|
//#define DHCP_REBOOT_TIME 0xd3 /* 211: RFC 5071 Reboot time */
|
|
|
|
//#define DHCP_MS_STATIC_ROUTES 0xf9 /* 249: Microsoft's pre-RFC 3442 code for 0x79? */
|
|
|
|
//#define DHCP_WPAD 0xfc /* 252: MSIE's Web Proxy Autodiscovery Protocol */
|
|
|
|
#define DHCP_END 0xff /* 255: */
|
2010-03-22 18:59:13 +05:30
|
|
|
|
|
|
|
/* Offsets in option byte sequence */
|
|
|
|
#define OPT_CODE 0
|
|
|
|
#define OPT_LEN 1
|
|
|
|
#define OPT_DATA 2
|
2018-05-14 14:36:35 +05:30
|
|
|
/* Offsets in option byte sequence for DHCPv6 */
|
2018-07-04 19:35:48 +05:30
|
|
|
#define D6_OPT_CODE 0
|
|
|
|
#define D6_OPT_LEN 2
|
|
|
|
#define D6_OPT_DATA 4
|
2010-03-22 18:59:13 +05:30
|
|
|
/* Bits in "overload" option */
|
|
|
|
#define OPTION_FIELD 0
|
|
|
|
#define FILE_FIELD 1
|
|
|
|
#define SNAME_FIELD 2
|
|
|
|
|
|
|
|
/* DHCP_MESSAGE_TYPE values */
|
|
|
|
#define DHCPDISCOVER 1 /* client -> server */
|
|
|
|
#define DHCPOFFER 2 /* client <- server */
|
|
|
|
#define DHCPREQUEST 3 /* client -> server */
|
|
|
|
#define DHCPDECLINE 4 /* client -> server */
|
|
|
|
#define DHCPACK 5 /* client <- server */
|
|
|
|
#define DHCPNAK 6 /* client <- server */
|
|
|
|
#define DHCPRELEASE 7 /* client -> server */
|
|
|
|
#define DHCPINFORM 8 /* client -> server */
|
|
|
|
#define DHCP_MINTYPE DHCPDISCOVER
|
|
|
|
#define DHCP_MAXTYPE DHCPINFORM
|
|
|
|
|
2010-04-04 18:58:49 +05:30
|
|
|
struct dhcp_optflag {
|
2010-03-22 18:59:13 +05:30
|
|
|
uint8_t flags;
|
|
|
|
uint8_t code;
|
|
|
|
};
|
|
|
|
|
2010-03-26 01:02:38 +05:30
|
|
|
struct option_set {
|
|
|
|
uint8_t *data;
|
|
|
|
struct option_set *next;
|
|
|
|
};
|
|
|
|
|
2017-06-28 22:48:17 +05:30
|
|
|
#if ENABLE_UDHCPC || ENABLE_UDHCPD
|
2010-04-04 18:58:49 +05:30
|
|
|
extern const struct dhcp_optflag dhcp_optflags[];
|
2012-07-24 19:26:37 +05:30
|
|
|
extern const char dhcp_option_strings[] ALIGN1;
|
2017-06-28 22:48:17 +05:30
|
|
|
#endif
|
2012-07-24 19:26:37 +05:30
|
|
|
extern const uint8_t dhcp_option_lengths[] ALIGN1;
|
2010-03-22 18:59:13 +05:30
|
|
|
|
2017-06-28 22:48:17 +05:30
|
|
|
unsigned FAST_FUNC udhcp_option_idx(const char *name, const char *option_strings);
|
2010-03-28 03:53:41 +05:30
|
|
|
|
2020-06-24 01:55:08 +05:30
|
|
|
void init_scan_state(struct dhcp_packet *packet, struct dhcp_scan_state *scan_state) FAST_FUNC;
|
|
|
|
uint8_t *udhcp_scan_options(struct dhcp_packet *packet, struct dhcp_scan_state *scan_state) FAST_FUNC;
|
2010-03-22 18:59:13 +05:30
|
|
|
uint8_t *udhcp_get_option(struct dhcp_packet *packet, int code) FAST_FUNC;
|
2018-12-17 22:37:18 +05:30
|
|
|
/* Same as above + ensures that option length is 4 bytes
|
|
|
|
* (returns NULL if size is different)
|
|
|
|
*/
|
|
|
|
uint8_t *udhcp_get_option32(struct dhcp_packet *packet, int code) FAST_FUNC;
|
2010-03-22 18:59:13 +05:30
|
|
|
int udhcp_end_option(uint8_t *optionptr) FAST_FUNC;
|
2010-03-26 14:02:09 +05:30
|
|
|
void udhcp_add_binary_option(struct dhcp_packet *packet, uint8_t *addopt) FAST_FUNC;
|
2017-06-28 22:48:17 +05:30
|
|
|
#if ENABLE_UDHCPC || ENABLE_UDHCPD
|
2010-03-26 14:02:09 +05:30
|
|
|
void udhcp_add_simple_option(struct dhcp_packet *packet, uint8_t code, uint32_t data) FAST_FUNC;
|
2017-06-28 22:48:17 +05:30
|
|
|
#endif
|
|
|
|
#if ENABLE_FEATURE_UDHCP_RFC3397 || ENABLE_FEATURE_UDHCPC6_RFC3646 || ENABLE_FEATURE_UDHCPC6_RFC4704
|
2010-03-22 18:59:13 +05:30
|
|
|
char *dname_dec(const uint8_t *cstr, int clen, const char *pre) FAST_FUNC;
|
2020-06-09 20:52:06 +05:30
|
|
|
uint8_t *dname_enc(/*const uint8_t *cstr, int clen,*/ const char *src, int *retlen) FAST_FUNC;
|
2010-03-22 18:59:13 +05:30
|
|
|
#endif
|
2010-03-26 14:02:09 +05:30
|
|
|
struct option_set *udhcp_find_option(struct option_set *opt_list, uint8_t code) FAST_FUNC;
|
2010-03-26 01:02:38 +05:30
|
|
|
|
2010-03-21 10:45:28 +05:30
|
|
|
// RFC 2131 Table 5: Fields and options used by DHCP clients
|
|
|
|
//
|
2019-05-23 18:54:03 +05:30
|
|
|
// Fields 'hops', 'yiaddr', 'siaddr', 'giaddr' are always zero, 'chaddr' is always client's MAC
|
2010-03-21 10:45:28 +05:30
|
|
|
//
|
2010-03-22 19:52:14 +05:30
|
|
|
// Field DHCPDISCOVER DHCPINFORM DHCPREQUEST DHCPDECLINE DHCPRELEASE
|
|
|
|
// ----- ------------ ------------ ----------- ----------- -----------
|
|
|
|
// 'xid' selected by client selected by client 'xid' from server selected by client selected by client
|
|
|
|
// DHCPOFFER message
|
|
|
|
// 'secs' 0 or seconds since 0 or seconds since 0 or seconds since 0 0
|
|
|
|
// DHCP process started DHCP process started DHCP process started
|
|
|
|
// 'flags' Set 'BROADCAST' Set 'BROADCAST' Set 'BROADCAST' 0 0
|
2019-05-23 18:54:03 +05:30
|
|
|
// flag if client needs flag if client needs flag if client needs
|
|
|
|
// broadcast reply broadcast reply broadcast reply
|
2010-03-22 19:52:14 +05:30
|
|
|
// 'ciaddr' 0 client's IP 0 or client's IP 0 client's IP
|
|
|
|
// (BOUND/RENEW/REBIND)
|
|
|
|
// 'sname' options or sname options or sname options or sname (unused) (unused)
|
|
|
|
// 'file' options or file options or file options or file (unused) (unused)
|
|
|
|
// 'options' options options options message type opt message type opt
|
|
|
|
//
|
2019-05-23 18:54:03 +05:30
|
|
|
// Option DHCPDISCOVER DHCPINFORM DHCPREQUEST DHCPDECLINE DHCPRELEASE
|
|
|
|
// ------ ------------ ---------- ----------- ----------- -----------
|
|
|
|
// Requested IP address MAY MUST NOT MUST (in SELECTING MUST MUST NOT
|
|
|
|
// or INIT-REBOOT)
|
|
|
|
// MUST NOT (in BOUND
|
|
|
|
// or RENEWING)
|
|
|
|
// IP address lease time MAY MUST NOT MAY MUST NOT MUST NOT
|
|
|
|
// Use 'file'/'sname' fields MAY MAY MAY MAY MAY
|
|
|
|
// Client identifier MAY MAY MAY MAY MAY
|
|
|
|
// Vendor class identifier MAY MAY MAY MUST NOT MUST NOT
|
|
|
|
// Server identifier MUST NOT MUST NOT MUST (after SELECTING) MUST MUST
|
2010-03-22 19:52:14 +05:30
|
|
|
// MUST NOT (after
|
2019-05-23 18:54:03 +05:30
|
|
|
// INIT-REBOOT, BOUND,
|
|
|
|
// RENEWING or REBINDING)
|
|
|
|
// Parameter request list MAY MAY MAY MUST NOT MUST NOT
|
|
|
|
// Maximum message size MAY MAY MAY MUST NOT MUST NOT
|
|
|
|
// Message SHOULD NOT SHOULD NOT SHOULD NOT SHOULD SHOULD
|
|
|
|
// Site-specific MAY MAY MAY MUST NOT MUST NOT
|
|
|
|
// All others MAY MAY MAY MUST NOT MUST NOT
|
2010-03-21 10:45:28 +05:30
|
|
|
|
2010-03-22 18:59:13 +05:30
|
|
|
/*** Logging ***/
|
|
|
|
|
|
|
|
#if defined CONFIG_UDHCP_DEBUG && CONFIG_UDHCP_DEBUG >= 1
|
2011-10-18 04:05:47 +05:30
|
|
|
# define IF_UDHCP_VERBOSE(...) __VA_ARGS__
|
2010-03-22 18:59:13 +05:30
|
|
|
extern unsigned dhcp_verbose;
|
2019-04-12 22:31:51 +05:30
|
|
|
# define log1(...) do { if (dhcp_verbose >= 1) bb_info_msg(__VA_ARGS__); } while (0)
|
libbb: reduce the overhead of single parameter bb_error_msg() calls
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
|
|
|
# define log1s(msg) do { if (dhcp_verbose >= 1) bb_simple_info_msg(msg); } while (0)
|
2010-03-22 18:59:13 +05:30
|
|
|
# if CONFIG_UDHCP_DEBUG >= 2
|
|
|
|
void udhcp_dump_packet(struct dhcp_packet *packet) FAST_FUNC;
|
2019-04-12 22:31:51 +05:30
|
|
|
# define log2(...) do { if (dhcp_verbose >= 2) bb_info_msg(__VA_ARGS__); } while (0)
|
libbb: reduce the overhead of single parameter bb_error_msg() calls
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
|
|
|
# define log2s(msg) do { if (dhcp_verbose >= 2) bb_simple_info_msg(msg); } while (0)
|
2010-03-22 18:59:13 +05:30
|
|
|
# else
|
|
|
|
# define udhcp_dump_packet(...) ((void)0)
|
|
|
|
# define log2(...) ((void)0)
|
libbb: reduce the overhead of single parameter bb_error_msg() calls
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
|
|
|
# define log2s(msg) ((void)0)
|
2010-03-22 18:59:13 +05:30
|
|
|
# endif
|
|
|
|
# if CONFIG_UDHCP_DEBUG >= 3
|
2019-04-12 22:31:51 +05:30
|
|
|
# define log3(...) do { if (dhcp_verbose >= 3) bb_info_msg(__VA_ARGS__); } while (0)
|
libbb: reduce the overhead of single parameter bb_error_msg() calls
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
|
|
|
# define log3s(msg) do { if (dhcp_verbose >= 3) bb_simple_info_msg(msg); } while (0)
|
2010-03-22 18:59:13 +05:30
|
|
|
# else
|
|
|
|
# define log3(...) ((void)0)
|
libbb: reduce the overhead of single parameter bb_error_msg() calls
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
|
|
|
# define log3s(msg) ((void)0)
|
2010-03-22 18:59:13 +05:30
|
|
|
# endif
|
|
|
|
#else
|
2011-10-18 04:05:47 +05:30
|
|
|
# define IF_UDHCP_VERBOSE(...)
|
2010-03-22 18:59:13 +05:30
|
|
|
# define udhcp_dump_packet(...) ((void)0)
|
|
|
|
# define log1(...) ((void)0)
|
libbb: reduce the overhead of single parameter bb_error_msg() calls
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
|
|
|
# define log1s(msg) ((void)0)
|
2010-03-22 18:59:13 +05:30
|
|
|
# define log2(...) ((void)0)
|
libbb: reduce the overhead of single parameter bb_error_msg() calls
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
|
|
|
# define log2s(msg) ((void)0)
|
2010-03-22 18:59:13 +05:30
|
|
|
# define log3(...) ((void)0)
|
libbb: reduce the overhead of single parameter bb_error_msg() calls
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
|
|
|
# define log3s(msg) ((void)0)
|
2010-03-22 18:59:13 +05:30
|
|
|
#endif
|
|
|
|
|
libbb: reduce the overhead of single parameter bb_error_msg() calls
Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm: -92 bytes
MIPS: -52 bytes
PPC: -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
|
|
|
#if defined(__mips__)
|
|
|
|
/*
|
|
|
|
* The 'simple' message functions have a negative impact on the size of the
|
|
|
|
* DHCP code when compiled for MIPS, so don't use them in this case.
|
|
|
|
*/
|
|
|
|
#define bb_simple_info_msg bb_info_msg
|
|
|
|
#define bb_simple_error_msg bb_error_msg
|
|
|
|
#define bb_simple_perror_msg_and_die bb_perror_msg_and_die
|
|
|
|
#undef log1s
|
|
|
|
#define log1s log1
|
|
|
|
#endif
|
2010-03-22 18:59:13 +05:30
|
|
|
|
|
|
|
/*** Other shared functions ***/
|
|
|
|
|
2010-03-26 13:05:24 +05:30
|
|
|
/* 2nd param is "uint32_t*" */
|
|
|
|
int FAST_FUNC udhcp_str2nip(const char *str, void *arg);
|
|
|
|
/* 2nd param is "struct option_set**" */
|
2018-05-14 14:36:35 +05:30
|
|
|
#if !ENABLE_UDHCPC6
|
|
|
|
#define udhcp_str2optset(str, arg, optflags, option_strings, dhcpv6) \
|
|
|
|
udhcp_str2optset(str, arg, optflags, option_strings)
|
|
|
|
#endif
|
2017-06-28 22:48:17 +05:30
|
|
|
int FAST_FUNC udhcp_str2optset(const char *str,
|
|
|
|
void *arg,
|
|
|
|
const struct dhcp_optflag *optflags,
|
2018-05-14 14:36:35 +05:30
|
|
|
const char *option_strings,
|
|
|
|
bool dhcpv6);
|
2007-12-21 02:41:38 +05:30
|
|
|
|
2017-07-03 04:52:13 +05:30
|
|
|
#if ENABLE_UDHCPC || ENABLE_UDHCPD
|
2009-06-17 15:27:09 +05:30
|
|
|
void udhcp_init_header(struct dhcp_packet *packet, char type) FAST_FUNC;
|
2017-07-03 04:52:13 +05:30
|
|
|
#endif
|
2007-12-21 02:41:38 +05:30
|
|
|
|
2009-06-17 15:27:09 +05:30
|
|
|
int udhcp_recv_kernel_packet(struct dhcp_packet *packet, int fd) FAST_FUNC;
|
2008-05-21 12:35:06 +05:30
|
|
|
|
2009-06-17 15:27:09 +05:30
|
|
|
int udhcp_send_raw_packet(struct dhcp_packet *dhcp_pkt,
|
2010-05-31 03:13:35 +05:30
|
|
|
uint32_t source_nip, int source_port,
|
|
|
|
uint32_t dest_nip, int dest_port, const uint8_t *dest_arp,
|
2008-09-26 21:59:12 +05:30
|
|
|
int ifindex) FAST_FUNC;
|
|
|
|
|
2009-06-17 15:27:09 +05:30
|
|
|
int udhcp_send_kernel_packet(struct dhcp_packet *dhcp_pkt,
|
2010-05-31 03:13:35 +05:30
|
|
|
uint32_t source_nip, int source_port,
|
2020-12-15 15:23:40 +05:30
|
|
|
uint32_t dest_nip, int dest_port,
|
|
|
|
const char *ifname) FAST_FUNC;
|
2006-11-19 01:21:32 +05:30
|
|
|
|
2008-09-26 15:04:59 +05:30
|
|
|
void udhcp_sp_setup(void) FAST_FUNC;
|
2017-02-17 03:55:44 +05:30
|
|
|
void udhcp_sp_fd_set(struct pollfd *pfds, int extra_fd) FAST_FUNC;
|
udhcpd: fix "not dying on SIGTERM"
Fixes:
commit 52a515d18724bbb34e3ccbbb0218efcc4eccc0a8
"udhcp: use poll() instead of select()"
Feb 16 2017
udhcp_sp_read() is meant to check whether signal pipe indeed has some data to read.
In the above commit, it was changed as follows:
- if (!FD_ISSET(signal_pipe.rd, rfds))
+ if (!pfds[0].revents)
return 0;
The problem is, the check was working for select() purely by accident.
Caught signal interrupts select()/poll() syscalls, they return with EINTR
(regardless of SA_RESTART flag in sigaction). _Then_ signal handler is invoked.
IOW: they can't see any changes to fd state caused by signal haldler
(in our case, signal handler makes signal pipe ready to be read).
For select(), it means that rfds[] bit array is unmodified, bit of signal
pipe's read fd is still set, and the above check "works": it thinks select()
says there is data to read.
This accident does not work for poll(): .revents stays clear, and we do not
try reading signal pipe as we should. In udhcpd, we fall through and block
in socket read. Further SIGTERM signals simply cause socket read to be
interrupted and then restarted (since SIGTERM handler has SA_RESTART=1).
Fixing this as follows: remove the check altogether. Set signal pipe read fd
to nonblocking mode. Always read it in udhcp_sp_read().
If read fails, assume it's EAGAIN and return 0 ("no signal seen").
udhcpd avoids reading signal pipe on every recvd packet by looping if EINTR
(using safe_poll()) - thus ensuring we have correct .revents for all fds -
and calling udhcp_sp_read() only if pfds[0].revents!=0.
udhcpc performs much fewer reads (typically it sleeps >99.999% of the time),
there is no need to optimize it: can call udhcp_sp_read() after each poll
unconditionally.
To robustify socket reads, unconditionally set pfds[1].revents=0
in udhcp_sp_fd_set() (which is before poll), and check it before reading
network socket in udhcpd.
TODO:
This might still fail: if pfds[1].revents=POLLIN, socket read may still block.
There are rare cases when select/poll indicates that data can be read,
but then actual read still blocks (one such case is UDP packets with
wrong checksum). General advise is, if you use a poll/select loop,
keep all your fds nonblocking.
Maybe we should also do that to our network sockets?
function old new delta
udhcp_sp_setup 55 65 +10
udhcp_sp_fd_set 54 60 +6
udhcp_sp_read 46 36 -10
udhcpd_main 1451 1437 -14
udhcpc_main 2723 2708 -15
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/3 up/down: 16/-39) Total: -23 bytes
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2018-03-10 23:31:48 +05:30
|
|
|
int udhcp_sp_read(void) FAST_FUNC;
|
2010-03-22 18:59:13 +05:30
|
|
|
|
2009-06-16 15:34:23 +05:30
|
|
|
int udhcp_read_interface(const char *interface, int *ifindex, uint32_t *nip, uint8_t *mac) FAST_FUNC;
|
2010-03-22 18:59:13 +05:30
|
|
|
|
2008-09-26 15:04:59 +05:30
|
|
|
int udhcp_listen_socket(/*uint32_t ip,*/ int port, const char *inf) FAST_FUNC;
|
2010-03-22 18:59:13 +05:30
|
|
|
|
2007-07-03 21:17:50 +05:30
|
|
|
/* Returns 1 if no reply received */
|
2009-06-17 16:54:03 +05:30
|
|
|
int arpping(uint32_t test_nip,
|
2009-06-16 13:50:27 +05:30
|
|
|
const uint8_t *safe_mac,
|
|
|
|
uint32_t from_ip,
|
|
|
|
uint8_t *from_mac,
|
2014-10-30 16:29:04 +05:30
|
|
|
const char *interface,
|
|
|
|
unsigned timeo) FAST_FUNC;
|
2006-05-08 08:50:50 +05:30
|
|
|
|
2011-11-17 00:47:12 +05:30
|
|
|
/* note: ip is a pointer to an IPv6 in network order, possibly misaliged */
|
|
|
|
int sprint_nip6(char *dest, /*const char *pre,*/ const uint8_t *ip) FAST_FUNC;
|
|
|
|
|
2009-04-09 18:05:13 +05:30
|
|
|
POP_SAVED_FUNCTION_VISIBILITY
|
2008-05-09 23:29:34 +05:30
|
|
|
|
2006-05-08 08:50:50 +05:30
|
|
|
#endif
|