busybox/libbb/bb_getgroups.c

48 lines
1.1 KiB
C
Raw Normal View History

/*
* Utility routines.
*
* Copyright (C) 2017 Denys Vlasenko
*
* Licensed under GPLv2, see file LICENSE in this source tree.
*/
//kbuild:lib-y += bb_getgroups.o
#include "libbb.h"
gid_t* FAST_FUNC bb_getgroups(int *ngroups, gid_t *group_array)
{
int n = ngroups ? *ngroups : 0;
/* getgroups may be a bit expensive, try to use it only once */
if (n < 32)
n = 32;
for (;;) {
// FIXME: ash tries so hard to not die on OOM (when we are called from test),
// and we spoil it with just one xrealloc here
group_array = xrealloc(group_array, (n+1) * sizeof(group_array[0]));
n = getgroups(n, group_array);
/*
* If buffer is too small, kernel does not return new_n > n.
* It returns -1 and EINVAL:
*/
if (n >= 0) {
/* Terminator for bb_getgroups(NULL, NULL) usage */
group_array[n] = (gid_t) -1;
break;
}
if (errno == EINVAL) { /* too small? */
/* This is the way to ask kernel how big the array is */
n = getgroups(0, group_array);
continue;
}
/* Some other error (should never happen on Linux) */
libbb: reduce the overhead of single parameter bb_error_msg() calls Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower overhead call to bb_perror_msg() when only a string was being printed with no parameters. This saves space for some CPU architectures because it avoids the overhead of a call to a variadic function. However there has never been a simple version of bb_error_msg(), and since 2007 many new calls to bb_perror_msg() have been added that only take a single parameter and so could have been using bb_simple_perror_message(). This changeset introduces 'simple' versions of bb_info_msg(), bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and bb_herror_msg_and_die(), and replaces all calls that only take a single parameter, or use something like ("%s", arg), with calls to the corresponding 'simple' version. Since it is likely that single parameter calls to the variadic functions may be accidentally reintroduced in the future a new debugging config option WARN_SIMPLE_MSG has been introduced. This uses some macro magic which will cause any such calls to generate a warning, but this is turned off by default to avoid use of the unpleasant macros in normal circumstances. This is a large changeset due to the number of calls that have been replaced. The only files that contain changes other than simple substitution of function calls are libbb.h, libbb/herror_msg.c, libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c, networking/udhcp/common.h and util-linux/mdev.c additonal macros have been added for logging so that single parameter and multiple parameter logging variants exist. The amount of space saved varies considerably by architecture, and was found to be as follows (for 'defconfig' using GCC 7.4): Arm: -92 bytes MIPS: -52 bytes PPC: -1836 bytes x86_64: -938 bytes Note that for the MIPS architecture only an exception had to be made disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h) because it made these files larger on MIPS. Signed-off-by: James Byrne <james.byrne@origamienergy.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2019-07-02 15:05:03 +05:30
bb_simple_perror_msg_and_die("getgroups");
}
if (ngroups)
*ngroups = n;
return group_array;
}