emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

"Unify base64 handling" is done, remove TODO

Browse Source
This commit is contained in:
Denis Vlasenko 2007-04-18 21:14:46 +00:00
parent 2ace1e3f07
commit 088b959d00
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
TODO
View File

@ -36,12 +36,7 @@ Rob Landley <rob@landley.net>:
modutils. The orig depmod is rather pointless to have to add to a firmware image modutils. The orig depmod is rather pointless to have to add to a firmware image
in when we already have a insmod/rmmod and friends. in when we already have a insmod/rmmod and friends.
Unify base64 handling. Unify base64 handling.
There's base64 encoding and decoding going on in: [done]
networking/wget.c:base64enc()
coreutils/uudecode.c:read_base64()
coreutils/uuencode.c:tbl_base64[]
networking/httpd.c:decodeBase64()
And probably elsewhere. That needs to be unified into libbb functions.
Do a SUSv3 audit Do a SUSv3 audit
Look at the full Single Unix Specification version 3 (available online at Look at the full Single Unix Specification version 3 (available online at
"http://www.opengroup.org/onlinepubs/009695399/nfindex.html") and "http://www.opengroup.org/onlinepubs/009695399/nfindex.html") and

5
networking/httpd.c
View File

@ -765,10 +765,9 @@ static void setenv_long(const char *name, long value)
****************************************************************************/ ****************************************************************************/
static void decodeBase64(char *Data) static void decodeBase64(char *Data)
{ {
const unsigned char *in = (const unsigned char *)Data; const unsigned char *in = (const unsigned char *)Data;
// The decoded size will be at most 3/4 the size of the encoded // The decoded size will be at most 3/4 the size of the encoded
unsigned long ch = 0; unsigned ch = 0;
int i = 0; int i = 0;
while (*in) { while (*in) {
@ -798,7 +797,7 @@ static void decodeBase64(char *Data)
i = 0; i = 0;
} }
} }
*Data = 0; *Data = '\0';
} }
#endif #endif