emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

start-stop-daemon: create pidfile before parent exits, closes 8596

Browse Source 
This removes DAEMON_DOUBLE_FORK flag from bb_daemonize_or_rexec(),
as SSD was the only user.

Also includes fix for -S: now works without -a and -x,
does not print pids
(compat with "start-stop-daemon (OpenRC) 0.34.11 (Gentoo Linux)").

function                                             old     new   delta
start_stop_daemon_main                              1018    1084     +66
add_interface                                         99     103      +4
fail_hunk                                            139     136      -3
bb_daemonize_or_rexec                                205     183     -22
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/2 up/down: 70/-25)             Total: 45 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko
2019-01-14 14:45:18 +01:00
parent b67d900395
commit 088fec36fe
4 changed files with 62 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
testsuite/start-stop-daemon.tests
View File

@ -16,4 +16,9 @@ testing "start-stop-daemon -a without -x" \
"1\n" \
"" ""
testing "start-stop-daemon without -x and -a" \
'start-stop-daemon -S false 2>&1; echo $?' \
"1\n" \
"" ""
exit $FAILCOUNT