add comments about ignoring some warnings which are OK

This commit is contained in:
Mike Frysinger 2005-04-23 01:43:07 +00:00
parent 7202e00b4c
commit 19d7021d99

View File

@ -260,12 +260,16 @@ rpm_index **rpm_gettags(int fd, int *num_tags)
int bsearch_rpmtag(const void *key, const void *item) int bsearch_rpmtag(const void *key, const void *item)
{ {
rpm_index **tmp = (rpm_index **) item; rpm_index **tmp = (rpm_index **) item;
/* gcc throws warnings here when sizeof(void*)!=sizeof(int) ...
* it's ok to ignore it because this isn't a 'real' pointer */
return ((int) key - tmp[0]->tag); return ((int) key - tmp[0]->tag);
} }
int rpm_getcount(int tag) int rpm_getcount(int tag)
{ {
rpm_index **found; rpm_index **found;
/* gcc throws warnings here when sizeof(void*)!=sizeof(int) ...
* it's ok to ignore it because tag won't be used as a pointer */
found = bsearch((void *) tag, mytags, tagcount, sizeof(struct rpmtag *), bsearch_rpmtag); found = bsearch((void *) tag, mytags, tagcount, sizeof(struct rpmtag *), bsearch_rpmtag);
if (!found) return 0; if (!found) return 0;
else return found[0]->count; else return found[0]->count;
@ -274,6 +278,8 @@ int rpm_getcount(int tag)
char *rpm_getstring(int tag, int itemindex) char *rpm_getstring(int tag, int itemindex)
{ {
rpm_index **found; rpm_index **found;
/* gcc throws warnings here when sizeof(void*)!=sizeof(int) ...
* it's ok to ignore it because tag won't be used as a pointer */
found = bsearch((void *) tag, mytags, tagcount, sizeof(struct rpmtag *), bsearch_rpmtag); found = bsearch((void *) tag, mytags, tagcount, sizeof(struct rpmtag *), bsearch_rpmtag);
if (!found || itemindex >= found[0]->count) return NULL; if (!found || itemindex >= found[0]->count) return NULL;
if (found[0]->type == RPM_STRING_TYPE || found[0]->type == RPM_I18NSTRING_TYPE || found[0]->type == RPM_STRING_ARRAY_TYPE) { if (found[0]->type == RPM_STRING_TYPE || found[0]->type == RPM_I18NSTRING_TYPE || found[0]->type == RPM_STRING_ARRAY_TYPE) {
@ -288,6 +294,8 @@ int rpm_getint(int tag, int itemindex)
{ {
rpm_index **found; rpm_index **found;
int n, *tmpint; int n, *tmpint;
/* gcc throws warnings here when sizeof(void*)!=sizeof(int) ...
* it's ok to ignore it because tag won't be used as a pointer */
found = bsearch((void *) tag, mytags, tagcount, sizeof(struct rpmtag *), bsearch_rpmtag); found = bsearch((void *) tag, mytags, tagcount, sizeof(struct rpmtag *), bsearch_rpmtag);
if (!found || itemindex >= found[0]->count) return -1; if (!found || itemindex >= found[0]->count) return -1;
tmpint = (int *) (map + found[0]->offset); tmpint = (int *) (map + found[0]->offset);