emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

udhcpc: fix segmentation fault on empty bin opt

Browse Source 
The following caused udhcpc to segfault:
  busybox udhcpc -i lo -s /dev/null -x 0x3d:

function                                             old     new   delta
udhcp_str2optset                                     629     641     +12

Signed-off-by: Michal Kazior <michal@plume.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Michal Kazior 2019-09-25 14:03:13 +02:00 committed by Denys Vlasenko
parent 6c1af283f7
commit 1f1988d525
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
networking/udhcp/common.c
View File

@ -539,7 +539,7 @@ int FAST_FUNC udhcp_str2optset(const char *const_str, void *arg,
if (optflag->flags == OPTION_BIN) { if (optflag->flags == OPTION_BIN) {
val = strtok(NULL, ""); /* do not split "'q w e'" */ val = strtok(NULL, ""); /* do not split "'q w e'" */
trim(val); if (val) trim(val);
} else } else
val = strtok(NULL, ", \t"); val = strtok(NULL, ", \t");
if (!val) if (!val)