emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hush: fix a possible bug

Browse Source 
Not sure this was actually a triggerable bug, but the code looked flaky.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2016-07-21 14:40:08 +02:00
parent e695ac97fd
commit 49117b4800
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
shell/hush.c
View File

@ -9153,9 +9153,11 @@ static int FAST_FUNC builtin_break(char **argv)
unsigned depth; unsigned depth;
if (G.depth_of_loop == 0) { if (G.depth_of_loop == 0) {
bb_error_msg("%s: only meaningful in a loop", argv[0]); bb_error_msg("%s: only meaningful in a loop", argv[0]);
/* if we came from builtin_continue(), need to undo "= 1" */
G.flag_break_continue = 0;
return EXIT_SUCCESS; /* bash compat */ return EXIT_SUCCESS; /* bash compat */
} }
G.flag_break_continue++; /* BC_BREAK = 1 */ G.flag_break_continue++; /* BC_BREAK = 1, or BC_CONTINUE = 2 */
G.depth_break_continue = depth = parse_numeric_argv1(argv, 1, 1); G.depth_break_continue = depth = parse_numeric_argv1(argv, 1, 1);
if (depth == UINT_MAX) if (depth == UINT_MAX)