build system: fix compiler warnings

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2019-01-06 20:12:16 +01:00
parent 2d9e097963
commit 4bdc914ff9
5 changed files with 13 additions and 7 deletions

View File

@ -12,7 +12,7 @@ config HAVE_DOT_CONFIG
menu "Settings" menu "Settings"
config DESKTOP config DESKTOP
bool "Enable compatibility for full-blown desktop systems" bool "Enable compatibility for full-blown desktop systems (8kb)"
default y default y
help help
Enable applet options and features which are not essential. Enable applet options and features which are not essential.

View File

@ -131,7 +131,8 @@ int main(int argc, const char * argv [])
is_same = 0; is_same = 0;
if ((fp_target = fopen(ptarget, "r")) != NULL) if ((fp_target = fopen(ptarget, "r")) != NULL)
{ {
fgets(old_line, buffer_size, fp_target); if (!fgets(old_line, buffer_size, fp_target))
ERROR_EXIT(ptarget);
if (fclose(fp_target) != 0) if (fclose(fp_target) != 0)
ERROR_EXIT(ptarget); ERROR_EXIT(ptarget);
if (!strcmp(line, old_line)) if (!strcmp(line, old_line))

View File

@ -142,7 +142,8 @@ static void conf_askvalue(struct symbol *sym, const char *def)
check_stdin(); check_stdin();
case ask_all: case ask_all:
fflush(stdout); fflush(stdout);
fgets(line, 128, stdin); if (!fgets(line, 128, stdin))
exit(1);
return; return;
case set_default: case set_default:
printf("%s\n", def); printf("%s\n", def);
@ -390,7 +391,8 @@ static int conf_choice(struct menu *menu)
check_stdin(); check_stdin();
case ask_all: case ask_all:
fflush(stdout); fflush(stdout);
fgets(line, 128, stdin); if (!fgets(line, 128, stdin))
exit(1);
strip(line); strip(line);
if (line[0] == '?') { if (line[0] == '?') {
printf("\n%s\n", menu->sym->help ? printf("\n%s\n", menu->sym->help ?

View File

@ -189,7 +189,7 @@ int j_inputbox(const char *t, int ac, const char *const *av)
int ret = dialog_inputbox(t, av[2], atoi(av[3]), atoi(av[4]), int ret = dialog_inputbox(t, av[2], atoi(av[3]), atoi(av[4]),
ac == 6 ? av[5] : (char *)NULL); ac == 6 ? av[5] : (char *)NULL);
if (ret == 0) if (ret == 0)
fprintf(stderr, dialog_input_result); fprintf(stderr, "%s", dialog_input_result);
return ret; return ret;
} }

View File

@ -482,7 +482,8 @@ static int exec_conf(void)
*argptr++ = NULL; *argptr++ = NULL;
pipe(pipefd); if (pipe(pipefd))
_exit(EXIT_FAILURE);
pid = fork(); pid = fork();
if (pid == 0) { if (pid == 0) {
sigprocmask(SIG_SETMASK, &osset, NULL); sigprocmask(SIG_SETMASK, &osset, NULL);
@ -846,9 +847,11 @@ static void conf(struct menu *menu)
static void show_textbox(const char *title, const char *text, int r, int c) static void show_textbox(const char *title, const char *text, int r, int c)
{ {
int fd; int fd;
int len = strlen(text);
fd = creat(".help.tmp", 0777); fd = creat(".help.tmp", 0777);
write(fd, text, strlen(text)); if (write(fd, text, len) != len)
exit(1);
close(fd); close(fd);
show_file(".help.tmp", title, r, c); show_file(".help.tmp", title, r, c);
unlink(".help.tmp"); unlink(".help.tmp");