emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hush: document a TODO. no code changes

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko
2009-09-25 12:58:37 +02:00
parent 8f88d85e34
commit 4ea0ca8193
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
shell/hush.c
View File

@@ -1111,6 +1111,14 @@ static void restore_G_args(save_arg_t *sv, char **argv)
* Note: as a result, we do not use signal handlers much. The only uses * Note: as a result, we do not use signal handlers much. The only uses
* are to count SIGCHLDs * are to count SIGCHLDs
* and to restore tty pgrp on signal-induced exit. * and to restore tty pgrp on signal-induced exit.
*
* TODO compat:
* Standard says "When a subshell is entered, traps that are not being ignored
* are set to the default actions". bash interprets it so that traps which
* are set to "" (ignore) are NOT reset to defaults. We reset them to default.
* bash example:
* # trap '' SYS; (bash -c 'kill -SYS $PPID'; echo YES)
* YES <-- subshell was not killed by SIGSYS
*/ */
enum { enum {
SPECIAL_INTERACTIVE_SIGS = 0 SPECIAL_INTERACTIVE_SIGS = 0
@@ -3625,9 +3633,9 @@ static int checkjobs(struct pipe* fg_pipe)
/* Note: is WIFSIGNALED, WEXITSTATUS = sig + 128 */ /* Note: is WIFSIGNALED, WEXITSTATUS = sig + 128 */
rcode = WEXITSTATUS(status); rcode = WEXITSTATUS(status);
IF_HAS_KEYWORDS(if (fg_pipe->pi_inverted) rcode = !rcode;) IF_HAS_KEYWORDS(if (fg_pipe->pi_inverted) rcode = !rcode;)
/* bash prints killing signal's name for *last* /* bash prints killer signal's name for *last*
* process in pipe (prints just newline for SIGINT). * process in pipe (prints just newline for SIGINT).
* Mimic this. Example: "sleep 5" + ^\ * Mimic this. Example: "sleep 5" + (^\ or kill -QUIT)
*/ */
if (WIFSIGNALED(status)) { if (WIFSIGNALED(status)) {
int sig = WTERMSIG(status); int sig = WTERMSIG(status);