emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hush: add a TODO about redir3.tests failure

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2017-07-06 20:57:37 +02:00
parent a107ef2a6a
commit 50b8b2914b
3 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
shell/hush.c
View File

@ -7723,6 +7723,10 @@ static NOINLINE int run_pipe(struct pipe *pi)
unset_vars(new_env); unset_vars(new_env);
add_vars(old_vars); add_vars(old_vars);
/* clean_up_and_ret0: */ /* clean_up_and_ret0: */
//FIXME: this restores stdio fds, but does not close other redirects!
//Example: after "echo TEST 9>/dev/null" fd#9 is not closed!
//The squirreling code needs rework to remember all fds, not just 0,1,2.
restore_redirects(squirrel); restore_redirects(squirrel);
clean_up_and_ret1: clean_up_and_ret1:
free(argv_expanded); free(argv_expanded);

3
shell/hush_test/hush-redir/redir3.right Normal file
View File

@ -0,0 +1,3 @@
TEST
./redir3.tests: line 4: 9: Bad file descriptor
Output to fd#9: 1

5
shell/hush_test/hush-redir/redir3.tests Executable file
View File

@ -0,0 +1,5 @@
# redirects to closed descriptors should not leave these descriptors
# open afterwards
echo TEST 9>/dev/null
echo MUST ERROR OUT >&9
echo "Output to fd#9: $?"