emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vi: fix range selection by forward character motion

Browse Source 
Selection of ranges for change/delete/yank by forward character
motion commands (SPACE or 'l') was incorrect.  The range was
always one character whereas vi allows the size of the range to
be specified.

Fix this by executing the motion command the required number of times.
There is a complication when the range is at the end of a line.  We need
to distinguish between a range which excludes the last character and
one which includes it.  This requires comparing the actual range with
that expected from the command count.  (With the additional quirk that
a command count of zero is equivalent to a command count of one.)

function                                             old     new   delta
find_range                                           587     619     +32
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/0 up/down: 32/0)               Total: 32 bytes

Signed-off-by: Ron Yorston <rmy@pobox.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Ron Yorston 2021-02-01 11:54:15 +00:00 committed by Denys Vlasenko
parent bcf91d2760
commit 5bef6781fa
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
editors/vi.c
View File

@ -3047,12 +3047,15 @@ static int find_range(char **start, char **stop, char c)
do_cmd(c); // execute movement cmd do_cmd(c); // execute movement cmd
dot_end(); // find NL dot_end(); // find NL
q = dot; q = dot;
} else { } else /* if (c == ' ' || c == 'l') */ {
// nothing -- this causes any other values of c to // forward motion by character
// represent the one-character range under the int tmpcnt = (cmdcnt ?: 1);
// cursor. this is correct for ' ' and 'l', but do_cmd(c); // execute movement cmd
// perhaps no others. // exclude last char unless range isn't what we expected
// // this indicates we've hit EOL
if (tmpcnt == dot - p)
dot--;
q = dot;
} }
if (q < p) { if (q < p) {
t = q; t = q;