emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libbb: shrink last_char_is(), no longer allow NULL string argument

Browse Source 
function                                             old     new   delta
last_char_is                                          40      28     -12

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2020-07-19 20:49:22 +02:00
parent 4468c569f7
commit 79a4032eef
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libbb/last_char_is.c
View File

@ -11,14 +11,9 @@
/* Find out if the last character of a string matches the one given */ /* Find out if the last character of a string matches the one given */
char* FAST_FUNC last_char_is(const char *s, int c) char* FAST_FUNC last_char_is(const char *s, int c)
{ {
if (s) { if (!s[0])
size_t sz = strlen(s);
/* Don't underrun the buffer if the string length is 0 */
if (sz != 0) {
s += sz - 1;
if ((unsigned char)*s == c)
return (char*)s;
}
}
return NULL; return NULL;
while (s[1])
s++;
return (*s == (char)c) ? (char *) s : NULL;
} }