emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

revert last two commits. vfork cannot be used in subroutine,

Browse Source 
it trashes stack on return
This commit is contained in:
Denis Vlasenko
2008-07-01 15:59:42 +00:00
parent b111917972
commit 82604e9730
15 changed files with 55 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
miscutils/crontab.c
View File

@@ -38,8 +38,10 @@ static void change_user(const struct passwd *pas)
static void edit_file(const struct passwd *pas, const char *file)
{
const char *ptr;
int pid = xvfork();
int pid = vfork();
if (pid < 0) /* failure */
bb_perror_msg_and_die("vfork");
if (pid) { /* parent */
wait4pid(pid);
return;
@@ -63,7 +65,9 @@ static int open_as_user(const struct passwd *pas, const char *file)
pid_t pid;
char c;
pid = xvfork();
pid = vfork();
if (pid < 0) /* ERROR */
bb_perror_msg_and_die("vfork");
if (pid) { /* PARENT */
if (wait4pid(pid) == 0) {
/* exitcode 0: child says it can read */

4
miscutils/time.c
View File

@@ -372,7 +372,9 @@ static void run_command(char *const *cmd, resource_t *resp)
void (*quit_signal)(int);
resp->elapsed_ms = monotonic_us() / 1000;
pid = xvfork(); /* Run CMD as child process. */
pid = vfork(); /* Run CMD as child process. */
if (pid < 0)
bb_error_msg_and_die("cannot fork");
if (pid == 0) { /* If child. */
/* Don't cast execvp arguments; that causes errors on some systems,
versus merely warnings if the cast is left off. */