emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lineedit: omit directories when tab-completing from PATH

Browse Source 
Only files should be matched when using PATH for tab-completion.

function                                             old     new   delta
complete_cmd_dir_file                                883     894     +11
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/0 up/down: 11/0)               Total: 11 bytes

Signed-off-by: Ron Yorston <rmy@pobox.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Ron Yorston 2020-12-10 14:44:57 +00:00 committed by Denys Vlasenko
parent caba1a16ec
commit 8506dd6730
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libbb/lineedit.c
View File

@ -871,6 +871,9 @@ static NOINLINE unsigned complete_cmd_dir_file(const char *command, int type)
strcpy(found, name_found); strcpy(found, name_found);
if (S_ISDIR(st.st_mode)) { if (S_ISDIR(st.st_mode)) {
/* skip directories if searching PATH */
if (type == FIND_EXE_ONLY && !dirbuf)
goto cont;
/* name is a directory, add slash */ /* name is a directory, add slash */
found[len] = '/'; found[len] = '/';
found[len + 1] = '\0'; found[len + 1] = '\0';