emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ash: jobs: Fix infinite loop in waitproc

Browse Source 
Upstream commit:

    Date: Fri, 10 Apr 2020 21:03:09 +1000
    jobs: Fix infinite loop in waitproc

    After we changed the resetting of gotsigchld so that it is only
    done if jp is NULL, we can now get an infinite loop in waitproc
    if gotsigchld is set but there is no outstanding child because
    everything had been waited for previously without gotsigchld being
    zeroed.

    This patch fixes it by always zeroing gotsigchld as we did before.
    The bug that the previous patch was trying to fix is now resolved
    by switching the blocking mode to DOWAIT_NORMAL after the specified
    job has been completed so that we really do wait for all outstanding
    dead children.

    Reported-by: Harald van Dijk <harald@gigawatt.nl>
    Fixes: 6c691b3e5099 ("jobs: Only clear gotsigchld when waiting...")
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

function                                             old     new   delta
dowait                                               553     631     +78

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2020-09-29 16:44:46 +02:00
parent 777a6357c0
commit 8d5f465a20
1 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
shell/ash.c
View File

@ -4453,15 +4453,28 @@ waitone(int block, struct job *job)
static int static int
dowait(int block, struct job *jp) dowait(int block, struct job *jp)
{ {
int pid = block == DOWAIT_NONBLOCK ? got_sigchld : 1; smallint gotchld = *(volatile smallint *)&got_sigchld;
int rpid;
int pid;
while (jp ? jp->state == JOBRUNNING : pid > 0) { if (jp && jp->state != JOBRUNNING)
if (!jp) block = DOWAIT_NONBLOCK;
if (block == DOWAIT_NONBLOCK && !gotchld)
return 1;
rpid = 1;
do {
got_sigchld = 0; got_sigchld = 0;
pid = waitone(block, jp); pid = waitone(block, jp);
} rpid &= !!pid;
return pid; if (!pid || (jp && jp->state != JOBRUNNING))
block = DOWAIT_NONBLOCK;
} while (pid >= 0);
return rpid;
} }
#if JOBS #if JOBS