emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

makedevs: make it NOEXEC

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2017-08-06 21:47:07 +02:00
parent 7389662dbf
commit 9536ef7c98
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
NOFORK_NOEXEC.lst
View File

@ -127,7 +127,7 @@ findfs - suid
flash_eraseall flash_eraseall
flash_lock flash_lock
flash_unlock flash_unlock
flashcp - needs ^C. flash writing may be slow, better to free memory memory by execing flashcp - needs ^C. flash writing may be slow, better to free memory by execing
flock - spawner, changes state (file locks), let's play safe and not be noexec flock - spawner, changes state (file locks), let's play safe and not be noexec
fold - noexec. runner fold - noexec. runner
free - nofork candidate(struct globals, needs to close /proc/meminfo fd) free - nofork candidate(struct globals, needs to close /proc/meminfo fd)
@ -214,7 +214,7 @@ lzcat - runner
lzma - runner lzma - runner
lzop - runner lzop - runner
lzopcat - runner lzopcat - runner
makedevs makedevs - noexec
makemime - runner makemime - runner
man - spawner, interactive, longterm man - spawner, interactive, longterm
md5sum - noexec. runner md5sum - noexec. runner
@ -278,7 +278,7 @@ raidautorun - noexec. very simple. leaks: open+xioctl
rdate - needs ^C (may talk to DNS servers, which may be down) rdate - needs ^C (may talk to DNS servers, which may be down)
rdev - leaks: find_block_device -> readdir+xstrdup rdev - leaks: find_block_device -> readdir+xstrdup
readlink - NOFORK readlink - NOFORK
readprofile - reads /boot/System.map and /proc/profile, better to free more memory memory by execing? readprofile - reads /boot/System.map and /proc/profile, better to free more memory by execing?
realpath - NOFORK realpath - NOFORK
reboot - rare reboot - rare
reformime - runner reformime - runner

2
miscutils/makedevs.c
View File

@ -38,7 +38,7 @@
//config: //config:
//config:endchoice //config:endchoice
//applet:IF_MAKEDEVS(APPLET(makedevs, BB_DIR_SBIN, BB_SUID_DROP)) //applet:IF_MAKEDEVS(APPLET_NOEXEC(makedevs, makedevs, BB_DIR_SBIN, BB_SUID_DROP, makedevs))
//kbuild:lib-$(CONFIG_MAKEDEVS) += makedevs.o //kbuild:lib-$(CONFIG_MAKEDEVS) += makedevs.o