emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

using [xa]sprintf for string concatenation is neat and saves

Browse Source 
~100 bytes according to bloatcheck. Also this fixes bug in rpm
This commit is contained in:
Denis Vlasenko
2006-09-09 12:24:19 +00:00
parent 3526a1320a
commit 9cac521f07
6 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
procps/sysctl.c
View File

@@ -129,7 +129,7 @@ int sysctl_preload_file(const char *filename, int output)
}
while (fgets(oneline, sizeof(oneline) - 1, fp)) {
oneline[sizeof(oneline) - 1] = 0;
oneline[sizeof(oneline) - 1] = '\0';
lineno++;
trim(oneline);
ptr = (char *) oneline;
@@ -156,9 +156,8 @@ int sysctl_preload_file(const char *filename, int output)
while ((*value == ' ' || *value == '\t') && *value != 0)
value++;
strcpy(buffer, name);
strcat(buffer, "=");
strcat(buffer, value);
/* safe because sizeof(oneline) == sizeof(buffer) */
sprintf(buffer, "%s=%s", name, value);
sysctl_write_setting(buffer, output);
}
fclose(fp);