emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add a note that SO_BINDTODEVICE needs padded iface name on 2.6.26

Browse Source
This commit is contained in:
Denis Vlasenko 2008-12-10 11:24:33 +00:00
parent 517413f9af
commit a3ca7cf069
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libbb/xconnect.c
View File

@ -24,7 +24,9 @@ int FAST_FUNC setsockopt_bindtodevice(int fd, const char *iface)
int r; int r;
struct ifreq ifr; struct ifreq ifr;
strncpy_IFNAMSIZ(ifr.ifr_name, iface); strncpy_IFNAMSIZ(ifr.ifr_name, iface);
/* Actually, ifr_name is at offset 0, and in practice /* NB: passing (iface, strlen(iface) + 1) does not work!
* (maybe it works on _some_ kernels, but not on 2.6.26)
* Actually, ifr_name is at offset 0, and in practice
* just giving char[IFNAMSIZ] instead of struct ifreq works too. * just giving char[IFNAMSIZ] instead of struct ifreq works too.
* But just in case it's not true on some obscure arch... */ * But just in case it's not true on some obscure arch... */
r = setsockopt(fd, SOL_SOCKET, SO_BINDTODEVICE, &ifr, sizeof(ifr)); r = setsockopt(fd, SOL_SOCKET, SO_BINDTODEVICE, &ifr, sizeof(ifr));