emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ar: better comment

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2013-09-10 16:27:08 +02:00
parent 2a053a2430
commit a613aa1b4c
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
archival/libarchive/get_header_ar.c
View File

@ -59,6 +59,11 @@ char FAST_FUNC get_header_ar(archive_handle_t *archive_handle)
if (ar.formatted.magic[0] != '`' || ar.formatted.magic[1] != '\n') if (ar.formatted.magic[0] != '`' || ar.formatted.magic[1] != '\n')
bb_error_msg_and_die("invalid ar header"); bb_error_msg_and_die("invalid ar header");
/*
* Note that the fields MUST be read in reverse order as
* read_num() clobbers the next byte after the field!
* Order is: name, date, uid, gid, mode, size, magic.
*/
typed->size = size = read_num(ar.formatted.size, 10, typed->size = size = read_num(ar.formatted.size, 10,
sizeof(ar.formatted.size)); sizeof(ar.formatted.size));
@ -91,8 +96,6 @@ char FAST_FUNC get_header_ar(archive_handle_t *archive_handle)
/* Only size is always present, the rest may be missing in /* Only size is always present, the rest may be missing in
* long filename pseudo file. Thus we decode the rest * long filename pseudo file. Thus we decode the rest
* after dealing with long filename pseudo file. * after dealing with long filename pseudo file.
* Note that the fields MUST be read in reverse order as
* read_num() clobbers the next byte after the field!
*/ */
typed->mode = read_num(ar.formatted.mode, 8, sizeof(ar.formatted.mode)); typed->mode = read_num(ar.formatted.mode, 8, sizeof(ar.formatted.mode));
typed->gid = read_num(ar.formatted.gid, 10, sizeof(ar.formatted.gid)); typed->gid = read_num(ar.formatted.gid, 10, sizeof(ar.formatted.gid));