emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

eliminate aliasing warning in networking/route.c

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2011-01-20 11:29:00 +01:00
parent 53f30b41ec
commit b3b6c8bdf2
2 changed files with 41 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
networking/ifplugd.c
View File

@ -133,7 +133,8 @@ static smallint detect_link_mii(void)
{ {
/* char buffer instead of bona-fide struct avoids aliasing warning */ /* char buffer instead of bona-fide struct avoids aliasing warning */
char buf[sizeof(struct ifreq)]; char buf[sizeof(struct ifreq)];
struct ifreq *ifreq = (void *)buf; struct ifreq *const ifreq = (void *)buf;
struct mii_ioctl_data *mii = (void *)&ifreq->ifr_data; struct mii_ioctl_data *mii = (void *)&ifreq->ifr_data;
set_ifreq_to_ifname(ifreq); set_ifreq_to_ifname(ifreq);
@ -155,7 +156,8 @@ static smallint detect_link_priv(void)
{ {
/* char buffer instead of bona-fide struct avoids aliasing warning */ /* char buffer instead of bona-fide struct avoids aliasing warning */
char buf[sizeof(struct ifreq)]; char buf[sizeof(struct ifreq)];
struct ifreq *ifreq = (void *)buf; struct ifreq *const ifreq = (void *)buf;
struct mii_ioctl_data *mii = (void *)&ifreq->ifr_data; struct mii_ioctl_data *mii = (void *)&ifreq->ifr_data;
set_ifreq_to_ifname(ifreq); set_ifreq_to_ifname(ifreq);

71
networking/route.c
View File

@ -153,7 +153,10 @@ static int kw_lookup(const char *kwtbl, char ***pargs)
static NOINLINE void INET_setroute(int action, char **args) static NOINLINE void INET_setroute(int action, char **args)
{ {
struct rtentry rt; /* char buffer instead of bona-fide struct avoids aliasing warning */
char rt_buf[sizeof(struct rtentry)];
struct rtentry *const rt = (void *)rt_buf;
const char *netmask = NULL; const char *netmask = NULL;
int skfd, isnet, xflag; int skfd, isnet, xflag;
@ -166,7 +169,7 @@ static NOINLINE void INET_setroute(int action, char **args)
} }
/* Clean out the RTREQ structure. */ /* Clean out the RTREQ structure. */
memset(&rt, 0, sizeof(rt)); memset(rt, 0, sizeof(*rt));
{ {
const char *target = *args++; const char *target = *args++;
@ -178,17 +181,17 @@ static NOINLINE void INET_setroute(int action, char **args)
int prefix_len; int prefix_len;
prefix_len = xatoul_range(prefix+1, 0, 32); prefix_len = xatoul_range(prefix+1, 0, 32);
mask_in_addr(rt) = htonl( ~(0xffffffffUL >> prefix_len)); mask_in_addr(*rt) = htonl( ~(0xffffffffUL >> prefix_len));
*prefix = '\0'; *prefix = '\0';
#if HAVE_NEW_ADDRT #if HAVE_NEW_ADDRT
rt.rt_genmask.sa_family = AF_INET; rt->rt_genmask.sa_family = AF_INET;
#endif #endif
} else { } else {
/* Default netmask. */ /* Default netmask. */
netmask = "default"; netmask = "default";
} }
/* Prefer hostname lookup is -host flag (xflag==1) was given. */ /* Prefer hostname lookup is -host flag (xflag==1) was given. */
isnet = INET_resolve(target, (struct sockaddr_in *) &rt.rt_dst, isnet = INET_resolve(target, (struct sockaddr_in *) &rt->rt_dst,
(xflag & HOST_FLAG)); (xflag & HOST_FLAG));
if (isnet < 0) { if (isnet < 0) {
bb_error_msg_and_die("resolving %s", target); bb_error_msg_and_die("resolving %s", target);
@ -204,20 +207,20 @@ static NOINLINE void INET_setroute(int action, char **args)
} }
/* Fill in the other fields. */ /* Fill in the other fields. */
rt.rt_flags = ((isnet) ? RTF_UP : (RTF_UP | RTF_HOST)); rt->rt_flags = ((isnet) ? RTF_UP : (RTF_UP | RTF_HOST));
while (*args) { while (*args) {
int k = kw_lookup(tbl_ipvx, &args); int k = kw_lookup(tbl_ipvx, &args);
const char *args_m1 = args[-1]; const char *args_m1 = args[-1];
if (k & KW_IPVx_FLAG_ONLY) { if (k & KW_IPVx_FLAG_ONLY) {
rt.rt_flags |= flags_ipvx[k & 3]; rt->rt_flags |= flags_ipvx[k & 3];
continue; continue;
} }
#if HAVE_NEW_ADDRT #if HAVE_NEW_ADDRT
if (k == KW_IPVx_METRIC) { if (k == KW_IPVx_METRIC) {
rt.rt_metric = xatoul(args_m1) + 1; rt->rt_metric = xatoul(args_m1) + 1;
continue; continue;
} }
#endif #endif
@ -225,7 +228,7 @@ static NOINLINE void INET_setroute(int action, char **args)
if (k == KW_IPVx_NETMASK) { if (k == KW_IPVx_NETMASK) {
struct sockaddr mask; struct sockaddr mask;
if (mask_in_addr(rt)) { if (mask_in_addr(*rt)) {
bb_show_usage(); bb_show_usage();
} }
@ -234,18 +237,18 @@ static NOINLINE void INET_setroute(int action, char **args)
if (isnet < 0) { if (isnet < 0) {
bb_error_msg_and_die("resolving %s", netmask); bb_error_msg_and_die("resolving %s", netmask);
} }
rt.rt_genmask = full_mask(mask); rt->rt_genmask = full_mask(mask);
continue; continue;
} }
if (k == KW_IPVx_GATEWAY) { if (k == KW_IPVx_GATEWAY) {
if (rt.rt_flags & RTF_GATEWAY) { if (rt->rt_flags & RTF_GATEWAY) {
bb_show_usage(); bb_show_usage();
} }
isnet = INET_resolve(args_m1, isnet = INET_resolve(args_m1,
(struct sockaddr_in *) &rt.rt_gateway, 1); (struct sockaddr_in *) &rt->rt_gateway, 1);
rt.rt_flags |= RTF_GATEWAY; rt->rt_flags |= RTF_GATEWAY;
if (isnet) { if (isnet) {
if (isnet < 0) { if (isnet < 0) {
@ -257,24 +260,24 @@ static NOINLINE void INET_setroute(int action, char **args)
} }
if (k == KW_IPVx_MSS) { /* Check valid MSS bounds. */ if (k == KW_IPVx_MSS) { /* Check valid MSS bounds. */
rt.rt_flags |= RTF_MSS; rt->rt_flags |= RTF_MSS;
rt.rt_mss = xatoul_range(args_m1, 64, 32768); rt->rt_mss = xatoul_range(args_m1, 64, 32768);
continue; continue;
} }
if (k == KW_IPVx_WINDOW) { /* Check valid window bounds. */ if (k == KW_IPVx_WINDOW) { /* Check valid window bounds. */
rt.rt_flags |= RTF_WINDOW; rt->rt_flags |= RTF_WINDOW;
rt.rt_window = xatoul_range(args_m1, 128, INT_MAX); rt->rt_window = xatoul_range(args_m1, 128, INT_MAX);
continue; continue;
} }
#ifdef RTF_IRTT #ifdef RTF_IRTT
if (k == KW_IPVx_IRTT) { if (k == KW_IPVx_IRTT) {
rt.rt_flags |= RTF_IRTT; rt->rt_flags |= RTF_IRTT;
rt.rt_irtt = xatoul(args_m1); rt->rt_irtt = xatoul(args_m1);
rt.rt_irtt *= (sysconf(_SC_CLK_TCK) / 100); /* FIXME */ rt->rt_irtt *= (sysconf(_SC_CLK_TCK) / 100); /* FIXME */
#if 0 /* FIXME: do we need to check anything of this? */ #if 0 /* FIXME: do we need to check anything of this? */
if (rt.rt_irtt < 1 || rt.rt_irtt > (120 * HZ)) { if (rt->rt_irtt < 1 || rt->rt_irtt > (120 * HZ)) {
bb_error_msg_and_die("bad irtt"); bb_error_msg_and_die("bad irtt");
} }
#endif #endif
@ -284,9 +287,9 @@ static NOINLINE void INET_setroute(int action, char **args)
/* Device is special in that it can be the last arg specified /* Device is special in that it can be the last arg specified
* and doesn't requre the dev/device keyword in that case. */ * and doesn't requre the dev/device keyword in that case. */
if (!rt.rt_dev && ((k == KW_IPVx_DEVICE) || (!k && !*++args))) { if (!rt->rt_dev && ((k == KW_IPVx_DEVICE) || (!k && !*++args))) {
/* Don't use args_m1 here since args may have changed! */ /* Don't use args_m1 here since args may have changed! */
rt.rt_dev = args[-1]; rt->rt_dev = args[-1];
continue; continue;
} }
@ -295,41 +298,41 @@ static NOINLINE void INET_setroute(int action, char **args)
} }
#ifdef RTF_REJECT #ifdef RTF_REJECT
if ((rt.rt_flags & RTF_REJECT) && !rt.rt_dev) { if ((rt->rt_flags & RTF_REJECT) && !rt->rt_dev) {
rt.rt_dev = (char*)"lo"; rt->rt_dev = (char*)"lo";
} }
#endif #endif
/* sanity checks.. */ /* sanity checks.. */
if (mask_in_addr(rt)) { if (mask_in_addr(*rt)) {
uint32_t mask = mask_in_addr(rt); uint32_t mask = mask_in_addr(*rt);
mask = ~ntohl(mask); mask = ~ntohl(mask);
if ((rt.rt_flags & RTF_HOST) && mask != 0xffffffff) { if ((rt->rt_flags & RTF_HOST) && mask != 0xffffffff) {
bb_error_msg_and_die("netmask %.8x and host route conflict", bb_error_msg_and_die("netmask %.8x and host route conflict",
(unsigned int) mask); (unsigned int) mask);
} }
if (mask & (mask + 1)) { if (mask & (mask + 1)) {
bb_error_msg_and_die("bogus netmask %s", netmask); bb_error_msg_and_die("bogus netmask %s", netmask);
} }
mask = ((struct sockaddr_in *) &rt.rt_dst)->sin_addr.s_addr; mask = ((struct sockaddr_in *) &rt->rt_dst)->sin_addr.s_addr;
if (mask & ~(uint32_t)mask_in_addr(rt)) { if (mask & ~(uint32_t)mask_in_addr(*rt)) {
bb_error_msg_and_die("netmask and route address conflict"); bb_error_msg_and_die("netmask and route address conflict");
} }
} }
/* Fill out netmask if still unset */ /* Fill out netmask if still unset */
if ((action == RTACTION_ADD) && (rt.rt_flags & RTF_HOST)) { if ((action == RTACTION_ADD) && (rt->rt_flags & RTF_HOST)) {
mask_in_addr(rt) = 0xffffffff; mask_in_addr(*rt) = 0xffffffff;
} }
/* Create a socket to the INET kernel. */ /* Create a socket to the INET kernel. */
skfd = xsocket(AF_INET, SOCK_DGRAM, 0); skfd = xsocket(AF_INET, SOCK_DGRAM, 0);
if (action == RTACTION_ADD) if (action == RTACTION_ADD)
xioctl(skfd, SIOCADDRT, &rt); xioctl(skfd, SIOCADDRT, rt);
else else
xioctl(skfd, SIOCDELRT, &rt); xioctl(skfd, SIOCDELRT, rt);
if (ENABLE_FEATURE_CLEAN_UP) close(skfd); if (ENABLE_FEATURE_CLEAN_UP) close(skfd);
} }