emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lineedit: do not tab-complete any strings which have control characters

Browse Source 
function                                             old     new   delta
add_match                                             41      68     +27

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2017-11-07 18:09:29 +01:00
parent a5060b8364
commit c3797d40a1
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libbb/lineedit.c
View File

@ -645,6 +645,18 @@ static void free_tab_completion_data(void)
static void add_match(char *matched) static void add_match(char *matched)
{ {
unsigned char *p = (unsigned char*)matched;
while (*p) {
/* ESC attack fix: drop any string with control chars */
if (*p < ' '
|| (!ENABLE_UNICODE_SUPPORT && *p >= 0x7f)
|| (ENABLE_UNICODE_SUPPORT && *p == 0x7f)
) {
free(matched);
return;
}
p++;
}
matches = xrealloc_vector(matches, 4, num_matches); matches = xrealloc_vector(matches, 4, num_matches);
matches[num_matches] = matched; matches[num_matches] = matched;
num_matches++; num_matches++;