emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tar: cache [ug]id->username/groupname mappings. Cuts down amount

Browse Source 
of open/read/close of /etc/passwd and /etc/group
dramatically (we were rereading those for each untarred file!!!)
This commit is contained in:
Denis Vlasenko
2006-11-24 14:57:31 +00:00
parent 4fbb584a0e
commit c50f370f98
3 changed files with 52 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
archival/tar.c
View File

@@ -211,12 +211,9 @@ static int writeTarHeader(struct TarBallInfo *tbInfo,
putOctal(header.mtime, sizeof(header.mtime), statbuf->st_mtime);
strcpy(header.magic, "ustar ");
/* Enter the user and group names (default to root if it fails) */
//cache!!!
if (bb_getpwuid(header.uname, statbuf->st_uid, sizeof(header.uname)) == NULL)
strcpy(header.uname, "root");
if (bb_getgrgid(header.gname, statbuf->st_gid, sizeof(header.gname)) == NULL)
strcpy(header.gname, "root");
/* Enter the user and group names */
safe_strncpy(header.uname, get_cached_username(statbuf->st_uid), sizeof(header.uname));
safe_strncpy(header.gname, get_cached_groupname(statbuf->st_gid), sizeof(header.gname));
if (tbInfo->hlInfo) {
/* This is a hard link */