emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hexedit: fixes for redraw and down movement causing SEGV on attempt to access

Browse Source 
"Go to:" command was not updating row position, making next "down" movements
for one screenful print empty lines instead of showing the contents.

If the file is whole pages long, "down" movement at EOF was advancing position
+16 bytes, mapping the next portion (entirely past the end of the file),
then finding out that the new position is beyond the EOF, rolling it back
-16 bytes... ending up with this postion pointing *before* the mapped portion.
Any next access (e.g. "move right" key) SEGVs.

function                                             old     new   delta
hexedit_main                                        1170    1184     +14

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2018-07-23 14:21:07 +02:00
parent f36caa4071
commit ca2f831ead
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
miscutils/hexedit.c
View File

@ -153,7 +153,8 @@ static void redraw(unsigned cursor)
i++; i++;
} }
printf(ESC"[%u;%uH", 1 + cursor / 16, 1 + pos + (cursor & 0xf) * 3); G.row = cursor / 16;
printf(ESC"[%u;%uH", 1 + G.row, 1 + pos + (cursor & 0xf) * 3);
} }
static void redraw_cur_line(void) static void redraw_cur_line(void)
@ -367,6 +368,8 @@ int hexedit_main(int argc UNUSED_PARAM, char **argv)
if (G.current_byte > G.eof_byte) { if (G.current_byte > G.eof_byte) {
/* _after_ eof - don't allow this */ /* _after_ eof - don't allow this */
G.current_byte -= 16; G.current_byte -= 16;
if (G.current_byte < G.baseaddr)
move_mapping_lower();
break; break;
} }
} }