emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

httpd:

Browse Source 
fix union aliasing bug
symptom: wget of non-existent file gets redirected to /text/html/something
on second and subsequend wget attempts
fix double-free bug
symptom: glibc caught double-free (we didn't NULL config->xxx ptrs after free)
This commit is contained in:
Denis Vlasenko 2006-11-16 16:20:12 +00:00
parent 0871bc89fb
commit d4f3d1a4bd
1 changed files with 17 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
networking/httpd.c
View File

@ -143,10 +143,8 @@ typedef struct {
#endif #endif
unsigned port; /* server initial port and for unsigned port; /* server initial port and for
set env REMOTE_PORT */ set env REMOTE_PORT */
union HTTPD_FOUND {
const char *found_mime_type; const char *found_mime_type;
const char *found_moved_temporarily; const char *found_moved_temporarily;
} httpd_found;
off_t ContentLength; /* -1 - unknown */ off_t ContentLength; /* -1 - unknown */
time_t last_mod; time_t last_mod;
@ -857,7 +855,7 @@ static int sendHeaders(HttpResponseNum responseNum)
} }
/* error message is HTML */ /* error message is HTML */
mime_type = responseNum == HTTP_OK ? mime_type = responseNum == HTTP_OK ?
config->httpd_found.found_mime_type : "text/html"; config->found_mime_type : "text/html";
/* emit the current date */ /* emit the current date */
strftime(timeStr, sizeof(timeStr), RFC1123FMT, gmtime(&timer)); strftime(timeStr, sizeof(timeStr), RFC1123FMT, gmtime(&timer));
@ -874,7 +872,7 @@ static int sendHeaders(HttpResponseNum responseNum)
#endif #endif
if (responseNum == HTTP_MOVED_TEMPORARILY) { if (responseNum == HTTP_MOVED_TEMPORARILY) {
len += sprintf(buf+len, "Location: %s/%s%s\r\n", len += sprintf(buf+len, "Location: %s/%s%s\r\n",
config->httpd_found.found_moved_temporarily, config->found_moved_temporarily,
(config->query ? "?" : ""), (config->query ? "?" : ""),
(config->query ? config->query : "")); (config->query ? config->query : ""));
} }
@ -894,7 +892,7 @@ static int sendHeaders(HttpResponseNum responseNum)
responseNum, responseString, infoString); responseNum, responseString, infoString);
} }
#if DEBUG #if DEBUG
fprintf(stderr, "Headers: '%s'", buf); fprintf(stderr, "headers: '%s'\n", buf);
#endif #endif
return full_write(config->accepted_socket, buf, len); return full_write(config->accepted_socket, buf, len);
} }
@ -1246,14 +1244,14 @@ static int sendFile(const char *url)
break; break;
} }
/* also, if not found, set default as "application/octet-stream"; */ /* also, if not found, set default as "application/octet-stream"; */
config->httpd_found.found_mime_type = *(table+1); config->found_mime_type = table[1];
#if ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES #if ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES
if (suffix) { if (suffix) {
Htaccess * cur; Htaccess * cur;
for (cur = config->mime_a; cur; cur = cur->next) { for (cur = config->mime_a; cur; cur = cur->next) {
if (strcmp(cur->before_colon, suffix) == 0) { if (strcmp(cur->before_colon, suffix) == 0) {
config->httpd_found.found_mime_type = cur->after_colon; config->found_mime_type = cur->after_colon;
break; break;
} }
} }
@ -1261,8 +1259,8 @@ static int sendFile(const char *url)
#endif /* CONFIG_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES */ #endif /* CONFIG_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES */
#if DEBUG #if DEBUG
fprintf(stderr, "Sending file '%s' Content-type: %s\n", fprintf(stderr, "sending file '%s' content-type: %s\n",
url, config->httpd_found.found_mime_type); url, config->found_mime_type);
#endif #endif
f = open(url, O_RDONLY); f = open(url, O_RDONLY);
@ -1278,7 +1276,7 @@ static int sendFile(const char *url)
close(f); close(f);
} else { } else {
#if DEBUG #if DEBUG
bb_perror_msg("unable to open '%s'", url); bb_perror_msg("cannot open '%s'", url);
#endif #endif
sendHeaders(HTTP_NOT_FOUND); sendHeaders(HTTP_NOT_FOUND);
} }
@ -1538,7 +1536,7 @@ BAD_REQUEST:
/* If URL is directory, adding '/' */ /* If URL is directory, adding '/' */
if (test[-1] != '/') { if (test[-1] != '/') {
if (is_directory(url + 1, 1, &sb)) { if (is_directory(url + 1, 1, &sb)) {
config->httpd_found.found_moved_temporarily = url; config->found_moved_temporarily = url;
} }
} }
#if DEBUG #if DEBUG
@ -1628,12 +1626,10 @@ FORBIDDEN: /* protect listing /cgi-bin */
} }
#endif #endif
if (config->httpd_found.found_moved_temporarily) { if (config->found_moved_temporarily) {
sendHeaders(HTTP_MOVED_TEMPORARILY); sendHeaders(HTTP_MOVED_TEMPORARILY);
#if DEBUG
/* clear unforked memory flag */ /* clear unforked memory flag */
config->httpd_found.found_moved_temporarily = NULL; config->found_moved_temporarily = NULL;
#endif
break; break;
} }
@ -1668,14 +1664,14 @@ FORBIDDEN: /* protect listing /cgi-bin */
} while (0); } while (0);
# if DEBUG # if DEBUG
fprintf(stderr, "closing socket\n"); fprintf(stderr, "closing socket\n\n");
# endif # endif
# if ENABLE_FEATURE_HTTPD_CGI # if ENABLE_FEATURE_HTTPD_CGI
free(cookie); free(cookie);
free(content_type); free(content_type);
free(config->referer); free(config->referer); config->referer = NULL;
# if ENABLE_FEATURE_HTTPD_BASIC_AUTH # if ENABLE_FEATURE_HTTPD_BASIC_AUTH
free(config->remoteuser); free(config->remoteuser); config->remoteuser = NULL;
# endif # endif
# endif # endif
shutdown(config->accepted_socket, SHUT_WR); shutdown(config->accepted_socket, SHUT_WR);
@ -1733,7 +1729,6 @@ static int miniHttpd(int server)
s = accept(server, (struct sockaddr *)&fromAddr, &fromAddrLen); s = accept(server, (struct sockaddr *)&fromAddr, &fromAddrLen);
if (s < 0) if (s < 0)
continue; continue;
config->accepted_socket = s; config->accepted_socket = s;
config->rmt_ip = ntohl(fromAddr.sin_addr.s_addr); config->rmt_ip = ntohl(fromAddr.sin_addr.s_addr);
#if ENABLE_FEATURE_HTTPD_CGI || DEBUG #if ENABLE_FEATURE_HTTPD_CGI || DEBUG