emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

netstat: was using buffers one byte short for scanf (no place for NUL). fixing

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2010-10-28 02:36:17 +02:00
parent 9ce642f974
commit db9ccc5772
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
networking/netstat.c
View File

@ -395,11 +395,14 @@ struct inet_params {
static int scan_inet_proc_line(struct inet_params *param, char *line) static int scan_inet_proc_line(struct inet_params *param, char *line)
{ {
int num; int num;
char local_addr[64], rem_addr[64]; /* IPv6 /proc files use 32-char hex representation
* of IPv6 address, followed by :PORT_IN_HEX
*/
char local_addr[33], rem_addr[33]; /* 32 + 1 for NUL */
num = sscanf(line, num = sscanf(line,
"%*d: %64[0-9A-Fa-f]:%X " "%*d: %32[0-9A-Fa-f]:%X "
"%64[0-9A-Fa-f]:%X %X " "%32[0-9A-Fa-f]:%X %X "
"%lX:%lX %*X:%*X " "%lX:%lX %*X:%*X "
"%*X %d %*d %ld ", "%*X %d %*d %ld ",
local_addr, &param->local_port, local_addr, &param->local_port,