zcip: fix slow environment leak

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2017-07-22 03:04:20 +02:00
parent bbf17bbf32
commit e4f6bfd6fe
3 changed files with 12 additions and 6 deletions
--- a/include/libbb.h
+++ b/include/libbb.h
@ -1485,6 +1485,9 @@ extern void selinux_or_die(void) FAST_FUNC;
 *   HOME=pw->pw_dir
 *   SHELL=shell
 * else does nothing
+ *
+ * NB: CHANGEENV and CLEARENV use setenv() - this leaks memory!
+ * If setup_environment() is used is vforked child, this leaks memory _in parent too_!
 */
 #define SETUP_ENV_CHANGEENV (1 << 0)
 #define SETUP_ENV_CLEARENV  (1 << 1)