emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

config: PID_FILE_PATH required for FEATURE_CROND_SPECIAL_TIMES

Browse Source 
When crond is built with FEATURE_CROND_SPECIAL_TIMES enabled, it creates
a file called 'crond.reboot' at CONFIG_PID_FILE_PATH, but if
FEATURE_PIDFILE is disabled, this will be an empty string and the file
will be created in the root directory, which is undesirable.

This commit makes PID_FILE_PATH depend on FEATURE_CROND_SPECIAL_TIMES as
well as FEATURE_PIDFILE so that you get sensible behaviour in crond when
FEATURE_PIDFILE is switched off.

Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
James Byrne 2019-07-17 15:53:04 +00:00 committed by Denys Vlasenko
parent eb1395147a
commit ed79af77a4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Config.in
View File

@ -156,12 +156,13 @@ config FEATURE_PIDFILE
config PID_FILE_PATH config PID_FILE_PATH
string "Directory for pidfiles" string "Directory for pidfiles"
default "/var/run" default "/var/run"
depends on FEATURE_PIDFILE depends on FEATURE_PIDFILE || FEATURE_CROND_SPECIAL_TIMES
help help
This is the default path where pidfiles are created. Applets which This is the default path where pidfiles are created. Applets which
allow you to set the pidfile path on the command line will override allow you to set the pidfile path on the command line will override
this value. The option has no effect on applets that require you to this value. The option has no effect on applets that require you to
specify a pidfile path. specify a pidfile path. When crond has the 'Support special times'
option enabled, the 'crond.reboot' file is also stored here.
config BUSYBOX config BUSYBOX
bool "Include busybox applet" bool "Include busybox applet"