57 Commits

Author	SHA1	Message	Date
Denis Vlasenko	682ad3045c	lineedit: fix problems with empty commands in history	2008-09-27 01:28:56 +00:00
Denis Vlasenko	f31c3b677d	linedit: fix use-after-free	2008-08-20 00:46:32 +00:00
Denis Vlasenko	41660c5b2d	another overlapping_strcpy	2008-07-22 20:25:24 +00:00
Denis Vlasenko	0f293b96dc	fix all cases of strcpy on overlapping strings.	2008-07-22 20:16:55 +00:00
Denis Vlasenko	5415c856ea	libbb: [x]fopen_for_{read,write} introduced and used. ... (by Valdimir) function old new delta config_open2 - 41 +41 config_read 507 542 +35 find_pair 169 187 +18 fopen_for_write - 14 +14 fopen_for_read - 14 +14 find_main 406 418 +12 xfopen_for_write - 10 +10 xfopen_for_read - 10 +10 popstring 134 140 +6 parse_inittab 396 401 +5 next_token 923 928 +5 pack_gzip 1659 1661 +2 bb__parsespent 117 119 +2 fallbackSort 1719 1717 -2 evalvar 1376 1374 -2 qrealloc 36 33 -3 ... ... ... ... singlemount 4579 4569 -10 process_stdin 443 433 -10 patch_main 1111 1101 -10 ifupdown_main 2175 2165 -10 file_action_grep 90 80 -10 uuidcache_init 649 637 -12 hush_main 797 785 -12 read_config 230 217 -13 dpkg_main 3835 3820 -15 read_line_input 3134 3110 -24 sysctl_main 232 203 -29 config_open 40 10 -30 WARN_BAD_LINE 44 - -44 login_main 1714 1575 -139 ------------------------------------------------------------------------------ (add/remove: 5/1 grow/shrink: 8/74 up/down: 174/-737) Total: -563 bytes	2008-07-21 23:05:26 +00:00
Denis Vlasenko	deeed59de0	libbb: introduce and use xrealloc_vector ... function old new delta xrealloc_vector_helper - 51 +51 create_list 84 99 +15 getopt_main 690 695 +5 passwd_main 1049 1053 +4 get_cached 85 89 +4 msh_main 1377 1380 +3 add_match 42 41 -1 read_lines 720 718 -2 grave 1068 1066 -2 fill_match_lines 143 141 -2 add_to_dirlist 67 65 -2 add_input_file 49 47 -2 act 252 250 -2 fsck_main 2252 2246 -6 man_main 765 757 -8 bb_internal_initgroups 228 220 -8 cut_main 1052 1041 -11 add_edge_to_node 55 43 -12 dpkg_main 3851 3835 -16 ifupdown_main 2202 2178 -24 sort_main 838 812 -26 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 5/15 up/down: 82/-124) Total: -42 bytes	2008-07-08 05:14:36 +00:00
Denis Vlasenko	78ff8197cc	lineedit: document prompt handling	2008-06-28 21:03:43 +00:00
Denis Vlasenko	defc1ea340	*: introduce and use FAST_FUNC: regparm on i386, otherwise no-on ... text data bss dec hex filename 808035 611 6868 815514 c719a busybox_old 804472 611 6868 811951 c63af busybox_unstripped	2008-06-27 02:52:20 +00:00
Denis Vlasenko	b267ed95bc	lineedit: correctly handle prompt longer than screen width. closes bug 3414	2008-05-25 21:52:03 +00:00
Denis Vlasenko	5599502a55	more -Wall warning fixes. -Wall is enabled now.	2008-05-18 22:28:26 +00:00
Denis Vlasenko	6b06cb80be	more of -Wall fixes from Cristian Ionescu-Idbohrn. ... Some are fixing real bugs. function old new delta syslogd_main 938 958 +20 get_signum 136 143 +7 obj_load 777 782 +5 recv_from_to 210 214 +4 get_next_block 1795 1799 +4 display_topmem_process_list 1117 1121 +4 logread_main 484 487 +3 buffer_fill_and_print 73 76 +3 kill_main 687 689 +2 ll_remember_index 240 241 +1 do_stats 452 453 +1 if_readconf 166 165 -1 display_process_list 1192 1191 -1 run_applet_and_exit 507 505 -2 print_signames 33 31 -2 parse_one_line 1092 1090 -2 find_out_spec 57 55 -2 add_ksymoops_symbols 421 419 -2 ash_main 1407 1402 -5 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 11/8 up/down: 54/-17) Total: 37 bytes	2008-05-15 21:30:45 +00:00
Denis Vlasenko	77ad97f199	more -Wall warning fixes from Cristian Ionescu-Idbohrn. ... This time it resulted in small code changes: function old new delta nexpr 820 828 +8 tail_main 1200 1202 +2 wrapf 166 167 +1 parse_mount_options 227 209 -18 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/1 up/down: 11/-18) Total: -7 bytes	2008-05-13 02:27:31 +00:00
Denis Vlasenko	2c84495184	lineedit: hack for making it sort-of-work even if term width is wrong ... function old new delta read_line_input 3158 3153 -5 input_end 29 24 -5 input_delete 115 110 -5 input_forward 27 20 -7 cmdedit_set_out_char 88 80 -8	2008-04-25 18:44:35 +00:00
Denis Vlasenko	b520271f65	lineedit: filename completion on symlinks-to-dirs should add / too	2008-04-24 04:42:52 +00:00
Denis Vlasenko	5d89fbaa2e	*: remove remaining instances of ".data" hack	2008-04-22 00:08:27 +00:00
Denis Vlasenko	8ee649a02e	*: more uniform naming: s/xmalloc_getline/xmalloc_fgetline/	2008-03-26 20:04:27 +00:00
Denis Vlasenko	08ec67bc62	patch: add support for -R. ~ +110 byte. By Pascal Bellard <pascal.bellard AT ads-lu.com> ... fbsplash: new applet by Michele Sanges <michele.sanges AT otomelara.it function old new delta fbsplash_main - 1525 +1525 fb_drawfullrectangle - 118 +118 static.param_value - 100 +100 packed_usage 23776 23872 +96 applet_names 1843 1852 +9 applet_main 1120 1124 +4 read_line_input 3156 3158 +2 applet_nameofs 560 562 +2 applet_install_loc 140 141 +1 ------------------------------------------------------------------------------ (add/remove: 3/0 grow/shrink: 6/0 up/down: 1857/0) Total: 1857 bytes text data bss dec hex filename 799233 641 7380 807254 c5156 busybox_old 801202 641 7380 809223 c5907 busybox_unstripped	2008-03-26 13:32:30 +00:00
Denis Vlasenko	85c247161b	*: fix fallout from -Wunused-parameter ... function old new delta bbunpack 358 366 +8 passwd_main 1070 1072 +2 handle_incoming_and_exit 2651 2653 +2 getpty 88 86 -2 script_main 975 972 -3 inetd_main 2036 2033 -3 dname_enc 377 373 -4 make_new_session 474 462 -12 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/5 up/down: 12/-24) Total: -12 bytes text data bss dec hex filename 797429 658 7428 805515 c4a8b busybox_old 797417 658 7428 805503 c4a7f busybox_unstripped	2008-03-17 09:04:04 +00:00
Denis Vlasenko	fb29038b59	libbb: inntroduce and use bb_pstrcmp() and qsort_string_vector() ... msh: glob0/glob1/glob2/glob3 are just a sorting routine! remove them. bb_pstrcmp - 25 +25 qsort_string_vector - 24 +24 expand 2209 2227 +18 getopt32 1359 1370 +11 passwd_main 1072 1074 +2 handle_incoming_and_exit 2737 2735 -2 UNSPEC_print 66 64 -2 forkexec 1343 1339 -4 input_tab 3338 3330 -8 get_dir 185 177 -8 expmeta 481 473 -8 cmdputs 405 397 -8 xstrcmp 12 - -12 find_pair 187 167 -20 match_compare 25 - -25 dir_strcmp 25 - -25 glob2 27 - -27 glob3 34 - -34 glob1 256 - -256 ------------------------------------------------------------------------------ (add/remove: 2/6 grow/shrink: 3/8 up/down: 80/-439) Total: -359 bytes	2008-03-02 12:51:26 +00:00
Denis Vlasenko	574f2f4394	*: add optimization barrier to all "G trick" locations	2008-02-27 18:41:59 +00:00
Denis Vlasenko	6f1713f216	*: intrduce and use safe_gethostname. By Tito <farmatito AT tiscali.it> ... safe_gethostname - 48 +48 glob3 35 37 +2 timestamp_and_log 314 315 +1 udhcp_send_kernel_packet 234 231 -3 scan_tree 275 271 -4 passwd_main 1074 1070 -4 print_login_prompt 68 58 -10 obscure 392 377 -15 syslogd_main 882 866 -16 print_login_issue 516 478 -38 hostname_main 278 223 -55 parse_and_put_prompt 825 756 -69 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 2/9 up/down: 51/-214) Total: -163 bytes text data bss dec hex filename 798791 728 7484 807003 c505b busybox_old 798631 728 7484 806843 c4fbb busybox_unstripped	2008-02-25 23:23:58 +00:00
Denis Vlasenko	e376d454bb	libbb: introduce and use nonblock_safe_read(). Yay! ... Our shells are immune from this nasty O_NONBLOCK now! function old new delta nonblock_safe_read - 78 +78 file_get 276 295 +19 generateMTFValues 428 435 +7 read_line_input 1776 1772 -4 preadbuffer 543 450 -93 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 2/2 up/down: 104/-97) Total: 7 bytes text data bss dec hex filename 615190 715 23924 639829 9c355 busybox_old 615168 715 23924 639807 9c33f busybox_unstripped	2008-02-20 22:23:24 +00:00
Denis Vlasenko	6f04391cec	lineedit: tiny shrink	2008-02-18 22:28:03 +00:00
Denis Vlasenko	39487e2d6a	libbb: filename completion should match dangling symlinks too	2008-02-14 19:55:58 +00:00
Denis Vlasenko	80667e30fb	msh: fix Ctrl-C handling with line editing	2008-02-02 18:35:55 +00:00
Paul Fox	518d8dd979	eliminated CONFIG_FEATURE_EDITING_FANCY_KEYS. the size savings ... was small, compared to the total size of the command-line editing features, and it removed key bindings that most wouldn't consider "fancy", like ^U, and 'l' and 'h' in vi mode, ^F and ^B in emacs mode.	2008-01-18 20:41:24 +00:00
Paul Fox	84bbac5a09	enable use of ^V prefix to allow forced insertion of any character. in ... particular, without this it's impossible to enter a TAB on the commandline (whether tab completion is enabled or not).	2008-01-11 16:50:08 +00:00
Paul Fox	ee8e3ee919	allow 8-bit characters	2008-01-11 16:12:57 +00:00
Denis Vlasenko	6b404431aa	ps: fix build breakage from vda's recent commit ... *: whitespace fixes	2008-01-07 16:13:14 +00:00
Denis Vlasenko	f7be20e70c	nameif: extended matching (Nico Erfurth <masta@perlgolf.de>) ... *: whitespace fixes function old new delta prepend_new_eth_table - 304 +304 nameif_main 620 684 +64 cc_macaddr 51 - -51 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 1/0 up/down: 368/-51) Total: 317 bytes	2007-12-24 14:09:19 +00:00
Denis Vlasenko	9cb220be9d	lineedit: don't violate API if we do simple fgets ... ash: cosmetic style fixes, no code changes	2007-12-09 10:03:28 +00:00
Denis Vlasenko	7221c8c22d	lineedit: reduce stack usage ... netstat: reduce stack usage; fix handling of NULs in unix socket filenames static.has_inode 1 - -1 do_info 119 116 -3 deinit_S 60 51 -9 unix_do_one 578 451 -127 parse_and_put_prompt 966 825 -141 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 0/4 up/down: 0/-281) Total: -281 bytes	2007-12-03 10:45:14 +00:00
Denis Vlasenko	6672c8e480	test: stop using lots of bss. ... function old new delta test_main 425 456 +31 t_lex 69 73 +4 syntax 100 104 +4 ptr_to_statics 8 12 +4 t_wp_op 4 - -4 t_wp 4 - -4 ngroups 4 - -4 group_array 4 - -4 binop 590 585 -5 oexpr 104 97 -7 aexpr 101 94 -7 nexpr 831 820 -11 leaving 156 - -156 ------------------------------------------------------------------------------ (add/remove: 0/5 grow/shrink: 4/4 up/down: 43/-202) Total: -159 bytes text data bss dec hex filename 775098 929 9084 785111 bfad7 busybox_old 775107 933 8908 784948 bfa34 busybox_unstripped	2007-11-30 07:29:05 +00:00
Denis Vlasenko	73cb1fdfea	lineedit: stop using both data/bss and tons of stack. ... stack usage was ~10 kb! unfortunately, noticeable code size growth: text data bss dec hex filename 9252 12 181 9445 24e5 busybox.t7/libbb/lineedit.o 9714 4 0 9718 25f6 busybox.t8/libbb/lineedit.o	2007-11-10 01:35:47 +00:00
Denis Vlasenko	037576d77b	read_line_input: fix it to not do any fancy editing if echoing is disabled. ... ash: make read handling both more correct and smaller read_line_input 4037 4101 +64 input_backward 140 139 -1 readcmd 1079 1070 -9 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/2 up/down: 65/-10) Total: 54 bytes text data bss dec hex filename 777575 1000 9532 788107 c068b busybox_old 777629 1000 9532 788161 c06c1 busybox_unstripped	2007-10-20 18:30:38 +00:00
Denis Vlasenko	f74194e942	xatonum.h: add comment ... lineedit: fix typo in comment httpd: support for proxying connection to other http server (by Alex Landau <landau_alex@yahoo.com>)	2007-10-18 12:54:39 +00:00
Denis Vlasenko	feb7ae7f01	printf("%s\n") -> puts()	2007-10-01 12:05:12 +00:00
Denis Vlasenko	e918e155ed	remove stray semicolon	2007-09-28 21:56:36 +00:00
Denis Vlasenko	4daad9004d	introduce bb_putchar(). saves ~1800 on uclibc (less on glibc).	2007-09-27 10:20:47 +00:00
Denis Vlasenko	86b29ea9e8	lineedit: plug memory leak	2007-09-27 10:17:16 +00:00
Denis Vlasenko	6a5377ac14	documentation bits in comments, no code changes	2007-09-25 18:35:28 +00:00
Denis Vlasenko	dc757aa16c	introduce and use bb_basename() ... function old new delta bb_basename - 26 +26 sv_main 1226 1225 -1 passwd_main 1985 1983 -2 showdirs 482 478 -4 sendCgi 1811 1807 -4 make_device 1354 1350 -4 handleIncoming 2443 2439 -4 func_name 82 78 -4 service_name 2292 2285 -7 main 909 901 -8 cmp_main 555 547 -8 test_main 434 422 -12 act 228 216 -12 find_pair 180 164 -16 rmmod_main 298 280 -18 find_pid_by_name 156 134 -22 modprobe_main 1606 1576 -30 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/16 up/down: 26/-156) Total: -130 bytes text data bss dec hex filename 734933 3028 14400 752361 b7ae9 busybox_old 734801 3028 14400 752229 b7a65 busybox_unstripped	2007-06-30 08:04:05 +00:00
Denis Vlasenko	e8a0788b24	moved biggest stack buffers to malloc space, or made their size configurable ... (8k of shell line edit buffer is an overkill) # make ARCH=i386 bloatcheck function old new delta read_line_input 3933 3967 +34 ifaddrlist 348 345 -3 do_loadfont 208 191 -17 edit_file 840 819 -21 .rodata 129112 129080 -32 uncompress 1305 1268 -37 loadfont_main 566 495 -71 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/6 up/down: 34/-181) Total: -147 bytes	2007-06-10 15:08:44 +00:00
Denis Vlasenko	9a7d38fe24	delete tons of extra #includes	2007-05-31 22:42:12 +00:00
Denis Vlasenko	b6adbf1be2	usage.c: remove reference to busybox.h ... *: s/include "busybox.h"/include "libbb.h"	2007-05-26 19:00:18 +00:00
Denis Vlasenko	0922192740	lineedit: state->hist_file doesn't exist if !FEATURE_EDITING_SAVEHISTORY, ... #ifdef it out	2007-04-15 13:21:01 +00:00
Denis Vlasenko	5f9468e996	lineedit: nuke two unused variables and code which sets them ... applets: do not even try to read config if run by real root msh: use named constants (O_RDONLY etc) in open() instead of magic numbers, other minor code size reduction.	2007-04-14 13:22:09 +00:00
Denis Vlasenko	bf3561fd15	lineedit: do not try to open NULL history file	2007-04-14 10:10:40 +00:00
Denis Vlasenko	6b343ddbc8	fix inadvertently leaked PWD_BUFFER_SIZE	2007-03-18 00:57:15 +00:00
Denis Vlasenko	5df955fce2	Do not fail password check if shadow password does not exist - ... fall back to ordinary one Reduced usage of functions returning datain static buffers. (mostly passwd/group/shadow related): function old new delta correct_password 143 193 +50 sulogin_main 490 533 +43 adduser_main 732 774 +42 passwd_main 1875 1915 +40 addgroup_main 330 365 +35 bb_internal_getspnam 38 - -38 bb_internal_fgetpwent 38 - -38 bb_internal_fgetgrent 38 - -38 static.resultbuf 168 88 -80 static.buffer 1872 1104 -768 ------------------------------------------------------------------------------ (add/remove: 0/3 grow/shrink: 5/2 up/down: 210/-962) Total: -752 bytes	2007-03-13 13:01:14 +00:00