James Byrne 
							
						 
					 
					
						
						
							
						
						6937487be7 
					 
					
						
						
							
							libbb: reduce the overhead of single parameter bb_error_msg() calls  
						
						 
						
						... 
						
						
						
						Back in 2007, commit 0c97c9d437  ("'simple' error message functions by
Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower
overhead call to bb_perror_msg() when only a string was being printed
with no parameters. This saves space for some CPU architectures because
it avoids the overhead of a call to a variadic function. However there
has never been a simple version of bb_error_msg(), and since 2007 many
new calls to bb_perror_msg() have been added that only take a single
parameter and so could have been using bb_simple_perror_message().
This changeset introduces 'simple' versions of bb_info_msg(),
bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and
bb_herror_msg_and_die(), and replaces all calls that only take a
single parameter, or use something like ("%s", arg), with calls to the
corresponding 'simple' version.
Since it is likely that single parameter calls to the variadic functions
may be accidentally reintroduced in the future a new debugging config
option WARN_SIMPLE_MSG has been introduced. This uses some macro magic
which will cause any such calls to generate a warning, but this is
turned off by default to avoid use of the unpleasant macros in normal
circumstances.
This is a large changeset due to the number of calls that have been
replaced. The only files that contain changes other than simple
substitution of function calls are libbb.h, libbb/herror_msg.c,
libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c,
networking/udhcp/common.h and util-linux/mdev.c additonal macros have
been added for logging so that single parameter and multiple parameter
logging variants exist.
The amount of space saved varies considerably by architecture, and was
found to be as follows (for 'defconfig' using GCC 7.4):
Arm:     -92 bytes
MIPS:    -52 bytes
PPC:   -1836 bytes
x86_64: -938 bytes
Note that for the MIPS architecture only an exception had to be made
disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h)
because it made these files larger on MIPS.
Signed-off-by: James Byrne <james.byrne@origamienergy.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2019-07-02 11:35:03 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						b097a84d62 
					 
					
						
						
							
							config: update size information  
						
						 
						
						... 
						
						
						
						Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2018-12-28 03:20:17 +01:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						a02a4e9830 
					 
					
						
						
							
							whitespace and comment format fixes, no code changes  
						
						 
						
						... 
						
						
						
						Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2017-10-05 15:19:25 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						22542eca18 
					 
					
						
						
							
							getopt32: remove opt_complementary  
						
						 
						
						... 
						
						
						
						function                                             old     new   delta
vgetopt32                                           1318    1392     +74
runsvdir_main                                        703     713     +10
bb_make_directory                                    423     425      +2
collect_cpu                                          546     545      -1
opt_chars                                              3       -      -3
opt_complementary                                      4       -      -4
tftpd_main                                           567     562      -5
ntp_init                                             476     471      -5
zcip_main                                           1266    1256     -10
xxd_main                                             428     418     -10
whois_main                                           140     130     -10
who_main                                             463     453     -10
which_main                                           212     202     -10
wget_main                                           2535    2525     -10
watchdog_main                                        291     281     -10
watch_main                                           222     212     -10
vlock_main                                           399     389     -10
uuencode_main                                        332     322     -10
uudecode_main                                        316     306     -10
unlink_main                                           45      35     -10
udhcpd_main                                         1482    1472     -10
udhcpc_main                                         2762    2752     -10
tune2fs_main                                         290     280     -10
tunctl_main                                          366     356     -10
truncate_main                                        218     208     -10
tr_main                                              518     508     -10
time_main                                           1134    1124     -10
tftp_main                                            286     276     -10
telnetd_main                                        1873    1863     -10
tcpudpsvd_main                                      1785    1775     -10
taskset_main                                         521     511     -10
tar_main                                            1009     999     -10
tail_main                                           1644    1634     -10
syslogd_main                                        1967    1957     -10
switch_root_main                                     368     358     -10
svlogd_main                                         1454    1444     -10
sv                                                  1296    1286     -10
stat_main                                            104      94     -10
start_stop_daemon_main                              1028    1018     -10
split_main                                           542     532     -10
sort_main                                            796     786     -10
slattach_main                                        624     614     -10
shuf_main                                            504     494     -10
setsid_main                                           96      86     -10
setserial_main                                      1132    1122     -10
setfont_main                                         388     378     -10
setconsole_main                                       78      68     -10
sendmail_main                                       1209    1199     -10
sed_main                                             677     667     -10
script_main                                         1077    1067     -10
run_parts_main                                       325     315     -10
rtcwake_main                                         454     444     -10
rm_main                                              175     165     -10
reformime_main                                       119     109     -10
readlink_main                                        123     113     -10
rdate_main                                           246     236     -10
pwdx_main                                            189     179     -10
pstree_main                                          317     307     -10
pscan_main                                           663     653     -10
popmaildir_main                                      818     808     -10
pmap_main                                             80      70     -10
nc_main                                             1042    1032     -10
mv_main                                              558     548     -10
mountpoint_main                                      477     467     -10
mount_main                                          1264    1254     -10
modprobe_main                                        768     758     -10
modinfo_main                                         333     323     -10
mktemp_main                                          200     190     -10
mkswap_main                                          324     314     -10
mkfs_vfat_main                                      1489    1479     -10
microcom_main                                        715     705     -10
md5_sha1_sum_main                                    521     511     -10
man_main                                             867     857     -10
makedevs_main                                       1052    1042     -10
ls_main                                              563     553     -10
losetup_main                                         432     422     -10
loadfont_main                                         89      79     -10
ln_main                                              524     514     -10
link_main                                             75      65     -10
ipcalc_main                                          544     534     -10
iostat_main                                         2397    2387     -10
install_main                                         768     758     -10
id_main                                              480     470     -10
i2cset_main                                         1239    1229     -10
i2cget_main                                          380     370     -10
i2cdump_main                                        1482    1472     -10
i2cdetect_main                                       682     672     -10
hwclock_main                                         406     396     -10
httpd_main                                           741     731     -10
grep_main                                            837     827     -10
getty_main                                          1559    1549     -10
fuser_main                                           297     287     -10
ftpgetput_main                                       345     335     -10
ftpd_main                                           2232    2222     -10
fstrim_main                                          251     241     -10
fsfreeze_main                                         77      67     -10
fsck_minix_main                                     2921    2911     -10
flock_main                                           314     304     -10
flashcp_main                                         740     730     -10
flash_eraseall_main                                  833     823     -10
fdformat_main                                        532     522     -10
expand_main                                          680     670     -10
eject_main                                           335     325     -10
dumpleases_main                                      630     620     -10
du_main                                              314     304     -10
dos2unix_main                                        441     431     -10
diff_main                                           1350    1340     -10
df_main                                             1064    1054     -10
date_main                                           1095    1085     -10
cut_main                                             961     951     -10
cryptpw_main                                         228     218     -10
crontab_main                                         575     565     -10
crond_main                                          1149    1139     -10
cp_main                                              370     360     -10
common_traceroute_main                              3834    3824     -10
common_ping_main                                    1767    1757     -10
comm_main                                            239     229     -10
cmp_main                                             655     645     -10
chrt_main                                            379     369     -10
chpst_main                                           704     694     -10
chpasswd_main                                        308     298     -10
chown_main                                           171     161     -10
chmod_main                                           158     148     -10
cat_main                                             428     418     -10
bzip2_main                                           120     110     -10
blkdiscard_main                                      264     254     -10
base64_main                                          221     211     -10
arping_main                                         1665    1655     -10
ar_main                                              556     546     -10
adjtimex_main                                        406     396     -10
adduser_main                                         882     872     -10
addgroup_main                                        411     401     -10
acpid_main                                          1198    1188     -10
optstring                                             11       -     -11
opt_string                                            18       -     -18
OPT_STR                                               25       -     -25
ubi_tools_main                                      1288    1258     -30
ls_options                                            31       -     -31
------------------------------------------------------------------------------
(add/remove: 0/6 grow/shrink: 3/129 up/down: 86/-1383)      Total: -1297 bytes
   text	   data	    bss	    dec	    hex	filename
 915428	    485	   6876	 922789	  e14a5	busybox_old
 914629	    485	   6872	 921986	  e1182	busybox_unstripped
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2017-08-08 21:55:02 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						72089cf6b4 
					 
					
						
						
							
							config: deindent all help texts  
						
						 
						
						... 
						
						
						
						Those two spaces after tab have no effect, and always a nuisance when editing.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2017-07-21 09:50:55 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						4eed2c6c50 
					 
					
						
						
							
							Update menuconfig items with approximate applet sizes  
						
						 
						
						... 
						
						
						
						Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2017-07-18 22:01:24 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						af3f420116 
					 
					
						
						
							
							Convert all coreutils/* applets to "new style" applet definitions  
						
						 
						
						... 
						
						
						
						Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2016-11-23 14:46:56 +01:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Richard Genoud 
							
						 
					 
					
						
						
							
						
						d683c5c2f1 
					 
					
						
						
							
							tr: support octal ranges  
						
						 
						
						... 
						
						
						
						now, we can do printf "a\tb\tcdef\n" | ./busybox tr -d "\1-\14b-e"
af
and bonus, we save some bytes.
function                                             old     new   delta
expand                                               718     699     -19
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-19)             Total: -19
bytes
Signed-off-by: Richard Genoud <richard.genoud@gmail.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2015-10-26 17:18:07 +01:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						66426760be 
					 
					
						
						
							
							*: remove "Options:" string from help texts  
						
						 
						
						... 
						
						
						
						function                                             old     new   delta
packed_usage                                       28706   28623     -83
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2011-06-05 03:58:28 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Pere Orga 
							
						 
					 
					
						
						
							
						
						34425389e0 
					 
					
						
						
							
							move help text from include/usage.src.h to coreutils/*.c  
						
						 
						
						... 
						
						
						
						Signed-off-by: Pere Orga <gotrunks@gmail.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2011-03-31 14:43:25 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Alexey Soloviev 
							
						 
					 
					
						
						
							
						
						41478ade4f 
					 
					
						
						
							
							tr: free allocated memory in tr if CLEANUP enabled  
						
						 
						
						... 
						
						
						
						Signed-off-by: Alexey Soloviev <EXT-Alexey.Soloviev@nokia.com >
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2011-03-06 18:21:07 +01:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						fb132e4737 
					 
					
						
						
							
							whitespace cleanup  
						
						 
						
						... 
						
						
						
						Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com > 
						
						
					 
					
						2010-10-29 11:46:52 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						0ef64bdb40 
					 
					
						
						
							
							*: make GNU licensing statement forms more regular  
						
						 
						
						... 
						
						
						
						This change retains "or later" state! No licensing _changes_ here,
only form is adjusted (article, space between "GPL" and "v2" and so on).
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2010-08-16 20:14:46 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						2f32bf8be6 
					 
					
						
						
							
							remove defconfig. Now "make defconfig" simply uses defaults from Config.in  
						
						 
						
						... 
						
						
						
						Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2010-06-06 04:14:28 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						729ce47360 
					 
					
						
						
							
							tr: add forgotten //config: prefixes  
						
						 
						
						... 
						
						
						
						Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2010-06-05 21:29:41 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						e4070cb0d7 
					 
					
						
						
							
							partially migrate coreutils to Config.src and Kbuild.src  
						
						 
						
						... 
						
						
						
						Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2010-06-04 19:59:49 +02:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denys Vlasenko 
							
						 
					 
					
						
						
							
						
						8684cbb5cc 
					 
					
						
						
							
							libbb: robustify isXXXX(). +39 bytes  
						
						 
						
						... 
						
						
						
						Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com > 
						
						
					 
					
						2009-11-18 11:34:43 +01:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						9210a36495 
					 
					
						
						
							
							tr: support -C as synonym to -c  
						
						 
						
						
						
						
					 
					
						2009-03-15 16:41:55 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						491d6e3b56 
					 
					
						
						
							
							tr: fix overflow in expand and complement, fix stop after [:class:],  
						
						 
						
						... 
						
						
						
						fix order of [:xdigit:], make tr require one param at least.
function                                             old     new   delta
expand                                              1743    1849    +106
tr_main                                              463     518     +55
complement                                            72      75      +3
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/0 up/down: 164/0)             Total: 164 bytes 
						
						
					 
					
						2009-03-02 12:05:57 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						1bfcc8b08e 
					 
					
						
						
							
							tr: support [:xdigit:], fix handling of ranges and [x]'s.  
						
						 
						
						... 
						
						
						
						add testsuite entry for each of 3 bugs fixed.
function                                             old     new   delta      
static.classes                                        73      82      +9      
expand                                              1738    1743      +5      
complement                                            74      72      -2      
tr_main                                              472     463      -9      
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/2 up/down: 14/-11)              Total: 3 bytes 
						
						
					 
					
						2009-03-01 04:50:18 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						20be63fe71 
					 
					
						
						
							
							tr: fix yet another access past the end of a string (bug 4374)  
						
						 
						
						
						
						
					 
					
						2008-07-30 22:58:18 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						043d15da31 
					 
					
						
						
							
							tr: fix "tr [=" case. Closes bug 4374.  
						
						 
						
						... 
						
						
						
						function                                             old     new   delta
expand                                              1701    1738     +37
tr_main                                              472     474      +2 
						
						
					 
					
						2008-07-28 23:49:42 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						5e40070d38 
					 
					
						
						
							
							tr: fix "access past the end of a string" bug 4354  
						
						 
						
						
						
						
					 
					
						2008-07-26 19:34:00 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						a60f84ebf0 
					 
					
						
						
							
							*: rename ATTRIBUTE_XXX to just XXX.  
						
						 
						
						
						
						
					 
					
						2008-07-05 09:18:54 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						77ad97f199 
					 
					
						
						
							
							more -Wall warning fixes from Cristian Ionescu-Idbohrn.  
						
						 
						
						... 
						
						
						
						This time it resulted in small code changes:
function                                             old     new   delta
nexpr                                                820     828      +8
tail_main                                           1200    1202      +2
wrapf                                                166     167      +1
parse_mount_options                                  227     209     -18
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/1 up/down: 11/-18)             Total: -7 bytes 
						
						
					 
					
						2008-05-13 02:27:31 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						023dc6798e 
					 
					
						
						
							
							fix warnings about pointer signedness  
						
						 
						
						
						
						
					 
					
						2008-05-09 18:07:15 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						68404f13d4 
					 
					
						
						
							
							*: add -Wunused-parameter; fix resulting breakage  
						
						 
						
						... 
						
						
						
						function                                             old     new   delta
procps_scan                                         1265    1298     +33
aliascmd                                             278     283      +5
parse_file_cmd                                       116     120      +4
dname_enc                                            373     377      +4
setcmd                                                90      93      +3
execcmd                                               57      60      +3
count_lines                                           72      74      +2
process_command_subs                                 340     339      -1
test_main                                            409     407      -2
mknod_main                                           179     177      -2
handle_incoming_and_exit                            2653    2651      -2
argstr                                              1312    1310      -2
shiftcmd                                             131     128      -3
exitcmd                                               46      43      -3
dotcmd                                               297     294      -3
breakcmd                                              86      83      -3
evalpipe                                             353     349      -4
evalcommand                                         1180    1176      -4
evalcmd                                              109     105      -4
send_tree                                            374     369      -5
mkfifo_main                                           82      77      -5
evalsubshell                                         152     147      -5
typecmd                                               75      69      -6
letcmd                                                61      55      -6
add_cmd                                             1190    1183      -7
main                                                 891     883      -8
ash_main                                            1415    1407      -8
parse_stream                                        1377    1367     -10
alloc_procps_scan                                     55       -     -55
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 7/21 up/down: 54/-148)          Total: -94 bytes
   text    data     bss     dec     hex filename
 797195     658    7428  805281   c49a1 busybox_old
 797101     658    7428  805187   c4943 busybox_unstripped 
						
						
					 
					
						2008-03-17 09:00:54 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						f7be20e70c 
					 
					
						
						
							
							nameif: extended matching (Nico Erfurth <masta@perlgolf.de>)  
						
						 
						
						... 
						
						
						
						*: whitespace fixes
function                                             old     new   delta
prepend_new_eth_table                                  -     304    +304
nameif_main                                          620     684     +64
cc_macaddr                                            51       -     -51
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 1/0 up/down: 368/-51)           Total: 317 bytes 
						
						
					 
					
						2007-12-24 14:09:19 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						8d0a734d91 
					 
					
						
						
							
							tr: more of code shrink (getopt32-ification)  
						
						 
						
						... 
						
						
						
						runtest: cleanup. Method of getting $applets was truly bizarre
function                                             old     new   delta
tr_main                                              655     527    -128 
						
						
					 
					
						2007-11-13 22:23:57 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						3d461676a9 
					 
					
						
						
							
							tr: better comments, small code shrink  
						
						 
						
						... 
						
						
						
						function                                             old     new   delta
expand                                              2232    2230      -2
tr_main                                              677     655     -22 
						
						
					 
					
						2007-11-13 22:22:29 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						a89d50fb9a 
					 
					
						
						
							
							tr: properly detect read errors (Fernando Silveira <fsilveira@gmail.com>)  
						
						 
						
						... 
						
						
						
						readprofile: use xwrite
function                                             old     new   delta
tr_main                                              679     677      -2
readprofile_main                                    1964    1944     -20 
						
						
					 
					
						2007-11-13 17:51:40 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						9b49a5ed85 
					 
					
						
						
							
							add -fvisibility=hidden to CC flags, mark XXX_main functions  
						
						 
						
						... 
						
						
						
						EXTERNALLY_VISIBLE. 5% size reduction of libbusybox.so 
						
						
					 
					
						2007-10-11 10:05:36 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						6ca409e0e4 
					 
					
						
						
							
							trylink: produce even more info about final link stage  
						
						 
						
						... 
						
						
						
						trylink: explain how to modify link and drastically decrease amount
  of padding (unfortunately, needs hand editing ATM).
*: add ALIGN1 / ALIGN2 to global strings and arrays of bytes and shorts
size saving: 0.5k 
						
						
					 
					
						2007-08-12 20:58:27 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						990d0f63ee 
					 
					
						
						
							
							Replace index_in_[sub]str_array with index_in_[sub]strings,  
						
						 
						
						... 
						
						
						
						which scans thru "abc\0def\0123\0\0" type strings. Saves 250 bytes.
   text    data     bss     dec     hex filename
 781266    1328   11844  794438   c1f46 busybox_old
 781010    1328   11844  794182   c1e46 busybox_unstripped 
						
						
					 
					
						2007-07-24 15:54:42 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						74324c8666 
					 
					
						
						
							
							Audit bb_common_bufsiz usage, add script which looks for misuse.  
						
						 
						
						... 
						
						
						
						tr: stop using globals needlessly.
code: -103 bytes 
						
						
					 
					
						2007-06-04 10:16:52 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						b6adbf1be2 
					 
					
						
						
							
							usage.c: remove reference to busybox.h  
						
						 
						
						... 
						
						
						
						*: s/include "busybox.h"/include "libbb.h" 
						
						
					 
					
						2007-05-26 19:00:18 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						240a1cfbbe 
					 
					
						
						
							
							add some missed statics on constant objects.  
						
						 
						
						... 
						
						
						
						fix few #ifndef ENABLE_xxx
# size busybox_old busybox_unstripped
   text    data     bss     dec     hex filename
 677152    2920   18208  698280   aa7a8 busybox_old
 676420    2920   18208  697548   aa4cc busybox_unstripped 
						
						
					 
					
						2007-04-08 16:07:02 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Bernhard Reutner-Fischer 
							
						 
					 
					
						
						
							
						
						7b881c7168 
					 
					
						
						
							
							- fix compilation if FEATURE_TR_CLASSES is off. Sorry for that..  
						
						 
						
						
						
						
					 
					
						2007-03-30 18:26:46 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Bernhard Reutner-Fischer 
							
						 
					 
					
						
						
							
						
						eceecea568 
					 
					
						
						
							
							- fix bug where we did not reject invalid classes like '[[:alpha'  
						
						 
						
						... 
						
						
						
						- debloat while at it:
   text    data     bss     dec     hex filename
   1554       0      19    1573     625 tr.o.oorig
   1357       0      16    1373     55d tr.o 
						
						
					 
					
						2007-03-30 14:43:27 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						06af216528 
					 
					
						
						
							
							suppress warnings about easch <applet>_main() having  
						
						 
						
						... 
						
						
						
						no preceding prototype 
						
						
					 
					
						2007-02-03 17:28:39 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						079f8afa0a 
					 
					
						
						
							
							style cleanup: return(a) -> return a, part 1  
						
						 
						
						
						
						
					 
					
						2006-11-27 16:49:31 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Denis Vlasenko 
							
						 
					 
					
						
						
							
						
						9cac521f07 
					 
					
						
						
							
							using [xa]sprintf for string concatenation is neat and saves  
						
						 
						
						... 
						
						
						
						~100 bytes according to bloatcheck. Also this fixes bug in rpm 
						
						
					 
					
						2006-09-09 12:24:19 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								"Robert P. J. Day" 
							
						 
					 
					
						
						
							
						
						68229837ff 
					 
					
						
						
							
							Remove all usage of the "register" storage class specifier.  
						
						 
						
						
						
						
					 
					
						2006-07-01 13:08:46 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Rob Landley 
							
						 
					 
					
						
						
							
						
						ab58d5cf8a 
					 
					
						
						
							
							Make warnings go away.  
						
						 
						
						
						
						
					 
					
						2006-06-30 19:04:09 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Rob Landley 
							
						 
					 
					
						
						
							
						
						cd545287c5 
					 
					
						
						
							
							Fix bug 744 by moving the flushing logic into the exhausted read buffer test.  
						
						 
						
						... 
						
						
						
						(Also some other minor cleanups while I was there, shouldn't affect the
resulting binary.) 
						
						
					 
					
						2006-06-30 16:35:40 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Rob Landley 
							
						 
					 
					
						
						
							
						
						998dbee6d9 
					 
					
						
						
							
							Patch from Jean Wolter:  
						
						 
						
						... 
						
						
						
						it looks like the introduced support for character classes and
equivalence classes is not correct. The attached patch tries to fix
some symptoms and tries to make tr behave like gnu tr for the added
test cases. The patch
 - removes if clauses with side effects
 - fixes handling of buffer pointer (strcat added characters to the
   buffer without increasing the buffer pointer)
 - re-arranges character classes to match ASCII order
regards,
Jean 
						
						
					 
					
						2006-04-19 22:22:06 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Rob Landley 
							
						 
					 
					
						
						
							
						
						998f449375 
					 
					
						
						
							
							We use -funsigned-char now, so having a separate RESERVE_CONFIG_UBUFFER is  
						
						 
						
						... 
						
						
						
						a bit silly.  Wean of that where it currently makes no difference... 
						
						
					 
					
						2006-04-10 16:40:47 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Rob Landley 
							
						 
					 
					
						
						
							
						
						dfba741457 
					 
					
						
						
							
							Robert P. Day removed 8 gazillion occurrences of "extern" on function  
						
						 
						
						... 
						
						
						
						definitions.  (That should only be on prototypes.) 
						
						
					 
					
						2006-03-06 20:47:33 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Eric Andersen 
							
						 
					 
					
						
						
							
						
						5e678873f9 
					 
					
						
						
							
							clean up yet more annoying signed/unsigned mismatches and fixup  
						
						 
						
						... 
						
						
						
						yet more incorrect types 
						
						
					 
					
						2006-01-30 19:48:23 +00:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								"Vladimir N. Oleynik" 
							
						 
					 
					
						
						
							
						
						6f347ef9dc 
					 
					
						
						
							
							common BUFSIZ BSS buffer, small reduce code, data and bss  
						
						 
						
						
						
						
					 
					
						2005-10-15 10:23:55 +00:00