102 Commits

Author	SHA1	Message	Date
Denis Vlasenko	7886275c98	top: make it work again on 2.4 kernels (closes bug 125)	2009-03-03 11:55:31 +00:00
Denis Vlasenko	db12d1d733	Fix forgotten license comments	2008-12-07 00:52:58 +00:00
Denis Vlasenko	61befda93b	ash,hush: add TODO for rare build failure ... *: remove some redundant includes	2008-11-25 01:36:03 +00:00
Denis Vlasenko	202ac504e1	*: code shrink by adding a wrapper around very common tcsetattr(0, TCSANOW, xx) op ... function old new delta tcsetattr_stdin_TCSANOW - 14 +14 set_sane_term 116 113 -3 top_main 1277 1273 -4 make_new_session 421 415 -6 rawmode 133 126 -7 reset_term 18 10 -8 die 43 35 -8 cookmode 62 54 -8 vlock_main 425 415 -10 read_line_input 3165 3155 -10 bb_askpass 357 347 -10 fsck_minix_main 3079 3065 -14 getty_main 2375 2332 -43 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/12 up/down: 14/-131) Total: -117 bytes	2008-11-05 13:20:58 +00:00
Denis Vlasenko	c8842213f5	top: fix "top -d 1" (bug 5144)	2008-09-25 11:42:10 +00:00
Denis Vlasenko	35840ab204	top: fixes to prev commit: '1' should toggle SMP view too; ... "cpu ..." line should be parsed unconditionally top: do not truncate loadavg string. More info -> better	2008-09-25 11:11:37 +00:00
Denis Vlasenko	17e7f04c8d	top: optional SMP support by Vineet Gupta (vineetg76 AT gmail.com)	2008-09-25 10:48:06 +00:00
Denis Vlasenko	1c45a505eb	libbb: fix mishandling of "all argv are opts" in getopt32() ... function old new delta top_main 1100 1095 -5 getopt32 1398 1361 -37 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-42) Total: -42 bytes	2008-08-20 00:12:22 +00:00
Denis Vlasenko	27842288b3	libbb: make xrealloc_vector zero out the realloc'ed tail ... function old new delta xrealloc_vector_helper 51 76 +25 man_main 712 705 -7 act 250 234 -16 create_list 91 70 -21 getopt_main 695 664 -31 load_dep_bb 281 248 -33 fileAction 744 709 -35 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/6 up/down: 25/-143) Total: -118 bytes	2008-08-04 13:20:36 +00:00
Denis Vlasenko	5415c856ea	libbb: [x]fopen_for_{read,write} introduced and used. ... (by Valdimir) function old new delta config_open2 - 41 +41 config_read 507 542 +35 find_pair 169 187 +18 fopen_for_write - 14 +14 fopen_for_read - 14 +14 find_main 406 418 +12 xfopen_for_write - 10 +10 xfopen_for_read - 10 +10 popstring 134 140 +6 parse_inittab 396 401 +5 next_token 923 928 +5 pack_gzip 1659 1661 +2 bb__parsespent 117 119 +2 fallbackSort 1719 1717 -2 evalvar 1376 1374 -2 qrealloc 36 33 -3 ... ... ... ... singlemount 4579 4569 -10 process_stdin 443 433 -10 patch_main 1111 1101 -10 ifupdown_main 2175 2165 -10 file_action_grep 90 80 -10 uuidcache_init 649 637 -12 hush_main 797 785 -12 read_config 230 217 -13 dpkg_main 3835 3820 -15 read_line_input 3134 3110 -24 sysctl_main 232 203 -29 config_open 40 10 -30 WARN_BAD_LINE 44 - -44 login_main 1714 1575 -139 ------------------------------------------------------------------------------ (add/remove: 5/1 grow/shrink: 8/74 up/down: 174/-737) Total: -563 bytes	2008-07-21 23:05:26 +00:00
Denis Vlasenko	deeed59de0	libbb: introduce and use xrealloc_vector ... function old new delta xrealloc_vector_helper - 51 +51 create_list 84 99 +15 getopt_main 690 695 +5 passwd_main 1049 1053 +4 get_cached 85 89 +4 msh_main 1377 1380 +3 add_match 42 41 -1 read_lines 720 718 -2 grave 1068 1066 -2 fill_match_lines 143 141 -2 add_to_dirlist 67 65 -2 add_input_file 49 47 -2 act 252 250 -2 fsck_main 2252 2246 -6 man_main 765 757 -8 bb_internal_initgroups 228 220 -8 cut_main 1052 1041 -11 add_edge_to_node 55 43 -12 dpkg_main 3851 3835 -16 ifupdown_main 2202 2178 -24 sort_main 838 812 -26 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 5/15 up/down: 82/-124) Total: -42 bytes	2008-07-08 05:14:36 +00:00
Denis Vlasenko	a60f84ebf0	*: rename ATTRIBUTE_XXX to just XXX.	2008-07-05 09:18:54 +00:00
Denis Vlasenko	7049ff8696	whitespace fixes. no code changes	2008-06-25 09:53:17 +00:00
Bernhard Reutner-Fischer	5e25ddb7d3	- use STD*_FILENO some more. No object-code changes	2008-05-19 09:48:17 +00:00
Bernhard Reutner-Fischer	636a1f85e8	- use EXIT_{SUCCESS,FAILURE}. No object-code changes	2008-05-19 09:29:47 +00:00
Denis Vlasenko	5599502a55	more -Wall warning fixes. -Wall is enabled now.	2008-05-18 22:28:26 +00:00
Denis Vlasenko	6b06cb80be	more of -Wall fixes from Cristian Ionescu-Idbohrn. ... Some are fixing real bugs. function old new delta syslogd_main 938 958 +20 get_signum 136 143 +7 obj_load 777 782 +5 recv_from_to 210 214 +4 get_next_block 1795 1799 +4 display_topmem_process_list 1117 1121 +4 logread_main 484 487 +3 buffer_fill_and_print 73 76 +3 kill_main 687 689 +2 ll_remember_index 240 241 +1 do_stats 452 453 +1 if_readconf 166 165 -1 display_process_list 1192 1191 -1 run_applet_and_exit 507 505 -2 print_signames 33 31 -2 parse_one_line 1092 1090 -2 find_out_spec 57 55 -2 add_ksymoops_symbols 421 419 -2 ash_main 1407 1402 -5 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 11/8 up/down: 54/-17) Total: 37 bytes	2008-05-15 21:30:45 +00:00
Denis Vlasenko	e96dcb4dcf	top: fix build failure	2008-04-17 18:04:38 +00:00
Paul Fox	275b929e01	let top build without TERMIOS enabled	2008-03-20 16:05:02 +00:00
Denis Vlasenko	cf7cf62204	*: s/BB_SIGS_FATAL/BB_FATAL_SIGS/ (latter proved easier to remember) ... top: fix "top </dev/null" case (by Cristian Ionescu-Idbohrn)	2008-03-19 19:38:46 +00:00
Denis Vlasenko	68404f13d4	*: add -Wunused-parameter; fix resulting breakage ... function old new delta procps_scan 1265 1298 +33 aliascmd 278 283 +5 parse_file_cmd 116 120 +4 dname_enc 373 377 +4 setcmd 90 93 +3 execcmd 57 60 +3 count_lines 72 74 +2 process_command_subs 340 339 -1 test_main 409 407 -2 mknod_main 179 177 -2 handle_incoming_and_exit 2653 2651 -2 argstr 1312 1310 -2 shiftcmd 131 128 -3 exitcmd 46 43 -3 dotcmd 297 294 -3 breakcmd 86 83 -3 evalpipe 353 349 -4 evalcommand 1180 1176 -4 evalcmd 109 105 -4 send_tree 374 369 -5 mkfifo_main 82 77 -5 evalsubshell 152 147 -5 typecmd 75 69 -6 letcmd 61 55 -6 add_cmd 1190 1183 -7 main 891 883 -8 ash_main 1415 1407 -8 parse_stream 1377 1367 -10 alloc_procps_scan 55 - -55 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 7/21 up/down: 54/-148) Total: -94 bytes text data bss dec hex filename 797195 658 7428 805281 c49a1 busybox_old 797101 658 7428 805187 c4943 busybox_unstripped	2008-03-17 09:00:54 +00:00
Denis Vlasenko	25591c322c	libbb: introduce bb_signals and bb_signals_recursive, ... which sets same handler for many signals. sig_catch is nuked (bb_signals_recursive is more descriptive name). *: use them as appropriate. function old new delta bb_signals_recursive - 95 +95 bb_signals - 52 +52 run_command 258 273 +15 svlogd_main 1368 1377 +9 runsv_main 1746 1752 +6 runsvdir_main 1643 1646 +3 UNSPEC_print 64 66 +2 time_main 1128 1127 -1 ... resize_main 246 210 -36 sig_catch 63 - -63 set_fatal_sighandler 85 14 -71 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 5/24 up/down: 182/-548) Total: -366 bytes	2008-02-16 22:58:56 +00:00
Bernhard Reutner-Fischer	a985d306a1	- spelling fixes	2008-02-11 11:44:38 +00:00
Denis Vlasenko	04e11c9209	getpot: add support for "a+" specifier for nonnegative int parameters. ... By Vladimir Dronnikov <dronnikov at gmail.com>. fdisk and top are converted as an example. function old new delta getopt32 1340 1370 +30 top_main 1137 1120 -17 fdisk_main 3033 2949 -84 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/2 up/down: 30/-101) Total: -71 bytes	2008-02-10 19:44:20 +00:00
Bernhard Reutner-Fischer	8c69afd992	- be C99 friendly. Anonymous unions are a GNU extension. This change is ... size-neutral WRT -std=gnu99 and fixes several compilation errors for strict C99 mode.	2008-01-29 10:33:34 +00:00
Denis Vlasenko	56ea65ca5f	ps: fix overflow in USER and VSZ columns ... function old new delta smart_ulltoa4 - 280 +280 smart_ulltoa5 283 408 +125 ulltoa6_and_space - 25 +25 scale 28 38 +10 bbunpack 358 366 +8 ps_main 259 261 +2 glob3 35 37 +2 fill_bounds 172 174 +2 process_stdin 456 446 -10 smart_ulltoa6 406 - -406 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 6/1 up/down: 454/-416) Total: 38 bytes	2008-01-06 03:26:53 +00:00
Denis Vlasenko	fcfb5c04bb	defconfig: update ... appletli.c: add vda's (C) top: fixlet for incorrect display of "0" Makefile: reduce stack size from 20k to 16k	2007-12-24 12:16:24 +00:00
Denis Vlasenko	5576136563	fixes revealed by randomconfig run	2007-10-16 22:53:05 +00:00
Denis Vlasenko	9b49a5ed85	add -fvisibility=hidden to CC flags, mark XXX_main functions ... EXTERNALLY_VISIBLE. 5% size reduction of libbusybox.so	2007-10-11 10:05:36 +00:00
Denis Vlasenko	4daad9004d	introduce bb_putchar(). saves ~1800 on uclibc (less on glibc).	2007-09-27 10:20:47 +00:00
Denis Vlasenko	5d61e71c3a	introduce safe_poll (fixes a problem in top) ... function old new delta safe_poll - 77 +77 svlogd_main 1470 1466 -4 zcip_main 1530 1524 -6 forkexec 1345 1338 -7 decode_format_string 795 788 -7 collect_blk 474 467 -7 buffer_pread 540 532 -8 tftp 1182 1172 -10 microcom_main 763 749 -14 arpping 441 424 -17 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/9 up/down: 77/-80) Total: -3 bytes text data bss dec hex filename 770162 1034 10404 781600 bed20 busybox_old 770158 1034 10404 781596 bed1c busybox_unstripped	2007-09-27 10:09:59 +00:00
Denis Vlasenko	4d7605af86	top: small fix for command line wrapping	2007-09-08 17:42:00 +00:00
Denis Vlasenko	4c1d88daff	top: get rid of on-stack variable buffers, use permanent one. ... code shrank with and without TOPMEM: top_main 828 844 +16 display_process_list 1525 1473 -52 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/1 up/down: 16/-52) Total: -36 bytes top_main 1150 1171 +21 display_topmem_process_list 1150 1167 +17 display_process_list 1525 1473 -52 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 38/-52) Total: -14 bytes	2007-09-08 17:34:05 +00:00
Denis Vlasenko	e7c1ad1540	top: add sizeof(G) check; fix style	2007-09-08 17:21:01 +00:00
Denis Vlasenko	ff6e8e2974	top: TOPMEM feature - 's(how sizes)' command. +2.5k when enabled, ... +80 bytes when disabled (mainly because of text wrapping fixes in display_process_list).	2007-09-08 16:51:19 +00:00
Denis Vlasenko	05241802a7	top: another readability fix	2007-08-29 18:34:26 +00:00
Denis Vlasenko	8bdba4d011	top: don't wait before final bailout (try top -b -n1). ... top: make code a bit more readable.	2007-08-29 18:18:08 +00:00
Denis Vlasenko	b308d81e92	top: use poll instead of select for waiting on one descriptor ... smart_ulltoa5: make it more cryptic. -50 bytes. function old new delta passwd_main 1095 1103 +8 getNum 557 565 +8 buffer_fill_and_print 73 76 +3 udhcpc_main 2393 2395 +2 mkfs_minix_main 3071 3070 -1 dname_enc 377 373 -4 expmeta 480 472 -8 smart_ulltoa5 334 283 -51 top_main 911 815 -96 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/5 up/down: 21/-160) Total: -139 bytes text data bss dec hex filename 770872 1063 10788 782723 bf183 busybox_old 770732 1063 10788 782583 bf0f7 busybox_unstripped	2007-08-28 19:35:34 +00:00
Denis Vlasenko	6ee023cf62	*: compile fixes for 64-bit build	2007-08-23 10:52:52 +00:00
Denis Vlasenko	fe7cd642b0	don't pass argc in getopt32, it's superfluous ... (add/remove: 0/0 grow/shrink: 12/131 up/down: 91/-727) Total: -636 bytes text data bss dec hex filename 773469 1058 11092 785619 bfcd3 busybox_old 772644 1058 11092 784794 bf99a busybox_unstripped	2007-08-18 15:32:12 +00:00
Denis Vlasenko	856be770a6	assorted fixes for breakage found by randomconfig	2007-08-17 08:29:48 +00:00
Denis Vlasenko	110967a6f7	top: nested function allows us to reuse some code ... (not everyone likes them - but code does get smaller). display_generic - 761 +761 static.fmt_100percent_8 - 111 +111 fmt_100percent_8 101 - -101 display_status 1489 581 -908 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 0/1 up/down: 872/-1009) Total: -137 bytes text data bss dec hex filename 677020 3344 13936 694300 a981c busybox_old 676876 3344 13936 694156 a978c busybox_unstripped	2007-07-15 19:27:48 +00:00
Denis Vlasenko	24c5fbaf42	top: make "100%" case less ugly, and shrink code while at it ... fmt_100percent_8 - 101 +101 .rodata 129185 129153 -32 display_status 1726 1489 -237 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/2 up/down: 101/-269) Total: -168 bytes text data bss dec hex filename 677180 3344 13936 694460 a98bc busybox_old 677020 3344 13936 694300 a981c busybox_unstripped	2007-07-15 19:25:01 +00:00
Denis Vlasenko	c1166c3a8c	top: simpler loadavg processing ... display_status 1787 1726 -61 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-61) Total: -61 bytes text data bss dec hex filename 677244 3344 13936 694524 a98fc busybox_old 677180 3344 13936 694460 a98bc busybox_unstripped	2007-07-15 19:23:38 +00:00
Denis Vlasenko	9109fbeaa1	top: truncate usernames to 8 chars	2007-07-15 17:07:58 +00:00
Denis Vlasenko	98ebab8b76	top,ps: improve /proc/PID/cmdinfo reading code ... function old new delta display_status - 1231 +1231 read_cmdline - 101 +101 parse_conf 1284 1303 +19 arith 2033 2042 +9 collect_blk 467 474 +7 fsck_main 1909 1911 +2 dhcprelay_main 1125 1122 -3 singlemount 4555 4547 -8 read_close 50 36 -14 get_lcm 123 105 -18 ed_main 3111 3084 -27 func_args 73 28 -45 procps_scan 732 658 -74 top_main 2187 899 -1288 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 4/8 up/down: 1369/-1477) Total: -108 bytes text data bss dec hex filename 676048 2744 13968 692760 a9218 busybox_old 675940 2744 13968 692652 a91ac busybox_unstripped	2007-06-30 14:47:41 +00:00
Denis Vlasenko	f7d07b1723	killall, pidof: use argv0 for process matching too ... top: show cmdline, not comm field (fixes problems with re-execed applets showing as processes with name "exe", and not being found by pidof/killall by applet name) function old new delta find_pid_by_name 98 156 +58 procps_scan 692 732 +40 top_main 2724 2762 +38 find_pair 164 180 +16 collect_int 114 123 +9 cmp_main 547 555 +8 collect_fork 112 119 +7 collect_ctx 112 119 +7 read_package_field 253 257 +4 passwd_main 1983 1985 +2 process_stdin 435 433 -2 xstrtoul_range_sfx 229 226 -3 get_next_block 1852 1849 -3 arith 2042 2033 -9 sv_main 1236 1226 -10 singlemount 4690 4672 -18 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 10/6 up/down: 189/-45) Total: 144 bytes text data bss dec hex filename 734789 3028 14400 752217 b7a59 busybox_old 734933 3028 14400 752361 b7ae9 busybox_unstripped	2007-06-30 08:03:26 +00:00
Denis Vlasenko	745119605e	top: on user suggestion make percentile calculations configurable. -56 bytes when off. +600 bytes when on ... top: reorder columns, so that [P]PIDs are together and VSZ/%MEM are together. Makes more sense	2007-06-11 16:31:55 +00:00
Denis Vlasenko	b1e5addfed	top: improve global CPU percentage (smaller & faster code)	2007-06-10 18:04:54 +00:00
Denis Vlasenko	5a65447e30	top: add config option and code for global CPU % display	2007-06-10 17:11:59 +00:00