Denis Vlasenko
893988182a
fdisk: comment out unused function
2008-01-25 20:18:46 +00:00
Denis Vlasenko
a5549c9617
fdisk: fix a case where break was reached only for DOS labels
2008-01-24 22:49:15 +00:00
Mike Frysinger
46ef46aefb
as reported by George Boudreau, make sure we properly skip blank lines
2008-01-23 18:48:26 +00:00
Denis Vlasenko
c03e872112
save a bit of code with *strchrnul = '\0' trick
...
function old new delta
nextline 59 55 -4
include_conf 902 898 -4
read_config 414 406 -8
fsck_main 1880 1869 -11
2007-12-26 20:56:55 +00:00
Denis Vlasenko
f7be20e70c
nameif: extended matching (Nico Erfurth <masta@perlgolf.de>)
...
*: whitespace fixes
function old new delta
prepend_new_eth_table - 304 +304
nameif_main 620 684 +64
cc_macaddr 51 - -51
------------------------------------------------------------------------------
(add/remove: 1/1 grow/shrink: 1/0 up/down: 368/-51) Total: 317 bytes
2007-12-24 14:09:19 +00:00
Denis Vlasenko
ef36c04ccf
umount: fix fallout from stack reduction change
2007-12-24 12:11:57 +00:00
Denis Vlasenko
94e3365b8f
perror_nomsg: don't print extra colon
...
losetup: print name of loop device in error messages
2007-12-22 15:44:23 +00:00
Denis Vlasenko
ee87ebf381
fix buglets found by randomconfig
2007-12-21 22:18:16 +00:00
Denis Vlasenko
f77f369ce8
fdisk: reduce global data/bss usage. 8k data+bss build is achievable soon ;)
...
(add/remove: 0/13 grow/shrink: 6/19 up/down: 74/-492) Total: -418 bytes
text data bss dec hex filename
778330 860 7408 786598 c00a6 busybox_old
777970 840 7376 786186 bff0a busybox_unstripped
2007-12-16 17:22:33 +00:00
Denis Vlasenko
7ab3699b58
mkfs.minix: add testsuite; disable code which makes images variable
2007-12-02 08:55:34 +00:00
Denis Vlasenko
ab801874f8
attack the biggest stack users:
...
-mkfs_minix_main [busybox_unstripped]: 4288
-mkfs_minix_main [busybox_unstripped]: 4276
-grave [busybox_unstripped]: 4260
(bzip2 users too - not listed)
price we pay in code size increase:
mainSort 2458 2515 +57
grave 1005 1058 +53
sendMTFValues 2177 2195 +18
BZ2_blockSort 122 125 +3
mkfs_minix_main 3070 3022 -48
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/1 up/down: 131/-48) Total: 83 bytes
2007-12-02 08:35:37 +00:00
Denis Vlasenko
d2023283ac
fix buglets found by randomconfig
2007-11-23 23:39:01 +00:00
Mike Frysinger
c881c733bb
cleanup comments and coding style and rewrite the mdev.conf parser to use common busybox functions and call strdup() less often ... saves a ~few hundred bytes
2007-11-19 09:04:22 +00:00
Denis Vlasenko
fbe5f39f0f
hexdump: add hd alias, add -R option
2007-11-18 05:36:50 +00:00
Denis Vlasenko
7e3a5f58bc
dmesg,klogd: make code more readable
...
libbb: explain why we declare klogctl
libbb: move defs around so that order makes more sense
2007-11-16 20:18:54 +00:00
Denis Vlasenko
a89d50fb9a
tr: properly detect read errors (Fernando Silveira <fsilveira@gmail.com>)
...
readprofile: use xwrite
function old new delta
tr_main 679 677 -2
readprofile_main 1964 1944 -20
2007-11-13 17:51:40 +00:00
Denis Vlasenko
5cc6459c46
umount: stop using excessive aounts of stack. Surprisingly,
...
code shrank a lot too
function old new delta
umount_main 751 640 -111
2007-11-10 01:45:03 +00:00
Denis Vlasenko
b4f608d8e0
readlink: realpath requires PATH_MAX, bb_common_bufsiz1 can be too small
...
umount: don't actually need char[2 * PATH_MAX] for realpath
2007-11-10 01:31:19 +00:00
Denis Vlasenko
6bef3d1d22
fbset: fix buglet where we were using wrong pointer
...
readahead: stop using stdio.h
*: style fixes
2007-11-06 03:05:54 +00:00
Denis Vlasenko
f8b21d0933
swaponoff: prevent arithmetic overflow (spotted by Paul Fox <pgf@brightstareng.com>)
2007-11-05 19:33:38 +00:00
Denis Vlasenko
63430ae35a
mount: size-optimize mount_options[] and nfs_errtbl[]
...
777253 974 9676 787903 c05bf busybox_old
777209 974 9676 787859 c0593 busybox_unstripped
2007-10-29 19:18:39 +00:00
Denis Vlasenko
85ff862753
mkswap: selinux support by KaiGai Kohei <kaigai@ak.jp.nec.com>
2007-10-19 21:49:48 +00:00
Denis Vlasenko
3f5fdc7572
remove trailing whitespace
2007-10-14 04:55:59 +00:00
Denis Vlasenko
9b49a5ed85
add -fvisibility=hidden to CC flags, mark XXX_main functions
...
EXTERNALLY_VISIBLE. 5% size reduction of libbusybox.so
2007-10-11 10:05:36 +00:00
Denis Vlasenko
feb7ae7f01
printf("%s\n") -> puts()
2007-10-01 12:05:12 +00:00
Denis Vlasenko
0c97c9d437
'simple' error message functions by Loic Grenie <loic.grenie@gmail.com>.
...
263 bytes saved.
2007-10-01 11:58:38 +00:00
Denis Vlasenko
b925605441
assorted static vars removal
...
function old new delta
tcpudpsvd_main 1829 1839 +10
update_status 567 569 +2
sigterm 1 - -1
.........
dhcprelay_signal_handler 8 - -8
nfs_strerror 60 49 -11
singlemount 4579 4564 -15
static.p 16 - -16
svstatus 20 - -20
dhcprelay_xid_list 32 - -32
runsv_main 1785 1746 -39
static.buf 74 28 -46
svd 56 - -56
dhcprelay_main 1141 1080 -61
------------------------------------------------------------------------------
(add/remove: 0/20 grow/shrink: 2/10 up/down: 12/-386) Total: -374 bytes
2007-09-28 10:29:17 +00:00
Denis Vlasenko
4daad9004d
introduce bb_putchar(). saves ~1800 on uclibc (less on glibc).
2007-09-27 10:20:47 +00:00
Denis Vlasenko
1acdc89e99
style and message text fixes
2007-09-27 10:17:53 +00:00
Denis Vlasenko
7ae209c019
losetup: support -f (Loic Grenie <loic.grenie@gmail.com>)
...
function old new delta
losetup_main 238 278 +40
packed_usage 23021 23027 +6
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 2/0 up/down: 46/0) Total: 46 bytes
2007-09-26 17:54:18 +00:00
Denis Vlasenko
06b3cc2811
make fdisk compile on libc without llseek64
2007-09-23 14:05:54 +00:00
Bernhard Reutner-Fischer
73f56bb76d
- actually mv microcom.c to miscutils
2007-09-22 21:18:46 +00:00
Denis Vlasenko
23856ab8e6
move microcom to miscutils
2007-09-22 20:51:41 +00:00
Bernhard Reutner-Fischer
f588f70b91
- remove some trailing whitespace
2007-09-22 20:35:32 +00:00
Denis Vlasenko
f34e821572
microcom: add copyright/license info
2007-09-22 20:23:57 +00:00
Denis Vlasenko
707669501f
microcom: add new applet, this time for real
2007-09-21 17:42:40 +00:00
Denis Vlasenko
efd3f38f8c
microcom: new applet by Vladimir Dronnikov <dronnikov@gmail.ru>
2007-09-21 13:43:28 +00:00
Denis Vlasenko
2535f12cf2
httpd: do not clear environment
...
mount: mount helpers support (by Vladimir Dronnikov <dronnikov@gmail.ru>)
2007-09-15 13:28:30 +00:00
Denis Vlasenko
c8d4d2f11d
messages: by popular request allow PATH to be customized at build time
...
mount: smallish code shrink
2007-09-07 19:33:56 +00:00
Denis Vlasenko
fdf9060aa3
umount: support (by ignoring) -i; style fixes
2007-09-06 16:57:05 +00:00
Denis Vlasenko
f0000653e9
mount: ignore NFS bg option on NOMMU machines
2007-09-04 18:30:26 +00:00
Denis Vlasenko
fb48f6c982
mount: allow (and ignore) -i
2007-08-29 11:49:41 +00:00
Denis Vlasenko
7d8de4d55d
mount: don't close fd twice in NFS code
2007-08-28 11:23:23 +00:00
Denis Vlasenko
fe7cd642b0
don't pass argc in getopt32, it's superfluous
...
(add/remove: 0/0 grow/shrink: 12/131 up/down: 91/-727) Total: -636 bytes
text data bss dec hex filename
773469 1058 11092 785619 bfcd3 busybox_old
772644 1058 11092 784794 bf99a busybox_unstripped
2007-08-18 15:32:12 +00:00
Denis Vlasenko
a27a11bb2c
introduce and use xdup2(int, int)
...
stop checking whether setsockopt_reuseaddr(int fd) was successful (it always is)
remove second parameter (sockllen) from xmalloc_sockaddr2xxxxx functions
sockaddr2str 142 156 +14
collect_blk 467 474 +7
xdup2 28 33 +5
singlemount 4456 4454 -2
print_host 214 212 -2
nslookup_main 139 137 -2
ftpgetput_main 414 412 -2
udhcpd_main 1258 1255 -3
udhcpc_main 2405 2402 -3
traceroute_main 4125 4122 -3
nc_main 1072 1069 -3
buffer_fill_and_print 76 73 -3
xmalloc_sockaddr2hostonly_noport 18 14 -4
xmalloc_sockaddr2host_noport 18 14 -4
xmalloc_sockaddr2host 15 11 -4
xmalloc_sockaddr2dotted_noport 18 14 -4
xmalloc_sockaddr2dotted 18 14 -4
wget_main 2618 2614 -4
ping_main 393 389 -4
ip_port_str 120 115 -5
dhcprelay_main 1146 1141 -5
dnsd_main 1531 1525 -6
passwd_main 1110 1102 -8
udhcp_kernel_packet 206 197 -9
udhcp_listen_socket 154 144 -10
getty_main 2576 2566 -10
setup 655 640 -15
xmove_fd 51 34 -17
dolisten 759 742 -17
tcpudpsvd_main 1866 1836 -30
startservice 339 299 -40
2007-08-18 14:16:39 +00:00
Denis Vlasenko
856be770a6
assorted fixes for breakage found by randomconfig
2007-08-17 08:29:48 +00:00
Denis Vlasenko
033e592cbc
more: by Tristan Schmelcher <tpkschme@engmail.uwaterloo.ca>:
...
- Fixed a number of deficiencies in the line wrapping.
- Fixed a bug where the page could scroll multiple times per keypress.
- Re-read terminal dimensions after user input, in case they
resized the terminal while we were waiting.
- Added an 'R' key to print the rest of the file without prompting.
- Crudely support tabs in the line-wrapping code by converting
them to 8 spaces.
2007-08-15 20:42:52 +00:00
Denis Vlasenko
e324184c05
s/#ifdef CONFIG_/#if ENABLE_/g
2007-08-13 10:36:25 +00:00
Denis Vlasenko
6ca409e0e4
trylink: produce even more info about final link stage
...
trylink: explain how to modify link and drastically decrease amount
of padding (unfortunately, needs hand editing ATM).
*: add ALIGN1 / ALIGN2 to global strings and arrays of bytes and shorts
size saving: 0.5k
2007-08-12 20:58:27 +00:00
Denis Vlasenko
0e2c9fb4e0
mount: print errno on NFS error (again)
2007-08-03 14:16:24 +00:00
Denis Vlasenko
f868963c67
multiplier suffixes are short, store them directly in struct suffix_mult
...
function old new delta
xstrtoul_range_sfx 226 217 -9
xstrtoull_range_sfx 291 280 -11
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-20) Total: -20 bytes
text data bss dec hex filename
669128 2668 13616 685412 a7564 busybox_old
669108 2668 13616 685392 a7550 busybox_unstripped
2007-07-27 15:06:25 +00:00
Denis Vlasenko
990d0f63ee
Replace index_in_[sub]str_array with index_in_[sub]strings,
...
which scans thru "abc\0def\0123\0\0" type strings. Saves 250 bytes.
text data bss dec hex filename
781266 1328 11844 794438 c1f46 busybox_old
781010 1328 11844 794182 c1e46 busybox_unstripped
2007-07-24 15:54:42 +00:00
Denis Vlasenko
bdc88fdc68
rework long option handling. saves ~1.2k
...
function old new delta
tar_longopts - 222 +222
static.udhcpc_longopts - 192 +192
start_stop_daemon_longopts - 150 +150
getopt32 1045 1185 +140
static.wget_longopts - 111 +111
static.od_longopts - 105 +105
getopt_longopts - 96 +96
install_longopts - 67 +67
ipcalc_longopts - 63 +63
static.hwclock_longopts - 54 +54
ftpgetput_longopts - 52 +52
static.dumpleases_longopts - 32 +32
env_longopts - 31 +31
runparts_longopts - 30 +30
mv_longopts - 24 +24
mkdir_longopts - 19 +19
find_pair 164 180 +16
bb_null_long_options - 16 +16
setconsole_longopts - 10 +10
display_speed 91 98 +7
collect_blk 467 474 +7
show_color 4 1 -3
ls_main 913 904 -9
bb_default_long_options 16 - -16
ls_color_opt 32 10 -22
setconsole_long_options 32 - -32
arith 2077 2030 -47
mv_long_options 48 - -48
mkdir_long_options 48 - -48
env_long_options 48 - -48
static.options 248 184 -64
runparts_long_options 80 - -80
ftpgetput_long_options 96 - -96
static.hwclock_long_options 112 - -112
install_long_options 112 - -112
static.long_options 144 - -144
static.wget_long_options 160 - -160
longopts 160 - -160
static.arg_options 304 - -304
tar_long_options 320 - -320
long_options 384 - -384
------------------------------------------------------------------------------
(add/remove: 17/15 grow/shrink: 4/5 up/down: 1444/-2209) Total: -765 bytes
text data bss dec hex filename
782618 1328 11900 795846 c24c6 busybox_old
781354 1328 11900 794582 c1fd6 busybox_unstripped
2007-07-23 17:14:14 +00:00
Denis Vlasenko
b71c668c57
style fix (stray space before ';')
2007-07-21 15:08:09 +00:00
Denis Vlasenko
091965768d
libbb: nuke BB_GETOPT_ERROR, always die if there are mutually exclusive options
...
find_pair 164 180 +16
passwd_main 1222 1230 +8
display_speed 91 96 +5
msh_main 1335 1339 +4
qrealloc 38 36 -2
refresh 1190 1182 -8
cut_main 543 532 -11
sendCgi 1807 1794 -13
getopt32 1063 1045 -18
arith 2077 2030 -47
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/6 up/down: 33/-99) Total: -66 bytes
text data bss dec hex filename
781548 1168 11900 794616 c1ff8 busybox_old
781452 1168 11900 794520 c1f98 busybox_unstripped
2007-07-21 13:27:44 +00:00
Denis Vlasenko
fb79a2e2cf
xioctl and friends by Tito <farmatito@tiscali.it>
...
function old new delta
do_iptunnel 203 977 +774
process_dev 5328 5494 +166
ioctl_or_perror - 54 +54
ioctl_or_perror_and_die - 51 +51
ioctl_alt_func - 49 +49
bb_ioctl_or_warn - 47 +47
do_add_ioctl 102 145 +43
bb_xioctl - 39 +39
print_value_on_off - 31 +31
get_lcm 105 123 +18
arp_main 2155 2167 +12
..................
zcip_main 1576 1566 -10
setlogcons_main 92 82 -10
dumpkmap_main 263 253 -10
do_get_ioctl 85 75 -10
setkeycodes_main 165 154 -11
write_table 244 232 -12
vconfig_main 318 306 -12
do_del_ioctl 93 81 -12
set_address 75 62 -13
maybe_set_utc 30 16 -14
loadfont_main 495 479 -16
slattach_main 712 695 -17
do_loadfont 191 174 -17
do_iplink 1155 1136 -19
getty_main 2583 2562 -21
fbset_main 2058 2035 -23
do_time 588 565 -23
xioctl 25 - -25
read_rtc 186 160 -26
parse_conf 1299 1270 -29
udhcp_read_interface 269 239 -30
bb_ioctl 45 - -45
bb_ioctl_alt 70 - -70
bb_ioctl_on_off 78 - -78
.rodata 129370 129018 -352
do_show 799 - -799
------------------------------------------------------------------------------
(add/remove: 6/5 grow/shrink: 13/49 up/down: 1316/-1864) Total: -548 bytes
text data bss dec hex filename
675352 2740 13968 692060 a8f5c busybox_old
674804 2740 13968 691512 a8d38 busybox_unstripped
2007-07-14 22:07:14 +00:00
Denis Vlasenko
dc757aa16c
introduce and use bb_basename()
...
function old new delta
bb_basename - 26 +26
sv_main 1226 1225 -1
passwd_main 1985 1983 -2
showdirs 482 478 -4
sendCgi 1811 1807 -4
make_device 1354 1350 -4
handleIncoming 2443 2439 -4
func_name 82 78 -4
service_name 2292 2285 -7
main 909 901 -8
cmp_main 555 547 -8
test_main 434 422 -12
act 228 216 -12
find_pair 180 164 -16
rmmod_main 298 280 -18
find_pid_by_name 156 134 -22
modprobe_main 1606 1576 -30
------------------------------------------------------------------------------
(add/remove: 1/0 grow/shrink: 0/16 up/down: 26/-156) Total: -130 bytes
text data bss dec hex filename
734933 3028 14400 752361 b7ae9 busybox_old
734801 3028 14400 752229 b7a65 busybox_unstripped
2007-06-30 08:04:05 +00:00
Denis Vlasenko
80b8b39899
Consolidate ARRAY_SIZE macro; remove one unneeded global var (walter harms <wharms@bfs.de>)
2007-06-25 10:55:35 +00:00
Bernhard Reutner-Fischer
bb0baed564
- strndupa is a GNU extension. Using strdup to avoid several errors like:
...
util-linux/mdev.c:(.text+0x29a): undefined reference to `strndupa'
2007-06-20 09:56:47 +00:00
Denis Vlasenko
459be35234
hwclock: size optimizations
...
libbb/time.c: new file, introducing monotonic_us()
pscan, traceroute, arping: use it instead of gettimeofday
ping, zcip: TODO
function old new delta
monotonic_us - 89 +89
find_pair 164 180 +16
.rodata 129747 129763 +16
refresh 1144 1152 +8
............
timeout 8 4 -4
static.start 8 4 -4
last 8 4 -4
parse_conf 1303 1284 -19
time_main 1149 1124 -25
gettimeofday_us 39 - -39
arping_main 2042 1969 -73
hwclock_main 594 501 -93
catcher 485 380 -105
traceroute_main 4300 4117 -183
------------------------------------------------------------------------------
(add/remove: 2/1 grow/shrink: 8/11 up/down: 157/-562) Total: -405 bytes
2007-06-17 19:09:05 +00:00
Denis Vlasenko
a7825f269d
make FEATURE_HAVE_RPC auto-selectable by mount and inetd sub-features
2007-06-16 13:56:51 +00:00
Mike Frysinger
0e0639b702
Alex Landau writes: open firmware for reading, not writing
2007-06-14 09:29:48 +00:00
Denis Vlasenko
26017b1b04
minix.h: add very simple test script
2007-06-13 12:49:46 +00:00
Denis Vlasenko
1fd46215b2
fsck_minix: forgotten bit of previous commit...
2007-06-13 12:35:34 +00:00
Denis Vlasenko
a6691317e5
fsck_minix: stop using data/bss
...
10847 8 271 11126 2b76 busybox.t2/util-linux/fsck_minix.o
10140 0 0 10140 279c busybox.t3/util-linux/fsck_minix.o
2007-06-13 12:28:21 +00:00
Denis Vlasenko
ca525b4f24
*: BB_BANNER -> bb_banner (it is not a const or #define)!
...
correct_password: explain in detail why it is ok to use bb_banner
fsck_minix: make it print bb version, not it's own (outdated/irrelevant) one
Marginal size difference:
text data bss dec hex filename
679119 2700 15632 697451 aa46b busybox_old
679091 2700 15632 697423 aa44f busybox_unstripped
2007-06-13 12:27:17 +00:00
Mike Frysinger
b51fd3525e
as suggested by Renaud Cerrato and Souf, switch over to recursive_action() for some nice shrinkage and so we work even when CONFIG_SYSFS_DEPRECATED is off
2007-06-13 09:24:50 +00:00
Mike Frysinger
a78ef2ccf1
add support for firmware loading
2007-06-13 07:34:15 +00:00
Denis Vlasenko
d67cef2425
hush: fix read builtin to not read ahead past eol and to not use
...
insane amounts of stack. Testsuite updated.
2007-06-13 06:47:47 +00:00
Denis Vlasenko
3ad5d0cbbe
diff: shrink code (-85 bytes):
...
function old new delta
fiddle_sum 8 - -8
diffreg 2717 2690 -27
prepare 334 284 -50
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 0/2 up/down: 0/-85) Total: -85 bytes
s/ATTRIBUTE_ALWAYS_INLINE/ALWAYS_INLINE/g
2007-06-12 20:54:54 +00:00
Denis Vlasenko
d6766c71a9
mdev: microscopic enhancement, should change nothing
2007-06-08 16:18:15 +00:00
Denis Vlasenko
4e5f82c76f
find_stray_communal_vars: script which finds communal variables
...
resize: remove globals var
mdev: remove globals var
2007-06-03 22:30:22 +00:00
Denis Vlasenko
3f22b7f718
fdisk: make it work with big disks (read: typical today's disks)
...
even if CONFIG_LFS is unset.
2007-06-02 12:46:55 +00:00
Denis Vlasenko
9a7d38fe24
delete tons of extra #includes
2007-05-31 22:42:12 +00:00
Denis Vlasenko
fad2b86c9e
use "glibc errno" trick not only for ash, but for entire busybox
...
(add/remove: 1/1 grow/shrink: 37/37 up/down: 139/-228) Total: -89 bytes
2007-05-31 22:16:38 +00:00
Denis Vlasenko
c2f011aa03
more: stop using bss
...
# make && make bloatcheck
function old new delta
gotsig 86 107 +21
more_main 777 781 +4
cin_fileno 4 - -4
set_tty_to_initial_mode 25 - -25
new_settings 120 60 -60
initial_settings 120 60 -60
------------------------------------------------------------------------------
(add/remove: 0/2 grow/shrink: 2/2 up/down: 25/-149) Total: -124 bytes
2007-05-31 21:31:56 +00:00
Denis Vlasenko
4b924f3a5c
whitespace fixes
2007-05-30 00:29:55 +00:00
Denis Vlasenko
b6adbf1be2
usage.c: remove reference to busybox.h
...
*: s/include "busybox.h"/include "libbb.h"
2007-05-26 19:00:18 +00:00
Denis Vlasenko
38ec147a18
mount: fix mounting of symlinks (mount from util-linux allows that)
2007-05-20 12:32:41 +00:00
Denis Vlasenko
68de720723
mount: fix incorrect usage of strtok (inadvertently used NULL sometimes).
...
the change is "for(xxx)...." -> "if(var) for(xxx)...", but my gcc 4.1.2
adds _158 bytes_!! WTF?? 8(
2007-05-09 20:38:04 +00:00
Denis Vlasenko
c34d35557b
loop device code: readability improvement
2007-04-19 00:09:34 +00:00
Denis Vlasenko
3ace9fa6d8
switch_root: error_msg -> perror_msg, reduce by 22 bytes while at it.
2007-04-18 21:40:30 +00:00
Denis Vlasenko
87468857f6
style fixes
2007-04-13 23:22:00 +00:00
Denis Vlasenko
51742f4bb0
style fixes. No code changes
2007-04-12 00:32:05 +00:00
Denis Vlasenko
50f7f446ec
bb_full_fd_action: remove potential xmalloc from NOFORK path
...
cat: stop using stdio.h opens
libbb: introduce & use open[3]_or_warn
function old new delta
open3_or_warn - 54 +54
bb_cat 115 144 +29
open_or_warn - 25 +25
unlzma 2404 2412 +8
chattr_main 334 339 +5
xstrtoul_range_sfx 251 255 +4
telnet_main 1514 1510 -4
static.opt 4 - -4
qgravechar 122 118 -4
fuser_add_pid 61 54 -7
fuser_add_inode 154 147 -7
writeFileToTarball 1542 1534 -8
refresh 1156 1148 -8
do_show 856 846 -10
read_leases 212 200 -12
setup_redirects 236 222 -14
iproute_list_or_flush 1582 1568 -14
read_config 427 411 -16
write_leases 284 264 -20
hash_file 338 318 -20
copy_file 1760 1740 -20
do_iproute 2610 2588 -22
bb_full_fd_action 320 269 -51
open_to_or_warn 103 49 -54
fuser_main 1660 1596 -64
.rodata 131160 131096 -64
------------------------------------------------------------------------------
(add/remove: 2/1 grow/shrink: 4/19 up/down: 125/-423) Total: -298 bytes
2007-04-11 23:20:53 +00:00
Denis Vlasenko
80d14beae9
Rename two config options:
...
FEATURE_SH_STANDALONE_SHELL => FEATURE_SH_STANDALONE
FEATURE_EXEC_PREFER_APPLETS => FEATURE_PREFER_APPLETS
Make SH_STANDALONE depend on PREFER_APPLETS.
getopt.c: more randomconfig-induced fixes
2007-04-10 23:03:30 +00:00
Denis Vlasenko
335b63d8d1
make a few struct bb_applet members conditional
...
rename sllep_and_die -> xfunc_die
make fflush_stdout_and_exit NOFORK-safe
fix some buglets found by randomconfig
2007-04-10 21:38:30 +00:00
Denis Vlasenko
99912ca733
audit small applets and mark some of them as NOFORK.
...
Put big scary warnings in relevant places.
2007-04-10 15:43:37 +00:00
Denis Vlasenko
ff131b980d
style fixes. No code changes.
2007-04-10 15:42:06 +00:00
Denis Vlasenko
240a1cfbbe
add some missed statics on constant objects.
...
fix few #ifndef ENABLE_xxx
# size busybox_old busybox_unstripped
text data bss dec hex filename
677152 2920 18208 698280 aa7a8 busybox_old
676420 2920 18208 697548 aa4cc busybox_unstripped
2007-04-08 16:07:02 +00:00
Denis Vlasenko
9c146a91d3
getopt: use getopt32 for option parsing - inspired by patch by
...
Mats Erik Andersson <mats.andersson64@comhem.se>
function old new delta
getopt_main 809 810 +1
static.BUFFER 4 - -4
shell 8 4 -4
quote 4 - -4
quiet_output 4 - -4
quiet_errors 4 - -4
long_options_nr 4 - -4
long_options_length 4 - -4
long_options 388 384 -4
alternative 4 - -4
shortopts 15 - -15
normalize 243 220 -23
.rodata 131832 131800 -32
add_longopt 200 - -200
------------------------------------------------------------------------------
(add/remove: 0/9 grow/shrink: 1/4 up/down: 1/-306) Total: -305 bytes
2007-04-07 10:25:04 +00:00
Denis Vlasenko
bf295dd5b6
[u]mount: extend -t option (Roy Marples <uberlord@gentoo.org>)
2007-04-05 21:57:47 +00:00
Bernhard Reutner-Fischer
febe3c4211
- sed -e "s/char[[:space:]]*\*[[:space:]]*argv\[\]/char **argv/g"
2007-04-04 20:52:03 +00:00
Denis Vlasenko
219d14d514
random style fixes (extra spaces deleted)
2007-03-24 15:40:16 +00:00
Denis Vlasenko
58875aefe4
assorted fixes uncovered by randomconfig runs
2007-03-22 22:22:10 +00:00
Denis Vlasenko
c86e052b81
fix accumulated whitespace and indentation damage
2007-03-20 11:30:28 +00:00
Denis Vlasenko
dfce08f281
fdisk: bb_common_bufsiz1 is too small for globals on 64-bit CPU
2007-03-19 14:45:10 +00:00
Denis Vlasenko
bd852076b9
fdisk: get rid of _() macro.
...
Shorten some messages. Stop using stderr - anyone who tries
to use fdisk no-interactively is "strange" anyway.
Improve storage handling in bsd module.
text data bss dec hex filename
728112 1488 33788 763388 ba5fc busybox.t0/busybox
727248 1488 33372 762108 ba0fc busybox.t1/busybox
2007-03-19 14:43:38 +00:00
Denis Vlasenko
83bb98f759
mkfs_minix: remove older, less efficient bss reduction trick
2007-03-18 14:43:21 +00:00
Denis Vlasenko
8e1a0cc4c9
fdisk: move 2k ptes[] array into bb_common_bufsiz1
2007-03-18 14:42:45 +00:00
Denis Vlasenko
4efeaee387
mkfs_minix: stop using lots of bss/data.
...
data -3500 bytes, code -300 bytes
keep_data_small: expand/fix
2007-03-15 19:52:42 +00:00
Denis Vlasenko
5659407595
swapon: reinstate hole check but reduce it to warning
...
inode_hash: remove unused variable
2007-03-14 22:55:39 +00:00
Denis Vlasenko
fad03bc3bb
fsck_minix: stop using large buffers in bss
2007-03-13 22:31:28 +00:00
Denis Vlasenko
b3f09f4a50
swapon: random shrinkage
2007-03-12 18:16:24 +00:00
Denis Vlasenko
4eb8b936cb
more: do not mess with "/dev/console" (!);
...
fill whole 1st screen (was "screen sans one line");
fall back to cat if redirected or no ctty
less: fall back to cat if no ctty (was exiting)
resize: cosmetics
2007-03-10 16:32:14 +00:00
Denis Vlasenko
673d4bbab6
hwclock: support /dev/rtc0 etc
2007-03-07 23:02:50 +00:00
Denis Vlasenko
8e858e2700
clean up accumulated whitespace damage
2007-03-07 09:35:43 +00:00
Denis Vlasenko
ec27feb045
init: code readability enhancements; very small code changes
2007-02-17 15:52:02 +00:00
Mike Frysinger
ae30210d90
create a document for mdev so people dont have to rtfs
2007-02-14 13:20:29 +00:00
Denis Vlasenko
d4eda22d0c
fix warning coming from printing size_t with %u
2007-02-06 21:52:05 +00:00
Denis Vlasenko
1d76f439da
EXEC_PREFER_APPLETS support by Gabriel L. Somlo <somlo@cmu.edu>
2007-02-06 01:20:12 +00:00
Denis Vlasenko
cc24419e98
minix utils: de-inline bit ops (saves ~130 bytes)
2007-02-06 00:37:40 +00:00
Denis Vlasenko
dc485c9da6
minix utils: make a message easier to understand; small tweaks
2007-02-06 00:36:53 +00:00
Denis Vlasenko
f885c543da
correct "pivot_root: pivot_root: <msg>"
2007-02-06 00:35:36 +00:00
Denis Vlasenko
5870ad9672
mount: (try to) support cifs with IPv6
2007-02-04 02:39:55 +00:00
Denis Vlasenko
06af216528
suppress warnings about easch <applet>_main() having
...
no preceding prototype
2007-02-03 17:28:39 +00:00
Denis Vlasenko
06c0a71d23
preparatory patch for -Wwrite-strings #3
2007-01-29 22:51:44 +00:00
Denis Vlasenko
b6aae0f381
preparatory patch for -Wwrite-strings #2
2007-01-29 22:51:25 +00:00
Mike Frysinger
0e282c9aed
combine depends lines
2007-01-24 14:50:27 +00:00
Mike Frysinger
71a6a4e723
correct file format errors
2007-01-24 08:24:43 +00:00
Denis Vlasenko
6cd2d2bcba
dnsd: getfileentry was leaking memory
...
mount: improve readability
2007-01-22 14:06:03 +00:00
Denis Vlasenko
8e1c71529c
Convert cmdedit into more generic line input facility
...
(make history and completion optional at runtime).
Use it for fdisk, as an example.
Some unrelated fixes in fdisk are also here.
2007-01-22 07:21:38 +00:00
Denis Vlasenko
9af7c9d6b6
openvt,getty,vfork_daemon_rexec,mount: tighten up fd cleanup code
...
(will close all fd's > 2 on daemonization now)
getty: fix "getty -" support, and also do not try to chown/chmod "-"
telnetd: fix "lost ctty" bug
Yet another attempt on saner function names:
bb_sanitize_server_stdio(0/1) -> bb_sanitize_stdio() + bb_daemonize();
2007-01-19 21:19:35 +00:00
Denis Vlasenko
150f402b36
whitespace fixes (leading spaces to tab)
2007-01-13 21:06:21 +00:00
Denis Vlasenko
f7996f3b70
Trailing whitespace removal over entire tree
2007-01-11 17:20:00 +00:00
Denis Vlasenko
3821fb13ea
fix verbose output; remove commented-out includes.
2007-01-11 16:51:21 +00:00
Denis Vlasenko
8e9ccba371
ipv6-ization efforts continue. Few bugs are found,
...
unknown number likely introduced...
2007-01-11 16:50:23 +00:00
Denis Vlasenko
d54708399d
fdisk: remove 8k buffer from bss - OSF labels
...
are not THAT common anyway
2007-01-03 02:58:54 +00:00
Denis Vlasenko
9b1381fd2f
convert calloc to xzalloc
...
fix sleep-on-die option
2007-01-03 02:56:00 +00:00
Denis Vlasenko
75fa4eb155
fsck_minix: tiny optimization
2007-01-03 01:36:42 +00:00
Denis Vlasenko
87033fb5fa
forgot to svn add util-linux/minix.h :(
2007-01-03 00:47:47 +00:00
Denis Vlasenko
73464ce53d
fbset: move variable from data to bss
...
fsck_minix: fix fallout
2007-01-03 00:45:05 +00:00
Denis Vlasenko
aa95959cb8
factor out minix structures/constants into minix.h
...
fsck_minix: optimizations
2007-01-03 00:43:19 +00:00
Denis Vlasenko
6dd392a252
fsck_minix: optimizations. ~130 bytes
2007-01-03 00:41:53 +00:00
Denis Vlasenko
24cfe8fe0c
introduce small[u]int
...
fsck_minix: use it for flag variables. 140 bytes saved
2007-01-03 00:39:15 +00:00
Denis Vlasenko
2a85676fa5
silly style fixes
2007-01-02 16:45:05 +00:00
Denis Vlasenko
6a5dc5d75a
next bunch of fixes for bugs found by randconfig
2006-12-30 18:42:29 +00:00
Denis Vlasenko
3bba545a54
done a dozen of randconfig test. guess what? ALL failed...
...
these are resulting fixes
2006-12-30 17:57:03 +00:00
Denis Vlasenko
666da5e2c6
merge post-1.3.0 fixes
2006-12-26 18:17:42 +00:00
Denis Vlasenko
b95636c52f
remove casts from xmalloc()
2006-12-19 23:36:04 +00:00
Denis Vlasenko
28703015ab
u_short, ulong exterminated
...
fdiskXXX: add a bit of sanity (not enough by far)
2006-12-19 20:32:02 +00:00
Denis Vlasenko
908d6b7054
mount: add getmntent_r stub for dietlibc
2006-12-18 23:07:42 +00:00
Denis Vlasenko
a597aaddfa
s/extern inline/static ATTRIBUTE_ALWAYS_INLINE/g
...
xstrtou: disallow leading '+'
2006-12-16 23:48:13 +00:00
Denis Vlasenko
b15b7f7a4a
more: fix for case when _FILE_OFFSET_BITS is not #defined.
...
samll size improvement.
2006-12-10 01:57:29 +00:00
Bernhard Reutner-Fischer
732268fe69
- provide central knob to turn off RPC related options.
2006-12-01 16:56:12 +00:00
Denis Vlasenko
93f6aa6bca
"make bigdata" biggest offender dealt with:
...
xmalloc 16Kb buffer instead of keeping it in bss
2006-11-30 21:11:01 +00:00
Denis Vlasenko
28bb84bd4e
Well, I am not 100.00% usre that uint16 will suffice there.
...
We don't lose anything by using 'unsigned' instead.
2006-11-29 23:15:04 +00:00
Denis Vlasenko
016a82e279
another -90 bytes. That #define is **evil**
2006-11-29 22:47:42 +00:00
Denis Vlasenko
66b86c6902
mkfs.minix: more cleanups, -~300 bytes of code.
...
Added debugging support.
2006-11-29 22:33:47 +00:00
Denis Vlasenko
c6ce8733dd
cut 0.5k off mkfs.minix
...
assorted strtoul fixes (that's what brought me into minix)...
2006-11-29 18:15:52 +00:00
Denis Vlasenko
834410a5a5
getopt32-ification of fdisk
2006-11-29 12:00:28 +00:00
Denis Vlasenko
5e90e10647
Closing bug 1040:
...
The "quiet" option is quietly (hah) ignored. It should be passed through
to the mount() syscall in the comma separated list of options.
I found the problem with the vfat/msdos filesystems, which uses
a quiet option to override some complaints and errors.
2006-11-27 19:50:16 +00:00
Denis Vlasenko
d9e15f2068
style cleanup: return(a) -> return a, part 2
2006-11-27 16:49:55 +00:00
Denis Vlasenko
079f8afa0a
style cleanup: return(a) -> return a, part 1
2006-11-27 16:49:31 +00:00
Denis Vlasenko
10d0d4eec7
byteswap ops had extra mask ops - removed
2006-11-27 16:48:17 +00:00
Denis Vlasenko
cf749bc10c
small fixes:
...
fix xstrdup to not grossly overallocate memory
use xopen instean of xopen3 in several places
etc.
2006-11-26 15:45:17 +00:00
Denis Vlasenko
d398ecab9d
hunt down improper include <>, make mkswap output 4Gb+ friendly
2006-11-24 15:38:03 +00:00
Denis Vlasenko
cf30cc82a3
header_verbose_list: stop truncating file size in listing
2006-11-24 14:53:18 +00:00
Denis Vlasenko
6a353c8158
mount: if FILE* is NULL, it's not wise to use it.
2006-11-19 17:34:57 +00:00
Denis Vlasenko
89f0b3486d
rodata cleanup. "unable to" == "cannot". -300 bytes
2006-11-18 22:04:09 +00:00
Denis Vlasenko
1119972f91
umount: umount -a shouldn't stop on first failure
2006-11-12 17:23:45 +00:00
Denis Vlasenko
5af906e7c8
rename: compare_string_array -> index_in_str_array
...
introduce index_in_substr_array and use it in
iproute2
2006-11-05 18:05:09 +00:00
Denis Vlasenko
dd539f7687
Unneeded code removed, usused field "unsigned pscpu" removed
2006-11-01 20:20:37 +00:00
Denis Vlasenko
9225854144
mostly style fixes
2006-11-01 10:25:35 +00:00
Denis Vlasenko
5c7596058d
ls: cleanup part 1
2006-10-28 12:37:16 +00:00
Denis Vlasenko
82f9e28513
OFF_T_FMT -> OFF_FMT
2006-10-27 13:00:07 +00:00
Denis Vlasenko
25d8062128
top: batch mode should output all processes
2006-10-27 09:34:22 +00:00
Denis Vlasenko
d3d004dd35
last nail into error_msg() (de)capitalization
2006-10-27 09:02:31 +00:00
Denis Vlasenko
ddec5af6b0
rename functions to more understandable names
2006-10-26 23:25:17 +00:00
Denis Vlasenko
f0ed376eda
remove bb_printf and the like
2006-10-26 23:21:47 +00:00
Denis Vlasenko
68f2187265
mount: use switch (compare_string_array(..))
...
where appropriate, saves >100 bytes.
2006-10-26 01:47:34 +00:00
Denis Vlasenko
1457915afc
xconnect is non-conforming to "xfunc like libc" rule. Fixing
2006-10-26 01:09:46 +00:00
Denis Vlasenko
c6f188def8
silly size savings and capitalization fixes
2006-10-26 00:37:00 +00:00
Denis Vlasenko
d18a3a20db
use skip_whitespace where appropriate
2006-10-25 12:46:03 +00:00
Denis Vlasenko
e1a0d486e4
message string changes, mostly for consistency, also -32 bytes in .rodata
2006-10-20 13:28:22 +00:00
Denis Vlasenko
13c5a6832f
mount: support user mounts if CONFIG_DESKTOP
2006-10-16 22:39:51 +00:00
Denis Vlasenko
f46be09106
mdev: reduce excessive indentation
2006-10-16 19:39:37 +00:00
Denis Vlasenko
efeed5ed28
fdisk: compilation fix
2006-10-14 16:16:03 +00:00
Denis Vlasenko
ea62077b85
add open_read_close() and similar stuff
2006-10-14 02:23:43 +00:00
Denis Vlasenko
2d5ca60bfb
bb_get_[chomped]line_from_file wasn't descriptive enough.
...
Renaming...
2006-10-12 22:43:20 +00:00
Denis Vlasenko
372686bde7
cut, mount: small improvements
2006-10-12 22:42:33 +00:00
Denis Vlasenko
98ae2160b6
fdisk: separate sun/aix/etc code into #included files
2006-10-12 19:30:44 +00:00
Denis Vlasenko
1385899416
attempt to regularize atoi mess.
2006-10-08 12:49:22 +00:00
Denis Vlasenko
000b9ba91f
eject: -T fix
2006-10-05 23:12:49 +00:00
Denis Vlasenko
7d219aab70
build system overhaul
2006-10-05 10:17:08 +00:00
Denis Vlasenko
8f8f268cfd
bb_applet_name -> applet_name
2006-10-03 21:00:43 +00:00
Denis Vlasenko
67b23e6043
getopt_ulflags -> getopt32.
...
It is impossible to formulate sane ABI based on
size of ulong because it can be 32-bit or 64-bit.
Basically it means that you cannot portably use
more that 32 option chars in one call anyway...
Make it explicit.
2006-10-03 21:00:06 +00:00
Denis Vlasenko
b6332248ca
fdformat: remove redundant check
2006-10-03 19:57:50 +00:00
Denis Vlasenko
9275814a9e
lots of silly indent fixes
2006-10-03 19:56:34 +00:00
Denis Vlasenko
546cd1881a
mount: accept and ignore -s (sloppy) option.
...
needed for compatibility with Linux automounter.
2006-10-02 18:52:49 +00:00
Denis Vlasenko
39d551fd15
fbset: store short string in the structure itself instead of the pointer
...
(small size saving)
2006-09-30 16:28:30 +00:00
Denis Vlasenko
274b8c0639
fbset: add support for -a (bug 1017)
2006-09-30 16:22:59 +00:00
Denis Vlasenko
0b193a7871
losetup: use /dev/loopN or /dev/loop/N according to CONFIG_FEATURE_DEVFS=n/y
2006-09-29 21:47:11 +00:00
Denis Vlasenko
a959588b80
Yet another silly little byte saving. couldn't -> cannot
2006-09-29 21:30:43 +00:00
Denis Vlasenko
b1726785f9
mount: fix bug 946 (mount -f should update mtab)
2006-09-29 14:43:20 +00:00
Denis Vlasenko
956a569360
losetup: with no arguments lists all /dev/loopN. Corrected help text.
...
(patch by Vladimir Dronnikov <dronnikov@gmail.ru>)
2006-09-27 14:51:27 +00:00
Denis Vlasenko
da3cec9c85
mount: fix breakage from recent changes (spurious -ro mounts)
2006-09-24 01:01:01 +00:00
Denis Vlasenko
4c196a80fc
hexdump: fixlet for my breakage
2006-09-23 15:53:01 +00:00
Denis Vlasenko
2dbeaa95ca
hexdump: deindent, almost fits into 80 columns now
2006-09-23 13:31:46 +00:00
Denis Vlasenko
27ee7ba95e
losetup: getopt_ulflags'ification + small fix for perror_nomsg
2006-09-22 14:53:41 +00:00
Denis Vlasenko
f47ff100cc
getopt: fix whitespace damage
2006-09-22 08:42:06 +00:00
Denis Vlasenko
cad36681d2
readprofile: getopt_ulflags'isation
2006-09-22 08:39:49 +00:00
Denis Vlasenko
7869c018b5
ipcs: fix my recent breakage
2006-09-22 08:30:52 +00:00
Rob Landley
e9a7a6212b
Change license statements (and clean up headers) on some of the files that
...
Erik or I are primary copyright holders on.
2006-09-22 02:52:41 +00:00
Denis Vlasenko
ce32f65a1b
mount: nfs mount should enable bb_error-to-syslog support
2006-09-21 12:30:16 +00:00
Denis Vlasenko
116080a13a
mount: make Rob happy by reinstating #defines
2006-09-21 11:13:08 +00:00
Denis Vlasenko
3ccc100670
ipcs: fix output (misaligned columns)
2006-09-19 17:43:56 +00:00
Denis Vlasenko
c7b9bad519
ipcs: getopt_ulflag'ification, -170 bytes
2006-09-19 17:40:31 +00:00
Denis Vlasenko
85f9e32f7f
mount: fstabname needs to be const char*
2006-09-19 14:14:12 +00:00
Denis Vlasenko
23514fe251
mount: fix warning (printf field width of * wants int, not size_t)
2006-09-19 14:07:52 +00:00
Denis Vlasenko
9213a9e0f2
whitespace cleanup
2006-09-17 16:28:10 +00:00
Denis Vlasenko
a6127aacef
mount: style fixlet
2006-09-17 15:51:52 +00:00
Denis Vlasenko
029c469934
mount: revert mount --bind to using "bind" as fstype.
2006-09-17 15:39:22 +00:00
Denis Vlasenko
a52145a927
mount: mount_it_now() - char *dir is not really needed.
2006-09-17 15:09:48 +00:00
Denis Vlasenko
c889d2b786
mount: fix "duplicate mount options in mtab" bug
2006-09-17 15:08:12 +00:00
Denis Vlasenko
c0975199be
mount: nfs_strerror's static buffer was bigger than needed.
2006-09-17 15:06:34 +00:00
Denis Vlasenko
9c99b62b9e
mount: getopt_ulflag'ification
2006-09-17 15:05:31 +00:00
Denis Vlasenko
13b4924ce0
mount: style fixes
2006-09-17 15:04:35 +00:00
Denis Vlasenko
3bc59aa2a4
mount: fix bugs: free(mp->mnt_fsname) of non-malloced ptr;
...
check for "more than 2 arguments" was actually checking for -2.
2006-09-17 15:04:01 +00:00
Denis Vlasenko
fc56dd2e21
mount: use bb_simplify_path as appropriate
2006-09-17 15:01:53 +00:00
Denis Vlasenko
8d474b5009
mount: style fixes
2006-09-17 15:00:58 +00:00
Denis Vlasenko
30a64cdc95
mount: reorder things, fix NFS-less mount.
2006-09-15 15:12:00 +00:00
Denis Vlasenko
af9854b81a
umount: do not try to close FILE* which is NULL.
2006-09-14 16:40:46 +00:00
Denis Vlasenko
be507170eb
mount: -o remount should not add lines to /etc/mtab
2006-09-14 16:09:27 +00:00
Denis Vlasenko
25098f7fd5
mount: move code from nfsmount.c into mount.c
2006-09-14 15:46:33 +00:00
Denis Vlasenko
727ef94447
mount: fix mtab support (but it is still rather buggy)
2006-09-14 13:19:19 +00:00
Rob Landley
cc9962d7fb
More code from kernel developers, and therefore licensed under GPLv2 only.
...
Clarify the license boilerplate.
On an unrelated note, this could use busyboxification. check_mount() looks
reusable and ask() is generic...
2006-09-14 05:27:28 +00:00
Bernhard Reutner-Fischer
7fee0c4357
- fix copy'n paste errors that got introduced when switching to the shorter boilerplate.
...
No object code changes.
2006-09-13 16:39:19 +00:00
Rob Landley
20cc6d567f
Remove pointless "const". Bloatcheck says 0 bytes difference.
2006-09-12 21:42:17 +00:00
Denis Vlasenko
00d7d6cef6
nfsmount: sanitize it. It had a rather peculiar idea of implementing "bg"
...
option - it was going to return a special flag back to caller and
expecting caller to call it again with special parameter! Also
caller was charged with calling mount() syscall...
mount: mtab support was non-functional. Enabling it revealed serious bug
which is not fixed yet.
2006-09-11 17:42:44 +00:00
Bernhard Reutner-Fischer
64d7e93081
- convert a few xopen3(,,0) into xopen(,). Also peruse the fact that xopen defaults to 0777 on it's own, so we don't need to xopen3(,,0777).
...
Saves a few bytes:
$ size busybox.old busybox text data bss dec hex filename
839676 8780 243592 1092048 10a9d0 busybox.old
839660 8780 243592 1092032 10a9c0 busybox
$ make CC=gcc-4.2-HEAD bloatcheck
function old new delta
static.vconfig_main 281 279 -2
static.rx_main 1076 1074 -2
static.mt_main 294 292 -2
static.gzip_main 753 751 -2
static.mkfs_minix_main 4034 4030 -4
static.unzip_main 1771 1766 -5
static.crontab_main 1513 1507 -6
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-23) Total: -23 bytes
2006-09-11 16:01:40 +00:00
Denis Vlasenko
3077294615
nfsmount: remove some really old code (for kernels 1.x!) + small cleanups.
2006-09-10 18:48:16 +00:00
Denis Vlasenko
d2b13eab98
nfsmount: delete nfsmount.h
2006-09-10 18:40:18 +00:00
Denis Vlasenko
39e93cc951
nfsmount: nfsmount.h merged into nfsmount.c
2006-09-10 18:38:17 +00:00
Denis Vlasenko
2244a21a8e
nfsmount: style fix
2006-09-10 18:28:23 +00:00
Denis Vlasenko
5983914c1b
ipcs: silly trick with strings. saves ~200 bytes.
2006-09-10 18:26:51 +00:00
Rob Landley
c27f4f5445
A quick cleanup pass of some low-hanging mess.
2006-09-08 00:41:48 +00:00
Denis Vlasenko
6d655be5df
removed a lot of trailing \n in bb_msg() calls. It is added
...
automatically by function itself.
2006-09-06 19:02:46 +00:00
Rob Landley
4cb035dd23
Vladimir Dronnikov (ybrnj80 at yandex dot ru) pointed out that my cleanup of
...
his code introduced a bug (an extra backslash in the CIFS mount string).
2006-09-05 14:00:21 +00:00
Rob Landley
4d609cb5a3
Thinko.
2006-09-04 19:43:26 +00:00
Rob Landley
89d9d4d5f7
Vladimir Dronnikov also submitted a CIFS support patch to mount, which I
...
heavily reworked here and probably broke. Tomorrow I need to set up a
copy of samba to test against. (This compiles, I make no promises beyond that.)
2006-09-01 08:10:44 +00:00
Rob Landley
88621d7398
Svn 16007 broke the build under gcc 4.0.3. This fixes up some of the damage
...
(the e2fsprogs directory is too twisty and evil to easily fix, but I plan
to rewrite it anyway so I'll just bump that up in priority a bit).
2006-08-29 19:41:06 +00:00
Bernhard Reutner-Fischer
73561cc75a
- pull from busybox_scratch: r15829:15850
...
Various fixes, cleanups and shrinkage:
saves 952 Bytes:
text data bss dec hex filename
1087742 15853 790632 1894227 1ce753 ../busybox/busybox.old
1086790 15853 790632 1893275 1ce39b busybox
via:
# scripts/bloat-o-meter ../busybox/busybox_unstripped.old busybox_unstripped
function old new delta
ipcrm_main 756 822 +66
getval - 61 +61
maybe_set_utc - 40 +40
udhcpc_main 2896 2912 +16
md5_hash_block 428 437 +9
opt 8 16 +8
qgravechar 106 110 +4
make_bitmap 292 295 +3
inflate_unzip 2056 2059 +3
add_partition 1412 1414 +2
__parsespent 156 158 +2
qrealloc 41 42 +1
format - 1 +1
catv_main 313 314 +1
watch_main 293 292 -1
varunset 81 80 -1
part 1 - -1
check_if_skip 837 836 -1
start_stop_daemon_main 840 837 -3
create_lost_and_found 175 172 -3
supress_non_delimited_lines 4 - -4
static.l 4 - -4
static.c 5 1 -4
bsd_sum_file 237 233 -4
eval2 338 332 -6
arithmetic_common 166 158 -8
cmpfunc 22 5 -17
cksum_main 294 275 -19
cmp_main 465 439 -26
dd_main 1535 1508 -27
rmmod_main 376 333 -43
cut_file 727 644 -83
ipcs_main 3809 3721 -88
cut_main 722 614 -108
date_main 1443 1263 -180
remove_ids 222 - -222
------------------------------------------------------------------------------
(add/remove: 3/4 grow/shrink: 11/18 up/down: 217/-853) Total: -636 bytes
2006-08-28 23:31:54 +00:00
Rob Landley
4470b74e29
The kernel can't handle umount /dev/hdc, we have to do it through mtab,
...
except that we still have to work when there is no mtab.
Oh, and while we're at it, take advantage of the fact that modern processors
avoid branches via conditional assignment where possible. ("x = a ? b : c;"
turns into "x = c; if (a) x = b;" because that way there's no branch to
potentially mispredict and thus never a bubble in the pipeline. The if(a)
turns into an assembly test followed by a conditional assignment (rather
than a conditional jump).) So since the compiler is going to do that _anyway_,
we might as well take advantage of it to produce a slightly smaller binary.
So there.
2006-08-17 19:07:20 +00:00
Rob Landley
10b36f94bb
Patch from Chris Steel to fix mdev deleting device nodes.
2006-08-10 01:09:37 +00:00
Rob Landley
3ba7bd143e
Vladimir Dronnikov convinced me to twiddle the semantics of the new shared
...
subtree stuff to look more like http://lwn.net/Articles/159077/ thinks
they should.
2006-08-09 19:51:13 +00:00
Rob Landley
721b46e0e6
Fix a typo (|| instead of |) and remove two comments about a problem fixed
...
in the previous patch.
2006-08-08 12:54:02 +00:00
Rob Landley
e3781b7312
Add shared subtree support, suggested by Vladimir Dronnikov. Also break out a
...
few new (unfinished) config options, which I intend to make hidden (but
enabled) when CONFIG_NITPICK is disabled. Getting the .config infrastructure
to do that is non-obvious, it seems...
2006-08-08 01:39:49 +00:00
Rob Landley
47b16a6fe9
Using lstat() instead of stat() means that attempting to loopback mount
...
a symlink doesn't work.
2006-08-08 00:47:17 +00:00
Rob Landley
7250915d78
Make a warning go away on 64-bit systems.
2006-08-06 20:41:11 +00:00
Rob Landley
59fe8b9089
There are a number of reasons for reinventing printf(). Writing status to
...
stdout is not one of them.
2006-08-04 22:02:55 +00:00
Rob Landley
081e38483e
Remove xcalloc() and convert its callers to xzalloc(). About half of them
...
were using "1" as one of the arguments anyway, and as for the rest a multiply
and a push isn't noticeably bigger than pushing two arguments on the stack.
2006-08-03 20:07:35 +00:00
Rob Landley
7478804b78
Fix umount so loop device disassociation hopefully doesn't screw up errno on
...
a failed mount. And while I'm at it, legacy mdev removal was only being done
in the _failure_ case? That can't be right. Plus minor header cleanups
and an option parsing tweak.
2006-08-03 17:54:45 +00:00
Rob Landley
d921b2ecc0
Remove bb_ prefixes from xfuncs.c (and a few other places), consolidate
...
things like xasprintf() into xfuncs.c, remove xprint_file_by_name() (it only
had one user), clean up lots of #includes... General cleanup pass. What I've
been doing for the last couple days.
And it conflicts! I've removed httpd.c from this checkin due to somebody else
touching that file. It builds for me. I have to catch a bus. (Now you know
why I'm looking forward to Mercurial.)
2006-08-03 15:41:12 +00:00
Rob Landley
446129adae
Add back in non-ifdef version of FEATURE_PRETTY_PRINT, and get the attribution
...
right this time.
2006-07-27 16:40:55 +00:00
Rob Landley
fc367f9824
There's no excuse for adding new #ifdefs to the code like that. None at all.
2006-07-27 15:02:58 +00:00
Mike Frysinger
eac0c06938
allow people to display dmesg output without syslog levels
2006-07-27 11:18:36 +00:00
Mike Frysinger
a7881119cc
de-cuddle if( to if (
2006-07-27 03:00:49 +00:00
Rob Landley
d893b120ba
New mkswap. Small and simple. Might even work. :)
2006-07-16 08:17:03 +00:00
Rob Landley
aa516a61b9
Fix three embarassing thinkos in the new dmesg.c:
...
1) the c argument shouldn't have had a : after that, dunno how that got there.
2) the xgetlarg for level was using size
3) because xgetlarg's error message _SUCKS_ (it does a show_usage() rather than giving any specific info about the range that was violated) I dropped the range down to 2 bytes. (Which works fine, I dunno why we were nit-picking about that...)
2006-07-06 16:41:56 +00:00
"Robert P. J. Day"
63fc1a9e08
Standardize on the vi editing directives being on the first line.
2006-07-02 19:47:05 +00:00
"Robert P. J. Day"
53f21e34a7
Remove "#if 0" content.
2006-07-01 14:34:33 +00:00
"Robert P. J. Day"
68229837ff
Remove all usage of the "register" storage class specifier.
2006-07-01 13:08:46 +00:00
Mike Frysinger
c340ea191a
fix from Kolbjørn Barmen for building for m68k targets
2006-06-30 02:53:56 +00:00
Rob Landley
ef10d52745
Upgrade mdev to allow commands to be run on create/delete.
...
Both Jason Schoon and Giuseppe Ciotta deserve credit for this, I used elements
of both. It's been upgraded so that you can specify that a given command
should run at create, at delete, or at both using different special characters
(@, $, and * respectively). It uses the system() method of running command
lines which means you can use environment variables on the command line (it
sets $MDEV to the name of the current device being created/deleted, which is
useful if you matched it via regex), and the documentation warns that you need
a /bin/sh to make that work, so you probably want to pick a default shell.
2006-06-26 14:11:33 +00:00
Rob Landley
11c7a7bed6
Various cleanups I made while going through Erik Hovland's patch submissions,
...
some of which are even from him. :)
2006-06-25 22:39:24 +00:00
Rob Landley
0cc2c2c289
Patch from Paul Fox to improve mount's error handling behavior, which I beat
...
on a bit.
2006-06-21 03:53:33 +00:00
Rob Landley
dbfb5a3cb7
Andre (armcc2200@yahoo) patched a bug where successful mounts could sometimes
...
produce an error, due to a missing rc assignment.
2006-06-21 02:39:57 +00:00
Rob Landley
7a260f01ce
Make some 64 bit warnings go away on x86-64.
2006-06-19 03:20:03 +00:00
Rob Landley
ea224be6aa
skip_whitespace() shouldn't claim its return value is const, it doesn't know
...
that and callers wind up typecasting it back.
2006-06-18 20:20:07 +00:00
Rob Landley
bc8c50351f
Remove warnings caused by #include <sys/mount.h> in platform.h. Apparently
...
we redefine a lot of stuff from standard header files...
2006-06-16 04:25:19 +00:00
Rob Landley
22d26fc6ae
Patch from Yann Morin to put BLKGETSIZE64 in platform.h had rather a lot of
...
fallout due to the #include <sys/mount.h>. Removed that #include from various
applets and fixed up those that were unhappy when that #include was made
because they'd block copied stuff out of it. (Sigh.)
2006-06-15 15:49:36 +00:00
Rob Landley
7c7b0d7437
Rewrite of dmesg, smaller and simpler.
2006-06-13 18:31:04 +00:00
Rob Landley
18958e9309
Random cleanup of platform.h.
2006-06-13 18:28:33 +00:00
Rob Landley
0960ca7383
Work around a persistent uClibc bug, since 0.9.29 still hasn't shipped.
...
Poked to do this by Jason Schoon.
2006-06-13 18:27:16 +00:00
Rob Landley
fd8409f8c5
Patch from Denis Vlasenko, tweak error messages.
2006-06-13 15:31:39 +00:00
Rob Landley
9a1a9de49f
Minor size shrinkage.
2006-06-13 15:12:14 +00:00
Bernhard Reutner-Fischer
19008b8373
- reuse strings and messages. Saves about 600B
2006-06-07 20:17:41 +00:00
Rob Landley
c44ab02f15
Whack the one last warning in make allbareconfig...
2006-06-06 19:50:16 +00:00
Bernhard Reutner-Fischer
1b9d7c9aa9
- use bb_msg_{read,write}_error where appropriate.
...
text data bss dec hex filename
825015 9100 645216 1479331 1692a3 busybox.old
824919 9100 645216 1479235 169243 busybox
2006-06-03 22:45:37 +00:00
Bernhard Reutner-Fischer
5c0ae06ef1
- No options should set the current system time.
...
Shaun Jackman writes:
A bug introduced in svn 11946 broke rdate. It no longer sets the
current system time when no options are specified. The options have
the opposite sense from what one might think, and, oddly enough, -ps
is intentionally a no-op.
Quoth rdate(8) from the BSD System Manager's Manual:
-p Do not set, just print the remote time
-s Do not print the time.
2006-06-03 10:24:20 +00:00
Rob Landley
15d20a03d6
Remove _() and N_() from platform.h. #define them as NOP macros in the two
...
files still using them. I didn't remove them from e2fsck.c to avoid stomping
pending cleanup patches from Garrett, and I didn't bother to remove them from
fdisk.c because that entire file needs to be rewritten from scratch.
2006-05-29 05:00:44 +00:00
Rob Landley
8394729ddf
Remove _().
2006-05-29 04:49:55 +00:00
Rob Landley
c44bc986b7
Fix some warnings in allbareconfig.
2006-05-28 01:19:06 +00:00
Rob Landley
299a6b4d7b
Consolidate #include <sys/time.h> so libbb.h does it.
2006-05-27 21:42:58 +00:00
Rob Landley
8bb50782a5
Change llist_add_* to take the address of the list rather than returning the new
...
head, and change all the callers.
2006-05-26 23:44:51 +00:00
Bernhard Reutner-Fischer
01d23ade57
- add central knob to turn off getopt_long everywhere. EXPERIMENTAL!
...
Adds "Enable getopt long" under "General options", default y.
Send patches to fix getopt_ulflags and run_parts.c if you turn this off..
See http://busybox.net/lists/busybox/2006-May/021828.html for a start to run-parts
2006-05-26 20:19:22 +00:00
Bernhard Reutner-Fischer
08421e1d0c
- work around bug in gcc-3.4.x on ARM
2006-05-26 14:05:48 +00:00
Mike Frysinger
fa6c4844b2
fix spelling mistakes
2006-05-26 01:48:17 +00:00
Rob Landley
5cd1ccd995
Convert to a global struct, the way sed was. Now I have two, I can work out
...
the infrastructure to merge global structs into a union...
2006-05-21 18:33:27 +00:00
Bernhard Reutner-Fischer
b1629b1b2a
- remove emacs layout block as suggested by Robert P.J. Day
...
- use shorter boilerplate while at it
2006-05-19 19:29:19 +00:00
Bernhard Reutner-Fischer
e2e56c7c41
- single KERNEL_VERSION(a,b,c) macro in platform.h
...
- rename get_kernel_revision() to get_linux_version_code
from Robert P. J. Day
2006-05-19 11:54:02 +00:00
Mike Frysinger
39440e520c
pull Rules.mak from top_srcdir as pointed out by Robert P. J. Day on the mailing list
2006-05-13 02:33:09 +00:00
Rob Landley
094b9f7e1d
Shut up the warning "implicit declaration of strlen".
2006-05-10 17:41:21 +00:00
Rob Landley
a6b5b60942
Fiddling with llist to make memory management easier. Specifically, the
...
option to delete the contents of the list when we delete the list is a
good thing.
2006-05-08 19:03:07 +00:00
Rob Landley
15fe2e11d7
Shrink the code about 50 bytes, allocate less run-time memory, and add a
...
comment that null terminating the string we sscanf() shouldn't be required
since the kernel adds \n to the end of it and sscanf will stop there.
2006-05-08 02:53:23 +00:00
Rob Landley
17507fa4c5
More busting on legacy mtab support in the help text.
2006-05-08 02:22:24 +00:00
Rob Landley
a389651115
Remove bb_strlen() in favor of -fno-builtin-strlen. Saves as many bytes
...
as the old optimization did (actually does slightly better under gcc 4.0), and
simplifies the code.
2006-05-07 20:20:34 +00:00
Rob Landley
2c39eee805
Migrate endianness macros.
2006-05-05 16:54:40 +00:00
Rob Landley
49159c7f94
Patch from Jason Schoon to make mount -a not abort on the first failure.
2006-05-05 15:01:38 +00:00
Rob Landley
db2ab89b7c
Build break fix from Bernhard fischer, fixing fallout from svn 14974. (My bad.)
2006-05-03 21:39:28 +00:00
Rob Landley
3ea66a805d
Patches from Denis Vlasenko to rework "current_name" handling and remove
...
print_current_name().
2006-04-29 20:08:40 +00:00
Rob Landley
8a6254994c
Patch from Denis Vlasenko:
...
* Do not initialize globals to 0, it is done automatically
* unsigned short -> uint16_t, unsigned int -> uint32_t
where appropriate (did it ever work on Alphas?)
* triple sync() is silly - removed
* check_zone_nr uses check_zone_nr2 now
* remove trailing periods from messages, uppercase first letter
2006-04-29 20:05:17 +00:00
Rob Landley
9950cab8e0
Patch from Denis Vlasenko:
...
ix bug (inode_map and zone_map are char* pointers,
sizeof() on them gives 4 or 8)
2006-04-29 20:03:54 +00:00
Mike Frysinger
10f55b1dae
Jason Schoon writes: This makes the case where LFS is not defined, but fdisk is configured with large disk support use the pretty build rules.
2006-04-21 21:59:22 +00:00
Rob Landley
29ba9796be
Robert Eggers noticed that nfsmount would sometimes incorrectly return success.
2006-04-17 23:02:57 +00:00
Mike Frysinger
1a54030445
use memmove() instead of bcopy()
2006-04-16 05:58:21 +00:00
Rob Landley
2ec922eed5
Patch from Robert P Day: let menuconfig indent stuff for us, we don't have
...
to do it in Config.in.
2006-04-13 23:22:16 +00:00
Bernhard Reutner-Fischer
c2cb0f32b4
- patch from Denis Vlasenko to add and use bb_xopen3()
2006-04-13 12:45:04 +00:00
Bernhard Reutner-Fischer
dac7ff15b7
- patch from Denis Vlasenko to add and use bb_xsocket() and to use
...
bb_xopen some more while at it.
Also use shorter boilerplate while at it.
2006-04-12 17:55:51 +00:00
Rob Landley
19af279d16
Kumar spotted another bug: if we autodetect nfs and they haven't specified the
...
fstype, it should be set to nfs.
2006-04-05 01:43:39 +00:00
Rob Landley
ab8736064b
You'd think there'd be a compiler warning for "pointless if", wouldn't you?
2006-04-04 16:56:04 +00:00
Bernhard Reutner-Fischer
a38330c366
- do away with useless fwd-decls, redundant bb_printf calls, silence warning
...
about comparing signed and unsigned and make stuff static.
text data bss dec hex filename
6944 0 0 6944 1b20 util-linux/ipcs.o.oorig
6509 0 0 6509 196d util-linux/ipcs.o
TODO: bb_getopt_ulflags, and further simplifications
2006-04-03 11:25:48 +00:00
Rob Landley
20fef96dd8
Bug spotted by Kumar Gala. Hopefully this fixes it...
2006-04-01 17:32:52 +00:00
Bernhard Reutner-Fischer
5cf905a871
- use RESERVE_CONFIG_BUFFER and a bit of whitespace-cleanup. defconfig:
...
text data bss dec hex filename
1307 0 0 1307 51b util-linux/hwclock.o.oorig
1255 0 0 1255 4e7 util-linux/hwclock.o
2006-03-31 22:36:15 +00:00
Bernhard Reutner-Fischer
56dd0bff06
- shrink mkswap and make v0 support optional. Thanks also to Tito for his ideas.
...
http://busybox.net/lists/busybox/2006-March/019326.html
2137 8 28 2173 87d util-linux/mkswap.o.orig
1890 8 28 1926 786 util-linux/mkswap.o.v0+v1
1560 4 28 1592 638 util-linux/mkswap.o.v1
2006-03-29 17:32:24 +00:00
Bernhard Reutner-Fischer
b256bd334f
- shrink dmesg a bit.
...
http://busybox.net/lists/busybox/2006-March/019477.html
2006-03-29 17:26:14 +00:00
Rob Landley
fe908fda28
Kumar Gala tracked down a problem with NFS mounting. This is a different fix
...
from his, but to the same problem.
2006-03-29 14:30:49 +00:00
Rob Landley
92fff34de6
Bernhard Fischer spotted that we shouldn't free fstype if we didn't allocate
...
it.
2006-03-28 19:19:19 +00:00
Rob Landley
4789694372
Robert P Day removed some commented out code.
2006-03-26 21:42:40 +00:00
Bernhard Reutner-Fischer
2dd13bd25a
- make sure that we see freeramdisk only once
2006-03-24 09:48:18 +00:00
Mike Frysinger
948a09d6f2
dont printf arguments given by user for security sanity
2006-03-23 02:07:20 +00:00
Rob Landley
3ea05d3222
Fix missing copyright and license notice.
2006-03-21 18:20:40 +00:00
Rob Landley
e3f4ab2bc4
Remove unneeded entries.
2006-03-20 18:40:07 +00:00
Eric Andersen
9601a1c8c2
whitespace cleanup
2006-03-20 18:07:50 +00:00
Eric Andersen
19b5b8ff6a
Fix some obvious compile problems. Make the -f' fakeIt option actually work.
2006-03-20 18:07:13 +00:00
Rob Landley
c30f445b08
Patch from tito, acked by Bernhard Fischer.
2006-03-20 02:20:18 +00:00
Rob Landley
e2b428cbb1
Use lstat() instead of stat so /init being a symlink doesn't screw people up.
...
(And use it consistently, for size reasons.)
2006-03-20 01:43:29 +00:00
Bernhard Reutner-Fischer
2523da259c
- explain what magic numbers we're using here.
2006-03-18 23:02:45 +00:00
Bernhard Reutner-Fischer
66753a3850
- whitespace cleanup (and also check against the const first and only then look
...
at bb_applet_name[1])
2006-03-18 15:59:29 +00:00
Rob Landley
eaa34ca5b4
More fixes. Type "auto" should mean unspecified from fstab as well as the
...
command line, initialize singlemount's rc to an error value so it doesn't
think it succeeded when it didn't, use absolute path when associating a
loop device (and the previous FEATURE_CLEAN_UP logic related to that was
freeing the wrong thing), move reading of /proc/filesystems to where we can
re-read it (when it's empty) for every entry on a "mount -a" so that when
/proc is mounted as the first entry, the later filesystems can autodetect
filesystem type.
2006-03-18 02:58:11 +00:00
Rob Landley
5a57821565
Bug fix: umount wasn't detaching loop devices unless mtab support was enabled.
...
Made some whitespace cleanups while I was there.
2006-03-17 03:30:05 +00:00
Rob Landley
d221d2137f
Missed one.
2006-03-14 20:06:44 +00:00
Rob Landley
dc0955b603
The new, new mount rewrite. (Mount double prime?) Still being debugged, but
...
the new infrastructure is reentrant so in theory it's capable of handling
mount -a sanely. It can also re-use existing flags with remount, handle
-t auto, mount -a -t, and several smaller bugfixes.
2006-03-14 18:16:25 +00:00
Rob Landley
0b22c1c962
Tito unified fdflush and freeramdisk. I tweaked the result a bit.
2006-03-14 02:40:51 +00:00
Bernhard Reutner-Fischer
df10094870
- revert back to r14406
2006-03-13 19:04:00 +00:00
Rob Landley
c5b1d4d6b1
Patch from Denis Vlasenko to add xstat() and use it.
2006-03-13 15:45:16 +00:00
Rob Landley
bc68cd14cc
Patch from Denis Vlasenko turning static const int (which gets emitted into
...
the busybox binary) into enums (which don't).
2006-03-10 19:22:06 +00:00
Bernhard Reutner-Fischer
07a79e75f5
- backout using features which are not available with the previous stable
...
version of make (3.71.1).
2006-03-09 09:03:37 +00:00
Rob Landley
dfba741457
Robert P. Day removed 8 gazillion occurrences of "extern" on function
...
definitions. (That should only be on prototypes.)
2006-03-06 20:47:33 +00:00
Bernhard Reutner-Fischer
022eb311d5
- use absolute path for top_builddir and top_srcdir.
...
Fixes make trying to include the very same file in an endless loop.
2006-03-02 17:33:25 +00:00
Bernhard Reutner-Fischer
5d26126b9e
- fixes parallel builds (make -j)
...
- use less resources for the buildsystem itself
2006-03-01 22:54:48 +00:00
"Vladimir N. Oleynik"
73804d6f7e
more security: don't start shell code from argv
2006-02-28 08:23:27 +00:00
Mike Frysinger
5ba2fb2c9d
remove duplicate license notice
2006-02-25 07:57:32 +00:00
Mike Frysinger
983e0ca89e
strip out unneeded comments
2006-02-25 07:42:02 +00:00
"Vladimir N. Oleynik"
5c06b277ce
fdisk unmaintained now :(
2006-02-25 07:20:15 +00:00
Rob Landley
5527b9117e
Another clean-up patch from Garrett.
2006-02-25 03:46:10 +00:00
Rob Landley
736e52532e
Minor cleanup from Garrett Kajmowicz.
2006-02-25 03:36:00 +00:00
Rob Landley
b73451daee
Cleanup from Denis Vlasenko.
2006-02-24 16:29:00 +00:00
Bernhard Reutner-Fischer
ed7bb6278d
- put NLS stuff in one central place to avoid redefines.
...
Fixes warnings about:
fdisk.c:45:1: warning: "_" redefined
nfsmount.c:121:1: warning: "_" redefined
nfsmount.c:122:1: warning: "N_" redefined
interface.c:84:1: warning: "_" redefined
2006-02-23 14:25:15 +00:00
Rob Landley
d6e14d8bee
Don't build directory libraries unless we're building an applet that needs it.
...
Cherry-picked from Devin Bayer's big MacOS X patch.
2006-02-21 19:11:35 +00:00
Rob Landley
a7e3d05208
Create /dev/root symlink pointing to real root device, if any.
2006-02-21 06:11:13 +00:00
Mike Frysinger
0a6b0bfa7a
add setarch/linux32/linux64 applet
2006-02-21 04:26:52 +00:00
Rob Landley
d05981eaf1
Fix off by one error. (I know I had a reason for doing that, but I have _no_
...
idea what it was...)
2006-02-14 07:33:45 +00:00
Rob Landley
cc6d8d30ec
Fix umount so it works if there's no /etc/mtab or /proc/mounts, make
...
umount -a into a CONFIG_FEATURE (why not?), and zap the now obsolete
defconfig file (which was supposed to be part of the previous checkin).
2006-02-08 20:06:57 +00:00
Mike Frysinger
271aa40a15
add back in path nulling after calling find_dev() since it is needed for now ...
2006-02-07 06:10:45 +00:00
Mike Frysinger
a421ba8203
cleanup style ... just because you use less spaces doesnt mean the resulting code is smaller
2006-02-03 00:25:37 +00:00
Mike Frysinger
248d2220f9
shrink the code a bit
2006-02-03 00:19:42 +00:00
Mike Frysinger
53d57dbe6b
gavinl writes in Bug 661:
...
if read() file return less than 1, we should close the fd and then goto end.
2006-02-03 00:16:53 +00:00
Mike Frysinger
5509228a7b
alphabetical order and fix mdev comments about echo>/sys vs echo>/proc/sys
2006-02-02 23:14:57 +00:00
Mike Frysinger
b38673fb9f
make the build system puuuuuuuuuuurty
2006-02-02 01:41:53 +00:00
"Vladimir N. Oleynik"
b399a96343
remode warning: const static mix
2006-02-01 12:41:35 +00:00
Bernhard Reutner-Fischer
3038557649
- bzero -> memset
...
text data bss dec hex filename
1652855
14444 1215616 2882915 2bfd63 busybox.oorig.gcc-3.3
1652823 14444 1215616 2882883 2bfd43 busybox.gcc-3.3
1603655 14412 1215552 2833619 2b3cd3 busybox.oorig.gcc-3.4
1603655 14412 1215552 2833619 2b3cd3 busybox.gcc-3.4
1609755 14508 1215744 2840007 2b55c7 busybox.oorig.gcc-4.0
1609755 14508 1215744 2840007 2b55c7 busybox.gcc-4.0
1590495 13516 1215392 2819403 2b054b busybox.oorig.gcc-4.1-HEAD
1590495 13516 1215392 2819403 2b054b busybox.gcc-4.1-HEAD
1589079 13036 1213248 2815363 2af583 busybox.oorig.gcc-4.2-HEAD
1589079 13036 1213248 2815363 2af583 busybox.gcc-4.2-HEAD
2006-01-31 17:57:48 +00:00
Bernhard Reutner-Fischer
9f4a1e1c75
- add and use ATTRIBUTE_ALIGNED(num_bytes)
...
- remove unused parameter pindex from fdisk.c, xbsd_initlabel()
2006-01-31 09:53:53 +00:00
Eric Andersen
3496fdc9a5
hopefully the last of the annoying signed/unsigned and mixed type errors
2006-01-30 23:09:20 +00:00
Tim Riker
c1ef7bdd8d
just whitespace
2006-01-25 00:08:53 +00:00
Rob Landley
e927743bb0
There was a missing ! on strcmp (despite the fact it worked in my testing,
...
I have no idea _how_), and a simpler fix for the extra \n problem. I tested
this and it worked for me, for what that's worth...
2006-01-22 23:14:16 +00:00
Bernhard Reutner-Fischer
86f5c9906b
- add platform.h.
...
- use shorter boilerplate while at it.
2006-01-22 22:55:11 +00:00
Bernhard Reutner-Fischer
7ca61b6f33
- shared libbusybox.
...
- IMA compilation option (aka IPO, IPA,..)
Please holler if i broke something..
2006-01-15 14:04:57 +00:00
Bernhard Reutner-Fischer
4a1865ca5e
- revert last change for now..
2006-01-13 18:11:59 +00:00
Bernhard Reutner-Fischer
5a62284972
this applet needlessly big! TODO: bb_getopt_ulflags()
...
- use atol for the offset, which is always in bytes. Small step in eventually dropping bb_xparse_number().
2006-01-13 17:29:46 +00:00
Rob Landley
29e08ffcdf
Frank Sorenson added hotplug support to mdev. (I tweaked it a bit. Need
...
to come up with a test suite for all the stuff that requires root access.
Something involving User Mode Linux or QEMU, probably...)
2006-01-12 06:13:50 +00:00
Rob Landley
1c19deed17
The major:minor read from dev ends with \n, need to trim that.
2006-01-12 03:07:49 +00:00
Rob Landley
71d6ccd801
With -a, the jump to mount_it_now can skip the initialization of f, and
...
if we don't zero it after closing it we re-close a filehandle that isn't
open, and since this is a file _pointer_ it segfaults on a double free.
Yeah, subtle bug. I need to break this out into separate functions if I can
figure out how to avoid making the code larger while doing so. Part of
the general -a and -o remount work I need to do, but that's after 1.1.0...
2006-01-10 05:30:28 +00:00
Rob Landley
8b0efdb1a1
Both atime and diratime should switch _off_ the corresponding no* flag.
2006-01-10 02:37:20 +00:00
Mike Frysinger
5990efb795
use MAP_PRIVATE instead of MAP_SHARED for uClinux systems (see Bug 550)
2006-01-04 07:31:19 +00:00
Rob Landley
ce88793698
When you went "losetup -d /dev/loop0 /dev/loop1" the error message was strange.
2005-12-21 17:00:25 +00:00
Rob Landley
5d84c2398e
Fix chroot, leave console alone if -c not specified, and yank debug code.
...
(I still haven't set up a test environment to confirm this works...)
2005-12-20 17:25:51 +00:00
Rob Landley
7b363fd3c9
Some minor cleanups/bugfixes split off from the big remount work:
...
Shorten GPL boilerplate.
Enabling FEATURE_CLEAN_UP broke things in two places.
Move the NFS with uClibc check to nfsmount.c
2005-12-20 17:18:01 +00:00
Rob Landley
9bdd742dd2
Sigh. Left the debug path in. Fixed.
2005-12-17 10:54:17 +00:00
Rob Landley
b56c285da5
Added /etc/mdev.conf support. Adds about 1.9k to mdev.
2005-12-17 10:52:30 +00:00
Bernhard Reutner-Fischer
73bffd4d96
- remove duplicate entry for switch_root
2005-12-15 11:44:31 +00:00
Rob Landley
70f7ef7be3
Nothing to see here. Move along.
...
Not buying it, eh?
I know I said new features before 1.1, but, well... (I was weak!)
The config file and hotplug modes aren't implemented yet. Might take a stab at
those tomorrow. (I _should_ go back to focusing on the bug triage list.)
2005-12-13 08:21:33 +00:00
Bernhard Reutner-Fischer
126da9ec2d
- typo: s/sucess/success/g
...
What's up with loginutils/su.c line 42: "SYSLOG_SUCESS" ? Please have a look..
2005-12-12 11:20:39 +00:00
"Vladimir N. Oleynik"
a972c870a8
reduce signedness warning
2005-12-02 10:06:04 +00:00
Rob Landley
1d589b2e2d
Fix losetup so that it A) actually works again, B) has much better error
...
messages, C) can show the current association (if any) when called
with only one argument. Update the documentation a lot too.
Remind me to add a test suite for this thing. I think I've figured out
how to handle root-only testsuites...
2005-11-29 23:47:10 +00:00
Paul Fox
969af89797
add "-C" format to hexdump
...
fixes bug #113 and satisfies a personal need at the same time.
output compares identically to util-linux version. (with
exception of whitespace differences on last lines of output with
non-uniform length, which are neither fixed nor worsened by this
change.)
2005-11-28 21:06:00 +00:00
"Vladimir N. Oleynik"
65bb10f253
reduce bss
2005-11-24 12:10:13 +00:00
"Vladimir N. Oleynik"
ea97282af1
bb_opt_complementally for rdate applet. Add losed record to util-linux/Makefile.in for switch_root applet
2005-10-28 15:43:41 +00:00
Rob Landley
1b751c894b
Rob Sullivan sent in some cleanups, which I beat on slightly.
2005-10-28 09:24:33 +00:00
Rob Landley
0f34a821ab
Add a switch_root utility (like kconfig's utils/run_init.c, although not
...
actuall using any of that code). This is needed because pivot_root doesn't
work right under initramfs. (See the menuconfig help.)
2005-10-27 22:55:50 +00:00
"Vladimir N. Oleynik"
1f0262bcdb
another more const
2005-10-20 11:17:48 +00:00
"Vladimir N. Oleynik"
5cf9a03b3f
more const, attribute_noreturn saved 200 bytes
2005-10-19 09:21:51 +00:00
"Vladimir N. Oleynik"
1f2dc40ede
data --> bss
2005-10-15 13:56:17 +00:00
"Vladimir N. Oleynik"
f704b27b5b
- new bb_opt_complementally syntax, use [-:?] only - 'free' chars
...
- new bb_getopt_ulflags features: check max and min args, convert first argv to options special for ar and tar applets
- use bb_default_error_retval for env applet
2005-10-14 09:56:52 +00:00
Bernhard Reutner-Fischer
bb66a6c94e
- initialize the correct variables
2005-10-13 10:24:44 +00:00
"Vladimir N. Oleynik"
064f04e7e2
- use complementally '!' to '?' - 'ask' is best 'free' char for this.
...
- more long opt compatibility, can set flag for long opt struct now
- more logic: check opt-depend requires and global requires, special for 'id' and 'start-stop-daemon' applets.
2005-10-11 14:38:01 +00:00
"Vladimir N. Oleynik"
54cb5c6af3
better check usage with options, correct show problem error message, indent
2005-10-10 12:17:33 +00:00
Rob Landley
4a7252babd
Rename CONFIG_NFSMOUNT to CONFIG_FEATURE_MOUNT_NFS so allbaseconfig can
...
find it (and tweak defconfig to catch up).
2005-10-08 18:49:45 +00:00
Mike Frysinger
747fc5d5fd
allow people to adjtime location
2005-09-28 03:21:21 +00:00
Mike Frysinger
95544f78cb
whitespace sucks
2005-09-25 05:23:58 +00:00
Mike Frysinger
75aa1928ac
re-order a little for alphabetical
2005-09-24 23:12:38 +00:00
Rob Landley
16722554bf
Tito switched option parsing over to switch umount over to bb_getopt_ulflags().
2005-09-24 22:41:08 +00:00
Mike Frysinger
62f18e1f20
use the shorter license header
2005-09-24 07:16:29 +00:00
Mike Frysinger
0d4ee68be5
use brief license line
2005-09-24 06:01:57 +00:00
"Vladimir N. Oleynik"
24cca8d958
Reduce exported from ipcs applet
2005-09-22 13:13:23 +00:00
Mike Frysinger
2d5e4f6b05
accept unlimited number of swap arguments like the real swap{on,off} and shrink do_em_all a little
2005-09-16 04:41:20 +00:00
Rob Landley
b7285001c9
Cleanup patch from Tito.
2005-09-14 15:28:15 +00:00
Mike Frysinger
6943a9489e
whitespace/syntax cleanups, dont mind me :p
2005-09-13 02:29:39 +00:00
Rob Landley
bc3d4a175f
Cleanup patch from Tito.
2005-09-13 01:30:19 +00:00
Rob Landley
658d2cf986
Tito sent in a few patches converting instances of CONFIG_FEATURE_CLEAN_UP to
...
ENABLE_FEATURE_CLEAN_UP.
2005-09-08 03:11:58 +00:00
"Vladimir N. Oleynik"
27421a1878
1) bb_opt_complementaly -> bb_opt_complementally
...
2) better support long options
3) new flag '!' for bb_opt_complementally: produce bb_show_usage() if BB_GETOPT_ERROR internally
2005-09-05 14:46:07 +00:00
Rob Landley
dbaf97e463
Fix the warnings, and fix the following two obvious segfaults:
...
./busybox getopt -n one -n two woot
./busybox getopt -o one -o two woot
This entire applet is still an enormous pile of garbage, which I can't clean
up because I really have no idea what it's for. (Both "man getopt" and trying
it out on the command line a bit fail to enlighten me. Reading the code, the
fact half of it seems to be special cases for bash vs tcsh does not fill me
with confidence.)
2005-09-05 06:16:53 +00:00
Rob Landley
9a643149de
Amir Shalem found some bugs in the new mount code; unknown options didn't get
...
added to the list, and my assumption that nfsmount() actually called
mount() was incorrect (and I coded it wrong anyway; I hate having to touch
codepaths I can't personally test).
2005-08-30 17:07:49 +00:00
Rob Landley
f4c684a1ef
When compiling with FEATURE_MTAB_SUPPORT disabled, the call to erase_mtab()
...
can never be made because useMtab is initialized to 0, and all the other
assignments of that variable assign 0 to it. Any compiler that can perform
simple constant propogation on local variables will optimize away if statements
testing against that variable, thus the call to erase_mtab() will never be
made.
When compiling for arm using gcc 3.3.3 with FEATURE_MTAB_SUPPORT disabled,
the linker complains that it can't find erase_mtab(). The arm optimizer isn't
exactly the brightest member of the family, and apparently needs to be hit over
the head with a hammer to get its' attention...
2005-08-23 20:03:17 +00:00
Rob Landley
de5fd23f25
If we goto singlemount, do _not_ try to continue through the loop we jumped
...
into. (That means "mount -t ext2 /dev/thingy thingy" would segfault if
it failed instead of giving us an error message.)
2005-08-14 19:26:14 +00:00
Rob Landley
6e98521d68
Stephane Billiart noticed that the return code of the new mount was horked.
...
(Cleaned up the return code path to consistently use numbers so I don't keep
confusing EXIT_SUCCESS with TRUE and EXIT_FAILURE with FALSE...)
2005-08-14 18:46:34 +00:00
Rob Landley
6a6798b8e4
Major rewrite of mount, umount, losetup. Untangled lots of code, shrunk
...
things down a bit, fixed a number of funky corner cases, added support for
several new features (things like mount --move, mount --bind, lazy unounts,
automatic detection of loop mounts, and so on). Probably broke several
other things, but it's fixable. (Bang on it, tell me what doesn't work for
you...)
Note: you no longer need to say "-o loop". It does that for you when
necessary.
Still need to add "user mount" support, which involves making mount suid. Not
too hard to do under the new infrastructure, just haven't done it yet...
The previous code had the following notes, that belong in the version
control comments:
- * 3/21/1999 Charles P. Wright <cpwright@cpwright.com>
- * searches through fstab when -a is passed
- * will try mounting stuff with all fses when passed -t auto
- *
- * 1999-04-17 Dave Cinege...Rewrote -t auto. Fixed ro mtab.
- *
- * 1999-10-07 Erik Andersen <andersen@codepoet.org>.
- * Rewrite of a lot of code. Removed mtab usage (I plan on
- * putting it back as a compile-time option some time),
- * major adjustments to option parsing, and some serious
- * dieting all around.
- *
- * 1999-11-06 mtab support is back - andersee
- *
- * 2000-01-12 Ben Collins <bcollins@debian.org>, Borrowed utils-linux's
- * mount to add loop support.
- *
- * 2000-04-30 Dave Cinege <dcinege@psychosis.com>
- * Rewrote fstab while loop and lower mount section. Can now do
- * single mounts from fstab. Can override fstab options for single
- * mount. Common mount_one call for single mounts and 'all'. Fixed
- * mtab updating and stale entries. Removed 'remount' default.
- *
2005-08-10 20:35:54 +00:00
Mike Frysinger
4d00896d05
use toplevel ARFLAGS and update default ARFLAGS to be quiet
2005-07-27 01:09:24 +00:00
Paul Fox
3f6f3174e9
applying fix from:
...
0000068: mount limited to max 8 loop devices (patch provided)
(made minor wording change for config help message)
2005-07-19 20:55:37 +00:00
Eric Andersen
576db48ef0
applets specified as _BB_SUID_ALWAYS in applets.h should also select
...
CONFIG_FEATURE_SUID to ensure proper behavior when installed.
2005-06-23 18:58:57 +00:00
Rob Landley
6eb1e41674
Rodney Radford submitted ipcs and ipcrm (system V IPC stuff). They could use
...
some more work to shrink them down.
2005-06-20 04:30:36 +00:00
Paul Mundt
8b2d02ed34
Add readprofile applet support.
2005-05-20 17:22:18 +00:00
Mike Frysinger
348e84c202
change the hardcoded error constant (0x80000000UL) to a nice flexible define (BB_GETOPT_ERROR)
2005-05-11 00:39:03 +00:00
Mike Frysinger
7eb6457c4c
moved to e2fsprogs too
2005-04-25 05:00:33 +00:00
Mike Frysinger
3b59821cbd
remove lsattr/chattr to prepare for a top level e2fsprogs dir with more stuff in it
2005-04-23 01:45:08 +00:00
Mike Frysinger
de9f1f757a
import lsattr and chattr from e2fsprogs
2005-04-22 02:33:37 +00:00
Mike Frysinger
f547d672cf
fix typoe (buildddir -> builddir)
2005-04-21 01:49:05 +00:00
Mike Frysinger
b31566ef32
minor style touchups
2005-04-16 04:48:48 +00:00
Eric Andersen
7daa076d3e
egor duda writes:
...
Hi!
I've created a patch to busybox' build system to allow building it in
separate tree in a manner similar to kbuild from kernel version 2.6.
That is, one runs command like
'make O=/build/some/where/for/specific/target/and/options'
and everything is built in this exact directory, provided that it exists.
I understand that applyingc such invasive changes during 'release
candidates' stage of development is at best unwise. So, i'm currently
asking for comments about this patch, starting from whether such thing
is needed at all to whether it coded properly.
'make check' should work now, and one make creates Makefile in build
directory, so one can run 'make' in build directory after that.
One possible caveat is that if we build in some directory other than
source one, the source directory should be 'distclean'ed first.
egor
2004-10-08 07:46:08 +00:00
Glenn L McGrath
d4004ee6a9
Patch from Felipe Kellermann, remove some unnecessary dups, i declared a few extra const's also.
2004-09-14 17:24:59 +00:00
Eric Andersen
b225e2a76b
Fixup some warnings
2004-08-28 00:43:07 +00:00
Eric Andersen
93d7fba892
Tito, farmatito at tiscali dot it writes:
...
Hi to all,
This patch is useful for:
1) remove an unused var from extern char *find_real_root_device_name(const char* name)
changing it to extern char *find_real_root_device_name(void).
2) fixes include/libbb.h, coreutils/df.c, util-linux/mount.c and util-linux/umount.c accordingly.
3) fixes a bug, really a false positive, in find_real_root_device_name() that happens if
in the /dev directory exists a link named root (/dev/root) that should be skipped but
is not. This affects applets like df that display wrong results
2004-08-03 00:14:02 +00:00
Eric Andersen
882cec3e40
YAEGASHI Takeshi writes:
...
Hi,
With the following /etc/fstab (any two or more lines of nfs), mount -a
-t nfs causes a segmentation faults.
server:/exports/aaa /mnt/aaa nfs defaults 0 0
server:/exprots/bbb /mnt/bbb nfs defaults 0 0
In util-linux/nfsmount.c, it overwrites malloc'ed pointer *mount_opts
with a static pointer. With this patch it does proper memory realloc
and data copy instead.
2004-07-26 12:05:12 +00:00
Eric Andersen
d926149d26
Avoid a number of places where large drives could wrap a uint, and
...
instead use off_t which will be automagically promoted to 64bit if
compiled with support for large drives.
-Erik
2004-06-28 23:50:31 +00:00
Eric Andersen
86af052d25
Kevin P. Fleming writes:
...
Yes, I know busybox is in feature freeze. If this two-liner is too much
that's fine, but it's handy.
This patch allows busybox mount to support "-o move" just like it
supports "-o bind", which is the equivalent of util-linux "mount --move".
Usage is:
mount -o move /mnt/point/1 /mnt/point/2
where /mnt/point/1 is an already mounted filesystem; it will be moved to
/mnt/point/2.
2004-05-26 21:26:07 +00:00
Eric Andersen
42f8883c71
Per suggestion from Bastian Blank, be less evil when we force fdisk to
...
transparently remap 32-bit interfaces to actually use 64 bit interfaces.
-Erik
2004-05-26 11:59:19 +00:00
Eric Andersen
823b17263a
Use tab not space
2004-05-26 11:50:37 +00:00
Eric Andersen
1be01072e9
Do not select LFS
2004-05-19 11:06:20 +00:00
Eric Andersen
84bdea8cb2
Erik,
...
>http://busybox.net/cgi-bin/cvsweb/busybox/util-linux/fdisk.c?r1=1.22&r2=1.23&diff_format=u
Its hack for "force" ;-)
If to return the previous version of a Config.in
http://busybox.net/cgi-bin/cvsweb/busybox/util-linux/Config.in?r1=1.12&r2=1.13
and to apply last patch, then I shall calm down. ;-)
(OOPS, last patch have autocorrected from my editor begins spaces to tabs and
removed spaces from empty lines too).
--w
vodz
2004-05-19 10:49:17 +00:00
Eric Andersen
256c4fd587
Make vodz happy and make fdisk always use large file support if
...
possible, even if LFS is not enabled for the rest of busybox.
-Erik
2004-05-19 09:00:00 +00:00
Eric Andersen
aff114c33d
Larry Doolittle writes:
...
This is a bulk spelling fix patch against busybox-1.00-pre10.
If anyone gets a corrupted copy (and cares), let me know and
I will make alternate arrangements.
Erik - please apply.
Authors - please check that I didn't corrupt any meaning.
Package importers - see if any of these changes should be
passed to the upstream authors.
I glossed over lots of sloppy capitalizations, missing apostrophes,
mixed American/British spellings, and German-style compound words.
What is "pretect redefined for test" in cmdedit.c?
Good luck on the 1.00 release!
- Larry
2004-04-14 17:51:38 +00:00
Eric Andersen
ee4b7d496d
make mount ignore -n when CONFIG_FEATURE_MTAB_SUPPORT is disabled
2004-04-12 15:02:53 +00:00
Eric Andersen
522a2f3b39
Everything should be made as simple as possible. But no simpler.
2004-04-03 12:36:03 +00:00
Eric Andersen
bbbbcfef24
Sigh. what a mess.
2004-03-30 09:33:18 +00:00
Eric Andersen
0a92f35702
As waldi noticed, checks for the size of an off_t and casting
...
etc was also redundant and possibly buggy...
2004-03-30 09:21:54 +00:00
Eric Andersen
259cf97803
Go ahead and kill off the FDISK_SUPPORT_LARGE_DISKS option,
...
as it is redundant....
2004-03-30 09:13:05 +00:00
Eric Andersen
1236631700
The fdisk llseek junk was redundant, since both uClibc and glibc
...
automatically promote lseek and friends to their 64 bit counterparts
when CONFIG_LFS is enabled, since it enables __USE_FILE_OFFSET64
2004-03-30 09:08:58 +00:00
Eric Andersen
70060d25d2
s/fileno\(stdin\)/STDIN_FILENO/g
...
s/fileno\(stdout\)/STDOUT_FILENO/g
2004-03-27 10:02:48 +00:00
Eric Andersen
edd580a088
Vladimir N. Oleynik (vodz) writes:
...
Ok. Last patch reduce 73 bytes for compensate (and over) your changes ;-)
Comments:
Added cin_fileno variable, auto setted to 0 from BSS and have "eq" stdin
descriptor if isatty(stout)==0, removed global variable FILE* cin.
Removed default setting to terminal_width/terminal_height, this used
only from main() and setted after call get_terminal_width_height()
always correct.
Variable please_display_more_prompt changed to bits logic, have size
reducing.
--w
vodz
2004-03-27 09:49:57 +00:00