70 Commits

Author	SHA1	Message	Date
Denys Vlasenko	3505e38bd1	sendmail: fix segfault if "To: email1,email2" is used ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-22 15:53:16 +02:00
Denys Vlasenko	e440b39416	*: stop using atexit in non-debug build: saves ~260 in bss with musl ... "builtin" below is atexit's 32-element global array of functions to call. function old new delta top_main 879 889 +10 launch_helper 185 193 +8 powertop_main 1555 1559 +4 sed_main 651 650 -1 slot 4 - -4 call 4 - -4 atexit 23 - -23 kill_helper 31 - -31 __funcs_on_exit 120 - -120 __cxa_atexit 168 - -168 builtin 260 - -260 ------------------------------------------------------------------------------ (add/remove: 0/8 grow/shrink: 3/1 up/down: 22/-611) Total: -589 bytes text data bss dec hex filename 912364 563 6132 919059 e0613 busybox_old 912035 563 5844 918442 e03aa busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-16 17:45:32 +02:00
Denys Vlasenko	22542eca18	getopt32: remove opt_complementary ... function old new delta vgetopt32 1318 1392 +74 runsvdir_main 703 713 +10 bb_make_directory 423 425 +2 collect_cpu 546 545 -1 opt_chars 3 - -3 opt_complementary 4 - -4 tftpd_main 567 562 -5 ntp_init 476 471 -5 zcip_main 1266 1256 -10 xxd_main 428 418 -10 whois_main 140 130 -10 who_main 463 453 -10 which_main 212 202 -10 wget_main 2535 2525 -10 watchdog_main 291 281 -10 watch_main 222 212 -10 vlock_main 399 389 -10 uuencode_main 332 322 -10 uudecode_main 316 306 -10 unlink_main 45 35 -10 udhcpd_main 1482 1472 -10 udhcpc_main 2762 2752 -10 tune2fs_main 290 280 -10 tunctl_main 366 356 -10 truncate_main 218 208 -10 tr_main 518 508 -10 time_main 1134 1124 -10 tftp_main 286 276 -10 telnetd_main 1873 1863 -10 tcpudpsvd_main 1785 1775 -10 taskset_main 521 511 -10 tar_main 1009 999 -10 tail_main 1644 1634 -10 syslogd_main 1967 1957 -10 switch_root_main 368 358 -10 svlogd_main 1454 1444 -10 sv 1296 1286 -10 stat_main 104 94 -10 start_stop_daemon_main 1028 1018 -10 split_main 542 532 -10 sort_main 796 786 -10 slattach_main 624 614 -10 shuf_main 504 494 -10 setsid_main 96 86 -10 setserial_main 1132 1122 -10 setfont_main 388 378 -10 setconsole_main 78 68 -10 sendmail_main 1209 1199 -10 sed_main 677 667 -10 script_main 1077 1067 -10 run_parts_main 325 315 -10 rtcwake_main 454 444 -10 rm_main 175 165 -10 reformime_main 119 109 -10 readlink_main 123 113 -10 rdate_main 246 236 -10 pwdx_main 189 179 -10 pstree_main 317 307 -10 pscan_main 663 653 -10 popmaildir_main 818 808 -10 pmap_main 80 70 -10 nc_main 1042 1032 -10 mv_main 558 548 -10 mountpoint_main 477 467 -10 mount_main 1264 1254 -10 modprobe_main 768 758 -10 modinfo_main 333 323 -10 mktemp_main 200 190 -10 mkswap_main 324 314 -10 mkfs_vfat_main 1489 1479 -10 microcom_main 715 705 -10 md5_sha1_sum_main 521 511 -10 man_main 867 857 -10 makedevs_main 1052 1042 -10 ls_main 563 553 -10 losetup_main 432 422 -10 loadfont_main 89 79 -10 ln_main 524 514 -10 link_main 75 65 -10 ipcalc_main 544 534 -10 iostat_main 2397 2387 -10 install_main 768 758 -10 id_main 480 470 -10 i2cset_main 1239 1229 -10 i2cget_main 380 370 -10 i2cdump_main 1482 1472 -10 i2cdetect_main 682 672 -10 hwclock_main 406 396 -10 httpd_main 741 731 -10 grep_main 837 827 -10 getty_main 1559 1549 -10 fuser_main 297 287 -10 ftpgetput_main 345 335 -10 ftpd_main 2232 2222 -10 fstrim_main 251 241 -10 fsfreeze_main 77 67 -10 fsck_minix_main 2921 2911 -10 flock_main 314 304 -10 flashcp_main 740 730 -10 flash_eraseall_main 833 823 -10 fdformat_main 532 522 -10 expand_main 680 670 -10 eject_main 335 325 -10 dumpleases_main 630 620 -10 du_main 314 304 -10 dos2unix_main 441 431 -10 diff_main 1350 1340 -10 df_main 1064 1054 -10 date_main 1095 1085 -10 cut_main 961 951 -10 cryptpw_main 228 218 -10 crontab_main 575 565 -10 crond_main 1149 1139 -10 cp_main 370 360 -10 common_traceroute_main 3834 3824 -10 common_ping_main 1767 1757 -10 comm_main 239 229 -10 cmp_main 655 645 -10 chrt_main 379 369 -10 chpst_main 704 694 -10 chpasswd_main 308 298 -10 chown_main 171 161 -10 chmod_main 158 148 -10 cat_main 428 418 -10 bzip2_main 120 110 -10 blkdiscard_main 264 254 -10 base64_main 221 211 -10 arping_main 1665 1655 -10 ar_main 556 546 -10 adjtimex_main 406 396 -10 adduser_main 882 872 -10 addgroup_main 411 401 -10 acpid_main 1198 1188 -10 optstring 11 - -11 opt_string 18 - -18 OPT_STR 25 - -25 ubi_tools_main 1288 1258 -30 ls_options 31 - -31 ------------------------------------------------------------------------------ (add/remove: 0/6 grow/shrink: 3/129 up/down: 86/-1383) Total: -1297 bytes text data bss dec hex filename 915428 485 6876 922789 e14a5 busybox_old 914629 485 6872 921986 e1182 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-08 21:55:02 +02:00
Denys Vlasenko	20077c1429	libbb: make trim() return pointer to terminating NUL ... function old new delta trim 80 90 +10 angle_address 56 50 -6 sysctl_main 282 273 -9 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/3 up/down: +10/-15) Total: -5 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-05 17:50:35 +02:00
Denys Vlasenko	72089cf6b4	config: deindent all help texts ... Those two spaces after tab have no effect, and always a nuisance when editing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-21 09:50:55 +02:00
Denys Vlasenko	4eed2c6c50	Update menuconfig items with approximate applet sizes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 22:01:24 +02:00
Denys Vlasenko	c39ee04705	sendmail: allow "+" symbol in recipient. Closes 9646 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-02-12 21:57:22 +01:00
Denys Vlasenko	c19f7584e1	Convert all mailutils/* applets to "new style" applet definitions ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-23 09:58:03 +01:00
Denys Vlasenko	b9f56e82da	sendmail: make it possible to pause after connection helper is started ... If a non-starttls helper is in use, initial 220 response is processed by us, not by helper. Some servers consider us to be a spammer if we don't wait for it. It is not in protocol, but it is a real-life problem. The workaround in this patch is a magic envvar, $SMTP_ANTISPAM_DELAY: ... -H 'PROG ARGS' Run connection helper. Examples: openssl s_client -quiet -tls1 -starttls smtp -connect smtp.gmail.com:25 openssl s_client -quiet -tls1 -connect smtp.gmail.com:465 $SMTP_ANTISPAM_DELAY: seconds to wait after helper connect ... By using it, people can tweak sendmail behavior even if sendmail invocation is buried in some scripts. function old new delta packed_usage 30464 30497 +33 sendmail_main 1185 1206 +21 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 54/0) Total: 54 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-07 13:16:33 +02:00
Denys Vlasenko	2a4d7f44a4	sendmail: include -H and -S in short help text ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-07-14 20:06:44 +02:00
Denys Vlasenko	9de7509aa0	sendmail: improve help text ... * explain which server we contact by default * explain when auth is done * -t is not implied! remove that from help text Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-07-14 19:14:54 +02:00
Denys Vlasenko	237bedd499	getopt32: add new syntax of 'o:+' and 'o:*' for -o NUM and -o LIST ... In many cases, this aqllows to drop use of opt_complementary. Approximately -400 bytes: function old new delta getopt32 1423 1502 +79 opt_string 17 18 +1 OPT_STR 24 25 +1 uniq_main 416 406 -10 timeout_main 279 269 -10 sulogin_main 270 260 -10 readprofile_main 1825 1815 -10 ps_main 543 533 -10 pidof_main 245 235 -10 pgrep_main 611 601 -10 od_main 2600 2590 -10 mkfs_minix_main 2684 2674 -10 mkfs_ext2_main 2603 2593 -10 microcom_main 712 702 -10 makemime_main 315 305 -10 ionice_main 282 272 -10 inetd_main 2074 2064 -10 ifplugd_main 1144 1134 -10 halt_main 353 343 -10 getopt_main 636 626 -10 fdisk_main 2854 2844 -10 env_main 206 196 -10 dmesg_main 319 309 -10 conspy_main 1214 1204 -10 awk_main 981 971 -10 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/22 up/down: 81/-220) Total: -139 bytes text data bss dec hex filename 919373 906 14060 934339 e41c3 busybox_old 918969 906 14060 933935 e402f busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-07-06 21:58:02 +02:00
Denys Vlasenko	76b680c7a8	Use bb_error_msg instead of bb_info_msg in all commented-out debug printouts ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-03-30 16:04:37 +02:00
Denys Vlasenko	d60752f8c9	build system: -fno-builtin-printf ... Benefits are: drops reference to out-of-line putchar(), fixes a few cases of failed string merge. function old new delta i2cdump_main 1488 1502 +14 sha256_process_block64 423 433 +10 sendmail_main 1183 1185 +2 list_table 1114 1116 +2 i2cdetect_main 1235 1237 +2 fdisk_main 2852 2854 +2 builtin_type 119 121 +2 unicode_conv_to_printable2 325 324 -1 scan_recursive 380 378 -2 mkfs_minix_main 2687 2684 -3 buffer_fill_and_print 178 169 -9 putchar 152 - -152 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 7/4 up/down: 34/-167) Total: -133 bytes text data bss dec hex filename 937788 932 17676 956396 e97ec busybox_old 937564 932 17676 956172 e970c busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 22:42:45 +02:00
Maninder Singh	97f2f7ca7f	Removes stray empty line from code ... This patch removes stray empty line from busybox code reported by script find_stray_empty_lines Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-07-13 03:25:46 +02:00
Kaarle Ritvanen	4e03d41342	sendmail: use FQDN in default envelope sender ... RFC 5321 requires the return path to be supplied with a proper domain name. Signed-off-by: Kaarle Ritvanen <kaarle.ritvanen@datakunkku.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-02-09 09:49:36 +01:00
Denys Vlasenko	07f417b6ab	sendmail: make -f optional, document its default value ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-02-05 15:01:39 +01:00
Denys Vlasenko	a42f530e03	sendmail: code shrink on top of previous patches ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-18 18:47:16 +01:00
Aaro Koskinen	e82bfef839	sendmail: don't add multiple To: headers ... When adding To: header, add only a single header. If there are multiple addresses, make it multiline. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-18 18:46:31 +01:00
Aaro Koskinen	4a732220e9	sendmail: don't add To: header if it already exists ... If the message we are sending already has To: header, don't add a new one. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-18 18:45:15 +01:00
Aaro Koskinen	236f222cde	sendmail: support long header fields for recipients ... Support long header fields in To:, Cc: and Bcc: headers. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-18 18:45:15 +01:00
Aaro Koskinen	a8ba0a0d0c	sendmail: support address lists ... Headers To:, Cc: and Bcc: may have a list of comma-separated addresses. Add support for that. Commas inside double quotes are ignored. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-18 18:45:14 +01:00
Aaro Koskinen	06ad964ae6	sendmail: support addresses inside angle brackets ... When we extract addresses from the e-mail, try to first check for an address inside angle brackets. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-18 18:45:14 +01:00
Aaro Koskinen	95e99e5271	sendmail: don't mangle e-mail headers ... Leave the original To: and Cc: headers untouched, when we try to extract addresses from them. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-18 18:45:13 +01:00
Aaro Koskinen	14285d14a5	sendmail: avoid sending mail to wrong addresses ... If we get an address we cannot parse properly, we currently just strip the unknown characters and still try to send it. This is considered harmful as the resulting address may still be valid but different from what the user originally intended. Instead, skip sending to an address we cannot fully understand and print the characters what we have scanned so far. Leading and trailing whitespace is allowed and silently stripped. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-18 18:45:13 +01:00
Ron Yorston	576b1d3c41	sendmail: use host rather than NIS domain name for HELO ... According to RFC 5321 the argument to HELO "contains the fully-qualified domain name of the SMTP client" or its IP address if no FQDN is available. BusyBox sendmail uses the NIS domain name instead which, in many cases, is likely to be the default "(none)". [vda: yes, I checked my machine and its uts.domainname was indeed "(none)"] Using the host name is more likely to satisfy the intent of the RFC while allowing the otherwise unused safe_getdomainname function to be removed. Signed-off-by: Ron Yorston <rmy@tigress.co.uk> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-04-28 17:04:19 +02:00
Denys Vlasenko	3365e9f3cc	makemime: tweak help text: -a HDR can be repeated ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-12-20 02:15:19 +01:00
Denys Vlasenko	fc186711fe	makemime: document our current behavior. Tweak help text ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-11-19 14:43:02 +01:00
Denys Vlasenko	3bc4fc5857	makemime: content-type should default to application/octet-stream ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-11-19 13:55:46 +01:00
Denys Vlasenko	578b817151	sendmail: fix a mistake in previous commit ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-11-19 13:54:50 +01:00
Denys Vlasenko	41fea01066	sendmail: stop doing -t unconditionally; makemime: generate 76 char base64 lines ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-11-18 22:25:35 +01:00
Denys Vlasenko	83e34ac4b5	makemime: fix -a option not taking parameter ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-10-28 18:25:38 +02:00
Denys Vlasenko	34c469ae04	sendmail: don't talk until 220 code is seen. Closes 3487 ... function old new delta sendmail_main 934 939 +5 smtp_checkp 167 165 -2 packed_usage 28634 28621 -13 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-09-18 03:01:49 +02:00
Denys Vlasenko	66426760be	*: remove "Options:" string from help texts ... function old new delta packed_usage 28706 28623 -83 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-06-05 03:58:28 +02:00
Denys Vlasenko	d616ab6bbb	reformime: do not require \r\n ... function old new delta parse 958 1063 +105 packed_usage 28691 28712 +21 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-22 03:46:33 +02:00
Denys Vlasenko	80c5b6893d	libbb: nonblock_safe_read->nonblock_immune_read, remove unused param of xmalloc_reads ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-08 21:21:10 +02:00
Pere Orga	6a3e01d5a9	move help text from include/usage.src.h to debianutils/*.c e2fsprogs/*.c editors/*.c loginutils/*.c mailutils/*.c ... Signed-off-by: Pere Orga <gotrunks@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-04-03 01:33:55 +02:00
Denys Vlasenko	51d714ce7e	sendmail: remove forgotten commenting-out on a "if (verbose)" ... Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-12-20 12:19:46 +01:00
Denys Vlasenko	5707b52fd4	mailutils/*: add verbose option to sendmail; remove -m and -j from makemime ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-12-20 05:12:39 +01:00
Denys Vlasenko	c0683acce8	*: pass md5/shaN context pointer as 1st arg, not last ... function old new delta md5_hash_block 458 459 +1 filter_rename_config 252 250 -2 md5_crypt 591 587 -4 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-10-16 20:45:27 +02:00
Vladimir Dronnikov	5b34300178	sendmail: fix assumption that headers should have a space after the colon ... Signed-off-by: Vladimir Dronnikov <dronnikov@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-10-05 01:21:32 +02:00
Denys Vlasenko	c8f9a8d3c0	move read_base64 to libbb/uuencode.c ... Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-16 18:10:04 +02:00
Denys Vlasenko	9fe98f701d	libbb: merge mail and uudecode's base64 decoders ... function old new delta read_base64 - 378 +378 uudecode_main 306 315 +9 parse 953 958 +5 read_stduu 250 254 +4 base64_main 217 219 +2 read_base64 358 - -358 decode_base64 371 - -371 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 4/0 up/down: 398/-729) Total: -331 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2010-09-16 17:51:13 +02:00
Denys Vlasenko	0ef64bdb40	*: make GNU licensing statement forms more regular ... This change retains "or later" state! No licensing _changes_ here, only form is adjusted (article, space between "GPL" and "v2" and so on). Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-08-16 20:14:46 +02:00
Pascal Bellard	926031b764	*: introduce and use xfork() and xvfork() ... function old new delta launch_helper 170 169 -1 setup_heredoc 312 302 -10 handle_dir_common 367 354 -13 expand_vars_to_list 2456 2443 -13 open_transformer 89 74 -15 data_extract_to_command 439 423 -16 do_ipaddr 1406 1389 -17 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-85) Total: -85 bytes Signed-off-by: Pascal Bellard <pascal.bellard@ads-lu.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-07-04 15:32:38 +02:00
Pascal Bellard	21e8e8da64	libbb: introduce and use BB_EXECVP_or_die() ... function old new delta BB_EXECVP_or_die - 47 +47 time_main 1042 1043 +1 chrt_main 371 364 -7 ionice_main 292 282 -10 setsid_main 69 56 -13 nohup_main 236 223 -13 cttyhack_main 266 253 -13 chroot_main 94 81 -13 chpst_main 746 733 -13 timeout_main 297 279 -18 taskset_main 541 522 -19 vfork_child 67 45 -22 parse 975 953 -22 lpd_main 770 748 -22 launch_helper 192 170 -22 tcpudpsvd_main 1810 1782 -28 nice_main 190 156 -34 env_main 242 206 -36 run_command 221 174 -47 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/17 up/down: 48/-352) Total: -304 bytes Signed-off-by: Pascal Bellard <pascal.bellard@ads-lu.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-07-04 00:57:03 +02:00
Denys Vlasenko	41ddd9f606	*: make exec failure message more consistent ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-06-25 01:46:53 +02:00
Denys Vlasenko	d70e0e995e	*: add INSERTs to *.src files where appropriate ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-06-08 12:15:11 +02:00
Denys Vlasenko	2f32bf8be6	remove defconfig. Now "make defconfig" simply uses defaults from Config.in ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-06-06 04:14:28 +02:00
Denys Vlasenko	da929a95aa	mass renaming Kbuild -> Kbuild.src, Config.in -> Config.src ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-06-04 20:10:51 +02:00