emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,267 Commits 1 Branch 0 Tags 33 MiB
ae5ca6fc41
Commit Graph

145 Commits

Author SHA1 Message Date
Rob Landley
14d7065ef1 Make this slightly more readable, and expose the hypocrasy of a comment that 
says "our implementation makes it impossible to use blocksizes smaller than
22 octets" right above a check for blocksize < 8.
 2006-06-18 15:23:13 +00:00
Bernhard Reutner-Fischer
32bf1f9d42 - rename CONFIG_FEATURE_TFTP_DEBUG to CONFIG_DEBUG_TFTP so it's off in defconfig 
- expand the cmd_get/cmd_put macros
- Jason Schoon writes: unlink only if non-stdio
 2006-06-14 17:29:10 +00:00
Rob Landley
575c8bacda Don't break allbareconfig. 2006-06-13 21:30:09 +00:00
Bernhard Reutner-Fischer
62f9856f54 - revert incorrect select change 2006-06-10 14:32:56 +00:00
Bernhard Reutner-Fischer
b25f98a417 - fix two segfaults (reported by Horst Kronstorfer) 
- remove dangling file if get fails (spotted and fixed by Jason Schoon)
- shrink it (Bernhard Fischer)
Thanks, all!
   text	   data	    bss	    dec	    hex	filename
   2684	      0	      0	   2684	    a7c	networking/tftp.o.orig
   2748	      0	      0	   2748	    abc	networking/tftp.o.allfixed
   2666	      0	      0	   2666	    a6a	networking/tftp.o.+shrink
 2006-06-10 14:15:03 +00:00
Bernhard Reutner-Fischer
3b1936dcf9 - use bb_xbind 
Thanks Erik Hovland
 2006-06-10 11:39:09 +00:00
Bernhard Reutner-Fischer
1b9d7c9aa9 - use bb_msg_{read,write}_error where appropriate. 
text	   data	    bss	    dec	    hex	filename
 825015	   9100	 645216	1479331	 1692a3	busybox.old
 824919	   9100	 645216	1479235	 169243	busybox
 2006-06-03 22:45:37 +00:00
Rob Landley
299a6b4d7b Consolidate #include <sys/time.h> so libbb.h does it. 2006-05-27 21:42:58 +00:00
Bernhard Reutner-Fischer
dac7ff15b7 - patch from Denis Vlasenko to add and use bb_xsocket() and to use 
bb_xopen some more while at it.
  Also use shorter boilerplate while at it.
 2006-04-12 17:55:51 +00:00
Bernhard Reutner-Fischer
886f6afc8a - this applet should peruse USE_FEATURE_TFTP_... 2006-04-05 16:47:02 +00:00
Tim Riker
c1ef7bdd8d just whitespace 2006-01-25 00:08:53 +00:00
Rob Landley
5aabf4e415 Fix -g and -p options. Patch from Traceman. (I don't know who that is, 
it's the darn bug generator again.)
 2005-12-15 05:42:55 +00:00
"Vladimir N. Oleynik"
86ac072b44 more const, use bb_getopt_ulflags, insert XXX for show place of problems 2005-10-17 10:47:19 +00:00
Paul Fox
1d4c88c8a5 applying fix for: 
0000271: [PATCH] tftp -g fails if a TFTP_ACK is lost
 2005-07-20 19:49:15 +00:00
Rob Landley
f3133c4149 Thus spake Brenda J. Butler: 
We were seeing some timeouts when getting files with the busybox tftp
client.

With tcpdump, we saw that the tftp client was receiving blocks and
ack'ing them, but the server was failing to receive the occasional
ack.

When that happened, the server would send the last block over again,
but the tftp client was expecting the next block.

This patch allows the client to recover from this situation
(it sends an ack for the repeat block but does not write it
to the local file).

I hope it meets your approval, please don't hesitate to send
me comments for improvement.

The patch is against "head" in svn, I tested it on an older version
of busybox in our environment.  It applied cleanly to the older
version.

Credit for this goes to my co-worker John McCarthy for finding
it and me for fixing it (assuming it works for everyone else too).

cheerio,
bjb
 2005-06-07 02:40:39 +00:00
Eric Andersen
14f5c8d764 Patch from Bernhard Fischer to make a bunch of symbols static 
which were otherwise cluttering the global namespace.
 2005-04-16 19:39:00 +00:00
Glenn L McGrath
d4004ee6a9 Patch from Felipe Kellermann, remove some unnecessary dups, i declared a few extra const's also. 2004-09-14 17:24:59 +00:00
Eric Andersen
4872ed9737 Robin Farine writes: 
Hi,

Package: BusyBox
Version: 1.0.0-pre10

When an incomplete read or write from/to a local file occurs (i.e.
not an EOF condition), the tftp client prematurely exits. This
problem can be reproduced by slowly piping data to the tftp client
like this:

  (for v in 1 2 3; do echo $v; sleep 1; done) | \
  tftp -p -l - -r output.txt <host>

The output file on the TFTP server will contain "1".

The attached patch provides a possible solution to this problem.

I can reproduce this on ARM sa1110 and ARM xscale boards, both
running Linux-2.6.4 & glibc-2.3.2. Thanks for the wonderful
program!

Robin
 2004-06-22 10:18:30 +00:00
Eric Andersen
70060d25d2 s/fileno\(stdin\)/STDIN_FILENO/g 
s/fileno\(stdout\)/STDOUT_FILENO/g
 2004-03-27 10:02:48 +00:00
Eric Andersen
c7bda1ce65 Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
Glenn L McGrath
fbe984e1c9 Fix debugging output, patch by Hideki IWAMOTO 2004-03-05 13:04:39 +00:00
Glenn L McGrath
d5d5e54290 Quick fix for tftp truncation bug 2004-02-26 07:47:20 +00:00
Glenn L McGrath
d33278dea5 Patch from Hideki IWAMOTO, output debugging messages to stderr 2004-02-22 07:20:25 +00:00
Glenn L McGrath
c699778fbb Ptch by Hideki IWAMOTO, fix a bug preventing tftp from getting or 
putting more than 0xffff blocks.
 2004-02-22 03:33:53 +00:00
Glenn L McGrath
036dbaa082 Modify bb_lookup_port to allow the protocol to be specified, allowing 
/etc/services support for inetd, netcat and tftp.
 2004-01-17 05:03:31 +00:00
Eric Andersen
b99aec0ba5 Christian Meyer provided this patch to fix more bugs with the tftp client 2003-07-30 07:16:39 +00:00
Eric Andersen
05e662ab4d Patch from Christian Meyer: 
The client gives up way too soon because timeout is set to 0 ...
    There's a solution for that problem.
 2003-07-26 08:16:10 +00:00
Manuel Novoa III
cad5364599 Major coreutils update. 2003-03-19 09:13:01 +00:00
Glenn L McGrath
0f18271a8a Bugfix, wastn retrieving last block, patch by Jean-Christophe Dubois 2002-12-19 20:16:22 +00:00
Glenn L McGrath
9bf9f1edbe Forgot to rename foo 2002-12-09 21:52:29 +00:00
Glenn L McGrath
fad90db887 Fix a debug message, from Bastian Blank 2002-12-09 21:05:40 +00:00
Eric Andersen
5ad22c933c This patch from Magnus Damm fixed a long standing problem 
with freeing memory.
 2002-10-25 12:14:02 +00:00
Eric Andersen
7829b8d067 Fix for handling of "tftp -l -" from Jean Wolter <jw5@os.inf.tu-dresden.de> 2002-09-10 06:03:31 +00:00
Eric Andersen
744ec1d549 Patch from Ben Low <ben@titr.uow.edu.au> to allow tftp to work 
with stdin as well as stdout.
 2002-04-15 07:40:27 +00:00
Eric Andersen
a66a43e8ef Teach tftp to direct the fetched file to stdout when the 
user specifies "-l -"
 -Erik
 2002-04-13 09:30:25 +00:00
Eric Andersen
900c24dc4e Patch from Jeff Studer <jstuder@aquilagroup.com> to supply a defaults for 
localfilename from remotefilename, and for remotefilename from localfilename
when the other one is not supplied.
 2002-03-20 14:25:27 +00:00
Eric Andersen
744a194f53 Can't use RESERVE_CONFIG_BUFFER here since the allocation 
size varies meaning BUFFERS_GO_ON_STACK will fail
 2001-11-10 11:16:39 +00:00
Eric Andersen
bdfd0d78bc Major rework of the directory structure and the entire build system. 
-Erik
 2001-10-24 05:00:29 +00:00
Glenn L McGrath
ad117d8a21 Apply Magnus Damm's patch, adds tftp blocksize support, and some cleanups. 2001-10-05 04:40:37 +00:00
Eric Andersen
76fa8ea790 Apply Glenn's tftp rewrite 2001-08-20 17:47:49 +00:00
Matt Kraai
c55b8d41c1 Add xgethostbyname and herror_msg* functions. 2001-05-16 15:40:51 +00:00
Eric Andersen
e76c3b08e1 A number of cleanups. Now compiles with libc5, glibc, and uClibc. Fix a few 
shadowed variables.  Move (almost) all syscalls to libbb/syscalls.c, so I can
handle them sanely and all at once.
 -Erik
 2001-04-05 03:14:39 +00:00
Eric Andersen
6b2c23d847 xstrdup tftp cleanup from Jeff Garzik 2001-03-23 17:10:19 +00:00
Mark Whitley
8bb7df49c2 Applied patch from Vladimir Oleynik via Magnus Damm that removes newlines from 
error_msg() calls and uses 'return EXIT_SUCCESS' instead of return 0.
 2001-03-06 20:58:48 +00:00
Mark Whitley
450736cd3c Added Magnus Damm's tftp applet to Busybox. 2001-03-02 19:08:50 +00:00