297 Commits

Author	SHA1	Message	Date
Ron Yorston	bb983f30e7	vi: fix faulty undo after autoinsert ... Enable autoinsert and enter the following with an indent of three spaces: line 1 line 2 Using 'u' to undo the last insert results in: line1e 2 The insertion of the indent hasn't been properly recorded. Since recording insertions is a common operation add a convenience function, undo_push_insert(), to handle this and use it to record the autoindent correctly. function old new delta undo_push_insert - 36 +36 string_insert 133 129 -4 char_insert 518 473 -45 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/2 up/down: 36/-49) Total: -13 bytes Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2019-02-08 12:57:58 +01:00
Denys Vlasenko	b097a84d62	config: update size information ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-12-28 03:20:17 +01:00
Ron Yorston	d08206dce1	vi: correctly detect when a deletion empties the buffer ... Michał Berger has reported two issues: - Repeatedly deleting and undoing the deletion of the last line results in characters being lost from the end of the line. - Deleting the bottom line twice then attempting to undo each of these deletions results in a segfault. The problem seems to be an incorrect test for whether the text buffer is empty. Reported-by: Michał Berger <michallinuxstuff@gmail.com> Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-12-03 10:07:58 +01:00
Denys Vlasenko	b733046069	vi: code shrink ... function old new delta char_search 241 247 +6 get_one_address 275 272 -3 colon 2878 2875 -3 do_cmd 4726 4720 -6 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/3 up/down: 6/-12) Total: -6 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-11-29 14:39:52 +01:00
Denys Vlasenko	836d0a7ee4	vi: fix FEATURE_VI_REGEX_SEARCH to respect LIMITED (one-line) search ... If busybox is compiled with FEATURE_VI_REGEX_SEARCH enabled, command ":s/x/y/" searches not only in the current line, but continues search after it. This makes range searches (":1,3s/x/y/") work incorrect. For example file "./test": 1 2 3 $ vi ./test :1,2s/3/e/ gives us: 1 2 e function old new delta char_search 213 241 +28 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-11-29 14:19:57 +01:00
Ron Yorston	552796791f	vi: remove duplicated code ... At worst show_status_line() might be called needlessly when the user presses ^L/^R, but I don't think we'll get many complaints about that. function old new delta do_cmd 4592 4558 -34 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-34) Total: -34 bytes Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-10-31 12:51:51 +01:00
Denys Vlasenko	8825cb6660	vi: placate "warning: variable orig_buf set but not used" ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-06-27 15:11:36 +02:00
Denys Vlasenko	39043ad25e	vi: placate "warning: statement with no effect" ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-06-27 14:46:08 +02:00
Denys Vlasenko	6f97b30a90	use %m printf specifier where appropriate ... function old new delta out 85 75 -10 udhcpd_main 1472 1461 -11 open_stdio_to_tty 98 85 -13 init_exec 245 232 -13 udhcpc_main 2763 2749 -14 do_cmd 4771 4755 -16 status_line_bold_errno 32 14 -18 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-95) Total: -95 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-09-29 18:17:25 +02:00
Denys Vlasenko	0c4dbd481a	regularize format of source file headers, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-09-18 16:28:43 +02:00
Denys Vlasenko	8187e01438	*: use ESC define instead of "\033"; use ESC[m instead of ESC[0m ... text data bss dec hex filename 922535 481 6832 929848 e3038 busybox_old 922534 481 6832 929847 e3037 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-09-13 22:48:30 +02:00
Denys Vlasenko	72089cf6b4	config: deindent all help texts ... Those two spaces after tab have no effect, and always a nuisance when editing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-21 09:50:55 +02:00
Denys Vlasenko	75d151e31d	libarchive: FEATURE_LZMA_FAST should be visible if FEATURE_SEAMLESS_LZMA ... While at it, tweak some config help texts. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-20 23:28:00 +02:00
Denys Vlasenko	4eed2c6c50	Update menuconfig items with approximate applet sizes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 22:01:24 +02:00
Denys Vlasenko	0cc9b1843d	vi: survive if stdin is nonblocking. closes 9851 ... function old new delta readit 55 69 +14 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-05-02 20:39:02 +02:00
Yousong Zhou	8f3bf4f0d3	vi: avoid touching a new file with ZZ when no editing has been done ... This is the behaviour observed with standard vim and busybox vi of at least 1.22.1. It was changed with commit "32afd3a vi: some simplifications" which happened before 1.23.0. Mistyping filename on command line happens fairly often and it's better we restore the old behaviour to avoid a few unnecessary flash writes and sometimes efforts of debugging bugs caused by those unneeded stray files. Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-03-24 21:13:10 +01:00
Denys Vlasenko	e88608eae2	vi: don't touch file with :x when modified_count == 0 ... Along with it, there are other changes - Check for uppercase X is removed as the expression will be always false and :X itself is another totally different command in standard vim - The status line will show number of written lines instead of lines requested by the colon command. This is also how the standard vim is doing, though the difference is that '!' has to be explicitly specified in vim to allow partial writes Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-03-13 20:50:42 +01:00
Denys Vlasenko	eba7fe6bb9	vi,fsck: do not use build timestamp unconditionally. Closes 9626 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-29 19:14:26 +01:00
Denys Vlasenko	01ccdd1d3c	libbb: consolidate the code to set termios unbuffered mode ... function old new delta set_termios_to_raw - 116 +116 count_lines 72 74 +2 powertop_main 1458 1430 -28 top_main 943 914 -29 more_main 759 714 -45 fsck_minix_main 2969 2921 -48 conspy_main 1197 1135 -62 rawmode 99 36 -63 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/6 up/down: 118/-275) Total: -157 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-11 16:17:59 +01:00
Denys Vlasenko	f560422fa0	Big cleanup in config help and description ... Redundant help texts (one which only repeats the description) are deleted. Descriptions and help texts are trimmed. Some config options are moved, even across menus. No config option _names_ are changed. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-10 14:58:54 +01:00
Denys Vlasenko	61fcc8c781	vi: fix '' command (goto to prev context) ... The '' command in vi doesn't currently work because after the first apostrophe is read, the next character is converted to an integer between 0 and 25 inclusive (for indexing the array of marks). The comparison of the converted character with an apostrophe therefore never succeeds, meaning that '' doesn't do anything. Based on the patch by Francis Rounds <francis.rounds@4bridgeworks.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-28 16:23:05 +02:00
Denys Vlasenko	de1996dac5	vi: make "g<key>" error message less likely to show garbage ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-15 13:53:42 +02:00
Denys Vlasenko	3e134ebf6a	*: slap on a few ALIGN1/2s where appropriate ... The result of looking at "grep -F -B2 '*fill*' busybox_unstripped.map" text data bss dec hex filename 829901 4086 1904 835891 cc133 busybox_before 829665 4086 1904 835655 cc047 busybox Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-22 18:09:21 +02:00
Denys Vlasenko	7f3a2a2256	join some common strings, -400 bytes ... function old new delta print_intel_cstates 499 511 +12 file_insert 355 364 +9 dpkg_main 2944 2940 -4 ifenslave_main 645 640 -5 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/2 up/down: 21/-9) Total: 12 bytes text data bss dec hex filename 937564 932 17676 956172 e970c busybox_old 937164 932 17676 955772 e957c busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-08 11:24:44 +02:00
Maninder Singh	97f2f7ca7f	Removes stray empty line from code ... This patch removes stray empty line from busybox code reported by script find_stray_empty_lines Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-07-13 03:25:46 +02:00
Maninder Singh	97c6491b4e	typo fixes ... Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-05-25 13:46:36 +02:00
Andrew Fuller	4d8ddb810d	vi: basic undo feature shouldn't depend on yankmark ... Currently basic undo functionality with the 'u' key depends on FEATURE_VI_YANKMARK. These two features are separate, so we can remove this dependency. Signed-off-by: Andrew Fuller <abf@google.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-05-03 18:18:25 +02:00
Denys Vlasenko	49acc1a761	vi: make BACKSPACE and DELETE join lines at start/end of line ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-03-12 21:15:34 +01:00
Ron Yorston	70f4320b40	vi: fix reading of file after last line ... If the :r command is used to read a file after the last line of the buffer the last line of the buffer and the first line of the file are joined. An extra blank line appears at the end of the buffer. file 1 file 1 file 1file 2 file 2 file 2 ~ ~ The insertion point is normally at the start of the line following the specified line. When the specified line is the last one the next_line function baulks at moving to the non-existent following line. Signed-off-by: Ron Yorston <rmy@tigress.co.uk> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-01-07 18:23:29 +01:00
Ron Yorston	e5213cee38	vi: failure to open file is not an error when initialising buffer ... Commit 32afd3a introduced these regressions on the master branch: Starting vi with no filename on the command line gives the status message "'(null)' Bad address" instead of "- No file 1/1 100%". Starting vi with a non-existent file on the command line gives the status message "'new.txt' No such file or directory" instead of "- new.txt 1/1 100%" Signed-off-by: Ron Yorston <rmy@tigress.co.uk> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-01-07 17:00:48 +01:00
Denys Vlasenko	05399fc53d	vi: fix incorrect memory access on brace matching. Closes 7256 ... While at it, fix brace matching to actually show the match (missed fflush was causing cursor positioning to be buffered); shorten brace matching code; remove unused macro indirection in indicate_error(). Custom linker script 'busybox_ldscript' found, using it function old new delta indicate_error - 61 +61 mysleep 43 56 +13 char_insert 483 486 +3 find_pair 167 124 -43 Indicate_Error 61 - -61 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 2/1 up/down: 77/-104) Total: -27 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-09-15 17:06:10 +02:00
Denys Vlasenko	32afd3aa60	vi: some simplifications ... function old new delta file_insert 301 315 +14 init_text_buffer 179 171 -8 colon 2889 2878 -11 file_size 37 - -37 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 1/2 up/down: 14/-56) Total: -42 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-04-05 22:57:46 +02:00
Denys Vlasenko	e7430867a8	vi: clear undo buffer when we change to another file ... function old new delta init_text_buffer 156 190 +34 undo_push 360 382 +22 count_lines 74 72 -2 undo_pop 246 222 -24 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/2 up/down: 56/-26) Total: 30 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-04-03 12:47:48 +02:00
Denys Vlasenko	2c51202aec	vi: undo code shrink ... function old new delta undo_push 414 395 -19 do_cmd 4803 4761 -42 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-04-03 01:45:05 +02:00
Jody Bruchon	a8d6f9bee4	vi: undo support for vi with intermediate queuing ... function old new delta undo_push - 411 +411 undo_pop - 288 +288 do_cmd 4160 4426 +266 char_insert 363 483 +120 undo_queue_commit - 61 +61 text_hole_delete 108 163 +55 string_insert 94 127 +33 colon 2864 2882 +18 yank_delete 92 101 +9 vi_main 273 280 +7 dot_scroll 88 93 +5 dot_right 29 34 +5 dot_prev 20 25 +5 dot_next 20 25 +5 dot_left 24 29 +5 dot_end 20 25 +5 dot_begin 20 25 +5 init_text_buffer 154 156 +2 text_hole_make 145 142 -3 file_insert 333 318 -15 ------------------------------------------------------------------------------ (add/remove: 3/0 grow/shrink: 15/2 up/down: 1305/-18) Total: 1287 bytes (without queuing it's ~870 bytes) Signed-off-by: Jody Bruchon <jody@jodybruchon.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-04-02 13:49:26 +02:00
Denys Vlasenko	264f37363d	vi: make regexp search case-insensitive if ":set ignorecase" is active ... Reported by Dan Moinescu <dan@moinescu.net>. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-04-21 15:51:41 +02:00
Denys Vlasenko	9e7c002182	vi: code shrink ... function old new delta status_line_bold_errno - 32 +32 colon 2891 2873 -18 file_insert 354 313 -41 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/2 up/down: 32/-59) Total: -27 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-15 02:17:29 +01:00
Ron Yorston	cb5aa725df	vi: fix adjustment of buffer on partial file read ... The second argument to text_hole_delete was incorrect: it should be a pointer to the end of the hole. Signed-off-by: Ron Yorston <rmy@tigress.co.uk> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-03-15 02:10:07 +01:00
Denys Vlasenko	778794d1dd	*: reuse more strings ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-22 10:13:52 +01:00
Denys Vlasenko	6830ade6aa	whitespace fixes. no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-15 13:58:01 +01:00
Denys Vlasenko	60cb48ca50	whitespace cleanup. no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2013-01-14 15:57:44 +01:00
Denys Vlasenko	d3dff879f0	vi: save/restore screen upon invocation ... function old new delta vi_main 253 273 +20 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-06-11 13:53:26 +02:00
Denys Vlasenko	04b52892ed	vi: nuke FEATURE_VI_OPTIMIZE_CURSOR ... It is not Unicode safe, it is not saving much of I/O, and it's large: function old new delta vi_main 255 253 -2 go_bottom_and_clear_to_eol 28 26 -2 do_cmd 4194 4182 -12 show_status_line 388 374 -14 strncat 39 - -39 __GI_strncat 39 - -39 refresh 774 724 -50 place_cursor 276 83 -193 ------------------------------------------------------------------------------ (add/remove: 0/3 grow/shrink: 0/6 up/down: 0/-351) Total: -351 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-06-11 13:51:38 +02:00
Denys Vlasenko	605f2641d8	vi: do not set autoindent by default ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-06-11 01:53:33 +02:00
Dennis Groenen	c0657e0d0a	vi: add ":prev" command support ... function old new delta colon 2844 2891 +47 vi_main 243 255 +12 text_yank 54 56 +2 refresh 780 774 -6 Signed-off-by: Dennis Groenen <tj.groenen@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-01-31 14:12:38 +01:00
Denys Vlasenko	800a9a056a	vi: move mark[i] pointers if text[] moves after realloc ... While at it, optimized :s/find/repl/ a bit function old new delta text_hole_make 120 150 +30 colon 2848 2844 -4 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-01-31 14:10:26 +01:00
Denys Vlasenko	6e8861b5f1	*: better comments on termios manipulations. No code changes. ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-01-15 23:00:13 +01:00
Denys Vlasenko	1fd7129bc6	vi: fix [end] key handling ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-11-28 04:55:48 +01:00
Denys Vlasenko	12e154f0cf	vi: prevent unlimited recursion in do_cmd(). Closes 4153 ... function old new delta do_cmd 4284 4194 -90 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-09-09 12:35:49 +02:00
Denys Vlasenko	4e552a70ec	less: optionally query terminal size via "ESC [ 6 n". Closes bug 2659. ... +7 bytes is not selected, +100 if selected. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-07-25 15:18:20 +02:00
Denys Vlasenko	066f399566	vi: tweak regex.h include ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-07-03 03:19:43 +02:00
Walter Harms	b9ba580917	vi: fix regex search, make it selectable in config ... function old new delta char_search 134 214 +80 find_pair 187 169 -18 mycmp 37 - -37 Signed-off-by: Walter Harms <wharms@bfs.de> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-06-27 02:59:37 +02:00
Denys Vlasenko	66426760be	*: remove "Options:" string from help texts ... function old new delta packed_usage 28706 28623 -83 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-06-05 03:58:28 +02:00
Cristian Ionescu-Idbohrn	9a296fbeab	vi.c: remove warning: variable 'sp' set but not used ... Signed-off-by: Cristian Ionescu-Idbohrn <cii@axis.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-16 03:53:43 +02:00
Denys Vlasenko	60a9414cad	fix "variable 'foo' set but not used" warnings ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-05-13 20:57:01 +02:00
Pere Orga	6a3e01d5a9	move help text from include/usage.src.h to debianutils/*.c e2fsprogs/*.c editors/*.c loginutils/*.c mailutils/*.c ... Signed-off-by: Pere Orga <gotrunks@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-04-03 01:33:55 +02:00
Denys Vlasenko	0ef64bdb40	*: make GNU licensing statement forms more regular ... This change retains "or later" state! No licensing _changes_ here, only form is adjusted (article, space between "GPL" and "v2" and so on). Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-08-16 20:14:46 +02:00
Denys Vlasenko	c5fb0ada9b	vi: fix "ask terminal" code ... function old new delta edit_file 761 793 +32 refresh 773 780 +7 query_screen_dimensions 63 54 -9 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-07-21 12:39:42 +02:00
Denys Vlasenko	243d1757d7	remove some dead assignments, add a TODO comment ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-07-04 04:26:55 +02:00
Denys Vlasenko	9f82d0be61	vi: fix "set ic" command; code shrink while at it. closes bug 1765 ... function old new delta colon 2970 2848 -122 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-05-19 01:54:37 +02:00
Denys Vlasenko	d9a3e89f50	consolidate ESC sequences ... function old new delta bell 2 - -2 CMdown 2 - -2 Ceos 4 - -4 Ceol 4 - -4 CMup 4 - -4 SOs 5 - -5 SOn 5 - -5 CMrc 9 - -9 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-05-16 23:42:13 +02:00
Denys Vlasenko	94043e8ad2	lineedit: change how cmdedit_set_out_char works ... Rename two badly names functions, use "clear to end of screen" to eliminate annoying problems with clearing wide/combining chars, and such. Run tested. function old new delta put_cur_glyph_and_inc_cursor - 124 +124 put_till_end_and_adv_cursor - 24 +24 input_delete 125 130 +5 Ceos 5 4 -1 Ceol 5 4 -1 input_end 24 - -24 cmdedit_set_out_char 122 - -122 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 1/2 up/down: 153/-148) Total: 5 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-05-11 14:49:13 +02:00
Denys Vlasenko	c175c46647	vi: discover window size even on serial consoles. optional ... function old new delta edit_file 671 761 +90 wh_helper - 57 +57 query_screen_dimensions 54 63 +9 ar_main 533 542 +9 refresh 767 773 +6 vi_main 242 243 +1 text_yank 56 54 -2 get_terminal_width_height 180 135 -45 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 5/2 up/down: 172/-47) Total: 125 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-04-18 22:09:30 -07:00
Denys Vlasenko	def4783a8a	vi: remove superfluous check on filename == "" ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-04-18 20:39:41 -07:00
Denys Vlasenko	04cecd5e61	vi: code shrink ... function old new delta vi_main 250 242 -8 colon 2980 2970 -10 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-18) Total: -18 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-04-16 22:13:55 -07:00
Denys Vlasenko	2bb651ae10	vi: code shrink; save/restore errno in signal handlers ... function old new delta query_screen_dimensions - 54 +54 suspend_sig 50 64 +14 cont_sig 65 66 +1 catch_sig 42 32 -10 winch_sig 88 60 -28 edit_file 719 671 -48 refresh 848 767 -81 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 2/4 up/down: 69/-167) Total: -98 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-04-16 20:55:52 -07:00
Denys Vlasenko	35fdb1bc9c	vi: fix NUM + "$" handling ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-03-26 16:10:14 +01:00
Denys Vlasenko	58f108eb33	lineedit: fix another corner case with bad unicode input ... function old new delta read_key 607 646 +39 readit 50 55 +5 getch_nowait 290 295 +5 hash_find 233 234 +1 xstrtoul_range_sfx 231 230 -1 passwd_main 1058 1056 -2 builtin_exit 45 43 -2 cmp_main 649 645 -4 lineedit_read_key 257 245 -12 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/5 up/down: 50/-21) Total: 29 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-03-11 21:17:55 +01:00
Denys Vlasenko	6b9f163353	*: style fixes. no code changes (verified with objdump) ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-01-28 02:24:24 +01:00
Denys Vlasenko	c270454f8f	fix fallout from isprint() changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-11-20 19:14:19 +01:00
Denys Vlasenko	8684cbb5cc	libbb: robustify isXXXX(). +39 bytes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-11-18 11:34:43 +01:00
Denys Vlasenko	6331cf059c	*: use "can't" instead of "cannot" ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-11-13 09:08:27 +01:00
Denys Vlasenko	8131eea3dc	*: introduce and use ffulsh_all() ... function old new delta buffer_fill_and_print 179 196 +17 fflush_all - 9 +9 spawn 87 92 +5 rtcwake_main 455 453 -2 ... alarm_intr 93 84 -9 readcmd 1072 1062 -10 bb_ask 345 333 -12 more_main 845 832 -13 flush_stdout_stderr 42 23 -19 xfflush_stdout 27 - -27 flush_stderr 30 - -30 ------------------------------------------------------------------------------ (add/remove: 1/2 grow/shrink: 2/50 up/down: 31/-397) Total: -366 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-11-02 14:19:51 +01:00
Denys Vlasenko	c0dab37d0a	*: remove last function calls to isspace ... function old new delta xstrtoul_range_sfx 232 231 -1 xstrtoull_range_sfx 295 293 -2 trim 82 80 -2 trim_trailing_spaces_and_print 57 52 -5 isspace 18 - -18 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-10-22 22:28:08 +02:00
Denys Vlasenko	adf922ec28	*: a few more NOINLINEs ... function old new delta print_linkinfo - 815 +815 do_msg - 783 +783 INET_setroute - 757 +757 varvalue - 746 +746 do_sem - 637 +637 inflate_codes - 617 +617 INET6_setroute - 491 +491 edir - 370 +370 sync_cursor - 298 +298 update_utmp - 246 +246 searchLines - 165 +165 setup_alarm - 144 +144 may_wakeup - 101 +101 getNum 566 371 -195 refresh 1166 848 -318 rtcwake_main 809 479 -330 getty_main 2396 1921 -475 chpst_main 1373 746 -627 inflate_unzip_internal 1335 567 -768 evalvar 1384 612 -772 ipaddr_list_or_flush 2160 1246 -914 route_main 1585 245 -1340 ipcs_main 2523 1049 -1474 ------------------------------------------------------------------------------ (add/remove: 13/0 grow/shrink: 0/10 up/down: 6170/-7213) Total: -1043 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-10-08 14:35:37 +02:00
Denys Vlasenko	606291beab	*: more portability fixes by Dan Fandrich ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-09-23 23:15:43 +02:00
Denys Vlasenko	b22bbfffec	fix dependencies of FEATURE_GETOPT_LONG ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-07-04 16:50:43 +02:00
Denys Vlasenko	6548edd430	vi: do not accept uppercase comments (compat). Closes bug 397. ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-06-15 12:44:11 +02:00
Denys Vlasenko	020f40693a	line editing: add an option to emit ESC [ 6 n and use results ... This makes line editing able to recognize case when cursor was not at the beginning of the line. It may also be adapted later to find out display size (serial line users would love it). Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-17 16:44:54 +02:00
Denis Vlasenko	5e34ff29bc	*: mass renaming of USE_XXXX to IF_XXXX ... and SKIP_XXXX to IF_NOT_XXXX - the second one was especially badly named. It was not skipping anything!	2009-04-21 11:09:40 +00:00
Denis Vlasenko	3266aa9ec2	trailing whitespace removal	2009-04-01 11:24:04 +00:00
Denis Vlasenko	00d8417631	vi: speedup and code shrink (Walter Harms) ... networking/interface.c: silence warning (Vladimir) wget: more robust EINTR detection	2008-11-24 07:34:42 +00:00
Denis Vlasenko	4ae1e13d3f	vi: fix several instances of major goof: when text grows, text[] ... might get reallocated! We were keeping around pointers to old place... function old new delta colon 3017 3037 +20 char_insert 336 354 +18 stupid_insert 18 24 +6 string_insert 89 94 +5 do_cmd 4461 4465 +4 file_insert 328 329 +1 text_hole_make 134 120 -14 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 6/1 up/down: 54/-14) Total: 40 bytes	2008-11-19 13:25:14 +00:00
Denis Vlasenko	202ac504e1	*: code shrink by adding a wrapper around very common tcsetattr(0, TCSANOW, xx) op ... function old new delta tcsetattr_stdin_TCSANOW - 14 +14 set_sane_term 116 113 -3 top_main 1277 1273 -4 make_new_session 421 415 -6 rawmode 133 126 -7 reset_term 18 10 -8 die 43 35 -8 cookmode 62 54 -8 vlock_main 425 415 -10 read_line_input 3165 3155 -10 bb_askpass 357 347 -10 fsck_minix_main 3079 3065 -14 getty_main 2375 2332 -43 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/12 up/down: 14/-131) Total: -117 bytes	2008-11-05 13:20:58 +00:00
Denis Vlasenko	31d58e58d2	randomconfig fixes	2008-10-29 13:16:28 +00:00
Denis Vlasenko	c3a9dc8ac5	vi: fix uninitialized last_search_pattern (bug 5794)	2008-10-29 00:58:04 +00:00
Denis Vlasenko	5f6aaf39cf	less: reuse former vi's key reading code. Improve SIGWINCH handling. ... function old new delta less_main 2056 2097 +41 getch_nowait 248 273 +25 read_key 310 321 +11 static.esccmds 61 69 +8 count_lines 72 74 +2 less_gets 166 142 -24 less_getch 172 43 -129 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 6/5 up/down: 91/-170) Total: -79 bytes text data bss dec hex filename	2008-10-25 23:27:29 +00:00
Denis Vlasenko	0112ff5203	vi: move key reading routine out of vi into llbbb ... function old new delta read_key - 310 +310 .... static.esccmds 170 61 -109 readit 286 60 -226 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 9/10 up/down: 349/-367) Total: -18 bytes	2008-10-25 23:23:00 +00:00
Denis Vlasenko	4c9e9c4314	vi: handle chars 0x80, 0x81... correctly	2008-10-20 08:59:03 +00:00
Rob Landley	4bdeaaf556	Comment and whitespace tweaks.	2008-10-19 04:21:21 +00:00
Denis Vlasenko	e3742f4217	vi: explain why reading 4 chars is unsafe	2008-10-18 19:37:41 +00:00
Denis Vlasenko	1dfeeeb651	vi: whitespace fix	2008-10-18 19:04:37 +00:00
Denis Vlasenko	8ef801b40c	vi: a few trivial optimizations to keyboard reading code; bump timeout to 50s. ... function old new delta edit_file 901 912 +11 count_lines 74 72 -2 readit 306 289 -17 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/2 up/down: 11/-19) Total: -8 bytes	2008-10-16 09:46:07 +00:00
Rob Landley	7960ea8918	Confirmed that on Linux the serial interrupt takes precedence over the timer ... interrupt, so we don't need to worry about scheduler delays. This means the delay can be trimmed down to 25 miliseconds. Add comment while at it.	2008-10-16 06:34:10 +00:00
Denis Vlasenko	d44c1535ae	vi: fix bizarre formatting. no code changes	2008-10-14 12:59:42 +00:00
Denis Vlasenko	ded6ad34ed	fix recurring "last_cmd overrun", fix [del] handling in insert mode	2008-10-14 12:26:30 +00:00
Denis Vlasenko	267e16c74a	vi: trivial size optimization -65 bytes	2008-10-14 10:34:41 +00:00
Denis Vlasenko	25497c1d92	vi: reinstate timeout of 300 ms	2008-10-14 10:25:05 +00:00
Denis Vlasenko	5373fbcd11	vi: add comments to Rob's algorithm of reading and matching ESC sequences ... (nice work btw!)	2008-10-14 10:09:56 +00:00
Rob Landley	5e38cd910a	Escape sequences sent over serial links don't come in as a block, so poll ... needs to pause a bit to make sure the next character has time to come in.	2008-10-14 08:44:09 +00:00