146 Commits

Author	SHA1	Message	Date
James Byrne	253c4e787a	Optionally re-introduce bb_info_msg() ... Between Busybox 1.24.2 and 1.25.0 the bb_info_msg() function was eliminated and calls to it changed to be bb_error_msg(). The downside of this is that daemons now log all messages to syslog at the LOG_ERR level which makes it hard to filter errors from informational messages. This change optionally re-introduces bb_info_msg(), controlled by a new option FEATURE_SYSLOG_INFO, restores all the calls to bb_info_msg() that were removed (only in applets that set logmode to LOGMODE_SYSLOG or LOGMODE_BOTH), and also changes informational messages in ifplugd and ntpd. The code size change of this is as follows (using 'defconfig' on x86_64 with gcc 7.3.0-27ubuntu1~18.04) function old new delta bb_info_msg - 182 +182 bb_vinfo_msg - 27 +27 static.log7 194 198 +4 log8 190 191 +1 log5 190 191 +1 crondlog 45 - -45 ------------------------------------------------------------------------------ (add/remove: 2/1 grow/shrink: 3/0 up/down: 215/-45) Total: 170 bytes If you don't care about everything being logged at LOG_ERR level then when FEATURE_SYSLOG_INFO is disabled Busybox actually gets smaller: function old new delta static.log7 194 200 +6 log8 190 193 +3 log5 190 193 +3 syslog_level 1 - -1 bb_verror_msg 583 581 -2 crondlog 45 - -45 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 3/1 up/down: 12/-48) Total: -36 bytes Signed-off-by: James Byrne <james.byrne@origamienergy.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2019-04-30 10:51:27 +02:00
Denys Vlasenko	b86b39bfda	config: more tweaks ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-12-28 17:52:43 +01:00
Denys Vlasenko	b097a84d62	config: update size information ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-12-28 03:20:17 +01:00
Denys Vlasenko	82d1c1f84a	randomconfig fixes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-12-31 17:30:02 +01:00
Denys Vlasenko	22542eca18	getopt32: remove opt_complementary ... function old new delta vgetopt32 1318 1392 +74 runsvdir_main 703 713 +10 bb_make_directory 423 425 +2 collect_cpu 546 545 -1 opt_chars 3 - -3 opt_complementary 4 - -4 tftpd_main 567 562 -5 ntp_init 476 471 -5 zcip_main 1266 1256 -10 xxd_main 428 418 -10 whois_main 140 130 -10 who_main 463 453 -10 which_main 212 202 -10 wget_main 2535 2525 -10 watchdog_main 291 281 -10 watch_main 222 212 -10 vlock_main 399 389 -10 uuencode_main 332 322 -10 uudecode_main 316 306 -10 unlink_main 45 35 -10 udhcpd_main 1482 1472 -10 udhcpc_main 2762 2752 -10 tune2fs_main 290 280 -10 tunctl_main 366 356 -10 truncate_main 218 208 -10 tr_main 518 508 -10 time_main 1134 1124 -10 tftp_main 286 276 -10 telnetd_main 1873 1863 -10 tcpudpsvd_main 1785 1775 -10 taskset_main 521 511 -10 tar_main 1009 999 -10 tail_main 1644 1634 -10 syslogd_main 1967 1957 -10 switch_root_main 368 358 -10 svlogd_main 1454 1444 -10 sv 1296 1286 -10 stat_main 104 94 -10 start_stop_daemon_main 1028 1018 -10 split_main 542 532 -10 sort_main 796 786 -10 slattach_main 624 614 -10 shuf_main 504 494 -10 setsid_main 96 86 -10 setserial_main 1132 1122 -10 setfont_main 388 378 -10 setconsole_main 78 68 -10 sendmail_main 1209 1199 -10 sed_main 677 667 -10 script_main 1077 1067 -10 run_parts_main 325 315 -10 rtcwake_main 454 444 -10 rm_main 175 165 -10 reformime_main 119 109 -10 readlink_main 123 113 -10 rdate_main 246 236 -10 pwdx_main 189 179 -10 pstree_main 317 307 -10 pscan_main 663 653 -10 popmaildir_main 818 808 -10 pmap_main 80 70 -10 nc_main 1042 1032 -10 mv_main 558 548 -10 mountpoint_main 477 467 -10 mount_main 1264 1254 -10 modprobe_main 768 758 -10 modinfo_main 333 323 -10 mktemp_main 200 190 -10 mkswap_main 324 314 -10 mkfs_vfat_main 1489 1479 -10 microcom_main 715 705 -10 md5_sha1_sum_main 521 511 -10 man_main 867 857 -10 makedevs_main 1052 1042 -10 ls_main 563 553 -10 losetup_main 432 422 -10 loadfont_main 89 79 -10 ln_main 524 514 -10 link_main 75 65 -10 ipcalc_main 544 534 -10 iostat_main 2397 2387 -10 install_main 768 758 -10 id_main 480 470 -10 i2cset_main 1239 1229 -10 i2cget_main 380 370 -10 i2cdump_main 1482 1472 -10 i2cdetect_main 682 672 -10 hwclock_main 406 396 -10 httpd_main 741 731 -10 grep_main 837 827 -10 getty_main 1559 1549 -10 fuser_main 297 287 -10 ftpgetput_main 345 335 -10 ftpd_main 2232 2222 -10 fstrim_main 251 241 -10 fsfreeze_main 77 67 -10 fsck_minix_main 2921 2911 -10 flock_main 314 304 -10 flashcp_main 740 730 -10 flash_eraseall_main 833 823 -10 fdformat_main 532 522 -10 expand_main 680 670 -10 eject_main 335 325 -10 dumpleases_main 630 620 -10 du_main 314 304 -10 dos2unix_main 441 431 -10 diff_main 1350 1340 -10 df_main 1064 1054 -10 date_main 1095 1085 -10 cut_main 961 951 -10 cryptpw_main 228 218 -10 crontab_main 575 565 -10 crond_main 1149 1139 -10 cp_main 370 360 -10 common_traceroute_main 3834 3824 -10 common_ping_main 1767 1757 -10 comm_main 239 229 -10 cmp_main 655 645 -10 chrt_main 379 369 -10 chpst_main 704 694 -10 chpasswd_main 308 298 -10 chown_main 171 161 -10 chmod_main 158 148 -10 cat_main 428 418 -10 bzip2_main 120 110 -10 blkdiscard_main 264 254 -10 base64_main 221 211 -10 arping_main 1665 1655 -10 ar_main 556 546 -10 adjtimex_main 406 396 -10 adduser_main 882 872 -10 addgroup_main 411 401 -10 acpid_main 1198 1188 -10 optstring 11 - -11 opt_string 18 - -18 OPT_STR 25 - -25 ubi_tools_main 1288 1258 -30 ls_options 31 - -31 ------------------------------------------------------------------------------ (add/remove: 0/6 grow/shrink: 3/129 up/down: 86/-1383) Total: -1297 bytes text data bss dec hex filename 915428 485 6876 922789 e14a5 busybox_old 914629 485 6872 921986 e1182 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-08 21:55:02 +02:00
Denys Vlasenko	68b653b66b	config: trim/improve item names and help texts, take 2 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-27 10:53:09 +02:00
Denys Vlasenko	72089cf6b4	config: deindent all help texts ... Those two spaces after tab have no effect, and always a nuisance when editing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-21 09:50:55 +02:00
Denys Vlasenko	4eed2c6c50	Update menuconfig items with approximate applet sizes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 22:01:24 +02:00
Denys Vlasenko	f560422fa0	Big cleanup in config help and description ... Redundant help texts (one which only repeats the description) are deleted. Descriptions and help texts are trimmed. Some config options are moved, even across menus. No config option _names_ are changed. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-10 14:58:54 +01:00
Denys Vlasenko	47367e1d50	Convert all networking/* applets to "new style" applet definitions ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-23 09:05:14 +01:00
Denys Vlasenko	47cfbf32fd	*: add most of the required setup_common_bufsiz() calls ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-21 18:18:48 +02:00
Denys Vlasenko	e6a2f4cc5a	libbb: make bb_common_bufsiz1 1 kbyte, add capability to use bss tail for it ... The config item is FEATURE_USE_BSS_TAIL. When it is off (default): function old new delta read_config 210 228 +18 doCommands 2279 2294 +15 ipneigh_list_or_flush 763 772 +9 ipaddr_list_or_flush 1256 1261 +5 display_process_list 1301 1306 +5 conspy_main 1378 1383 +5 do_lzo_compress 352 355 +3 do_lzo_decompress 565 567 +2 push 46 44 -2 inetd_main 2136 2134 -2 uevent_main 421 418 -3 addLines 97 92 -5 bb_common_bufsiz1 8193 1024 -7169 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 8/5 up/down: 62/-7181) Total: -7119 bytes text data bss dec hex filename 829850 4086 9080 843016 cdd08 busybox_old 829901 4086 1904 835891 cc133 busybox_unstripped FEATURE_USE_BSS_TAIL=y: read_config 210 228 +18 doCommands 2279 2294 +15 ipneigh_list_or_flush 763 772 +9 ipaddr_list_or_flush 1256 1261 +5 display_process_list 1301 1306 +5 conspy_main 1378 1383 +5 do_lzo_compress 352 355 +3 do_lzo_decompress 565 567 +2 inetd_main 2136 2134 -2 bb_common_bufsiz1 8193 - -8193 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 8/1 up/down: 62/-8195) Total: -8133 bytes text data bss dec hex filename 829850 4086 9080 843016 cdd08 busybox_old 829911 4086 880 834877 cbd3d busybox_unstripped FIXME: setup_common_bufsiz() calls are missing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-21 17:39:11 +02:00
Denys Vlasenko	ab3964db4e	libbb: introduce kernel-style BUILD_BUG_ON() ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-13 14:50:20 +02:00
Maninder Singh	97f2f7ca7f	Removes stray empty line from code ... This patch removes stray empty line from busybox code reported by script find_stray_empty_lines Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-07-13 03:25:46 +02:00
Denys Vlasenko	4eb1e425fe	tftpd: tweak HP PA-RISC firmware bug compatibility ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-09-04 12:24:03 +02:00
Denys Vlasenko	67e01fecce	tftpd: support full 512-byte requests ... Some HP PA-RISC firmware always sends fixed 512-byte requests, with trailing garbage. function old new delta tftpd_main 578 572 -6 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2014-09-03 18:35:38 +02:00
Denys Vlasenko	dbed6c4b46	tftpd: fix -u USER to work with chroot. Closes 5348 ... function old new delta tftpd_main 546 568 +22 tftp_protocol 1844 1839 -5 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-07-18 17:32:32 +02:00
Denys Vlasenko	4e3beb2e1d	tftpd: chroot to DIR, not merely chdir. Closes 4874 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2012-03-08 00:28:52 +01:00
Denys Vlasenko	faf7c62f1d	tftp: mode string is case independent ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-10-06 17:19:09 +02:00
Denys Vlasenko	66426760be	*: remove "Options:" string from help texts ... function old new delta packed_usage 28706 28623 -83 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-06-05 03:58:28 +02:00
Denys Vlasenko	88d3cfdb75	add forgotten #include ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-04-11 05:24:58 +02:00
Denys Vlasenko	532e961f7e	tftpd: add -l "log to syslog" option. Needed for inetd mode ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-04-11 05:12:53 +02:00
Denys Vlasenko	24ec952f14	tftp: fix progress bar for large (>32M) files. Closes 3499 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-04-11 04:29:39 +02:00
Pere Orga	5bc8c005a8	move remaining help text from include/usage.src.h ... Signed-off-by: Pere Orga <gotrunks@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-04-11 03:29:49 +02:00
Denys Vlasenko	ab8d00d64f	progress meter: fix bugs found in stall detection and unknown size logic ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-02-11 19:09:30 +01:00
Denys Vlasenko	d55e139649	progress meter: move file name to bb_progress_t. +20 bytes ... We were doing expensive unicode conversion on every update Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2011-02-11 18:56:13 +01:00
Denys Vlasenko	84dba9c5bb	tftp: fix bad interaction betweel poll() and alarm(). Closes bug 3061 ... This was breaking timeout handling. function old new delta tftp_progress_update - 45 +45 tftp_progress_done - 32 +32 tftp_protocol 1839 1858 +19 tftp_progress_init 9 15 +6 tftp_main 298 286 -12 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 2/1 up/down: 102/-12) Total: 90 bytes Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>	2011-01-10 12:51:44 +01:00
Denys Vlasenko	e4dcba1c10	*: whitespace fixes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-10-28 18:57:19 +02:00
Denys Vlasenko	0ef64bdb40	*: make GNU licensing statement forms more regular ... This change retains "or later" state! No licensing _changes_ here, only form is adjusted (article, space between "GPL" and "v2" and so on). Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-08-16 20:14:46 +02:00
Denys Vlasenko	5b1dfe609c	tftp: increase initial retry timeout from 50 to 100 ms ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-06-18 02:47:27 +02:00
Denys Vlasenko	53e2f38b69	tftp: make message about 512 byte block less confusing ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-06-12 03:29:58 +02:00
Denys Vlasenko	19ced5c425	pipe_progress: make it independent of printf machinery ... function old new delta bb_putchar_stderr - 24 +24 ParseField 494 471 -23 progress_meter 212 188 -24 xargs_main 888 842 -46 pipe_progress_main 151 105 -46 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 0/4 up/down: 24/-139) Total: -115 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-06-06 21:53:09 +02:00
Denys Vlasenko	cbcc1236f8	tftp: do not show progress bar if we get error right away. +13 bytes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-03-05 23:38:54 +01:00
Denys Vlasenko	98a4c7cf3d	*: suppress ~60% of "aliased warnings" on gcc-4.4.1 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-02-04 15:00:15 +01:00
Denys Vlasenko	4b061461d3	tftpd: fix file creation with bogus mode. Closes bug 1021. ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2010-02-02 01:01:40 +01:00
Denys Vlasenko	31e2e7b863	randomconfig fixes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-12-12 02:42:35 +01:00
Denys Vlasenko	6528abeb6a	tftpd: another small tweak ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-11-08 18:27:18 +01:00
Denys Vlasenko	1e9ac9f685	tftp: another small tweak ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-11-08 18:15:10 +01:00
Denys Vlasenko	adc08ef194	tftpd: slight correction to progress bar code ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-11-08 18:07:36 +01:00
Magnus Damm	8bd0af9962	tftp: add optiona support for progress bar ... function old new delta tftp_protocol 1662 1834 +172 progress_meter 212 365 +153 tftp_progress_init - 14 +14 tftp_main 276 281 +5 tftpd_main 513 500 -13 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/1 up/down: 344/-13) Total: 331 bytes Signed-off-by: Magnus Damm <magnus.damm@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-11-08 18:03:09 +01:00
Magnus Damm	bbd423530f	tftp: extend tsize support a little ... function old new delta tftp_protocol 1624 1662 +38 tftpd_main 495 513 +18 tftp_main 274 276 +2 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/0 up/down: 58/0) Total: 58 bytes Signed-off-by: Magnus Damm <magnus.damm@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-11-08 18:02:53 +01:00
Denys Vlasenko	0939f2ebd2	fix up potential printf's with unsafe format strings ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-10-24 17:47:56 +02:00
Denys Vlasenko	5370bfb123	documentation and typo fixes. By Dan Fandrich (dan AT coneharvesters.com) ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-09-06 02:58:59 +02:00
Denys Vlasenko	bac9f03ed8	tftp: add comment, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-07-25 01:56:23 +02:00
Atsushi Nemoto	330d898e99	tftp[d]: fix block# handling on upload with non-default blocksize ... function old new delta tftp_protocol 1590 1618 +28 Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-07-24 22:34:47 +02:00
Denys Vlasenko	c8ab67cad8	tftp: do not risk invoking Sorcerer's Apprentice syndrome ... examples/udhcp/simple.script: fix incorrect test for $1 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2009-05-10 23:27:43 +02:00
Denis Vlasenko	5e34ff29bc	*: mass renaming of USE_XXXX to IF_XXXX ... and SKIP_XXXX to IF_NOT_XXXX - the second one was especially badly named. It was not skipping anything!	2009-04-21 11:09:40 +00:00
Denis Vlasenko	f9beb61a81	tftp: when we infer local name from remote (-r [/]path/path/file), ... strip path. This mimics wget and is generally more intuitive.	2009-03-25 03:55:53 +00:00
Denis Vlasenko	73c571a5ff	*: move get_sock_lsa and xwrite_str to libbb, use where appropriate ... function old new delta get_sock_lsa - 72 +72 buffer_fill_and_print 179 196 +17 parse_expr 824 832 +8 read_base64 343 348 +5 nameval 202 206 +4 fbset_main 1694 1698 +4 expand 1849 1853 +4 udhcp_send_kernel_packet 249 252 +3 udhcp_get_option 223 222 -1 chat_main 1246 1245 -1 pack_gzip 1661 1659 -2 doset 299 297 -2 bb__parsespent 119 117 -2 test_main 260 257 -3 qgravechar 109 106 -3 tcpudpsvd_main 1834 1830 -4 sysctl_display_all 589 580 -9 xopen_xwrite_close 44 33 -11 prs 30 18 -12 find_main 418 406 -12 full_write2_str 25 12 -13 adduser_main 667 654 -13 evaltreenr 817 802 -15 evaltree 817 802 -15 tftpd_main 526 493 -33 ftpd_main 2050 1990 -60 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 7/18 up/down: 117/-211) Total: -94 bytes	2009-03-09 00:12:37 +00:00
Denis Vlasenko	d7a805efaf	libbb: introduce and use xgetpwnam. ~ -150 bytes.	2008-12-03 19:05:55 +00:00