2040 Commits

Author	SHA1	Message	Date
Rostislav Skudnov	3f6a978a0d	dd: add 'oflag=seek_bytes' ... Allow specifying position in the output file in bytes instead of obs-sized blocks, improve compatibility with GNU dd. function old new delta dd_main 1632 1693 +61 packed_usage 33130 33150 +20 static.oflag_words - 12 +12 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 2/0 up/down: 93/0) Total: 93 bytes Signed-off-by: Rostislav Skudnov <rostislav@tuxera.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-10-30 16:55:09 +01:00
Bernhard Reutner-Fischer	3db4e7f84c	printf: fix printing +-prefixed numbers ... Thanks to Cristian Ionescu-Idbohrn for noticing. Also fix "%d" ' 42' to skip leading whitespace. function old new delta print_direc 435 454 +19 bb_strtoll 99 103 +4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 23/0) Total: 23 bytes Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>	2018-10-19 15:27:42 +02:00
Denys Vlasenko	349d72c19c	unzip: use printable_string() for printing filenames ... function old new delta unzip_main 2726 2792 +66 printable_string2 - 57 +57 identify 4329 4336 +7 expmeta 659 663 +4 add_interface 99 103 +4 beep_main 286 289 +3 changepath 192 194 +2 builtin_type 115 117 +2 devmem_main 469 470 +1 input_tab 1076 1074 -2 create_J 1821 1819 -2 poplocalvars 314 311 -3 doCommands 2222 2214 -8 do_load 918 902 -16 printable_string 57 9 -48 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 8/6 up/down: 146/-79) Total: 67 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-09-30 16:56:56 +02:00
Denys Vlasenko	c9720a761e	timeout: fix arguments to match coreutils ... Was: timeout [-t SECS] [-s SIG] PROG ARGS Is: timeout [-s SIG] SECS PROG ARGS function old new delta timeout_main 312 319 +7 packed_usage 32882 32858 -24 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/1 up/down: 7/-24) Total: -17 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-08-03 18:28:17 +02:00
Denys Vlasenko	4c20d9f2b0	extend fractional duration support to "top -d N.N" and "timeout" ... function old new delta parse_duration_str - 168 +168 sleep_for_duration - 157 +157 top_main 885 928 +43 timeout_main 269 312 +43 handle_input 571 614 +43 duration_suffixes - 40 +40 sfx 40 - -40 sleep_main 364 79 -285 ------------------------------------------------------------------------------ (add/remove: 4/1 grow/shrink: 3/1 up/down: 494/-325) Total: 169 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-08-03 18:17:12 +02:00
Lauri Kasanen	a380aacca6	ls: When -h is passed, the total should also be in human units ... Signed-off-by: Lauri Kasanen <cand@gmx.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-08-01 19:47:15 +02:00
Denys Vlasenko	d01c9aa7ca	cp: placate gcc8 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-08-01 18:29:41 +02:00
Denys Vlasenko	1fbb73fc4c	cp: add missing quote in config snippet ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-07-17 00:16:16 +02:00
Denys Vlasenko	79fb6ac7a5	cp: optional --reflink support ... function old new delta cp_main 428 512 +84 copy_file 1676 1742 +66 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-07-13 20:30:02 +02:00
Denys Vlasenko	cbe8c65e59	sort: add -V "sort version" ... function old new delta packed_usage 32855 32858 +3 get_key 500 503 +3 sort_opt_str 36 37 +1 sort_main 1037 1036 -1 compare_keys 795 783 -12 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/2 up/down: 7/-13) Total: -6 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-07-08 01:37:54 +02:00
haroon maqsood	4a85d56c4c	nproc: implement --all --ignore=N ... function old new delta nproc_main 98 242 +144 packed_usage 32799 32816 +17 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 161/0) Total: 161 bytes Signed-off-by: haroon maqsood <maqsood3525@live.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-07-06 16:19:04 +02:00
Denys Vlasenko	34254f9dde	install: fix "-D -t DIR1/DIR2/DIR3" creating only DIR1/DIR2, closes 11106 ... function old new delta install_main 758 767 +9 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-06-22 18:59:10 +02:00
Kartik Agaram	43b17b1cd0	restore documentation on the build config language ... Kconfig-language.txt was deleted in commit 4fa499a17b back in 2006. Move to docs/ as suggested by Xabier Oneca: http://lists.busybox.net/pipermail/busybox/2014-May/080914.html Also update references to it everywhere. Signed-off-by: Kartik Agaram <akkartik@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-06-06 15:16:48 +02:00
Denys Vlasenko	747162109f	realpath,readlink -f: coreutils compat, closes 11021 ... function old new delta xmalloc_realpath_coreutils - 121 +121 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-05-24 17:31:00 +02:00
Denys Vlasenko	d80eecb868	cat: fix cat -e and cat -v erroneously numbering 1st line ... function old new delta cat_main 418 421 +3 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-04-29 14:05:43 +02:00
Denys Vlasenko	3632cb15f1	shell: add comments about [[, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-04-10 15:25:41 +02:00
Denys Vlasenko	38ccd6af8a	bzip2: fix two crashes on corrupted archives ... As it turns out, longjmp'ing into freed stack is not healthy... function old new delta unpack_usage_messages - 97 +97 unpack_bz2_stream 369 409 +40 get_next_block 1667 1677 +10 get_bits 156 155 -1 start_bunzip 212 183 -29 bb_show_usage 181 120 -61 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 2/3 up/down: 147/-91) Total: 56 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-04-08 20:05:04 +02:00
Denys Vlasenko	7bcde5f00d	libbb.h: always include sys/resource.h ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-04-08 17:23:27 +02:00
Denys Vlasenko	77cb6b99a4	libbb: rename bb_ask -> bb_ask_noecho, bb_ask_confirmation -> bb_ask_y_confirmation ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-04-07 15:08:12 +02:00
Denys Vlasenko	d1d6d9c5d8	sort: smaller and more agressive FEATURE_SORT_OPTIMIZE_MEMORY ... function old new delta sort_main 1098 1037 -61 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-04-06 16:44:50 +02:00
Denys Vlasenko	759ca8a4cb	sort: move misplaced comment ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-04-04 17:07:21 +02:00
Denys Vlasenko	c29c2e60d8	sort: FEATURE_SORT_OPTIMIZE_MEMORY ... On sorting all kernel/linux/arch/ *.[ch] files, this reduces memory usage by 6%. yes | head -99999999 | sort goes down from 1900Mb to 380 Mb. function old new delta sort_main 862 1098 +236 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-04-04 17:03:41 +02:00
Denys Vlasenko	7bf304f371	stat: fix a typo: s/romfs/ramfs/, closes 10876 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-03-31 02:45:22 +02:00
Denys Vlasenko	694bc06345	md5sum: use config help text similar to other "sum" tools ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-03-08 12:49:39 +01:00
Denys Vlasenko	e20a703fd3	df: do "rootfs" check sooner ... function old new delta df_main 1065 1064 -1 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-02-23 17:08:32 +01:00
Denys Vlasenko	58cd6e1ade	df: 4TB+ support on 32 bits arch ... Reported for Pascal Bellard. function old new delta df_main 1054 1065 +11 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-02-23 17:00:23 +01:00
Denys Vlasenko	3177626033	od: move address_fmt[] from data to globals. 8 less bytes in data section ... function old new delta od_main 2164 2179 +15 address_fmt 8 - -8 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 1/0 up/down: 15/-8) Total: 7 bytes text data bss dec hex filename 930954 481 6852 938287 e512f busybox_old 930977 473 6852 938302 e513e busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-02-22 12:14:55 +01:00
Denys Vlasenko	2709acbbda	sort: fix potentially buggy use of OPT_STR ... This also makes OPT_STR reused: text data bss dec hex filename 930979 481 6852 938312 e5148 busybox_old 930954 481 6852 938287 e512f busybox_unstripped ^^^^^^ Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-02-22 11:03:23 +01:00
Denys Vlasenko	427ae18348	sort: in -s handling, return 1/-1, not 1/0 compare result ... function old new delta compare_keys 794 795 +1 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-02-22 10:54:55 +01:00
Denys Vlasenko	7d285c78a3	sort: fix -s. Closes 10671 ... function old new delta sort_main 786 862 +76 compare_keys 720 794 +74 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 150/0) Total: 150 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-02-21 20:08:54 +01:00
Denys Vlasenko	7f441403cb	cp: fix option handling in non-longopt config ... the patch getopt32: remove opt_complementary 22542eca18 introduced a regressed in the cp command since it removed all aliases of arguments if long_opts is not configured. Patch by Sebastian Gottschall <s.gottschall@dd-wrt.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-02-11 21:25:23 +01:00
Denys Vlasenko	da49e7057a	cksum: code shrink ... function old new delta cksum_main 281 262 -19 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-02-01 11:44:52 +01:00
Aaro Koskinen	d15d7a0a4b	cp: implement -T ... Implement "cp -T". Some Linux kernel Makefiles started using this recently, so allow also building on systems using busybox cp. function old new delta cp_main 360 428 +68 copy_file 1678 1676 -2 packed_usage 32290 32259 -31 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/2 up/down: 76/-39) Total: 35 bytes Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-02-01 09:30:59 +01:00
Nicholas Clark	77a6678c42	dd: add 'fullblock' iflag ... Adds a fullblock iflag for improved compatibility with GNU dd. The new iflag can be used to ensure that dd calls retrieve the expected amount of data when reading from pipes or unusual filesystems. function old new delta packed_usage 32249 32334 +85 dd_main 1582 1632 +50 static.iflag_words 12 22 +10 ------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/0 up/down: 145/0) Total: 145 bytes Signed-off-by: Nicholas Clark <nicholas.clark@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-01-25 19:00:19 +01:00
Denys Vlasenko	2b9a45b9e8	od_bloaty: fix debug code ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-01-23 14:49:12 +01:00
Denys Vlasenko	88663e481f	mv: make it NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-01-14 14:41:52 +01:00
Denys Vlasenko	2c876774a9	dd: fixed partial count logic ... $ busybox dd if=/dev/zero of=/dev/loop0 bs=100M count=8; echo $? 8+0 records in 7+0 records out <=========== FIXED, was 7+1 805220352 bytes (767.9MB) copied, 0.464010 seconds, 1.6GB/s 1 function old new delta write_and_stats 97 99 +2 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-01-10 11:04:09 +01:00
Denys Vlasenko	5afd63a631	dd: exit with 1 if last write was incomplete ... $ busybox dd if=/dev/zero of=/dev/loop0 bs=100M count=8; echo $? 8+0 records in 7+1 records out 805220352 bytes (767.9MB) copied, 0.464010 seconds, 1.6GB/s 1 <=========== FIXED function old new delta write_and_stats 96 97 +1 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-01-10 10:58:55 +01:00
Denys Vlasenko	2f55404bbc	mknod: better --help, much clearer code ... function old new delta packed_usage 32066 32091 +25 mknod_main 173 174 +1 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-01-08 11:22:37 +01:00
Denys Vlasenko	c9807d787d	nice: code shrink ... function old new delta nice_main 157 152 -5 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2018-01-08 10:13:11 +01:00
Denys Vlasenko	b013bec31b	chown: fix a mistake in opt_complementary change ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-12-31 17:59:16 +01:00
Denys Vlasenko	82d1c1f84a	randomconfig fixes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-12-31 17:30:02 +01:00
Ron Yorston	8d8ee910f0	env: -u option fails due to typo ... The -u option is supposed to be allowed to appear multiple times; the option string supplied to getopt32long requires it to be followed by a nonnegative integer. Reported-by: Keith Maxwell <keith.maxwell@gmail.com> Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-12-25 21:36:05 +01:00
James Clarke	d1535216ca	df: Use statvfs instead of non-standard statfs ... Platforms differ on what their implementations of statfs include. Importantly, FreeBSD's does not include a f_frsize member inside struct statfs. However, statvfs is specified by POSIX and includes everything we need, so we can just use that instead. Signed-off-by: James Clarke <jrtc27@jrtc27.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-10-30 15:30:59 +01:00
Denys Vlasenko	a02a4e9830	whitespace and comment format fixes, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-10-05 15:19:25 +02:00
Denys Vlasenko	ebe6d9d875	whitespace and comment format fixes, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-10-05 14:40:24 +02:00
Denys Vlasenko	6e2beb7dfe	date: maybe_set_utc only once ... It's not clear at all why we do it twice. git archaeology did not help. function old new delta date_main 836 839 +3 maybe_set_utc 16 - -16 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-10-05 12:53:25 +02:00
Denys Vlasenko	0c4dbd481a	regularize format of source file headers, no code changes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-09-18 16:28:43 +02:00
Denys Vlasenko	3f5ba0c872	stty: add cmspar, flusho, extproc attributes ... function old new delta mode_info 688 704 +16 mode_name 502 516 +14 wrapf 162 157 -5 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 30/-5) Total: 25 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-09-18 12:17:20 +02:00
Denys Vlasenko	8187e01438	*: use ESC define instead of "\033"; use ESC[m instead of ESC[0m ... text data bss dec hex filename 922535 481 6832 929848 e3038 busybox_old 922534 481 6832 929847 e3037 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-09-13 22:48:30 +02:00
Denys Vlasenko	bc9bbeb2b8	libarchive: do not extract unsafe symlinks unless $EXTRACT_UNSAFE_SYMLINKS=1 ... function old new delta unsafe_symlink_target - 147 +147 unzip_main 2711 2732 +21 copy_file 1657 1678 +21 tar_main 999 971 -28 data_extract_all 1038 984 -54 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 2/2 up/down: 189/-82) Total: 107 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-10 11:52:42 +02:00
Denys Vlasenko	22542eca18	getopt32: remove opt_complementary ... function old new delta vgetopt32 1318 1392 +74 runsvdir_main 703 713 +10 bb_make_directory 423 425 +2 collect_cpu 546 545 -1 opt_chars 3 - -3 opt_complementary 4 - -4 tftpd_main 567 562 -5 ntp_init 476 471 -5 zcip_main 1266 1256 -10 xxd_main 428 418 -10 whois_main 140 130 -10 who_main 463 453 -10 which_main 212 202 -10 wget_main 2535 2525 -10 watchdog_main 291 281 -10 watch_main 222 212 -10 vlock_main 399 389 -10 uuencode_main 332 322 -10 uudecode_main 316 306 -10 unlink_main 45 35 -10 udhcpd_main 1482 1472 -10 udhcpc_main 2762 2752 -10 tune2fs_main 290 280 -10 tunctl_main 366 356 -10 truncate_main 218 208 -10 tr_main 518 508 -10 time_main 1134 1124 -10 tftp_main 286 276 -10 telnetd_main 1873 1863 -10 tcpudpsvd_main 1785 1775 -10 taskset_main 521 511 -10 tar_main 1009 999 -10 tail_main 1644 1634 -10 syslogd_main 1967 1957 -10 switch_root_main 368 358 -10 svlogd_main 1454 1444 -10 sv 1296 1286 -10 stat_main 104 94 -10 start_stop_daemon_main 1028 1018 -10 split_main 542 532 -10 sort_main 796 786 -10 slattach_main 624 614 -10 shuf_main 504 494 -10 setsid_main 96 86 -10 setserial_main 1132 1122 -10 setfont_main 388 378 -10 setconsole_main 78 68 -10 sendmail_main 1209 1199 -10 sed_main 677 667 -10 script_main 1077 1067 -10 run_parts_main 325 315 -10 rtcwake_main 454 444 -10 rm_main 175 165 -10 reformime_main 119 109 -10 readlink_main 123 113 -10 rdate_main 246 236 -10 pwdx_main 189 179 -10 pstree_main 317 307 -10 pscan_main 663 653 -10 popmaildir_main 818 808 -10 pmap_main 80 70 -10 nc_main 1042 1032 -10 mv_main 558 548 -10 mountpoint_main 477 467 -10 mount_main 1264 1254 -10 modprobe_main 768 758 -10 modinfo_main 333 323 -10 mktemp_main 200 190 -10 mkswap_main 324 314 -10 mkfs_vfat_main 1489 1479 -10 microcom_main 715 705 -10 md5_sha1_sum_main 521 511 -10 man_main 867 857 -10 makedevs_main 1052 1042 -10 ls_main 563 553 -10 losetup_main 432 422 -10 loadfont_main 89 79 -10 ln_main 524 514 -10 link_main 75 65 -10 ipcalc_main 544 534 -10 iostat_main 2397 2387 -10 install_main 768 758 -10 id_main 480 470 -10 i2cset_main 1239 1229 -10 i2cget_main 380 370 -10 i2cdump_main 1482 1472 -10 i2cdetect_main 682 672 -10 hwclock_main 406 396 -10 httpd_main 741 731 -10 grep_main 837 827 -10 getty_main 1559 1549 -10 fuser_main 297 287 -10 ftpgetput_main 345 335 -10 ftpd_main 2232 2222 -10 fstrim_main 251 241 -10 fsfreeze_main 77 67 -10 fsck_minix_main 2921 2911 -10 flock_main 314 304 -10 flashcp_main 740 730 -10 flash_eraseall_main 833 823 -10 fdformat_main 532 522 -10 expand_main 680 670 -10 eject_main 335 325 -10 dumpleases_main 630 620 -10 du_main 314 304 -10 dos2unix_main 441 431 -10 diff_main 1350 1340 -10 df_main 1064 1054 -10 date_main 1095 1085 -10 cut_main 961 951 -10 cryptpw_main 228 218 -10 crontab_main 575 565 -10 crond_main 1149 1139 -10 cp_main 370 360 -10 common_traceroute_main 3834 3824 -10 common_ping_main 1767 1757 -10 comm_main 239 229 -10 cmp_main 655 645 -10 chrt_main 379 369 -10 chpst_main 704 694 -10 chpasswd_main 308 298 -10 chown_main 171 161 -10 chmod_main 158 148 -10 cat_main 428 418 -10 bzip2_main 120 110 -10 blkdiscard_main 264 254 -10 base64_main 221 211 -10 arping_main 1665 1655 -10 ar_main 556 546 -10 adjtimex_main 406 396 -10 adduser_main 882 872 -10 addgroup_main 411 401 -10 acpid_main 1198 1188 -10 optstring 11 - -11 opt_string 18 - -18 OPT_STR 25 - -25 ubi_tools_main 1288 1258 -30 ls_options 31 - -31 ------------------------------------------------------------------------------ (add/remove: 0/6 grow/shrink: 3/129 up/down: 86/-1383) Total: -1297 bytes text data bss dec hex filename 915428 485 6876 922789 e14a5 busybox_old 914629 485 6872 921986 e1182 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-08 21:55:02 +02:00
Denys Vlasenko	036585a911	getopt32: remove applet_long_options ... FEATURE_GETOPT_LONG made dependent on LONG_OPTS. The folloving options are removed, now LONG_OPTS enables long options for affected applets: FEATURE_ENV_LONG_OPTIONS FEATURE_EXPAND_LONG_OPTIONS FEATURE_UNEXPAND_LONG_OPTIONS FEATURE_MKDIR_LONG_OPTIONS FEATURE_MV_LONG_OPTIONS FEATURE_RMDIR_LONG_OPTIONS FEATURE_ADDGROUP_LONG_OPTIONS FEATURE_ADDUSER_LONG_OPTIONS FEATURE_HWCLOCK_LONG_OPTIONS FEATURE_NSENTER_LONG_OPTS FEATURE_CHCON_LONG_OPTIONS FEATURE_RUNCON_LONG_OPTIONS They either had a small number of long options, or their long options are essential. Example: upstream addgroup and adduser have ONLY longopts, we should probably go further and get rid of non-standard short options. To this end, make addgroup and adduser "select LONG_OPTS". We had this breakage caused by us even in our own package! #if ENABLE_LONG_OPTS || !ENABLE_ADDGROUP /* We try to use --gid, not -g, because "standard" addgroup * has no short option -g, it has only long --gid. */ argv[1] = (char*)"--gid"; #else /* Breaks if system in fact does NOT use busybox addgroup */ argv[1] = (char*)"-g"; #endif xargs: its lone longopt no longer depends on DESKTOP, only on LONG_OPTS. hwclock TODO: get rid of incompatible -t, -l aliases to --systz, --localtime Shorten help texts by omitting long option when short opt alternative exists. Reduction of size comes from the fact that store of an immediate (an address of longopts) to a fixed address (global variable) is a longer insn than pushing that immediate or passing it in a register. This effect is CPU-agnostic. function old new delta getopt32 1350 22 -1328 vgetopt32 - 1318 +1318 getopt32long - 24 +24 tftpd_main 562 567 +5 scan_recursive 376 380 +4 collect_cpu 545 546 +1 date_main 1096 1095 -1 hostname_main 262 259 -3 uname_main 259 255 -4 setpriv_main 362 358 -4 rmdir_main 191 187 -4 mv_main 562 558 -4 ipcalc_main 548 544 -4 ifenslave_main 641 637 -4 gzip_main 192 188 -4 gunzip_main 77 73 -4 fsfreeze_main 81 77 -4 flock_main 318 314 -4 deluser_main 337 333 -4 cp_main 374 370 -4 chown_main 175 171 -4 applet_long_options 4 - -4 xargs_main 894 889 -5 wget_main 2540 2535 -5 udhcpc_main 2767 2762 -5 touch_main 436 431 -5 tar_main 1014 1009 -5 start_stop_daemon_main 1033 1028 -5 sed_main 682 677 -5 script_main 1082 1077 -5 run_parts_main 330 325 -5 rtcwake_main 459 454 -5 od_main 2169 2164 -5 nl_main 201 196 -5 modprobe_main 773 768 -5 mkdir_main 160 155 -5 ls_main 568 563 -5 install_main 773 768 -5 hwclock_main 411 406 -5 getopt_main 622 617 -5 fstrim_main 256 251 -5 env_main 198 193 -5 dumpleases_main 635 630 -5 dpkg_main 3991 3986 -5 diff_main 1355 1350 -5 cryptpw_main 233 228 -5 cpio_main 593 588 -5 conspy_main 1135 1130 -5 chpasswd_main 313 308 -5 adduser_main 887 882 -5 addgroup_main 416 411 -5 ftpgetput_main 351 345 -6 get_terminal_width_height 242 234 -8 expand_main 690 680 -10 static.expand_longopts 18 - -18 static.unexpand_longopts 27 - -27 mkdir_longopts 28 - -28 env_longopts 30 - -30 static.ifenslave_longopts 34 - -34 mv_longopts 46 - -46 static.rmdir_longopts 48 - -48 packed_usage 31739 31687 -52 ------------------------------------------------------------------------------ (add/remove: 2/8 grow/shrink: 3/49 up/down: 1352/-1840) Total: -488 bytes text data bss dec hex filename 915681 485 6880 923046 e15a6 busybox_old 915428 485 6876 922789 e14a5 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-08 17:09:40 +02:00
Denys Vlasenko	af5d008669	expr: make it NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 23:23:18 +02:00
Denys Vlasenko	fc9efcb53b	df: make NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 22:19:17 +02:00
Denys Vlasenko	248a67fb75	free,stat: make NOEXEC ... pkill/pgrep/pidof uncovered another quirk: what about noexec's _process names_? Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 18:18:09 +02:00
Denys Vlasenko	1a1203ff89	users,w,who,uptime,renice: make NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-07 16:47:34 +02:00
Denys Vlasenko	b9be780705	sv,svc: fix NOEXEC fallout ... function old new delta svc_main 145 162 +17 sv 1280 1297 +17 status 139 133 -6 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 34/-6) Total: 28 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-06 21:23:03 +02:00
Denys Vlasenko	184c738582	stty: fix bb_common_bufsiz1 use in NOEXEC ... function old new delta stty_main 1211 1221 +10 do_display 379 370 -9 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-06 20:55:56 +02:00
Denys Vlasenko	692eeb81a4	stty: make in NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-04 20:07:19 +02:00
Denys Vlasenko	5c527dc57e	make 17 state-changing execing applets (ex: "nice PROG ARGS") noexec ... The applets with "<applet> [opts] PROG ARGS" API very quickly exec another program, noexec is okay for them: chpst/envdir/envuidgid/softlimit/setuidgid chroot chrt ionice nice nohup setarch/linux32/linux64 taskset cttyhack "reset" and "sulogin" applets don't have this form, but also exec another program at once, thus made noexec too. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-04 19:55:01 +02:00
Denys Vlasenko	6bec24c4f5	mktemp: make it NOEXEC ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-04 17:39:05 +02:00
Denys Vlasenko	39194f0309	new NOFORKs: pwdx,kill[all5],ttysize,realpath,readlink NOEXECs: date,resize ... function old new delta run_nofork_applet 258 280 +22 readlink_main 112 123 +11 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 33/0) Total: 33 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-03 19:03:32 +02:00
Denys Vlasenko	663ae52676	config: FEDORA_COMPAT option (so far only tweaks uname) ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-03 03:46:14 +02:00
Denys Vlasenko	819b47aa35	new NOFORKs: clear, nproc, tty, uname, arch, unlink, which ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-03 03:29:32 +02:00
Denys Vlasenko	7c40ddd950	NOFORK fixes ... "rm -i FILE" and "yes" can now be interrupted by ^C in hush. This also now works: $ usleep 19999999 ^C $ echo $? 130 function old new delta run_pipe 1668 1711 +43 pseudo_exec_argv 312 321 +9 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 52/0) Total: 52 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-02 16:37:39 +02:00
Denys Vlasenko	95f7953f2c	do not use `a' quoting style in comments ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-02 14:26:33 +02:00
Denys Vlasenko	18e781dc02	config: do not use `a' quoting in help texts ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-08-02 14:12:48 +02:00
Denys Vlasenko	78b1b1b07a	test: fix 4-argument case ... Upstream dash commit: Date: Sun, 13 Jul 2008 19:20:10 +0800 Fixed 3,4-argument cases for test per POSIX ----- Forwarded message from Gerrit Pape <pape@smarden.org> ----- Subject: Bug#455828: dash: 4-argument test "test \( ! -e \)" yields an error Date: Fri, 28 Dec 2007 08:53:29 +0000 From: Gerrit Pape <pape@smarden.org> To: Vincent Lefevre <vincent@vinc17.org>, 455828@bugs.debian.org On Thu, Dec 27, 2007 at 06:23:20PM +0100, Vincent Lefevre wrote: > On 2007-12-27 16:00:06 +0000, Gerrit Pape wrote: > > On Wed, Dec 12, 2007 at 02:18:47AM +0100, Vincent Lefevre wrote: > > > According to POSIX[*], "test \( ! -e \)" is a 4-argument test and is > > > here equivalent to "test ! -e". But dash (like ksh93 and bash) yields > > > an error: > > > > > > $ test \( ! -e \) || echo $? > > > test: 1: closing paren expected > > > 2 > > > $ test ! -e || echo $? > > > 1 > > > > Hi Vincent, > > > > the -e switch to test takes an argument, a pathname. > > According to POSIX, in both above examples, "-e" is *not* a switch, > just a string. > > test \( ! -e \) > > means: return true if the string "-e" is empty, otherwhise return false. > The error in dash is that it incorrectly thinks that "-e" is a switch in > this context. I see, you're right. Thanks, Gerrit. ----- End forwarded message ----- This patch hard-codes the 3,4-argument cases in the way required by POSIX. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> function old new delta test_main 370 421 +51 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-31 19:21:51 +02:00
Denys Vlasenko	b920a38dc0	tar: postpone creation of symlinks with "suspicious" targets. Closes 8411 ... function old new delta data_extract_all 968 1038 +70 tar_main 952 986 +34 scan_tree 258 262 +4 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/0 up/down: 108/0) Total: 108 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-24 17:20:13 +02:00
Denys Vlasenko	fd5e66eb8e	basename: do not use argc ... function old new delta basename_main 153 148 -5 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-21 18:41:46 +02:00
Denys Vlasenko	72089cf6b4	config: deindent all help texts ... Those two spaces after tab have no effect, and always a nuisance when editing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-21 09:50:55 +02:00
Denys Vlasenko	ae178cee3d	Update remaining menuconfig items with approximate applet sizes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-19 14:32:54 +02:00
Ron Yorston	a165603d24	od_bloaty: fix floating point output ... Currently od_bloaty does this: $ /bin/echo -en '\x00\x00\x00\x00\x00\x00\x00\x00' | busybox od -f od: invalid character 'F' in type string 'fF' $ /bin/echo -en '\x00\x00\x00\x00\x00\x00\x00\x00' | busybox od -t fD od: invalid character 'D' in type string 'fD' $ /bin/echo -en '\x00\x00\x00\x00\x00\x00\x00\x00' | busybox od -t f 0000000 0000010 The first two occur because the alphabetic length specifier isn't being properly skipped. The third is due to the empty length specifier being treated as alphabetic so we fall off the end of the FDL_sizeof array with undetermined consequences. Coreutils defaults to printing a double in this case. With this patch the output is: $ /bin/echo -en '\x00\x00\x00\x00\x00\x00\x00\x00' | ./busybox od -f 0000000 0.0000000e+00 0.0000000e+00 0000010 $ /bin/echo -en '\x00\x00\x00\x00\x00\x00\x00\x00' | ./busybox od -t fD 0000000 0.000000000000000e+00 0000010 $ /bin/echo -en '\x00\x00\x00\x00\x00\x00\x00\x00' | ./busybox od -t f 0000000 0.000000000000000e+00 0000010 I guess nobody uses BusyBox od to print floating point numbers. Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-19 13:12:02 +02:00
Denys Vlasenko	4eed2c6c50	Update menuconfig items with approximate applet sizes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 22:01:24 +02:00
Denys Vlasenko	483405a9b0	Tweaks from mass recompile for 1.27.1 release ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 20:17:51 +02:00
Ron Yorston	513a2457b6	printf: fix format string sanity check ... One of the tests for printf checks for an invalid bare '%' in the format string: $ busybox printf '%' a b c printf: %: invalid format On x86_64 a slightly different test doesn't work correctly: $ busybox printf '%' d e f printf: invalid number 'd' printf: invalid number 'e' printf: invalid number 'f' On other platforms the test fails randomly depending on how the arguments are laid out in memory. There are two places in the code where strchr is used to determine if a character in the format string is valid. However, strchr also returns a valid pointer if the character being searched for is the null terminator thus causing the code to incorrectly suppose that a valid character has been found. Add explicit checks for the null terminator. Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-18 16:00:38 +02:00
Denys Vlasenko	c49638b7d2	arch: new applet (same as unmae -m). ~30 bytes. ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-16 16:43:41 +02:00
Denys Vlasenko	7b6e8f3f1a	uuencode: allow space instead of "`" as padding char. Closes 10046 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-14 17:24:59 +02:00
Denys Vlasenko	d5b98e2ef4	dd: fix status=none. Closes 10066 ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-14 13:44:30 +02:00
Denys Vlasenko	75e90b1548	cat: fix "cat -An" ignoring -n; make numbering go througn all files ... function old new delta cat_main 418 428 +10 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-14 10:47:18 +02:00
Kang-Che Sung	a2bdc5c554	cat: allow compiling out -n and -b ... When these options were introduced in d88f94a5df it provides no config options to compile them out. Now provide one. Introduce config FEATURE_CATN. Signed-off-by: Kang-Che Sung <explorer09@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-14 09:56:13 +02:00
Denys Vlasenko	9de9c871bf	shuf: fix random line selection. Closes 9971 ... """ For example, given input file: foo bar baz after shuffling the input file, foo will never end up back on the first line. This came to light when I ran into a use-case where someone was selecting a random line from a file using shuf | head -n 1, and the results on busybox were showing a statistical anomaly (as in, the first line would never ever be picked) vs the same process running on environments that had gnu coreutils installed. On line https://git.busybox.net/busybox/tree/coreutils/shuf.c#n56 it uses r %= i, which will result in 0 <= r < i, while the algorithm specifies 0 <= r <= i. """ Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-09 00:39:15 +02:00
Denys Vlasenko	a8cf9c5a3f	libbb: new function bb_getgroups() - allocating wrapper around getgroups() ... function old new delta bb_getgroups - 111 +111 nexpr 843 757 -86 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 0/1 up/down: 111/-86) Total: 25 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-07-04 18:56:45 +02:00
Laurent Bercot	2599937c4e	ls: fix support for long options when FEATURE_LS_COLOR is deselected ... Declaration of ls_longopts and initialization of applet_long_options were incorrectly guarded with ENABLE_FEATURE_LS_COLOR; that yielded a "ls: NO_OPT: \xff" error message when long options were selected and color support was not. This patch ensures long options are initialized separately from color support. Signed-off-by: Laurent Bercot <ska-dietlibc@skarnet.org> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-05-26 16:50:53 +02:00
Denys Vlasenko	10ad622dc2	Spelling fixes in comments, documentation, tests and examples ... By klemens <ka7@github.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-17 16:13:32 +02:00
Denys Vlasenko	d85352b4ff	factor: fix stray semicolon ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-17 15:57:07 +02:00
Denys Vlasenko	8352b717ce	factor: support "no-argvs" usage ... function old new delta factorize_numstr - 72 +72 packed_usage 31562 31566 +4 factor_main 109 101 -8 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/1 up/down: 76/-8) Total: 68 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-14 14:23:49 +02:00
Denys Vlasenko	107159ef1c	factor: improve comments for sieving logic... also fix a typo ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-13 13:38:16 +02:00
Denys Vlasenko	021d50405b	factor: improve comments for sieving logic ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-13 13:34:40 +02:00
Denys Vlasenko	c054822027	factor: tweak comments ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-13 10:51:13 +02:00
Denys Vlasenko	e31ca2e9b2	catv: convert this bbox-specific applet into "cat -v" ... function old new delta cat_main 150 320 +170 packed_usage 31511 31552 +41 applet_install_loc 190 189 -1 applet_main 1516 1512 -4 applet_names 2618 2613 -5 catv_main 227 - -227 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 2/3 up/down: 211/-237) Total: -26 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-12 17:17:29 +02:00
Denys Vlasenko	d9eb40c185	fix errors found with make_single_applets.sh ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-12 15:48:19 +02:00
Denys Vlasenko	0cecbe7d5d	Sort more misplaced applets into coreutils or util-linux ... No code changes Surprisingly, nice and renice are coming from different packages :) Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-12 14:16:29 +02:00
Denys Vlasenko	783d57af7b	Sort some miscutils/ applets into coreutils or util-linux ... No code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-12 13:58:40 +02:00
Denys Vlasenko	1bc0bd13b5	w: new applet, alias to "who -H" ... function old new delta who_main 451 463 +12 packed_usage 31477 31485 +8 applet_main 1508 1512 +4 applet_names 2606 2608 +2 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/0 up/down: 26/0) Total: 26 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-11 18:17:03 +02:00
Denys Vlasenko	a976aaab0b	factor: remove debug code ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-11 07:50:42 +02:00
Denys Vlasenko	8a134ec680	libbb: move isqrt from factor, use it in diff too ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-11 07:34:56 +02:00
Denys Vlasenko	10673c44f1	factor: much faster, and very slightly larger isqrt() ... function old new delta isqrt_odd 70 88 +18 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-11 07:02:42 +02:00
Denys Vlasenko	cc1f8ba489	factor: don't be too clever in isqrt - be small instead ... function old new delta isqrt_odd 111 70 -41 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-10 18:30:35 +02:00
Denys Vlasenko	ad5394d591	factor: add code to test isqrt() correctness ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-10 13:53:57 +02:00
Denys Vlasenko	dd3a395053	factor: 25% faster sieving ... function old new delta factorize 287 260 -27 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-10 12:10:46 +02:00
Denys Vlasenko	4908c79a01	factor: better comments, slightl more clever conversion even->odd ... function old new delta isqrt_odd 114 111 -3 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-10 11:47:48 +02:00
Denys Vlasenko	f428f1dc6c	factor: fix HALF_FMT usage ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-10 10:13:14 +02:00
Denys Vlasenko	12dc4fbf18	factor: fix comments ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-10 00:41:11 +02:00
Denys Vlasenko	bef1713217	factor: a bit more simple isqrt ... function old new delta isqrt_odd 87 80 -7 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-10 00:28:26 +02:00
Denys Vlasenko	c6476dca54	factor: simpler isqrt ... function old new delta isqrt_odd 102 87 -15 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-10 00:24:16 +02:00
Denys Vlasenko	c804d4ec5c	factor: factor2 variable is unused now, drop it ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-09 23:19:47 +02:00
Denys Vlasenko	7e5f2f3b51	factor: expand comments ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-09 23:12:38 +02:00
Denys Vlasenko	1d232fd440	factor: 30% faster code (estimate max possible factor just once) ... function old new delta factorize - 161 +161 isqrt_odd - 102 +102 factor_main 281 110 -171 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 0/1 up/down: 263/-171) Total: 92 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-09 22:54:57 +02:00
Denys Vlasenko	c1b5b2a190	nl: fix copyright message ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-09 21:19:29 +02:00
Denys Vlasenko	ee7f75d94f	factor: new applet ... thus far only able to factor up to ULLONG_MAX function old new delta factor_main - 378 +378 packed_usage 31427 31502 +75 applet_names 2590 2597 +7 applet_main 1500 1504 +4 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 3/0 up/down: 464/0) Total: 464 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-09 21:18:43 +02:00
Denys Vlasenko	87ae0fe095	nproc: new applet ... function old new delta nproc_main - 98 +98 applet_names 2584 2590 +6 applet_main 1496 1500 +4 applet_install_loc 187 188 +1 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-07 21:47:53 +02:00
Denys Vlasenko	0f7f1ae094	shred: smaller code ... function old new delta shred_main 361 356 -5 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-07 21:10:00 +02:00
Denys Vlasenko	2f59bf39e2	shred: new applet ... function old new delta shred_main - 361 +361 packed_usage 31427 31467 +40 applet_names 2578 2584 +6 applet_main 1492 1496 +4 run_applet_and_exit 679 682 +3 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 4/0 up/down: 414/0) Total: 414 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-07 20:45:08 +02:00
Jody Bruchon	19578b4edf	Add help text for 'uniq -i' ... Signed-off-by: Jody Bruchon <jody@jodybruchon.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-05 18:51:27 +02:00
Denys Vlasenko	e7ac7abf06	nl: use CONFIG_NL, not CONFIG_UNIQ ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-05 18:31:19 +02:00
Denys Vlasenko	d88f94a5df	nl: new applet; also implement cat -nb (similar functionality to nl) ... function old new delta nl_main - 201 +201 print_numbered_lines - 115 +115 cat_main 36 149 +113 static.nl_longopts - 106 +106 packed_usage 31081 31182 +101 applet_main 1488 1492 +4 applet_names 2575 2578 +3 applet_suid 93 94 +1 applet_install_loc 186 187 +1 ------------------------------------------------------------------------------ (add/remove: 4/0 grow/shrink: 6/0 up/down: 645/0) Total: 645 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-04-05 18:17:17 +02:00
Jody Bruchon	8808f7fc2e	uniq: add -i option to ignore case ... Signed-off-by: Jody Bruchon <jody@jodybruchon.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-03-30 18:15:54 +02:00
Denys Vlasenko	876c121ccb	whitespace fix ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-03-24 15:00:12 +01:00
Denys Vlasenko	f4a670a911	paste: delimiter list use should restart for each new output line ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-03-23 17:58:32 +01:00
Denys Vlasenko	f1db95abfb	typo fix ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-03-23 17:41:59 +01:00
Maxime Coste	d2383f57cd	paste: new applet ... function old new delta paste_main - 493 +493 packed_usage 31019 31070 +51 applet_names 2569 2575 +6 applet_main 1484 1488 +4 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 3/0 up/down: 554/0) Total: 554 bytes Signed-off-by: Maxime Coste <mawww@kakoune.org> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-03-23 17:35:52 +01:00
Rostislav Skudnov	dba0dc1999	dd: call fsync() only once before exiting if conv=fsync is specified ... Signed-off-by: Rostislav Skudnov <rostislav@tuxera.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-03-16 20:54:35 +01:00
Denys Vlasenko	205d48e948	*: add comment about APPLET_ODDNAME format ... It confused me more than once Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-29 14:57:33 +01:00
Denys Vlasenko	06f20bf675	link: new applet ... coreutils grew itself a tiny simplistic alternative to ln: Usage: link FILE LINK Create hard LINK to FILE function old new delta link_main - 75 +75 packed_usage 31114 31131 +17 applet_names 2564 2569 +5 applet_main 1480 1484 +4 applet_install_loc 185 186 +1 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 4/0 up/down: 102/0) Total: 102 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-26 00:27:53 +01:00
Denys Vlasenko	b13b618335	ftpd/ls: show directories first ... Old TODO finally done function old new delta ls_main 548 568 +20 packed_usage 31116 31097 -19 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-25 04:52:45 +01:00
Denys Vlasenko	49ecee098d	tls: add 2nd cipher_id, TLS_RSA_WITH_AES_128_CBC_SHA, so far it doesn't work ... Good news that TLS_RSA_WITH_AES_256_CBC_SHA256 still works with new code ;) This change adds inevitable extension to have different sized hashes and AES key sizes. In libbb, md5_end() and shaX_end() are extended to return result size instead of void - this helps *a lot* in tls (the cost is ~5 bytes per _end() function). Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-24 16:00:54 +01:00
Denys Vlasenko	9a64c3337c	ls: convert DISP_DIRNAME to a bool variable ... function old new delta ls_main 553 548 -5 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 20:46:12 +01:00
Denys Vlasenko	ccc1699e3e	ls: get rid of opt_flags[], handle -l1c through option_mask32 ... function old new delta display_single 885 888 +3 scan_and_display_dirs_recur 496 486 -10 opt_flags 11 - -11 ls_main 618 553 -65 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 1/2 up/down: 3/-86) Total: -83 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 20:43:06 +01:00
Denys Vlasenko	92c6898e10	ls: handle -x through option_mask32, remove default -C from --help ... function old new delta packed_usage 31024 31002 -22 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 20:21:14 +01:00
Denys Vlasenko	4cde4cca65	ls: handle -d and -R through option_mask32 ... function old new delta scan_and_display_dirs_recur 545 550 +5 display_single 1039 1044 +5 append_char 67 68 +1 display_files 399 396 -3 ls_main 736 717 -19 opt_flags 68 11 -57 .rodata 168864 168784 -80 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/4 up/down: 11/-159) Total: -148 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 20:08:22 +01:00
Denys Vlasenko	96d9c5bdbd	ls: handle -p and -F through option_mask32 ... function old new delta display_single 1039 1044 +5 append_char 67 68 +1 display_files 399 396 -3 scan_and_display_dirs_recur 545 541 -4 ls_main 736 722 -14 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/3 up/down: 6/-21) Total: -15 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 19:56:13 +01:00
Denys Vlasenko	51b01fda30	ls: LIST_ID_NAME/ID_NUMERIC/LOPT/LONG are the same, merge as LONG ... Also, handle -n and --full-time using option_mask32 function old new delta scan_and_display_dirs_recur 548 545 -3 display_single 1053 1039 -14 ls_main 777 736 -41 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-58) Total: -58 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 19:42:12 +01:00
Denys Vlasenko	a1cbaca1ba	ls: make -Z output compatible with GNU coreutils 8.25 ... This also makes it clear that LIST_MODEBITS == LIST_LOPT function old new delta ls_main 752 777 +25 display_files 400 399 -1 display_single 1055 1053 -2 my_stat 320 317 -3 packed_usage 32311 32280 -31 .rodata 168895 168864 -31 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/5 up/down: 25/-68) Total: -43 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 19:30:14 +01:00
Denys Vlasenko	2c3131d88e	ls: LIST_NLINKS/SIZE/DATE_TIME/SYMLINK are always the same, merge as LIST_LOPT ... They are always set and cleared together function old new delta append_char 69 68 -1 display_single 910 908 -2 ls_main 677 664 -13 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-16) Total: -16 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 19:05:11 +01:00
Denys Vlasenko	5d43ddc59b	ls: handle -s through option_mask32 ... function old new delta scan_and_display_dirs_recur 493 494 +1 sort_and_display_files 424 423 -1 ls_main 682 677 -5 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 18:43:43 +01:00
Denys Vlasenko	b60686cc2a	ls: handle -i through option_mask32 ... function old new delta sort_and_display_files 420 424 +4 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 18:34:11 +01:00
Denys Vlasenko	f5bd6f631c	ls: handle -a and -A through option_mask32 ... function old new delta ls_main 685 682 -3 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 18:24:05 +01:00
Denys Vlasenko	11540a8da4	ls: handle all sort options through option_mask32 ... function old new delta packed_usage 31007 31024 +17 my_stat 318 324 +6 sort_and_display_files 419 420 +1 print_name 216 217 +1 sortcmp 228 216 -12 opt_flags 96 64 -32 ls_main 732 685 -47 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/3 up/down: 25/-91) Total: -66 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-23 18:01:48 +01:00
Denys Vlasenko	e1f90d13fa	ls: -1 should be ignored by -l (and options which imply -l) ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-22 22:02:19 +01:00
Denys Vlasenko	f580baf94a	ls: more correct handling of -c, -u ... function old new delta my_stat 302 318 +16 packed_usage 30977 30969 -8 display_single 928 910 -18 sortcmp 258 228 -30 ls_main 776 732 -44 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/4 up/down: 16/-100) Total: -84 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-22 19:02:57 +01:00
Denys Vlasenko	194b2ebd2a	ls: replace -e with --full-time, add --group-directories-first, delete -K ... -K and -e were non-standard function old new delta static.ls_longopts 9 47 +38 ls_main 748 776 +28 display_single 901 928 +27 sortcmp 254 258 +4 ls_options 32 31 -1 opt_flags 100 96 -4 packed_usage 31032 30977 -55 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 4/3 up/down: 97/-60) Total: 37 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-22 17:32:20 +01:00
Denys Vlasenko	bbc7bee966	make --help texts more uniform ... function old new delta packed_usage 31062 31035 -27 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-21 02:49:58 +01:00
Denys Vlasenko	ed15dde60a	Move FEATURE_AUTOWIDTH config option to two applets which use it ... No code changes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-11 16:35:52 +01:00
Denys Vlasenko	265062d59d	shells: make hush test optional, rename ASH_BUILTIN_foo -> ASH_foo ... This makes hash and ash more symmetrical wrt config menu and config options. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-10 15:13:30 +01:00
Denys Vlasenko	f560422fa0	Big cleanup in config help and description ... Redundant help texts (one which only repeats the description) are deleted. Descriptions and help texts are trimmed. Some config options are moved, even across menus. No config option _names_ are changed. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-10 14:58:54 +01:00
Denys Vlasenko	1cc6804f69	hush: make echo builtin optional ... It's a bit overkill (who would want it off?) but ash already has it configurable. Let's be symmetric. Also tweak kbuild logic to use ASH_BUILTIN_ECHO to select echo.o, not ASH. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-09 17:10:04 +01:00
Denys Vlasenko	1125d7d680	hush: kill builtin and kill %jobspec support ... Also made it and printf, type and wait builtins optional. function old new delta builtin_kill - 323 +323 bltins1 336 348 +12 builtin_type 114 116 +2 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 2/0 up/down: 337/0) Total: 337 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2017-01-08 17:19:38 +01:00
Denys Vlasenko	0b8835861b	Make it possible to select "sh" and "bash" aliases without selecting ash or hush ... The same can be done for msh, but we are probably better off just deleting it in a next versio or two. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-12-23 16:56:43 +01:00
Denys Vlasenko	e184a88356	df: implement -B n<suff> and -B <suff> formats of -B option ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-12-12 19:56:31 +01:00
Denys Vlasenko	4bd0c2ab38	fix musl problem with dirname, now for all users of bb_make_directory() ... function old new delta bb_make_directory 412 419 +7 install_main 793 769 -24 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/1 up/down: 7/-24) Total: -17 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-12-04 10:42:07 +01:00
Denys Vlasenko	cf2600c366	install: fix musl problem with dirname ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-12-03 11:49:23 +01:00
Denys Vlasenko	15fb91cefb	test: make [ and [[ forms individually selectable ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-23 18:31:48 +01:00
Denys Vlasenko	73f743a381	Remove remnants of disabled "length" applet ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-23 14:54:38 +01:00
Denys Vlasenko	7caf1369f5	Make dos2unix/unix2dos independently selectable ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-23 14:52:19 +01:00
Denys Vlasenko	af3f420116	Convert all coreutils/* applets to "new style" applet definitions ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-11-23 14:46:56 +01:00
Denys Vlasenko	42eeb255c1	test: fix compile error in last commit ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-02 02:35:13 +02:00
Denys Vlasenko	de89205bdf	test: memory leak: free group id list ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-10-02 01:49:13 +02:00
Denys Vlasenko	7373759947	fix "aloc" -> "alloc" typos ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-09-17 20:58:22 +02:00
Denys Vlasenko	d811aaa43c	sha3sum: fix config text (it's no longer only 512-bit) ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-08-29 15:20:15 +02:00
Denys Vlasenko	71a090f187	sha3: fix to conform to final SHA3 padding standard, add -a BITS option ... function old new delta hash_file 331 396 +65 md5_sha1_sum_main 485 538 +53 packed_usage 30423 30464 +41 sha3_begin 17 31 +14 sha3_hash 101 110 +9 sha3_end 41 49 +8 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-08-29 14:05:25 +02:00
Denys Vlasenko	e695ac97fd	typo fixes ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-07-19 17:48:55 +02:00
Denys Vlasenko	b0056ea86d	{md5,shaN}sum: make -c EMPTY fail ... function old new delta md5_sha1_sum_main 466 485 +19 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-07-11 19:51:08 +02:00
Denys Vlasenko	237bedd499	getopt32: add new syntax of 'o:+' and 'o:*' for -o NUM and -o LIST ... In many cases, this aqllows to drop use of opt_complementary. Approximately -400 bytes: function old new delta getopt32 1423 1502 +79 opt_string 17 18 +1 OPT_STR 24 25 +1 uniq_main 416 406 -10 timeout_main 279 269 -10 sulogin_main 270 260 -10 readprofile_main 1825 1815 -10 ps_main 543 533 -10 pidof_main 245 235 -10 pgrep_main 611 601 -10 od_main 2600 2590 -10 mkfs_minix_main 2684 2674 -10 mkfs_ext2_main 2603 2593 -10 microcom_main 712 702 -10 makemime_main 315 305 -10 ionice_main 282 272 -10 inetd_main 2074 2064 -10 ifplugd_main 1144 1134 -10 halt_main 353 343 -10 getopt_main 636 626 -10 fdisk_main 2854 2844 -10 env_main 206 196 -10 dmesg_main 319 309 -10 conspy_main 1214 1204 -10 awk_main 981 971 -10 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/22 up/down: 81/-220) Total: -139 bytes text data bss dec hex filename 919373 906 14060 934339 e41c3 busybox_old 918969 906 14060 933935 e402f busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-07-06 21:58:02 +02:00
Natanael Copa	8f4faa1e3d	df: use f_frsize instead of f_bsize for correct sizes ... Use the correct field f_frsize instead of f_bsize. The statfs f_bsize is the "Optimal transfer block size" while the f_frsize is the "Fragment size (since Linux 2.6)". On some FUSE filesystems those may differ. Fixes bug 9046 URL: https://bugs.busybox.net/show_bug.cgi?id=9046 Signed-off-by: Natanael Copa <ncopa@alpinelinux.org> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-06-24 04:12:01 +02:00
Denys Vlasenko	877dedb825	cp: add -u/--update and --remove-destination ... Based on the patch by wdlkmpx@gmail.com function old new delta copy_file 1546 1644 +98 add_partition 1270 1362 +92 ask_and_unlink 95 133 +38 do_iproute 132 157 +25 decode_one_format 710 715 +5 cp_main 369 374 +5 ubirename_main 198 202 +4 read_package_field 232 230 -2 bb_make_directory 421 412 -9 packed_usage 30505 30476 -29 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 7/3 up/down: 267/-40) Total: 227 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-05-27 00:46:38 +02:00
Denys Vlasenko	3e134ebf6a	*: slap on a few ALIGN1/2s where appropriate ... The result of looking at "grep -F -B2 '*fill*' busybox_unstripped.map" text data bss dec hex filename 829901 4086 1904 835891 cc133 busybox_before 829665 4086 1904 835655 cc047 busybox Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-22 18:09:21 +02:00
Denys Vlasenko	9de2e5a222	*: hopefully all setup_common_bufsiz() are in place ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-21 18:38:51 +02:00
Denys Vlasenko	47cfbf32fd	*: add most of the required setup_common_bufsiz() calls ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-21 18:18:48 +02:00
Denys Vlasenko	e6a2f4cc5a	libbb: make bb_common_bufsiz1 1 kbyte, add capability to use bss tail for it ... The config item is FEATURE_USE_BSS_TAIL. When it is off (default): function old new delta read_config 210 228 +18 doCommands 2279 2294 +15 ipneigh_list_or_flush 763 772 +9 ipaddr_list_or_flush 1256 1261 +5 display_process_list 1301 1306 +5 conspy_main 1378 1383 +5 do_lzo_compress 352 355 +3 do_lzo_decompress 565 567 +2 push 46 44 -2 inetd_main 2136 2134 -2 uevent_main 421 418 -3 addLines 97 92 -5 bb_common_bufsiz1 8193 1024 -7169 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 8/5 up/down: 62/-7181) Total: -7119 bytes text data bss dec hex filename 829850 4086 9080 843016 cdd08 busybox_old 829901 4086 1904 835891 cc133 busybox_unstripped FEATURE_USE_BSS_TAIL=y: read_config 210 228 +18 doCommands 2279 2294 +15 ipneigh_list_or_flush 763 772 +9 ipaddr_list_or_flush 1256 1261 +5 display_process_list 1301 1306 +5 conspy_main 1378 1383 +5 do_lzo_compress 352 355 +3 do_lzo_decompress 565 567 +2 inetd_main 2136 2134 -2 bb_common_bufsiz1 8193 - -8193 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 8/1 up/down: 62/-8195) Total: -8133 bytes text data bss dec hex filename 829850 4086 9080 843016 cdd08 busybox_old 829911 4086 880 834877 cbd3d busybox_unstripped FIXME: setup_common_bufsiz() calls are missing. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-21 17:39:11 +02:00
Denys Vlasenko	b14374a5ba	sort: "-o FILE", not "-o", is the syntax ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-02 18:20:26 +02:00
Denys Vlasenko	c87e81f944	sort: help text does not need to say that -mST are supported but ignored ... Such information is useless for users of "sort --help" Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-04-02 17:39:50 +02:00
Denys Vlasenko	ea351b9742	ls: fix columnar output. Closes 8731 ... In coreutils/ls.c, 1.19 introduced commit 2f7d9e8903, removing the variable tabstops and hard coding the column separation to 2 characters, but was not done correctly. The column_width assumes a gap of 1 character, so the computed number of columns exceeds the terminal width when many small files are encountered. A minor problem but surprisingly annoying. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-03-06 17:53:11 +01:00
Rafał Miłecki	c30a5b1373	dd: support iflag=skip_bytes ... It allows specifying amount of bytes directly (not only amount of blocks) is also supported by GNU's Coreutils. function old new delta parse_comma_flags - 93 +93 static.iflag_words - 12 +12 dd_main 1569 1580 +11 packed_usage 30591 30600 +9 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 2/0 up/down: 125/0) Total: 125 bytes Signed-off-by: Rafał Miłecki <zajec5@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-02-01 02:17:28 +01:00
Ron Yorston	4a79224cfc	printf: short-circuit output when argument to %b includes \c ... printf wasn't correctly handling \c in an argument to the %b format specifier. printf %bXX OK\\c returned 'OK\cXX' rather than the expected 'OK'. function old new delta printf_main 886 899 +13 Signed-off-by: Ron Yorston <rmy@pobox.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-01-31 22:23:05 +01:00
Denys Vlasenko	c7e47cf627	dos2unix: try to preserve ownership. closes 8311 ... function old new delta dos2unix_main 426 441 +15 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2016-01-17 03:50:36 +01:00
Mike Frysinger	6a70db85cf	truncate: use O_WRONLY|O_NONBLOCK ... This matches coreutils behavior. We don't read the fd, and truncation does not need blocking. Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2016-01-13 13:30:20 -05:00
Ari Sundholm	e111a16404	truncate: always set mode when opening file to avoid fortify errors ... Busybox crashes due to no mode being given when opening: $ ./busybox truncate -s 1M foo *** invalid open64 call: O_CREAT without mode ***: ./busybox terminated ======= Backtrace: ========= /lib/x86_64-linux-gnu/libc.so.6(+0x7338f)[0x7f66d921338f] /lib/x86_64-linux-gnu/libc.so.6(__fortify_fail+0x5c)[0x7f66d92aac9c] /lib/x86_64-linux-gnu/libc.so.6(+0xeb6aa)[0x7f66d928b6aa] ./busybox[0x4899f9] ======= Memory map: ======== 00400000-004d0000 r-xp 00000000 00:1a 137559 /home/ari/busybox/busybox 006cf000-006d0000 r--p 000cf000 00:1a 137559 /home/ari/busybox/busybox 006d0000-006d1000 rw-p 000d0000 00:1a 137559 /home/ari/busybox/busybox 006d1000-006d4000 rw-p 00000000 00:00 0 014e7000-01508000 rw-p 00000000 00:00 0 [heap] 7f66d8f8a000-7f66d8fa0000 r-xp 00000000 08:07 1579008 /lib/x86_64-linux-gnu/libgcc_s.so.1 7f66d8fa0000-7f66d919f000 ---p 00016000 08:07 1579008 /lib/x86_64-linux-gnu/libgcc_s.so.1 7f66d919f000-7f66d91a0000 rw-p 00015000 08:07 1579008 /lib/x86_64-linux-gnu/libgcc_s.so.1 7f66d91a0000-7f66d935b000 r-xp 00000000 08:07 1578994 /lib/x86_64-linux-gnu/libc-2.19.so 7f66d935b000-7f66d955a000 ---p 001bb000 08:07 1578994 /lib/x86_64-linux-gnu/libc-2.19.so 7f66d955a000-7f66d955e000 r--p 001ba000 08:07 1578994 /lib/x86_64-linux-gnu/libc-2.19.so 7f66d955e000-7f66d9560000 rw-p 001be000 08:07 1578994 /lib/x86_64-linux-gnu/libc-2.19.so 7f66d9560000-7f66d9565000 rw-p 00000000 00:00 0 7f66d9565000-7f66d966a000 r-xp 00000000 08:07 1579020 /lib/x86_64-linux-gnu/libm-2.19.so 7f66d966a000-7f66d9869000 ---p 00105000 08:07 1579020 /lib/x86_64-linux-gnu/libm-2.19.so 7f66d9869000-7f66d986a000 r--p 00104000 08:07 1579020 /lib/x86_64-linux-gnu/libm-2.19.so 7f66d986a000-7f66d986b000 rw-p 00105000 08:07 1579020 /lib/x86_64-linux-gnu/libm-2.19.so 7f66d986b000-7f66d988e000 r-xp 00000000 08:07 1578981 /lib/x86_64-linux-gnu/ld-2.19.so 7f66d9a64000-7f66d9a67000 rw-p 00000000 00:00 0 7f66d9a8a000-7f66d9a8d000 rw-p 00000000 00:00 0 7f66d9a8d000-7f66d9a8e000 r--p 00022000 08:07 1578981 /lib/x86_64-linux-gnu/ld-2.19.so 7f66d9a8e000-7f66d9a8f000 rw-p 00023000 08:07 1578981 /lib/x86_64-linux-gnu/ld-2.19.so 7f66d9a8f000-7f66d9a90000 rw-p 00000000 00:00 0 7ffc47761000-7ffc47782000 rw-p 00000000 00:00 0 [stack] 7ffc477ab000-7ffc477ad000 r-xp 00000000 00:00 0 [vdso] ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0 [vsyscall] Aborted (core dumped) $ Fix this by simply always setting the mode, as it doesn't hurt even when O_CREAT is not specified. This bug is a regression introduced in fc3e40e, as xopen(), which was originally used, would automatically set the mode. Signed-off-by: Ari Sundholm <ari@tuxera.com> Signed-off-by: Mike Frysinger <vapier@gentoo.org>	2016-01-13 13:28:01 -05:00
Denys Vlasenko	ace833028f	stat: make -f optional. This allows to build stat for non-linux systems ... function old new delta packed_usage 30761 30706 -55 Based on the patch by Ron Yorston. Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-30 22:10:44 +01:00
Richard Genoud	d683c5c2f1	tr: support octal ranges ... now, we can do printf "a\tb\tcdef\n" | ./busybox tr -d "\1-\14b-e" af and bonus, we save some bytes. function old new delta expand 718 699 -19 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-19) Total: -19 bytes Signed-off-by: Richard Genoud <richard.genoud@gmail.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-26 17:18:07 +01:00
Denys Vlasenko	641caaec3d	libbb: factor out code which queries screen width ... function old new delta get_terminal_width - 17 +17 stty_main 1196 1197 +1 pstree_main 321 319 -2 ls_main 735 731 -4 watch_main 232 225 -7 bb_progress_update 714 706 -8 ps_main 555 543 -12 run_applet_and_exit 708 695 -13 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/6 up/down: 18/-46) Total: -28 byte Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-23 01:44:22 +02:00
Denys Vlasenko	0506e292b5	sort: fix ENDCHAR handling in "-kSTART,N.ENDCHAR" ... function old new delta get_key 505 503 -2 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-19 19:27:26 +02:00
Denys Vlasenko	d1ed3e68b8	sort: code shrink ... function old new delta compare_keys 738 695 -43 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-19 19:13:06 +02:00
Denys Vlasenko	fd19faf705	remove extra debug printout ... Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-19 14:48:24 +02:00
Denys Vlasenko	2e86a5c98d	sort: fix key with delimiters breakage ... function old new delta get_key 509 505 -4 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-19 14:44:51 +02:00
Denys Vlasenko	3d0805e9e7	libbb: make parse_chown_usergroup_or_die() set unspecified uid/gid to -1 ... function old new delta parse_chown_usergroup_or_die 102 115 +13 chown_main 190 175 -15 start_stop_daemon_main 1043 1027 -16 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/2 up/down: 13/-31) Total: -18 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-19 04:37:19 +02:00
Denys Vlasenko	f3d58a29be	od: get rid of (almost all) statics ... function old new delta od_main 2565 2600 +35 check_and_close 113 115 +2 static.prev_pair_equal 1 - -1 static.first 1 - -1 exit_code 1 - -1 string_min 4 - -4 n_specs 4 - -4 in_stream 4 - -4 format_address 4 - -4 file_list 4 - -4 bytes_per_block 4 - -4 get_lcm 120 115 -5 pseudo_offset 8 - -8 ------------------------------------------------------------------------------ (add/remove: 0/10 grow/shrink: 2/1 up/down: 37/-40) Total: -3 bytes text data bss dec hex filename 938487 932 17392 956811 e998b busybox_old 938519 924 17360 956803 e9983 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-19 02:51:56 +02:00
Aaro Koskinen	2735bc00e3	cpio: implement -R/--owner ... Implement -R/--owner to force ownership of files. function old new delta cpio_main 532 586 +54 get_header_cpio 909 939 +30 print 36 65 +29 cpio_o 804 832 +28 cpio_TRAILER - 11 +11 packed_usage 30667 30662 -5 static.trailer 11 - -11 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 4/1 up/down: 152/-16) Total: 136 bytes Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-16 17:24:46 +02:00
Denys Vlasenko	93dd9fd90a	du: extra compat: with -k and -m, round sizes up ... function old new delta print 36 65 +29 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-15 21:33:34 +02:00
Denys Vlasenko	0f296a3a56	libiproute: rename invarg(a,b) to invarg_1_to_2(a,b) ... invarg(a,b) - "invalid argument", but how a and b enter the message? invarg_1_to_2(a,b) is somewhat easier to read: "invalid argument 'a' to 'b'" Audit of usage revealed a number of bad uses, with too long messages. text data bss dec hex filename 938848 932 17448 957228 e9b2c busybox_old 938788 932 17448 957168 e9af0 busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-14 13:21:01 +02:00
Denys Vlasenko	d60752f8c9	build system: -fno-builtin-printf ... Benefits are: drops reference to out-of-line putchar(), fixes a few cases of failed string merge. function old new delta i2cdump_main 1488 1502 +14 sha256_process_block64 423 433 +10 sendmail_main 1183 1185 +2 list_table 1114 1116 +2 i2cdetect_main 1235 1237 +2 fdisk_main 2852 2854 +2 builtin_type 119 121 +2 unicode_conv_to_printable2 325 324 -1 scan_recursive 380 378 -2 mkfs_minix_main 2687 2684 -3 buffer_fill_and_print 178 169 -9 putchar 152 - -152 ------------------------------------------------------------------------------ (add/remove: 0/2 grow/shrink: 7/4 up/down: 34/-167) Total: -133 bytes text data bss dec hex filename 937788 932 17676 956396 e97ec busybox_old 937564 932 17676 956172 e970c busybox_unstripped Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 22:42:45 +02:00
Denys Vlasenko	5711a2a4ad	libbb: more compact API for bb_parse_mode() ... function old new delta make_device 2182 2188 +6 parse_command 1440 1443 +3 parse_params 1497 1499 +2 install_main 773 769 -4 mkdir_main 168 160 -8 getoptscmd 641 632 -9 builtin_umask 158 147 -11 bb_parse_mode 431 410 -21 umaskcmd 286 258 -28 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/6 up/down: 11/-81) Total: -70 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-07 17:55:33 +02:00
Denys Vlasenko	2b48c38be6	uudecode: tolerate text input with CR+LF line ends ... function old new delta read_stduu 265 308 +43 uudecode_main 313 317 +4 Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-10-05 15:10:44 +02:00
Denys Vlasenko	8aa7cf305b	sort: fix -kN,M handling (was including last separator into the comparison) ... Testcase: $ printf '%s\n' a/a:a a:b | sort -t: -k1,1 a:b a/a:a Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-09-19 22:06:40 +02:00
Ron Yorston	64ed5f0d3c	uname: make OS name configurable ... A mailing list thread in September 2013 discussed changing the string returned by the non-POSIX 'uname -o' option. Nothing ever came of this because there was no agreement as to what the string should be. Make the string configurable so that people can decide for themselves. Signed-off-by: Ron Yorston <rmy@frippery.org> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-08-03 18:09:18 +02:00
Mike Frysinger	670c3f7822	echo: make escape sequences depend on fancy mode ... Currently when you disable fancy echo, escape sequences are hardcoded enabled (e.g. as if you used `echo -e` all the time). The opposite behavior is more desirable (always disable -e support) because: * This seems to contradict the spirit of the kconfig help text (where it says enable support for -n/-e flags), although you could say that we aren't supporting the -e flag directly as `echo -e` will show the -e flag. * POSIX makes escape sequences optional, and even says they are there only on XSI-conformant systems. * It saves space (~100 bytes on x86_64). * It makes things faster! * It makes it behave more like bash where you need an explicit -e flag in order for escape sequences to be interpreted. Signed-off-by: Mike Frysinger <vapier@gentoo.org> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-07-31 03:47:49 +02:00
Denys Vlasenko	35ae2ccb40	sync: add support for -d -f FILE ... Based on the patch by Ari Sundholm <ari@tuxera.com> function old new delta sync_main 20 163 +143 packed_usage 30653 30673 +20 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 163/0) Total: 163 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-07-21 19:50:48 +02:00
Maninder Singh	97f2f7ca7f	Removes stray empty line from code ... This patch removes stray empty line from busybox code reported by script find_stray_empty_lines Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-07-13 03:25:46 +02:00
Maninder Singh	7db312ad26	fix whitespaces ... reported by script :- scripts/fix_ws.sh Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>	2015-06-07 18:19:47 +02:00