Denis Vlasenko
d0a071a528
brctl: eliminate stray data object
...
brctl: use constant fd to reduce parameter passing
runsvdir: do not use data/bss
od: reuse bb_argv_dash
last: do not go into endless loop on read error
mount: make it not fail scripts/find_bad_common_bufsiz check
dc: add INIT_G() (no-op for dc, but we want uniform usage of "G trick")
function old new delta
runsvdir_main 1646 1672 +26
set_pgrp 1 - -1
exitsoon 1 - -1
check 679 678 -1
svnum 4 - -4
svdir 4 - -4
sv 4 - -4
stamplog 4 - -4
rploglen 4 - -4
rplog 4 - -4
mount_main 995 988 -7
static.default_file_list 8 - -8
pfd 8 - -8
logpipe 8 - -8
static.info 20 - -20
brctl_main 767 739 -28
------------------------------------------------------------------------------
(add/remove: 0/12 grow/shrink: 1/3 up/down: 26/-106) Total: -80 bytes
text data bss dec hex filename
793327 662 7412 801401 c3a79 busybox_old
793329 641 7372 801342 c3a3e busybox_unstripped
2008-03-17 09:33:45 +00:00
Denis Vlasenko
b44c790e41
*: fix various kinds of damage to letter 'c' in Arkadiusz Mickiewicz' surname.
...
chrt,taskset,dc,eject: shrink
crontab: call "vi" with just name, no path
watchdog: intercept all fatal signals
function old new delta
xstrtoull_range - 35 +35
static.sg_commands - 18 +18
packed_usage 23698 23712 +14
watchdog_main 148 151 +3
crontab_main 637 638 +1
base 1 - -1
static.ps 4 - -4
pointer 4 - -4
stack_machine 99 92 -7
run_command 273 260 -13
eject_main 360 343 -17
static.C 30 12 -18
ptok 61 38 -23
xstrtol_range 27 - -27
get_token 35 - -35
taskset_main 586 550 -36
chrt_main 411 372 -39
dc_main 158 117 -41
time_main 1127 1037 -90
------------------------------------------------------------------------------
(add/remove: 2/5 grow/shrink: 3/9 up/down: 71/-355) Total: -284 bytes
text data bss dec hex filename
793680 662 7420 801762 c3be2 busybox_old
793327 662 7412 801401 c3a79 busybox_unstripped
2008-03-17 09:29:43 +00:00
Denis Vlasenko
68404f13d4
*: add -Wunused-parameter; fix resulting breakage
...
function old new delta
procps_scan 1265 1298 +33
aliascmd 278 283 +5
parse_file_cmd 116 120 +4
dname_enc 373 377 +4
setcmd 90 93 +3
execcmd 57 60 +3
count_lines 72 74 +2
process_command_subs 340 339 -1
test_main 409 407 -2
mknod_main 179 177 -2
handle_incoming_and_exit 2653 2651 -2
argstr 1312 1310 -2
shiftcmd 131 128 -3
exitcmd 46 43 -3
dotcmd 297 294 -3
breakcmd 86 83 -3
evalpipe 353 349 -4
evalcommand 1180 1176 -4
evalcmd 109 105 -4
send_tree 374 369 -5
mkfifo_main 82 77 -5
evalsubshell 152 147 -5
typecmd 75 69 -6
letcmd 61 55 -6
add_cmd 1190 1183 -7
main 891 883 -8
ash_main 1415 1407 -8
parse_stream 1377 1367 -10
alloc_procps_scan 55 - -55
------------------------------------------------------------------------------
(add/remove: 0/1 grow/shrink: 7/21 up/down: 54/-148) Total: -94 bytes
text data bss dec hex filename
797195 658 7428 805281 c49a1 busybox_old
797101 658 7428 805187 c4943 busybox_unstripped
2008-03-17 09:00:54 +00:00
Denis Vlasenko
397de617f3
help text: regularize format, and shrink
...
getty: shrink, and improve comments
mount: OPT_ALL is superfluous, we already have OPT_a
function old new delta
bcode 47 25 -22
getty_main 2503 2349 -154
packed_usage 23928 23698 -230
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-406) Total: -406 bytes
text data bss dec hex filename
798031 658 7428 806117 c4ce5 busybox_old
797604 658 7428 805690 c4b3a busybox_unstripped
2008-03-17 08:55:44 +00:00
Denis Vlasenko
a4522c5a66
mount: plug a hole where FEATURE_MOUNT_HELPERS could allow execution
...
of arbitrary command.
function old new delta
mount_it_now 266 309 +43
2008-03-17 08:46:43 +00:00
Bernhard Reutner-Fischer
51f421a55c
- fix compilation failure due to implicit decl of resolve_mount_spec().
...
DCE DTRT so remove the wrong guard.
2008-02-27 21:14:52 +00:00
Denis Vlasenko
53ce7f0d71
findfs,mount: trivial build fix and whitespace fiexs
2008-02-19 11:29:46 +00:00
Denis Vlasenko
de7684a309
support for mount by label (not yet tested)
...
Also adds findfs applet. Closes bug 1143.
2008-02-18 21:08:49 +00:00
Denis Vlasenko
b4133683a4
mount: with -vv -f, say what mount() calls we were going to make
...
782357 728 7476 790561 c1021 busybox_old
782429 728 7476 790633 c1069 busybox_unstripped
2008-02-18 13:05:38 +00:00
Denis Vlasenko
f732e96757
mount: optional support for -vv verbosity
...
mount: do "struct globals" trick
With -vv on:
function old new delta
verbose_mount - 83 +83
mount_main 970 988 +18
mount_it_now 219 229 +10
singlemount 4564 4570 +6
mount_option_str 227 233 +6
nfs_mount_version 1 - -1
fslist 4 - -4
------------------------------------------------------------------------------
(add/remove: 1/2 grow/shrink: 4/0 up/down: 123/-5) Total: 118 bytes
2008-02-18 12:07:49 +00:00
Denis Vlasenko
c9ca0a3274
mount: recognize "dirsync" (closes bug 835)
...
mount: sanitize environ if called by non-root
*: adjust for slightly different sanitize routine
2008-02-18 11:08:33 +00:00
Denis Vlasenko
b1d8e7db0f
mount: make -f work even without mtab support
...
(Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com>)
2008-02-16 23:28:42 +00:00
Denis Vlasenko
32d49bc70f
mkswap: do not do extra seek
...
mount: add another mount helper call method
2008-02-03 23:52:41 +00:00
Bernhard Reutner-Fischer
8c69afd992
- be C99 friendly. Anonymous unions are a GNU extension. This change is
...
size-neutral WRT -std=gnu99 and fixes several compilation errors for strict
C99 mode.
2008-01-29 10:33:34 +00:00
Denis Vlasenko
8c638cbf09
mount: allow and ignore _netdev option
2008-01-29 09:31:09 +00:00
Bernhard Reutner-Fischer
f470196a41
- fix conflicting decls of syslog related facilitynames and prioritynames tables
2008-01-27 12:50:12 +00:00
Denis Vlasenko
c03e872112
save a bit of code with *strchrnul = '\0' trick
...
function old new delta
nextline 59 55 -4
include_conf 902 898 -4
read_config 414 406 -8
fsck_main 1880 1869 -11
2007-12-26 20:56:55 +00:00
Denis Vlasenko
63430ae35a
mount: size-optimize mount_options[] and nfs_errtbl[]
...
777253 974 9676 787903 c05bf busybox_old
777209 974 9676 787859 c0593 busybox_unstripped
2007-10-29 19:18:39 +00:00
Denis Vlasenko
3f5fdc7572
remove trailing whitespace
2007-10-14 04:55:59 +00:00
Denis Vlasenko
9b49a5ed85
add -fvisibility=hidden to CC flags, mark XXX_main functions
...
EXTERNALLY_VISIBLE. 5% size reduction of libbusybox.so
2007-10-11 10:05:36 +00:00
Denis Vlasenko
0c97c9d437
'simple' error message functions by Loic Grenie <loic.grenie@gmail.com>.
...
263 bytes saved.
2007-10-01 11:58:38 +00:00
Denis Vlasenko
b925605441
assorted static vars removal
...
function old new delta
tcpudpsvd_main 1829 1839 +10
update_status 567 569 +2
sigterm 1 - -1
.........
dhcprelay_signal_handler 8 - -8
nfs_strerror 60 49 -11
singlemount 4579 4564 -15
static.p 16 - -16
svstatus 20 - -20
dhcprelay_xid_list 32 - -32
runsv_main 1785 1746 -39
static.buf 74 28 -46
svd 56 - -56
dhcprelay_main 1141 1080 -61
------------------------------------------------------------------------------
(add/remove: 0/20 grow/shrink: 2/10 up/down: 12/-386) Total: -374 bytes
2007-09-28 10:29:17 +00:00
Denis Vlasenko
2535f12cf2
httpd: do not clear environment
...
mount: mount helpers support (by Vladimir Dronnikov <dronnikov@gmail.ru>)
2007-09-15 13:28:30 +00:00
Denis Vlasenko
c8d4d2f11d
messages: by popular request allow PATH to be customized at build time
...
mount: smallish code shrink
2007-09-07 19:33:56 +00:00
Denis Vlasenko
f0000653e9
mount: ignore NFS bg option on NOMMU machines
2007-09-04 18:30:26 +00:00
Denis Vlasenko
fb48f6c982
mount: allow (and ignore) -i
2007-08-29 11:49:41 +00:00
Denis Vlasenko
7d8de4d55d
mount: don't close fd twice in NFS code
2007-08-28 11:23:23 +00:00
Denis Vlasenko
fe7cd642b0
don't pass argc in getopt32, it's superfluous
...
(add/remove: 0/0 grow/shrink: 12/131 up/down: 91/-727) Total: -636 bytes
text data bss dec hex filename
773469 1058 11092 785619 bfcd3 busybox_old
772644 1058 11092 784794 bf99a busybox_unstripped
2007-08-18 15:32:12 +00:00
Denis Vlasenko
a27a11bb2c
introduce and use xdup2(int, int)
...
stop checking whether setsockopt_reuseaddr(int fd) was successful (it always is)
remove second parameter (sockllen) from xmalloc_sockaddr2xxxxx functions
sockaddr2str 142 156 +14
collect_blk 467 474 +7
xdup2 28 33 +5
singlemount 4456 4454 -2
print_host 214 212 -2
nslookup_main 139 137 -2
ftpgetput_main 414 412 -2
udhcpd_main 1258 1255 -3
udhcpc_main 2405 2402 -3
traceroute_main 4125 4122 -3
nc_main 1072 1069 -3
buffer_fill_and_print 76 73 -3
xmalloc_sockaddr2hostonly_noport 18 14 -4
xmalloc_sockaddr2host_noport 18 14 -4
xmalloc_sockaddr2host 15 11 -4
xmalloc_sockaddr2dotted_noport 18 14 -4
xmalloc_sockaddr2dotted 18 14 -4
wget_main 2618 2614 -4
ping_main 393 389 -4
ip_port_str 120 115 -5
dhcprelay_main 1146 1141 -5
dnsd_main 1531 1525 -6
passwd_main 1110 1102 -8
udhcp_kernel_packet 206 197 -9
udhcp_listen_socket 154 144 -10
getty_main 2576 2566 -10
setup 655 640 -15
xmove_fd 51 34 -17
dolisten 759 742 -17
tcpudpsvd_main 1866 1836 -30
startservice 339 299 -40
2007-08-18 14:16:39 +00:00
Denis Vlasenko
6ca409e0e4
trylink: produce even more info about final link stage
...
trylink: explain how to modify link and drastically decrease amount
of padding (unfortunately, needs hand editing ATM).
*: add ALIGN1 / ALIGN2 to global strings and arrays of bytes and shorts
size saving: 0.5k
2007-08-12 20:58:27 +00:00
Denis Vlasenko
0e2c9fb4e0
mount: print errno on NFS error (again)
2007-08-03 14:16:24 +00:00
Denis Vlasenko
990d0f63ee
Replace index_in_[sub]str_array with index_in_[sub]strings,
...
which scans thru "abc\0def\0123\0\0" type strings. Saves 250 bytes.
text data bss dec hex filename
781266 1328 11844 794438 c1f46 busybox_old
781010 1328 11844 794182 c1e46 busybox_unstripped
2007-07-24 15:54:42 +00:00
Denis Vlasenko
80b8b39899
Consolidate ARRAY_SIZE macro; remove one unneeded global var (walter harms <wharms@bfs.de>)
2007-06-25 10:55:35 +00:00
Denis Vlasenko
b6adbf1be2
usage.c: remove reference to busybox.h
...
*: s/include "busybox.h"/include "libbb.h"
2007-05-26 19:00:18 +00:00
Denis Vlasenko
38ec147a18
mount: fix mounting of symlinks (mount from util-linux allows that)
2007-05-20 12:32:41 +00:00
Denis Vlasenko
68de720723
mount: fix incorrect usage of strtok (inadvertently used NULL sometimes).
...
the change is "for(xxx)...." -> "if(var) for(xxx)...", but my gcc 4.1.2
adds _158 bytes_!! WTF?? 8(
2007-05-09 20:38:04 +00:00
Denis Vlasenko
87468857f6
style fixes
2007-04-13 23:22:00 +00:00
Denis Vlasenko
51742f4bb0
style fixes. No code changes
2007-04-12 00:32:05 +00:00
Denis Vlasenko
240a1cfbbe
add some missed statics on constant objects.
...
fix few #ifndef ENABLE_xxx
# size busybox_old busybox_unstripped
text data bss dec hex filename
677152 2920 18208 698280 aa7a8 busybox_old
676420 2920 18208 697548 aa4cc busybox_unstripped
2007-04-08 16:07:02 +00:00
Denis Vlasenko
bf295dd5b6
[u]mount: extend -t option (Roy Marples <uberlord@gentoo.org>)
2007-04-05 21:57:47 +00:00
Denis Vlasenko
5870ad9672
mount: (try to) support cifs with IPv6
2007-02-04 02:39:55 +00:00
Denis Vlasenko
06af216528
suppress warnings about easch <applet>_main() having
...
no preceding prototype
2007-02-03 17:28:39 +00:00
Denis Vlasenko
06c0a71d23
preparatory patch for -Wwrite-strings #3
2007-01-29 22:51:44 +00:00
Denis Vlasenko
6cd2d2bcba
dnsd: getfileentry was leaking memory
...
mount: improve readability
2007-01-22 14:06:03 +00:00
Denis Vlasenko
9af7c9d6b6
openvt,getty,vfork_daemon_rexec,mount: tighten up fd cleanup code
...
(will close all fd's > 2 on daemonization now)
getty: fix "getty -" support, and also do not try to chown/chmod "-"
telnetd: fix "lost ctty" bug
Yet another attempt on saner function names:
bb_sanitize_server_stdio(0/1) -> bb_sanitize_stdio() + bb_daemonize();
2007-01-19 21:19:35 +00:00
Denis Vlasenko
666da5e2c6
merge post-1.3.0 fixes
2006-12-26 18:17:42 +00:00
Denis Vlasenko
28703015ab
u_short, ulong exterminated
...
fdiskXXX: add a bit of sanity (not enough by far)
2006-12-19 20:32:02 +00:00
Denis Vlasenko
908d6b7054
mount: add getmntent_r stub for dietlibc
2006-12-18 23:07:42 +00:00
Denis Vlasenko
5e90e10647
Closing bug 1040:
...
The "quiet" option is quietly (hah) ignored. It should be passed through
to the mount() syscall in the comma separated list of options.
I found the problem with the vfat/msdos filesystems, which uses
a quiet option to override some complaints and errors.
2006-11-27 19:50:16 +00:00
Denis Vlasenko
6a353c8158
mount: if FILE* is NULL, it's not wise to use it.
2006-11-19 17:34:57 +00:00
Denis Vlasenko
5af906e7c8
rename: compare_string_array -> index_in_str_array
...
introduce index_in_substr_array and use it in
iproute2
2006-11-05 18:05:09 +00:00
Denis Vlasenko
68f2187265
mount: use switch (compare_string_array(..))
...
where appropriate, saves >100 bytes.
2006-10-26 01:47:34 +00:00
Denis Vlasenko
d18a3a20db
use skip_whitespace where appropriate
2006-10-25 12:46:03 +00:00
Denis Vlasenko
13c5a6832f
mount: support user mounts if CONFIG_DESKTOP
2006-10-16 22:39:51 +00:00
Denis Vlasenko
2d5ca60bfb
bb_get_[chomped]line_from_file wasn't descriptive enough.
...
Renaming...
2006-10-12 22:43:20 +00:00
Denis Vlasenko
372686bde7
cut, mount: small improvements
2006-10-12 22:42:33 +00:00
Denis Vlasenko
1385899416
attempt to regularize atoi mess.
2006-10-08 12:49:22 +00:00
Denis Vlasenko
8f8f268cfd
bb_applet_name -> applet_name
2006-10-03 21:00:43 +00:00
Denis Vlasenko
67b23e6043
getopt_ulflags -> getopt32.
...
It is impossible to formulate sane ABI based on
size of ulong because it can be 32-bit or 64-bit.
Basically it means that you cannot portably use
more that 32 option chars in one call anyway...
Make it explicit.
2006-10-03 21:00:06 +00:00
Denis Vlasenko
546cd1881a
mount: accept and ignore -s (sloppy) option.
...
needed for compatibility with Linux automounter.
2006-10-02 18:52:49 +00:00
Denis Vlasenko
b1726785f9
mount: fix bug 946 (mount -f should update mtab)
2006-09-29 14:43:20 +00:00
Denis Vlasenko
da3cec9c85
mount: fix breakage from recent changes (spurious -ro mounts)
2006-09-24 01:01:01 +00:00
Denis Vlasenko
116080a13a
mount: make Rob happy by reinstating #defines
2006-09-21 11:13:08 +00:00
Denis Vlasenko
85f9e32f7f
mount: fstabname needs to be const char*
2006-09-19 14:14:12 +00:00
Denis Vlasenko
23514fe251
mount: fix warning (printf field width of * wants int, not size_t)
2006-09-19 14:07:52 +00:00
Denis Vlasenko
9213a9e0f2
whitespace cleanup
2006-09-17 16:28:10 +00:00
Denis Vlasenko
a6127aacef
mount: style fixlet
2006-09-17 15:51:52 +00:00
Denis Vlasenko
029c469934
mount: revert mount --bind to using "bind" as fstype.
2006-09-17 15:39:22 +00:00
Denis Vlasenko
a52145a927
mount: mount_it_now() - char *dir is not really needed.
2006-09-17 15:09:48 +00:00
Denis Vlasenko
c889d2b786
mount: fix "duplicate mount options in mtab" bug
2006-09-17 15:08:12 +00:00
Denis Vlasenko
c0975199be
mount: nfs_strerror's static buffer was bigger than needed.
2006-09-17 15:06:34 +00:00
Denis Vlasenko
9c99b62b9e
mount: getopt_ulflag'ification
2006-09-17 15:05:31 +00:00
Denis Vlasenko
13b4924ce0
mount: style fixes
2006-09-17 15:04:35 +00:00
Denis Vlasenko
3bc59aa2a4
mount: fix bugs: free(mp->mnt_fsname) of non-malloced ptr;
...
check for "more than 2 arguments" was actually checking for -2.
2006-09-17 15:04:01 +00:00
Denis Vlasenko
fc56dd2e21
mount: use bb_simplify_path as appropriate
2006-09-17 15:01:53 +00:00
Denis Vlasenko
8d474b5009
mount: style fixes
2006-09-17 15:00:58 +00:00
Denis Vlasenko
30a64cdc95
mount: reorder things, fix NFS-less mount.
2006-09-15 15:12:00 +00:00
Denis Vlasenko
be507170eb
mount: -o remount should not add lines to /etc/mtab
2006-09-14 16:09:27 +00:00
Denis Vlasenko
25098f7fd5
mount: move code from nfsmount.c into mount.c
2006-09-14 15:46:33 +00:00
Denis Vlasenko
727ef94447
mount: fix mtab support (but it is still rather buggy)
2006-09-14 13:19:19 +00:00
Denis Vlasenko
00d7d6cef6
nfsmount: sanitize it. It had a rather peculiar idea of implementing "bg"
...
option - it was going to return a special flag back to caller and
expecting caller to call it again with special parameter! Also
caller was charged with calling mount() syscall...
mount: mtab support was non-functional. Enabling it revealed serious bug
which is not fixed yet.
2006-09-11 17:42:44 +00:00
Denis Vlasenko
39e93cc951
nfsmount: nfsmount.h merged into nfsmount.c
2006-09-10 18:38:17 +00:00
Denis Vlasenko
6d655be5df
removed a lot of trailing \n in bb_msg() calls. It is added
...
automatically by function itself.
2006-09-06 19:02:46 +00:00
Rob Landley
4cb035dd23
Vladimir Dronnikov (ybrnj80 at yandex dot ru) pointed out that my cleanup of
...
his code introduced a bug (an extra backslash in the CIFS mount string).
2006-09-05 14:00:21 +00:00
Rob Landley
4d609cb5a3
Thinko.
2006-09-04 19:43:26 +00:00
Rob Landley
89d9d4d5f7
Vladimir Dronnikov also submitted a CIFS support patch to mount, which I
...
heavily reworked here and probably broke. Tomorrow I need to set up a
copy of samba to test against. (This compiles, I make no promises beyond that.)
2006-09-01 08:10:44 +00:00
Rob Landley
3ba7bd143e
Vladimir Dronnikov convinced me to twiddle the semantics of the new shared
...
subtree stuff to look more like http://lwn.net/Articles/159077/ thinks
they should.
2006-08-09 19:51:13 +00:00
Rob Landley
721b46e0e6
Fix a typo (|| instead of |) and remove two comments about a problem fixed
...
in the previous patch.
2006-08-08 12:54:02 +00:00
Rob Landley
e3781b7312
Add shared subtree support, suggested by Vladimir Dronnikov. Also break out a
...
few new (unfinished) config options, which I intend to make hidden (but
enabled) when CONFIG_NITPICK is disabled. Getting the .config infrastructure
to do that is non-obvious, it seems...
2006-08-08 01:39:49 +00:00
Rob Landley
47b16a6fe9
Using lstat() instead of stat() means that attempting to loopback mount
...
a symlink doesn't work.
2006-08-08 00:47:17 +00:00
Rob Landley
d921b2ecc0
Remove bb_ prefixes from xfuncs.c (and a few other places), consolidate
...
things like xasprintf() into xfuncs.c, remove xprint_file_by_name() (it only
had one user), clean up lots of #includes... General cleanup pass. What I've
been doing for the last couple days.
And it conflicts! I've removed httpd.c from this checkin due to somebody else
touching that file. It builds for me. I have to catch a bus. (Now you know
why I'm looking forward to Mercurial.)
2006-08-03 15:41:12 +00:00
Rob Landley
0cc2c2c289
Patch from Paul Fox to improve mount's error handling behavior, which I beat
...
on a bit.
2006-06-21 03:53:33 +00:00
Rob Landley
dbfb5a3cb7
Andre (armcc2200@yahoo) patched a bug where successful mounts could sometimes
...
produce an error, due to a missing rc assignment.
2006-06-21 02:39:57 +00:00
Rob Landley
22d26fc6ae
Patch from Yann Morin to put BLKGETSIZE64 in platform.h had rather a lot of
...
fallout due to the #include <sys/mount.h>. Removed that #include from various
applets and fixed up those that were unhappy when that #include was made
because they'd block copied stuff out of it. (Sigh.)
2006-06-15 15:49:36 +00:00
Rob Landley
8bb50782a5
Change llist_add_* to take the address of the list rather than returning the new
...
head, and change all the callers.
2006-05-26 23:44:51 +00:00
Bernhard Reutner-Fischer
08421e1d0c
- work around bug in gcc-3.4.x on ARM
2006-05-26 14:05:48 +00:00
Rob Landley
a6b5b60942
Fiddling with llist to make memory management easier. Specifically, the
...
option to delete the contents of the list when we delete the list is a
good thing.
2006-05-08 19:03:07 +00:00
Rob Landley
49159c7f94
Patch from Jason Schoon to make mount -a not abort on the first failure.
2006-05-05 15:01:38 +00:00
Rob Landley
19af279d16
Kumar spotted another bug: if we autodetect nfs and they haven't specified the
...
fstype, it should be set to nfs.
2006-04-05 01:43:39 +00:00
Rob Landley
ab8736064b
You'd think there'd be a compiler warning for "pointless if", wouldn't you?
2006-04-04 16:56:04 +00:00