emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
17,256 Commits 1 Branch 0 Tags 33 MiB
eb60777769
Commit Graph

44 Commits

Author SHA1 Message Date
Denys Vlasenko
8d718686f7 tar: fix testsuite 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2021-08-16 00:48:50 +02:00
Denys Vlasenko
332a191e7f testsuite/tar.tests: fix false positive 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2018-06-27 14:35:56 +02:00
Denys Vlasenko
5738823dff testsuite/tar.tests: fix false positive 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2018-06-27 10:01:49 +02:00
Harald van Dijk
8c24af9dcf tar: fix interaction of delayed symlink and hardlink creation 
function                                             old     new   delta
create_or_remember_link                                -     106    +106
create_links_from_list                                 -      93     +93
find_applet_by_name                                  124     128      +4
unzip_main                                          2724    2726      +2
data_extract_all                                     891     873     -18
create_symlinks_from_list                             64       -     -64
create_or_remember_symlink                            94       -     -94
------------------------------------------------------------------------------
(add/remove: 2/2 grow/shrink: 2/1 up/down: 205/-176)           Total: 29 bytes

Signed-off-by: Harald van Dijk <harald@gigawatt.nl>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2018-05-22 17:34:31 +02:00
Denys Vlasenko
a84db18fc7 tar,unzip: postpone creation of symlinks with "suspicious" targets 
This mostly reverts commit bc9bbeb2b8
"libarchive: do not extract unsafe symlinks unless $EXTRACT_UNSAFE_SYMLINKS=1"

Users report that it is somewhat too restrictive. See
https://bugs.busybox.net/show_bug.cgi?id=8411

In particular, this interferes with unpacking of busybox-based
filesystems with links like "sbin/applet" -> "../bin/busybox".

The change is made smaller by deleting ARCHIVE_EXTRACT_QUIET flag -
it is unused since 2010, and removing conditionals on it
allows commonalizing some error message codes.

function                                             old     new   delta
create_or_remember_symlink                             -      94     +94
create_symlinks_from_list                              -      64     +64
tar_main                                            1002    1006      +4
unzip_main                                          2732    2724      -8
data_extract_all                                     984     891     -93
unsafe_symlink_target                                147       -    -147
------------------------------------------------------------------------------
(add/remove: 2/1 grow/shrink: 1/2 up/down: 162/-248)          Total: -86 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2018-02-20 16:06:53 +01:00
Denys Vlasenko
bc9bbeb2b8 libarchive: do not extract unsafe symlinks unless $EXTRACT_UNSAFE_SYMLINKS=1 
function                                             old     new   delta
unsafe_symlink_target                                  -     147    +147
unzip_main                                          2711    2732     +21
copy_file                                           1657    1678     +21
tar_main                                             999     971     -28
data_extract_all                                    1038     984     -54
------------------------------------------------------------------------------
(add/remove: 2/0 grow/shrink: 2/2 up/down: 189/-82)           Total: 107 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2017-08-10 11:52:42 +02:00
Denys Vlasenko
b920a38dc0 tar: postpone creation of symlinks with "suspicious" targets. Closes 8411 
function                                             old     new   delta
data_extract_all                                     968    1038     +70
tar_main                                             952     986     +34
scan_tree                                            258     262      +4
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/0 up/down: 108/0)             Total: 108 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2017-07-24 17:20:13 +02:00
Denys Vlasenko
76de3257f7 randomconfig fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2016-12-12 19:17:12 +01:00
Denys Vlasenko
df25df784f randomconfig fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2016-12-12 14:33:53 +01:00
Denys Vlasenko
de912f0153 randomconfig fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2016-12-12 11:08:51 +01:00
Denys Vlasenko
52ae098011 randomconfig fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2016-12-12 09:26:16 +01:00
Denys Vlasenko
9655f95d0f tar: handle pax-encoded utf8 filenames and link names. Closes 9406 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2016-11-11 17:56:45 +01:00
Denys Vlasenko
ecf25cb5bc randomconfig fixes 5: false positive for tar; mount emits corrupted message 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2016-06-20 11:04:04 +02:00
Denys Vlasenko
0ad872baf3 randomconfig fixes 4 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2016-06-20 01:40:19 +02:00
Denys Vlasenko
bb0bf287d8 randomconfig fixes 2 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2016-06-19 21:54:04 +02:00
Denys Vlasenko
a960748748 tar: add a test that we don't write into symlinks 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2015-10-22 16:37:01 +02:00
Denys Vlasenko
6c563e370d tar: add support for --strip-components=N 
function                                             old     new   delta
data_extract_all                                     882     995    +113
tar_longopts                                         290     309     +19
tar_main                                             938     942      +4
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 3/0 up/down: 136/0)             Total: 136 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2015-10-22 01:07:13 +02:00
Denys Vlasenko
7625811d25 testsuite: remove forgotten debug hack 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2013-12-31 23:25:46 +01:00
Denys Vlasenko
198b02f7dd fix failures found by randomconfig builds 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2013-12-31 23:22:36 +01:00
Denys Vlasenko
0545e3b69a tar: prevent empty file to be treated as valid tarball 
function                                             old     new   delta
tar_main                                             879     895     +16

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2013-11-19 17:17:48 +01:00
Denys Vlasenko
dd1d8ab506 fix a copy/paste error in last tar testcase name 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2013-11-19 16:56:26 +01:00
Denys Vlasenko
1cbc642bed tar: add a testcase for previous commit 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2013-11-19 14:52:02 +01:00
Denys Vlasenko
bb8d7db597 testsuite: add a test that tar detects XZ-compressed data 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2012-03-06 16:57:01 +01:00
Denys Vlasenko
b47b3ce1bd randomconfig fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-08-10 00:51:29 +02:00
Denys Vlasenko
b80acf58f1 tar: skip leading / and handle names like abc/..////def -> def (not ///def) 
function                                             old     new   delta
strip_unsafe_prefix                                    -     105    +105
writeFileToTarball                                   557     520     -37
get_header_tar                                      1545    1462     -83

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-03-02 01:21:02 +01:00
Denys Vlasenko
5e29e26388 tar: on extract, everything up to and including last ".." is stripped 
function                                             old     new   delta
get_header_tar                                      1493    1545     +52

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-03-01 17:21:07 +01:00
Denys Vlasenko
b8ab4b0388 typo fix 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-02-06 20:02:15 +01:00
Denys Vlasenko
aef441cb4d tar: fix a bug where autodetection messes up -z on extract 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2011-02-06 20:01:11 +01:00
Dan Fandrich
80d80ba6dd Fixed a couple of failing tar tests 
The tar symlinks mode test is fixed similarly to the hardlinks
test in 0d7cb4cc, and the read-only test is skipped by
SKIP_KNOWN_BUGS.

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
 2010-09-12 16:19:33 +02:00
Dan Fandrich
8d789e4197 tar: add a test for extraction of read-only directory 
Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
 2010-09-05 16:16:46 +02:00
Denys Vlasenko
0d7cb4cc9e fix false positive in testsuite/tar.tests 
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
 2010-09-03 17:22:56 +02:00
Dan Fandrich
eb2bf5b6bf Fix some test cases 
The tar tests still don't pass, but at least now it's because of
a problem with Busybox and not the tests themselves.

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
 2010-09-03 17:09:51 +02:00
Denys Vlasenko
0ef64bdb40 *: make GNU licensing statement forms more regular 
This change retains "or later" state! No licensing _changes_ here,
only form is adjusted (article, space between "GPL" and "v2" and so on).

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2010-08-16 20:14:46 +02:00
Dan Fandrich
775965de85 Improved portability of tests 
Removed assumptions about umask and locale. Fixed hostname
tests to work even when the host has no DNS domain set.

Signed-off-by: Dan Fandrich <dan@coneharvesters.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2010-08-11 14:09:28 +02:00
Denys Vlasenko
e82cf339e4 randomtest fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2010-05-12 15:59:32 +02:00
Denys Vlasenko
da1382410b randomtest fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2010-05-11 12:02:48 +02:00
Denys Vlasenko
bfa1b2e8e8 randomtest fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2010-05-11 03:53:57 +02:00
Denys Vlasenko
e3d90a90d4 randomconfig testsuite fixes 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2010-05-10 05:53:16 +02:00
Denys Vlasenko
e69ad87802 tar: fix "hardlinks to symlinks chown" bug 1519. 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2010-04-09 14:11:45 +02:00
Denys Vlasenko
02365a6ef7 tar: fix mishandling of repeated hardlink in tarball; expand tests 
function                                             old     new   delta
data_extract_all                                     727     767     +40
get_header_tar                                      1576    1572      -4

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2010-04-09 10:52:52 +02:00
Chris Metcalf
208d35d21f testsuite fixes 
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2010-04-02 09:57:27 +02:00
Denys Vlasenko
8a936cfab7 tar: add support for --overwrite. +70 bytes. 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2009-12-16 23:18:59 +01:00
Denys Vlasenko
425ad9c93b libunarchive: move dpkg-specific things into dpkg.c. 0 byte size differences 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2009-12-16 22:46:01 +01:00
Denys Vlasenko
bf22475e95 tar: add a test for latest fix 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
 2009-11-29 19:09:29 +01:00