busybox/shell
Colin Watson 3963d943f8 ash: refresh stack pointers after makestrspace in rmescapes
Without this, rmescapes sometimes returns random garbage while
performing parameter expansions such as ${foo#bar}, in the event that
the allocation of r happens to need to reallocate the stack and hence
invalidate str and p.  I'd love to provide a test case but unfortunately
it's dependent on exact stack layout, so I don't have anything simpler
than the situation described in
https://bugs.launchpad.net/ubuntu/+source/partman-base/+bug/527401/comments/23
which involved a sequence of foo="${foo#*, }" expansions on a long
string inside our RAID configuration tool.

The same fix has been in dash since 2007-09-26, contributed by Roy
Marples <uberlord@gentoo.org>.  I actually came up with it independently
almost to the character, but then synced it up with the variable naming
used in dash when I noticed that change afterwards.

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2010-04-26 14:21:27 +02:00
..
ash_test ash: trap with bad signal name should not abort 2010-03-26 15:52:24 +01:00
hush_test whitespace fixes 2010-01-25 13:39:24 +01:00
msh_test whitespace fixes 2010-01-25 13:39:24 +01:00
ash_doc.txt ash: fix TRACE commands 2009-03-19 23:09:58 +00:00
ash_ptr_hack.c fix build with gcc -combine 2008-04-11 11:27:29 +00:00
ash.c ash: refresh stack pointers after makestrspace in rmescapes 2010-04-26 14:21:27 +02:00
bbsh.c *: remove some uses of argc 2010-01-04 14:15:38 +01:00
brace.txt hush: wait for cmd to complete, and immediately store its exitcode in $? 2009-11-15 19:58:19 +01:00
builtin_read.c shell/read: check that variable names are sane 2010-01-13 18:22:35 +01:00
builtin_read.h hush: use ash's read builtin 2010-01-12 23:29:57 +01:00
builtin_ulimit.c shell/ulimit: code shrink by 10 bytes 2010-03-08 23:28:30 +01:00
builtin_ulimit.h hush: use ash's ulimit builtin; make it more more bash0like while at it 2010-03-06 20:12:00 +01:00
Config.in ash: remove config items for read options which are no longer optional 2010-01-13 18:31:29 +01:00
cttyhack.c switch_root: improve behavior on error; improve help text 2009-04-21 20:40:51 +00:00
hush_doc.txt hush: implement break and continue 2008-07-28 23:04:34 +00:00
hush_leaktool.sh hush: fix "export not_yet_defined_var", fix parsing of "cmd | }" 2009-04-19 23:07:51 +00:00
hush.c *: merge some common strings 2010-03-23 16:25:17 +01:00
Kbuild hush: use ash's ulimit builtin; make it more more bash0like while at it 2010-03-06 20:12:00 +01:00
lash_unused.c *: style fixes. no code changes (verified with objdump) 2010-01-28 02:24:24 +01:00
match.c shell: split read builtin from ash 2010-01-12 22:11:24 +01:00
match.h hush: use ash's read builtin 2010-01-12 23:29:57 +01:00
math.c hush: use ash's read builtin 2010-01-12 23:29:57 +01:00
math.h hush: use ash's read builtin 2010-01-12 23:29:57 +01:00
msh_unused.c style fixes, no code changes 2010-01-28 12:30:24 +01:00
random.c ash,hush: fix $RANDOM in children being repeated 2009-10-12 15:25:01 +02:00
random.h shell: split read builtin from ash 2010-01-12 22:11:24 +01:00
README
README.job
shell_common.c shell/read: check that variable names are sane 2010-01-13 18:22:35 +01:00
shell_common.h shell/read: check that variable names are sane 2010-01-13 18:22:35 +01:00

Various bits of what is known about busybox shells, in no particular order.

2008-02-14
ash: does not restore tty pgrp if killed by HUP. Symptom: Midnight Commander
is backgrounded if you started ash under it, and then killed it with HUP.

2007-11-23
hush: fixed bogus glob handling; fixed exec <"$1"; added test and echo builtins

2007-06-13
hush: exec <"$1" doesn't do parameter subst

2007-05-24
hush: environment-related memory leak plugged, with net code size
decrease.

2007-05-24
hush: '( echo ${name )' will show syntax error message, but prompt
doesn't return (need to press <enter>). Pressing Ctrl-C, <enter>,
'( echo ${name )' again, Ctrl-C segfaults.

2007-05-21
hush: environment cannot be handled by libc routines as they are leaky
(by API design and thus unfixable): hush will leak memory in this script,
bash does not:
pid=$$
while true; do
    unset t;
    t=111111111111111111111111111111111111111111111111111111111111111111111111
    export t
    ps -o vsz,pid,comm | grep " $pid "
done
The fix is to not use setenv/putenv/unsetenv but manipulate env ourself. TODO.
hush: meanwhile, first three command subst bugs mentioned below are fixed. :)

2007-05-06
hush: more bugs spotted. Comparison with bash:
bash-3.2# echo "TEST`date;echo;echo`BEST"
TESTSun May  6 09:21:05 CEST 2007BEST         [we dont strip eols]
bash-3.2# echo "TEST`echo '$(echo ZZ)'`BEST"
TEST$(echo ZZ)BEST                            [we execute inner echo]
bash-3.2# echo "TEST`echo "'"`BEST"
TEST'BEST                                     [we totally mess up this one]
bash-3.2# echo `sleep 5`
[Ctrl-C should work, Ctrl-Z should do nothing][we totally mess up this one]
bash-3.2# if true; then
> [Ctrl-C]
bash-3.2#                                     [we re-issue "> "]
bash-3.2# if echo `sleep 5`; then
> true; fi                                    [we execute sleep before "> "]

2007-05-04
hush: made ctrl-Z/C work correctly for "while true; do true; done"
(namely, it backgrounds/interrupts entire "while")

2007-05-03
hush: new bug spotted: Ctrl-C on "while true; do true; done" doesn't
work right:
# while true; do true; done
[1] 0 true <-- pressing Ctrl-C several times...
[2] 0 true
[3] 0 true
Segmentation fault

2007-05-03
hush: update on "sleep 1 | exit 3; echo $?" bug.
parse_stream_outer() repeatedly calls parse_stream().
parse_stream() is now fixed to stop on ';' in this example,
fixing it (parse_stream_outer() will call parse_stream() 1st time,
execute the parse tree, call parse_stream() 2nd time and execute the tree).
But it's not the end of story.
In more complex situations we _must_ parse way farther before executing.
Example #2: "{ sleep 1 | exit 3; echo $?; ...few_lines... } >file".
Because of redirection, we cannot execute 1st pipe before we parse it all.
We probably need to learn to store $var expressions in parse tree.
Debug printing of parse tree would be nice too.

2007-04-28
hush: Ctrl-C and Ctrl-Z for single NOFORK commands are working.
Memory and other resource leaks (opendir) are not addressed
(testcase is "rm -i" interrupted by ctrl-c).

2007-04-21
hush: "sleep 5 | sleep 6" + Ctrl-Z + fg seems to work.
"rm -i" + Ctrl-C, "sleep 5" + Ctrl-Z still doesn't work
for SH_STANDALONE case :(

2007-04-21
hush: fixed non-backgrounding of "sleep 1 &" and totally broken
"sleep 1 | sleep 2 &". Noticed a bug where successive jobs
get numbers 1,2,3 even when job #1 has exited before job# 2 is started.
(bash reuses #1 in this case)

2007-04-21
hush: "sleep 1 | exit 3; echo $?" prints 0 because $? is substituted
_before_ pipe gets executed!! run_list_real() already has "pipe;echo"
parsed and handed to it for execution, so it sees "pipe"; "echo 0".

2007-04-21
hush: removed setsid() and made job control sort-of-sometimes-work.
Ctrl-C in "rm -i" works now except for SH_STANDALONE case.
"sleep 1 | exit 3" + "echo $?" works, "sleep 1 | exit 3; echo $?"
shows exitcode 0 (should be 3). "sleep 1 | sleep 2 &" fails horribly.

2007-04-14
lash, hush: both do setsid() and as a result don't have ctty!
Ctrl-C doesn't work for any child (try rm -i), etc...
lash: bare ">file" doesn't create a file (hush works)