busybox/shell/hush_test/hush-redir
Denys Vlasenko 41ef41b3e0 hush: fix nested redirects colliding with script fds
This necessitates switch from libc FILE api to a simple
homegrown replacement.
The change which fixes the bug here is the deleting of

	restore_redirected_FILEs();

line. It was prematurely moving (restoring) script fd#3.
The fix is: we don't even _want_ to restore scrit fds,
we are perfectly fine with them being moved.
The only reason we tried to restore them is that FILE api
did not allow moving of FILE->fd.

function                                             old     new   delta
refill_HFILE_and_getc                                  -      93     +93
hfopen                                                 -      90     +90
hfclose                                                -      66     +66
pseudo_exec_argv                                     591     597      +6
hush_main                                           1089    1095      +6
builtin_source                                       209     214      +5
save_fd_on_redirect                                  197     200      +3
setup_redirects                                      320     321      +1
fgetc_interactive                                    235     236      +1
i_peek_and_eat_bkslash_nl                             99      97      -2
expand_vars_to_list                                 1103    1100      -3
restore_redirects                                     99      52     -47
fclose_and_forget                                     57       -     -57
remember_FILE                                         63       -     -63
------------------------------------------------------------------------------
(add/remove: 3/2 grow/shrink: 6/3 up/down: 271/-172)           Total: 99 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2018-07-24 16:54:41 +02:00
..
redir1.right
redir1.tests
redir2.right sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir2.tests sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir3.right hush: fix two redirection testcase failures 2017-07-07 22:07:28 +02:00
redir3.tests hush: add a TODO about redir3.tests failure 2017-07-06 20:57:37 +02:00
redir4.right sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir4.tests sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir5.right
redir5.tests
redir6.right sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir6.tests sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir7.right
redir7.tests
redir8.right
redir8.tests
redir9.right
redir9.tests
redir_backquote1.right hush: fix a few more corner cases with empty-expanding cmds 2018-04-05 15:15:53 +02:00
redir_backquote1.tests hush: fix a few more corner cases with empty-expanding cmds 2018-04-05 15:15:53 +02:00
redir_children_should_not_see_saved_fd_1.right ash,hush: fix "saved" redirected fds still visible in children 2018-03-28 18:35:07 +02:00
redir_children_should_not_see_saved_fd_1.tests ash,hush: fix "saved" redirected fds still visible in children 2018-03-28 18:35:07 +02:00
redir_children_should_not_see_saved_fd_2.right ash,hush: fix "saved" redirected fds still visible in children 2018-03-28 18:35:07 +02:00
redir_children_should_not_see_saved_fd_2.tests ash,hush: fix "saved" redirected fds still visible in children 2018-03-28 18:35:07 +02:00
redir_children_should_not_see_saved_fd_3.right ash,hush: fix "saved" redirected fds still visible in children 2018-03-28 18:35:07 +02:00
redir_children_should_not_see_saved_fd_3.tests ash,hush: fix "saved" redirected fds still visible in children 2018-03-28 18:35:07 +02:00
redir_errors.right hush: rename hush-redir/redir3.tests (ash has redir3.tests which id different) 2017-07-06 20:36:40 +02:00
redir_errors.tests hush: rename hush-redir/redir3.tests (ash has redir3.tests which id different) 2017-07-06 20:36:40 +02:00
redir_escapednum.right sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir_escapednum.tests sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir_exec1.right hush: fix corner cases with exec in empty expansions 2018-04-05 14:41:21 +02:00
redir_exec1.tests hush: fix corner cases with exec in empty expansions 2018-04-05 14:41:21 +02:00
redir_expand.right sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir_expand.tests sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir_leak.right ash: fix open fds leaking in redirects. Closes 9561 2017-01-07 10:16:56 +01:00
redir_leak.tests ash: fix open fds leaking in redirects. Closes 9561 2017-01-07 10:16:56 +01:00
redir_multi.right sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir_multi.tests sh testsuite: sync ash-redir/ and hush-redir/ 2016-10-02 18:32:52 +02:00
redir_script.right
redir_script.tests hush: fix nested redirects colliding with script fds 2018-07-24 16:54:41 +02:00
redir_space.right
redir_space.tests
redir_to_bad_fd3.right ash: significant overhaul of redirect saving logic 2017-07-31 04:21:46 +02:00
redir_to_bad_fd3.tests ash: significant overhaul of redirect saving logic 2017-07-31 04:21:46 +02:00
redir_to_bad_fd255.right ash: significant overhaul of redirect saving logic 2017-07-31 04:21:46 +02:00
redir_to_bad_fd255.tests ash: significant overhaul of redirect saving logic 2017-07-31 04:21:46 +02:00
redir_to_bad_fd.right hush: fix two redirection testcase failures 2017-07-07 22:07:28 +02:00
redir_to_bad_fd.tests shell: sync redir/* tests 2017-07-06 21:01:50 +02:00
redir.right hush: fix a case when redirect to a closed fd #1 is not restoring (closing) it 2017-07-24 12:42:17 +02:00
redir.tests hush: fix a case when redirect to a closed fd #1 is not restoring (closing) it 2017-07-24 12:42:17 +02:00
redirA.right
redirA.tests