emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
41ef41b3e0
busybox/shell/hush_test
History
Denys Vlasenko 41ef41b3e0 hush: fix nested redirects colliding with script fds 
This necessitates switch from libc FILE api to a simple
homegrown replacement.
The change which fixes the bug here is the deleting of

	restore_redirected_FILEs();

line. It was prematurely moving (restoring) script fd#3.
The fix is: we don't even _want_ to restore scrit fds,
we are perfectly fine with them being moved.
The only reason we tried to restore them is that FILE api
did not allow moving of FILE->fd.

function                                             old     new   delta
refill_HFILE_and_getc                                  -      93     +93
hfopen                                                 -      90     +90
hfclose                                                -      66     +66
pseudo_exec_argv                                     591     597      +6
hush_main                                           1089    1095      +6
builtin_source                                       209     214      +5
save_fd_on_redirect                                  197     200      +3
setup_redirects                                      320     321      +1
fgetc_interactive                                    235     236      +1
i_peek_and_eat_bkslash_nl                             99      97      -2
expand_vars_to_list                                 1103    1100      -3
restore_redirects                                     99      52     -47
fclose_and_forget                                     57       -     -57
remember_FILE                                         63       -     -63
------------------------------------------------------------------------------
(add/remove: 3/2 grow/shrink: 6/3 up/down: 271/-172)           Total: 99 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2018-07-24 16:54:41 +02:00
..
hush-arith ash: parser: Add syntax stack for recursive parsing 2018-04-02 13:15:37 +02:00
hush-bugs hush: fix and_or_and_backgrounding.tests failure 2017-07-15 22:51:55 +02:00
hush-getopts hush: fix "getopts" builtin to not be upset by other builtins calling getopt() 2017-08-29 13:38:30 +02:00
hush-glob hush: never glob result of dquoted "${v:+/bin/c*}" 2018-07-20 19:29:41 +02:00
hush-heredoc hush: fix nested redirects colliding with script fds 2018-07-24 16:54:41 +02:00
hush-invert hush testsuite: add many tests from ash testsuite 2016-10-02 17:39:31 +02:00
hush-leak
hush-misc hush: support "f() (cmd)" functions 2018-04-03 14:56:52 +02:00
hush-parsing hush: fix recent breakage from parse_stream() changes 2018-04-11 20:00:43 +02:00
hush-psubst hush: fix a few more corner cases with empty-expanding cmds 2018-04-05 15:15:53 +02:00
hush-quoting hush: fix handling of '' in ${var:+ARG} 2018-07-20 17:36:06 +02:00
hush-read hush: fix IFS handling in read 2018-04-11 17:18:34 +02:00
hush-redir hush: fix nested redirects colliding with script fds 2018-07-24 16:54:41 +02:00
hush-signals hush: add support for "set -e" 2017-07-14 13:36:48 +02:00
hush-standalone ash: fix nofork bug where environment is not properly passed to a command 2017-11-03 14:16:25 +01:00
hush-vars hush: IFS fixes 2018-04-11 16:02:58 +02:00
hush-z_slow hush: improve ${var#...}, ${var:+...} and ${var/.../...} - handle quoting 2018-07-17 14:21:38 +02:00
.gitignore
run-all nofork: fix a bug uncovered by hush testsuite (forgotten fflush) 2017-08-03 19:52:47 +02:00