busybox/testsuite
Denys Vlasenko a84db18fc7 tar,unzip: postpone creation of symlinks with "suspicious" targets
This mostly reverts commit bc9bbeb2b8
"libarchive: do not extract unsafe symlinks unless $EXTRACT_UNSAFE_SYMLINKS=1"

Users report that it is somewhat too restrictive. See
https://bugs.busybox.net/show_bug.cgi?id=8411

In particular, this interferes with unpacking of busybox-based
filesystems with links like "sbin/applet" -> "../bin/busybox".

The change is made smaller by deleting ARCHIVE_EXTRACT_QUIET flag -
it is unused since 2010, and removing conditionals on it
allows commonalizing some error message codes.

function                                             old     new   delta
create_or_remember_symlink                             -      94     +94
create_symlinks_from_list                              -      64     +64
tar_main                                            1002    1006      +4
unzip_main                                          2732    2724      -8
data_extract_all                                     984     891     -93
unsafe_symlink_target                                147       -    -147
------------------------------------------------------------------------------
(add/remove: 2/1 grow/shrink: 1/2 up/down: 162/-248)          Total: -86 bytes

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
2018-02-20 16:06:53 +01:00
..
basename *: trailing empty lines removed 2010-07-26 01:49:12 +02:00
bunzip2 randomconfig fixes 2016-12-12 09:26:16 +01:00
bzcat randomconfig fixes 2016-12-12 09:26:16 +01:00
cat
cmp
cp testsuite fixes 2010-04-02 09:57:27 +02:00
cut randomtest fixes 2010-05-12 15:59:32 +02:00
date testsuite: disable tests for no longer supported bbox-specific date formats 2013-12-31 18:57:39 +01:00
dd
dirname *: trailing empty lines removed 2010-07-26 01:49:12 +02:00
du randomconfig fixes 3 2016-06-20 00:36:21 +02:00
echo echo: fix ENOSPC detection and some iffy code in \NNN handling 2011-02-14 15:42:18 +01:00
expand randomtest fixes 2010-05-12 15:59:32 +02:00
expr *: trailing empty lines removed 2010-07-26 01:49:12 +02:00
false
find randomtest fixes 2010-05-11 03:53:57 +02:00
gunzip
gzip gzip: add test that checks that -9 compresses better than -1 2016-08-15 01:31:17 +02:00
head
hostid fix bashisms in testsuite/ 2013-11-10 22:06:06 +01:00
hostname Improved portability of tests 2010-08-11 14:09:28 +02:00
id
ln *: trailing empty lines removed 2010-07-26 01:49:12 +02:00
ls randomtest fixes 2010-05-11 03:53:57 +02:00
md5sum randomtest fixes 2010-05-11 03:53:57 +02:00
mkdir
mv touch: implement -d --date (our own testsuite needs that) 2009-07-18 03:41:29 +02:00
paste paste: new applet 2017-03-23 17:35:52 +01:00
pwd randconfig fixes 2015-10-11 16:27:55 +02:00
rm
rmdir
strings
tail randomtest fixes 2010-05-11 03:53:57 +02:00
tar testsuite: fixes after randomconfig run 2011-08-11 10:40:12 +02:00
tee
touch
tr randomtest fixes 2010-05-12 15:59:32 +02:00
true
unexpand
uptime *: trailing empty lines removed 2010-07-26 01:49:12 +02:00
wc
wget add SKIP_KNOWN_BUGS and SKIP_INTERNET_TESTS to testsuite 2009-07-18 15:19:41 +02:00
which testsuite: fix last "which" change 2014-01-23 14:41:53 +01:00
xargs
all_sourcecode.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
ar.tests randomconfig fixes 2 2016-06-19 21:54:04 +02:00
ash.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
awk_t1.tar.bz2
awk.tests awk: fix 'delete array[var--]' decrementing var twice 2018-01-07 01:19:08 +01:00
bunzip2.tests decompress_bunzip2: handle concatenated .bz2 files 2010-10-28 23:08:53 +02:00
busybox.tests testsuite: update busybox and bzcat tests 2018-02-12 15:32:02 +01:00
bzcat.tests testsuite: update busybox and bzcat tests 2018-02-12 15:32:02 +01:00
cal.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
comm.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
cp.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
cpio.tests randomconfig fixes 2016-12-12 09:26:16 +01:00
cryptpw.tests cryptpw: support "rounds=NNNNNNN$" thing in salts 2017-01-15 21:48:31 +01:00
cut.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
dc.tests dc: tweak parsing 2015-02-16 17:12:04 +01:00
diff.tests diff.tests: add testcases for -B and single line changes 2015-07-31 16:51:15 +02:00
expand.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
factor.tests factor: new applet 2017-04-09 21:18:43 +02:00
find.tests find: fix handling of trailing slashes in -name PATTERN comparisons 2016-11-25 20:14:33 +01:00
fold.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
grep.tests Make grep/egrep/fgrep independently selectable 2016-11-14 05:09:48 +01:00
gunzip.tests testsuite: add tests for {ms5,shaN}sum 2010-10-16 21:26:47 +02:00
ls.mk_uni_tests testsuite: fix the mishap in the previous commit 2011-10-31 01:08:35 +01:00
ls.tests randomconfig fixes 2011-08-10 00:51:29 +02:00
makedevs.device_table.txt test, tcpsvd, tcpsvd: shrink 2009-06-13 22:49:08 +02:00
makedevs.tests randconfig fixes 2015-10-11 23:48:28 +02:00
md5sum.tests {md5,shaN}sum: make -c EMPTY fail 2016-07-11 19:51:08 +02:00
mdev.tests sysctl: fix file parsing, do not require -w for VAR=VAL 2017-08-05 13:45:22 +02:00
mkfs.minix.tests fix testsuite false positive 2013-01-21 08:28:37 +01:00
mount.testroot *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
mount.tests mount: fix the wrongly stored fs creation time 2012-06-21 16:50:46 +02:00
od.tests od_bloaty: fix floating point output 2017-07-19 13:12:02 +02:00
parse.tests sysctl: fix file parsing, do not require -w for VAR=VAL 2017-08-05 13:45:22 +02:00
patch.tests patch: fix matching failure 2016-11-24 11:40:36 +01:00
pidof.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
printf.tests Fix some test cases 2010-09-03 17:09:51 +02:00
readlink.tests Spelling fixes in comments, documentation, tests and examples 2017-04-17 16:13:32 +02:00
README documentation and typo fixes. By Dan Fandrich (dan AT coneharvesters.com) 2009-09-06 02:58:59 +02:00
runtest remove "local" bashism from a few scripts 2017-01-24 20:52:42 +01:00
rx.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
sed.tests sed: in '/regexp/cmd1;//cmd2', cmd2 should use the same regexp as cmd1 2017-08-23 17:56:03 +02:00
seq.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
sha1sum.tests testsuite: add tests for {ms5,shaN}sum 2010-10-16 21:26:47 +02:00
sha3sum.tests sha3: fix to conform to final SHA3 padding standard, add -a BITS option 2016-08-29 14:05:25 +02:00
sha256sum.tests testsuite: add tests for {ms5,shaN}sum 2010-10-16 21:26:47 +02:00
sha512sum.tests testsuite: add tests for {ms5,shaN}sum 2010-10-16 21:26:47 +02:00
sort.tests sort: fix ENDCHAR handling in "-kSTART,N.ENDCHAR" 2015-10-19 19:27:26 +02:00
start-stop-daemon.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
sum.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
tail.tests tail: fix -c +N. Closes 4111 2011-09-17 00:12:24 +02:00
tar.tests tar,unzip: postpone creation of symlinks with "suspicious" targets 2018-02-20 16:06:53 +01:00
tar.utf8.tar.bz2 tar: handle pax-encoded utf8 filenames and link names. Closes 9406 2016-11-11 17:56:45 +01:00
taskset.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
test.tests test: fix mishandling of "test '(' = '('" and similar 2014-07-01 14:16:28 +02:00
testing.sh fix bashisms in testsuite/ 2013-11-10 22:06:06 +01:00
TODO
tr.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
umlwrapper.sh
uncompress.tests uncompress: fix buffer underrun by corrupted input 2011-08-18 14:29:41 +02:00
unexpand.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
uniq.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00
unzip.tests unzip: do not use CDF.extra_len, read local file header. Closes 9536 2017-01-08 14:14:19 +01:00
uuencode.tests libbb: split decode_base64 off read_base64 2011-10-28 13:59:55 +02:00
xargs.tests *: make GNU licensing statement forms more regular 2010-08-16 20:14:46 +02:00

To run the test suite, change to this directory and run "./runtest".  It will
run all of the test cases, and list those with unexpected outcomes.  Adding the
-v option will cause it to show expected outcomes as well.  To only run the test
cases for particular applets:

./runtest <applet1> <applet2>...

Set SKIP_KNOWN_BUGS environment variable to any non-empty value
to exclude tests which are known to fail.

Set SKIP_INTERNET_TESTS to exclude tests which require working
internet connection.


Common causes of false positives:

For busybox built against uclibc, /etc/TZ does not exist or does not match
host system timezone setting. For glibc based host systems, timezone settings
are in /etc/localtime.

LANG and LC_xxx environment variables set to non-C locale.


Developer's notes:

The test cases for an applet reside in the subdirectory of the applet name.
The name of the test case should be the assertion that is tested.
The test case should be a shell fragment that returns successfully
if the test case passes, and unsuccessfully otherwise.

If the test case relies on a certain feature, it should include the string
"FEATURE: " followed by the name of the feature in a comment.  If it is always
expected to fail, it should include the string "XFAIL" in a comment.


For the entire testsuite, the copyright is as follows:

Copyright (C) 2001, 2002  Matt Kraai

This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2
of the License, or (at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.