busybox/shell
Denis Vlasenko 7b4f3f13d3 hush: fix two nasty bugs:
hush-bugs/tick2.tests: ok
hush-bugs/tick.tests: ok

function                                             old     new   delta
parse_stream                                        1332    1557    +225
b_addptr                                               -      97     +97
add_till_backquote                                     -      82     +82
b_addstr                                               -      58     +58
b_grow_by                                              -      50     +50
setup_string_in_str                                    -      29     +29
expand_variables                                    1196    1199      +3
expand_on_ifs                                        100      97      -3
b_addqchr                                             57      50      -7
parse_and_run_string                                  48      31     -17
lookup_param                                          27       -     -27
b_addchr                                              75      45     -30
count_ifs                                             44       -     -44
process_command_subs                                 222       -    -222
------------------------------------------------------------------------------
(add/remove: 5/3 grow/shrink: 2/4 up/down: 544/-350)          Total: 194 bytes
   text    data     bss     dec     hex filename
 759354     604    6684  766642   bb2b2 busybox_old
 759534     604    6684  766822   bb366 busybox_unstripped
2008-06-10 18:04:32 +00:00
..
ash_test ash testsuite: modify it so that it can run hush and msh tests 2008-06-05 09:07:02 +00:00
hush_test hush: add yet another bug to testsuite :( 2008-06-08 16:47:09 +00:00
msh_test msh: fix ENOENT testcase 2008-06-01 14:16:54 +00:00
ash_doc.txt ash: fix "orwell bug" 1984. Testcase: 2008-02-10 19:02:53 +00:00
ash_ptr_hack.c fix build with gcc -combine 2008-04-11 11:27:29 +00:00
ash.c reword the error msg so people realize that they broke it, they buy it 2008-06-09 09:38:45 +00:00
bbsh.c - use EXIT_{SUCCESS,FAILURE}. No object-code changes 2008-05-19 09:29:47 +00:00
Config.in ash: optional printf builtin. +25 bytes if off, +35 if on. 2008-06-01 22:36:39 +00:00
cttyhack.c *: fix fallout from -Wunused-parameter 2008-03-17 09:04:04 +00:00
hush_doc.txt hush: small fixes to docs/testsuite 2008-02-10 16:00:30 +00:00
hush_leaktool.sh hush: plug memory leak 2007-11-23 12:50:54 +00:00
hush.c hush: fix two nasty bugs: 2008-06-10 18:04:32 +00:00
Kbuild *: add optimization barrier to all "G trick" locations 2008-02-27 18:41:59 +00:00
lash_unused.c *: shrink by using [f]open_or_warn_stdin where appropriate 2008-03-17 09:07:36 +00:00
msh_function.patch cosmetics 2008-06-09 07:58:53 +00:00
msh.c msh: style cleanups. No code changes. 2008-06-09 07:44:19 +00:00
README typo fix 2008-02-14 10:31:18 +00:00
README.job hush: small code shrink; style fixes 2007-04-20 08:35:45 +00:00
susv3_doc.tar.bz2 shell/: add SUSv3 doc for fast & easy reference 2007-04-13 19:44:22 +00:00

Various bits of what is known about busybox shells, in no particular order.

2008-02-14
ash: does not restore tty pgrp if killed by HUP. Symptom: Midnight Commander
is backgrounded if you started ash under it, and then killed it with HUP.

2007-11-23
hush: fixed bogus glob handling; fixed exec <"$1"; added test and echo builtins

2007-06-13
hush: exec <"$1" doesn't do parameter subst

2007-05-24
hush: environment-related memory leak plugged, with net code size
decrease.

2007-05-24
hush: '( echo ${name )' will show syntax error message, but prompt
doesn't return (need to press <enter>). Pressing Ctrl-C, <enter>,
'( echo ${name )' again, Ctrl-C segfaults.

2007-05-21
hush: environment cannot be handled by libc routines as they are leaky
(by API design and thus unfixable): hush will leak memory in this script,
bash does not:
pid=$$
while true; do
    unset t;
    t=111111111111111111111111111111111111111111111111111111111111111111111111
    export t
    ps -o vsz,pid,comm | grep " $pid "
done
The fix is to not use setenv/putenv/unsetenv but manipulate env ourself. TODO.
hush: meanwhile, first three command subst bugs mentioned below are fixed. :)

2007-05-06
hush: more bugs spotted. Comparison with bash:
bash-3.2# echo "TEST`date;echo;echo`BEST"
TESTSun May  6 09:21:05 CEST 2007BEST         [we dont strip eols]
bash-3.2# echo "TEST`echo '$(echo ZZ)'`BEST"
TEST$(echo ZZ)BEST                            [we execute inner echo]
bash-3.2# echo "TEST`echo "'"`BEST"
TEST'BEST                                     [we totally mess up this one]
bash-3.2# echo `sleep 5`
[Ctrl-C should work, Ctrl-Z should do nothing][we totally mess up this one]
bash-3.2# if true; then
> [Ctrl-C]
bash-3.2#                                     [we re-issue "> "]
bash-3.2# if echo `sleep 5`; then
> true; fi                                    [we execute sleep before "> "]

2007-05-04
hush: made ctrl-Z/C work correctly for "while true; do true; done"
(namely, it backgrounds/interrupts entire "while")

2007-05-03
hush: new bug spotted: Ctrl-C on "while true; do true; done" doesn't
work right:
# while true; do true; done
[1] 0 true <-- pressing Ctrl-C several times...
[2] 0 true
[3] 0 true
Segmentation fault

2007-05-03
hush: update on "sleep 1 | exit 3; echo $?" bug.
parse_stream_outer() repeatedly calls parse_stream().
parse_stream() is now fixed to stop on ';' in this example,
fixing it (parse_stream_outer() will call parse_stream() 1st time,
execute the parse tree, call parse_stream() 2nd time and execute the tree).
But it's not the end of story.
In more complex situations we _must_ parse way farther before executing.
Example #2: "{ sleep 1 | exit 3; echo $?; ...few_lines... } >file".
Because of redirection, we cannot execute 1st pipe before we parse it all.
We probably need to learn to store $var expressions in parse tree.
Debug printing of parse tree would be nice too.

2007-04-28
hush: Ctrl-C and Ctrl-Z for single NOFORK commands are working.
Memory and other resource leaks (opendir) are not addressed
(testcase is "rm -i" interrupted by ctrl-c).

2007-04-21
hush: "sleep 5 | sleep 6" + Ctrl-Z + fg seems to work.
"rm -i" + Ctrl-C, "sleep 5" + Ctrl-Z still doesn't work
for SH_STANDALONE case :(

2007-04-21
hush: fixed non-backgrounding of "sleep 1 &" and totally broken
"sleep 1 | sleep 2 &". Noticed a bug where successive jobs
get numbers 1,2,3 even when job #1 has exited before job# 2 is started.
(bash reuses #1 in this case)

2007-04-21
hush: "sleep 1 | exit 3; echo $?" prints 0 because $? is substituted
_before_ pipe gets executed!! run_list_real() already has "pipe;echo"
parsed and handed to it for execution, so it sees "pipe"; "echo 0".

2007-04-21
hush: removed setsid() and made job control sort-of-sometimes-work.
Ctrl-C in "rm -i" works now except for SH_STANDALONE case.
"sleep 1 | exit 3" + "echo $?" works, "sleep 1 | exit 3; echo $?"
shows exitcode 0 (should be 3). "sleep 1 | sleep 2 &" fails horribly.

2007-04-14
lash, hush: both do setsid() and as a result don't have ctty!
Ctrl-C doesn't work for any child (try rm -i), etc...
lash: bare ">file" doesn't create a file (hush works)