emo/openrc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix the Internal Field Seperator when using ethtool

Browse Source 
ethtool.sh didn't reset the Internal Field Seperator (IFS) properly.
It now does, by storing the old IFS to OIFS, which will be used later
in the for loop.

It also fixes the "ethtool_ring_<if>" option.

Reported-by: Alois Schmid <alois.schmid@gmx.de>
X-Gentoo-Bug: 368525
X-Gentoo-Bug-URL: https://bugs.gentoo.org/368525
This commit is contained in:
Gilles Oivier 2011-09-18 14:42:39 +02:00 committed by Christian Ruppert
parent 72e31e753d
commit 0e4d169a40
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/ethtool.sh
View File

@ -31,6 +31,7 @@ ethtool_pre_start() {
[ -z "${args}" ] && continue [ -z "${args}" ] && continue
# Split on \n # Split on \n
OIFS="${IFS}"
local IFS="$__IFS" local IFS="$__IFS"
for p in ${args} ; do for p in ${args} ; do
@ -38,6 +39,7 @@ ethtool_pre_start() {
local args_pretty="$(_trim "${p}")" local args_pretty="$(_trim "${p}")"
# Do nothing if empty # Do nothing if empty
[ -z "${args_pretty}" ] && continue [ -z "${args_pretty}" ] && continue
[ "${opt}" = "ring" ] && opt="set-ring"
args_pretty="--${opt} $IFACE ${args_pretty}" args_pretty="--${opt} $IFACE ${args_pretty}"
args="--${opt} $IFACE ${args}" args="--${opt} $IFACE ${args}"
ebegin "ethtool ${args_pretty}" ebegin "ethtool ${args_pretty}"